1. 04 Mar, 2019 1 commit
  2. 13 Dec, 2018 1 commit
    • Jakob Gruber's avatar
      [builtins] Associate ASM builtins with descriptors · e61d3564
      Jakob Gruber authored
      Post-stub-to-builtin migration, all explicit connection between
      descriptors and their associated ASM code has been lost. This restores
      the connection where possible. Builtins without an associated
      descriptor are marked with the DummyDescriptor.
      
      Drive-by: alpha-sort the descriptor list.
      Drive-by: use Builtins::CallableFor in code factory.
      
      Bug: v8:8562, v8:8553
      Change-Id: If1f13bbaf7e42453b3235cc97c58ada91b5fa7b8
      Reviewed-on: https://chromium-review.googlesource.com/c/1373552Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58212}
      e61d3564
  3. 29 Oct, 2018 1 commit
  4. 20 Sep, 2018 1 commit
    • Dan Elphick's avatar
      [interpreter] Always put bytecode handlers in builtins table · daa296b5
      Dan Elphick authored
      This always creates the bytecode handlers as part of the builtins table
      regardless of the V8_EMBEDDED_BYTECODE_HANDLERS definition.
      
      Lazy deserialization of bytecode handlers is enabled for this flow by
      moving the three lazy bytecode deserializers from the strong roots into
      the builtins table (ensuring that they not marked lazy themselves).
      
      To simplify lazy deserialization, the illegal bytecode handler is made
      non-lazy so that GetAndMaybeDeserializeBytecodeHandler doesn't to know
      about it.
      
      Since the bytecode handlers are now always part of the builtins table,
      many bytecode specific methods are removed, including logging and in
      BuiltinsSerializer and BuiltinsDeserializer.
      
      Removes setup-interpreter.h, setup-interpreter-internal.cc and
      builtin-snapshot-utils.*.
      
      Change-Id: Ie421aa897a04f7b3bcb964c476eb7ab149388d53
      Reviewed-on: https://chromium-review.googlesource.com/1220046Reviewed-by: 's avatarHannes Payer <hpayer@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
      Commit-Queue: Dan Elphick <delphick@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#56063}
      daa296b5
  5. 21 Aug, 2018 1 commit
    • Dan Elphick's avatar
      Reland "[builtins] Start adding byte code handlers to builtins" · fe5e07d7
      Dan Elphick authored
      This is a reland of 041ae1f8
      
      The clashing method has been fixed.
      
      Original change's description:
      > [builtins] Start adding byte code handlers to builtins
      >
      > Adds a new build flag, v8_enable_embedded_bytecode_handlers, that adds
      > the bytecode handlers to the BUILTIN_LIST macros.
      >
      > Currently it's not connected up to the code-generation so it actually
      > does nothing except expand the builtins table.
      >
      > Bug: v8:8068
      > Change-Id: Iaecc3982cf22d04e6c46169b86c9d694952fd091
      > Reviewed-on: https://chromium-review.googlesource.com/1179887
      > Commit-Queue: Dan Elphick <delphick@chromium.org>
      > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
      > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#55215}
      
      Bug: v8:8068
      Change-Id: Ibc98929a9ad464e9d4c9fc7d43401f0fb0df9a00
      Reviewed-on: https://chromium-review.googlesource.com/1181981Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Commit-Queue: Dan Elphick <delphick@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55244}
      fe5e07d7
  6. 20 Aug, 2018 2 commits
    • Dan Elphick's avatar
      Revert "[builtins] Start adding byte code handlers to builtins" · 737ffec5
      Dan Elphick authored
      This reverts commit 041ae1f8.
      
      Reason for revert: Causes jumbo builds to fail because of duplicate GenerateBytecodeHandler definitions.
      
      Original change's description:
      > [builtins] Start adding byte code handlers to builtins
      > 
      > Adds a new build flag, v8_enable_embedded_bytecode_handlers, that adds
      > the bytecode handlers to the BUILTIN_LIST macros.
      > 
      > Currently it's not connected up to the code-generation so it actually
      > does nothing except expand the builtins table.
      > 
      > Bug: v8:8068
      > Change-Id: Iaecc3982cf22d04e6c46169b86c9d694952fd091
      > Reviewed-on: https://chromium-review.googlesource.com/1179887
      > Commit-Queue: Dan Elphick <delphick@chromium.org>
      > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
      > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#55215}
      
      TBR=rmcilroy@chromium.org,jgruber@chromium.org,delphick@chromium.org
      
      Change-Id: I860b3ecf543944fd0f4fdcb8de09d21a4b784150
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:8068
      Reviewed-on: https://chromium-review.googlesource.com/1181301Reviewed-by: 's avatarDan Elphick <delphick@chromium.org>
      Commit-Queue: Dan Elphick <delphick@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55225}
      737ffec5
    • Dan Elphick's avatar
      [builtins] Start adding byte code handlers to builtins · 041ae1f8
      Dan Elphick authored
      Adds a new build flag, v8_enable_embedded_bytecode_handlers, that adds
      the bytecode handlers to the BUILTIN_LIST macros.
      
      Currently it's not connected up to the code-generation so it actually
      does nothing except expand the builtins table.
      
      Bug: v8:8068
      Change-Id: Iaecc3982cf22d04e6c46169b86c9d694952fd091
      Reviewed-on: https://chromium-review.googlesource.com/1179887
      Commit-Queue: Dan Elphick <delphick@chromium.org>
      Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55215}
      041ae1f8
  7. 22 Jun, 2018 1 commit
  8. 18 Jun, 2018 1 commit
  9. 29 Sep, 2017 1 commit
  10. 28 Sep, 2017 1 commit
  11. 16 Aug, 2017 1 commit
  12. 07 Apr, 2017 1 commit
    • jgruber's avatar
      [builtins] Introduce new TFC macro and auto-generate TFS descriptors · 9ddfeafe
      jgruber authored
      Split TFS builtins into
      
      * TFC: TF builtins with stub linkage that use a custom interface descriptor
             (e.g. because of a non-standard return size or untagged arguments)
      * TFS: the rest.
      
      Automatically generate interface descriptors for TFS builtins to reduce
      boilerplate involved in setting up stub calls. These are now as simple as
      creating the TFS stub and using CSA::CallBuiltin, no extra work required.
      
      BUG=v8:6116
      
      Review-Url: https://codereview.chromium.org/2777203007
      Cr-Commit-Position: refs/heads/master@{#44490}
      9ddfeafe
  13. 28 Mar, 2017 2 commits
  14. 20 Mar, 2017 1 commit