- 04 Mar, 2019 1 commit
-
-
Sven Sauleau authored
Removes the result_size parameter in TFC definitions which can be infered from the provided CallInterfaceDescriptor. Previously, the result size was added to support stubs with custom linkage. However, In pratice, the size don't differ from the provided CallInterfaceDescriptor (given that it's a DCHECK) and use mostly JS linkage (only one return). Change-Id: I8efdb3e3ce1a470735dac84ec6be506e071d2756 Bug: v8:6116 Reviewed-on: https://chromium-review.googlesource.com/c/1495554 Commit-Queue: Sven Sauleau <ssauleau@igalia.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#60004}
-
- 13 Dec, 2018 1 commit
-
-
Jakob Gruber authored
Post-stub-to-builtin migration, all explicit connection between descriptors and their associated ASM code has been lost. This restores the connection where possible. Builtins without an associated descriptor are marked with the DummyDescriptor. Drive-by: alpha-sort the descriptor list. Drive-by: use Builtins::CallableFor in code factory. Bug: v8:8562, v8:8553 Change-Id: If1f13bbaf7e42453b3235cc97c58ada91b5fa7b8 Reviewed-on: https://chromium-review.googlesource.com/c/1373552Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58212}
-
- 29 Oct, 2018 1 commit
-
-
Jakob Gruber authored
Now that embedded builtins are enabled everywhere*, lazy deserialization can be turned off and removed. * Except nosnap builds, on aix and in msvc builds. Bug: v8:6666, v8:6624, v8:7990 Change-Id: Ib5fefe10e7ff35b13a1eb803fbc3736b8851b22b Reviewed-on: https://chromium-review.googlesource.com/c/1288638Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#57064}
-
- 20 Sep, 2018 1 commit
-
-
Dan Elphick authored
This always creates the bytecode handlers as part of the builtins table regardless of the V8_EMBEDDED_BYTECODE_HANDLERS definition. Lazy deserialization of bytecode handlers is enabled for this flow by moving the three lazy bytecode deserializers from the strong roots into the builtins table (ensuring that they not marked lazy themselves). To simplify lazy deserialization, the illegal bytecode handler is made non-lazy so that GetAndMaybeDeserializeBytecodeHandler doesn't to know about it. Since the bytecode handlers are now always part of the builtins table, many bytecode specific methods are removed, including logging and in BuiltinsSerializer and BuiltinsDeserializer. Removes setup-interpreter.h, setup-interpreter-internal.cc and builtin-snapshot-utils.*. Change-Id: Ie421aa897a04f7b3bcb964c476eb7ab149388d53 Reviewed-on: https://chromium-review.googlesource.com/1220046Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#56063}
-
- 21 Aug, 2018 1 commit
-
-
Dan Elphick authored
This is a reland of 041ae1f8 The clashing method has been fixed. Original change's description: > [builtins] Start adding byte code handlers to builtins > > Adds a new build flag, v8_enable_embedded_bytecode_handlers, that adds > the bytecode handlers to the BUILTIN_LIST macros. > > Currently it's not connected up to the code-generation so it actually > does nothing except expand the builtins table. > > Bug: v8:8068 > Change-Id: Iaecc3982cf22d04e6c46169b86c9d694952fd091 > Reviewed-on: https://chromium-review.googlesource.com/1179887 > Commit-Queue: Dan Elphick <delphick@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55215} Bug: v8:8068 Change-Id: Ibc98929a9ad464e9d4c9fc7d43401f0fb0df9a00 Reviewed-on: https://chromium-review.googlesource.com/1181981Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#55244}
-
- 20 Aug, 2018 2 commits
-
-
Dan Elphick authored
This reverts commit 041ae1f8. Reason for revert: Causes jumbo builds to fail because of duplicate GenerateBytecodeHandler definitions. Original change's description: > [builtins] Start adding byte code handlers to builtins > > Adds a new build flag, v8_enable_embedded_bytecode_handlers, that adds > the bytecode handlers to the BUILTIN_LIST macros. > > Currently it's not connected up to the code-generation so it actually > does nothing except expand the builtins table. > > Bug: v8:8068 > Change-Id: Iaecc3982cf22d04e6c46169b86c9d694952fd091 > Reviewed-on: https://chromium-review.googlesource.com/1179887 > Commit-Queue: Dan Elphick <delphick@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55215} TBR=rmcilroy@chromium.org,jgruber@chromium.org,delphick@chromium.org Change-Id: I860b3ecf543944fd0f4fdcb8de09d21a4b784150 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8068 Reviewed-on: https://chromium-review.googlesource.com/1181301Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#55225}
-
Dan Elphick authored
Adds a new build flag, v8_enable_embedded_bytecode_handlers, that adds the bytecode handlers to the BUILTIN_LIST macros. Currently it's not connected up to the code-generation so it actually does nothing except expand the builtins table. Bug: v8:8068 Change-Id: Iaecc3982cf22d04e6c46169b86c9d694952fd091 Reviewed-on: https://chromium-review.googlesource.com/1179887 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#55215}
-
- 22 Jun, 2018 1 commit
-
-
Igor Sheludko authored
Bug: v8:7754 Change-Id: I0c74b4025d9e52f3580e2da6bd7ac2b8ec2ee620 Reviewed-on: https://chromium-review.googlesource.com/1104469 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#53969}
-
- 18 Jun, 2018 1 commit
-
-
Igor Sheludko authored
Now TFJ builtins can use their own descriptors so there's no need to keep the hacky BuiltinDescriptor around. Bug: v8:7754 Change-Id: Ia7f23a21fb979370fd2149fef13186b83a3d5d30 Reviewed-on: https://chromium-review.googlesource.com/1104428 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#53806}
-
- 29 Sep, 2017 1 commit
-
-
Toon Verwaest authored
Bug: Change-Id: I644c9f8b9ab3bd4250809ee557ec34ee738f5244 Reviewed-on: https://chromium-review.googlesource.com/691654 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#48219}
-
- 28 Sep, 2017 1 commit
-
-
Toon Verwaest authored
There are only very few custom compiled IC handlers left that go in there, and for each compiled handler we only have 1 cache hit on top25; maximally saving 60ms over 33s. Additionally we'll migrate the remaining handlers to data-driven handlers anyway. Let's try to remove this code. Bug: Change-Id: Ib874cc498015046a3ff67c83ea8b10b3c4eb7d0f Reviewed-on: https://chromium-review.googlesource.com/668409 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#48201}
-
- 16 Aug, 2017 1 commit
-
-
Yang Guo authored
This removes: - CodeBreakIterator for FCG code. - RelocModes for debug breaks. - Code generator for debug break slots. - GC support for debug break slots. - Code flag to indicate code with debug break slots. - Builtin type DBG. - Mechanisms to replace FCG code in the debugger and LiveEdit. - Runtime entry to the debugger from debug break slots. R=bmeurer@chromium.org, rmcilroy@chromium.org, ulan@chromium.org Bug: v8:6409 Change-Id: I5662c8800e3ef1b1584ad107bfe0aae26c9d8abb Reviewed-on: https://chromium-review.googlesource.com/613263Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#47364}
-
- 07 Apr, 2017 1 commit
-
-
jgruber authored
Split TFS builtins into * TFC: TF builtins with stub linkage that use a custom interface descriptor (e.g. because of a non-standard return size or untagged arguments) * TFS: the rest. Automatically generate interface descriptors for TFS builtins to reduce boilerplate involved in setting up stub calls. These are now as simple as creating the TFS stub and using CSA::CallBuiltin, no extra work required. BUG=v8:6116 Review-Url: https://codereview.chromium.org/2777203007 Cr-Commit-Position: refs/heads/master@{#44490}
-
- 28 Mar, 2017 2 commits
-
-
Igor Sheludko authored
BUG=v8:6116 Change-Id: I1487165550e938200ce49a022222892752feccae Reviewed-on: https://chromium-review.googlesource.com/461819Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#44195}
-
Igor Sheludko authored
BUG=v8:6116 Change-Id: I8e2587926f9e11f022624778fd5168799d20d2df Reviewed-on: https://chromium-review.googlesource.com/461158Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#44186}
-
- 20 Mar, 2017 1 commit
-
-
Igor Sheludko authored
This is a first bulk of changes. BUG=v8:6116 Change-Id: I9308129bd032c0bf5b60c8e0413ee2cb710891ea Reviewed-on: https://chromium-review.googlesource.com/456556 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#43930}
-