- 19 Mar, 2019 16 commits
-
-
Hannes Payer authored
Change-Id: I878bc11ac8d4988b608507bced1363129c29a179 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528993 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#60328}
-
Michael Starzinger authored
This extends the support for the "except_ref" type on global variables to support mutable globals, as well as importing and exporting such globals. Test coverage is also increased. R=ahaas@chromium.org TEST=mjsunit/wasm/exceptions-global BUG=v8:8091 Change-Id: I816406e322ffb574a4f054947682491e7b40335f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1530802Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#60327}
-
Sigurd Schneider authored
Change-Id: I46eb94e58fc4da55cb1b2adb9ffdbb09e5e33a5d Bug: v8:8557 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1530800Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60326}
-
Clemens Hammacher authored
This makes it easier to publish them in batches. Function index and requested compilation tier are duplicated from the WasmCompilationUnit. R=titzer@chromium.org Bug: v8:8916 Change-Id: I87852670be029b1d729f98f01729362ca379fb50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1529009Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60325}
-
Leszek Swirski authored
This reverts commit b1769313. Reason for revert: Flag access breaks TSAN (not an issue with this CL as such, but we need to revert to re-open the tree). Original change's description: > [regalloc] Introduce deferred fixed ranges > > Fixed ranges are used to express register constraints in the > allocator. This change splits these fixed ranges into one for > normal code and deferred code. The former are handeled as before > whereas the latter are only made visible while allocating > registers for deferred code. > > This prevents forward looking decisions in normal code to be > impacted by register constraints from deferred code. > > Change-Id: I67d562bb41166194e62765d5ab051bc961054fc7 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1477742 > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60322} TBR=jarin@chromium.org,sigurds@chromium.org,herhut@chromium.org Change-Id: I5675a96acf0b5e5f7d63c60a742d2971b6d0d34d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1530803Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#60324}
-
Yu Yin authored
We should use 'constant pool' to allow concurrent patching of the jump table like arm. For now just skip the test to make CI mips bot green. Bug: v8:8974 Change-Id: Iaf2b0245128fdcf2c8ed964f796781134570c889 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524755 Commit-Queue: Yu Yin <xwafish@gmail.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60323}
-
Stephan Herhut authored
Fixed ranges are used to express register constraints in the allocator. This change splits these fixed ranges into one for normal code and deferred code. The former are handeled as before whereas the latter are only made visible while allocating registers for deferred code. This prevents forward looking decisions in normal code to be impacted by register constraints from deferred code. Change-Id: I67d562bb41166194e62765d5ab051bc961054fc7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1477742 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60322}
-
Igor Sheludko authored
When pointer compression is enabled the [u]intptr_t and double fields are only kTaggedSize aligned so in order to avoid undefined behavior in C++ code we have to access these values in an unaligned pointer friendly way although both x64 and arm64 architectures (where pointer compression is supported) allow unaligned access. These changes will be removed once v8:8875 is fixed and all the kSystemPointerSize fields are properly aligned. Bug: v8:7703 Change-Id: I4df477cbdeab806303bb4f675d52b61c06342c8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528996 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Peter Marshall authored
This was unimplemented but is needed for Perfetto which posts delayed tasks on worker threads e.g. drain the trace buffer into a file every x seconds. This is implemented by adding a second queue which holds the delayed tasks in chronological order of 'next-to-execute'. We use an std::multimap for the queue so that we can easily get the next delayed task with begin(). The implementation will move delayed tasks into the main task queue when their deadline expires. Drive-by cleanup of the runner destructor which can just use = default. Bug: v8:8339 Change-Id: I3629c5d6e15ced2fc47eb1b7519a2dbbf8461fce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1521114 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... which can be used with STL algorithms. When pointer compression is enabled the [u]intptr_t and double fields are only kTaggedSize aligned so in order to avoid undefined behavior in C++ code we have to access these values in an unaligned pointer friendly way although both x64 and arm64 architectures (where pointer compression is supported) allow unaligned access. These changes will be removed once v8:8875 is fixed and all the kSystemPointerSize fields are properly aligned. Bug: v8:7703 Change-Id: If581fc00d63ae759c73b2a0f115331eea336605f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528995Reviewed-by:
-
Benedikt Meurer authored
This change significantly improves the performance of string concatenation in optimized code for the case where the resulting string is represented as a ConsString. On the relevant test cases we go from serializeNaive: 10762 ms. serializeClever: 7813 ms. serializeConcat: 10271 ms. to serializeNaive: 10278 ms. serializeClever: 5533 ms. serializeConcat: 10310 ms. which represents a 30% improvement on the "clever" benchmark, which tests specifically the ConsString creation performance. This was accomplished via a couple of different steps, which are briefly outlined here: 1. The empty_string gets its own map, so that we can easily recognize and handle it appropriately in the TurboFan type system. This allows us to express (and assert) that the inputs to NewConsString are non-empty strings, making sure that TurboFan no longer creates "crippled ConsStrings" with empty left or right hand sides. 2. Further split the existing String types in TurboFan to be able to distinguish between OneByte and TwoByte strings on the type system level. This allows us to avoid having to dynamically lookup the resulting ConsString map in case of ConsString creation (i.e. when we know that both input strings are OneByte strings or at least one of the input strings is TwoByte). 3. We also introduced more finegrained feedback for the Add bytecode in the interpreter, having it collect feedback about ConsStrings, specifically ConsOneByteString and ConsTwoByteString. This feedback can be used by TurboFan to only inline the relevant code for what was seen so far. This allows us to remove the Octane/Splay specific magic in JSTypedLowering to detect ConsString creation, and instead purely rely on the feedback of what was seen so far (also making it possible to change the semantics of NewConsString to be a low-level operator, which is only introduced in SimplifiedLowering by looking at the input types of StringConcat). 4. On top of the before mentioned type and interpreter changes we added new operators CheckNonEmptyString, CheckNonEmptyOneByteString, and CheckNonEmptyTwoByteString, which perform the appropriate (dynamic) checks. There are several more improvements that are possible based on this, but since the change was already quite big, we decided not to put everything into the first change, but do some follow up tweaks to the type system, and builtin optimizations later. Tbr: mstarzinger@chromium.org Bug: v8:8834, v8:8931, v8:8939, v8:8951 Change-Id: Ia24e17c6048bf2b04df966d3cd441f0edda05c93 Cq-Include-Trybots: luci.chromium.try:linux-blink-rel Doc: https://bit.ly/fast-string-concatenation-in-javascript Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1499497 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:Yang Guo <yangguo@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60318}
-
Michael Starzinger authored
This adds basic support and tests for having global variables of type "except_ref" that are default initialized to "null". The functionality is part of the exception handling proposal and solely enabled by the corresponding feature flag. R=ahaas@chromium.org TEST=mjsunit/wasm/exceptions-global BUG=v8:8091 Change-Id: I581bc942fbe6688a5c58790a842fb024de22d924 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528439 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/2f5d8e7..d51ec1b Reject the promise if reading the imports fails. (Ms2ger) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/d51ec1b TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: I1af73510bc61e7c5cc9a68ed866a0cc7ef86e4d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1530193Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60316}
-
Michael Achenbach authored
This ports: https://crrev.com/c/1526276 TBR=tmrts@chromium.org Bug: chromium:855791 Change-Id: I1370b4f72a1aa22d3ec1c5c7ca4ff07fad306501 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528999Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60315}
-
Michael Achenbach authored
This is to mitigate current resource shortage on win7. TBR=tmrts@chromium.org Bug: chromium:943411 Change-Id: I9fae1c3ffe13d5e6c4318d63ddabd2e0d807d941 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1529003Reviewed-by:
-
Mike Stanton authored
If pointer compression is on, it makes sense to embed the map as a 32-bit constant, for direct comparison. No need to uncompress the receiver map. Bug: v8:8982 Change-Id: I285ca4d5b49b26536873776d298e18bcbf84b23e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1518182Reviewed-by:
-
- 18 Mar, 2019 24 commits
-
-
Sven Sauleau authored
According to WebAssembly's thread proposal, the memory type is decided at the Object's creation and don't change over time. When growing a shared memory and the old buffer was marked as shared; setup the new buffer as shared as well. Bug: v8:8564 Change-Id: I7e59071d11b41315429232ae0c90436c6810bd0e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526012Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Sven Sauleau <ssauleau@igalia.com> Auto-Submit: Sven Sauleau <ssauleau@igalia.com> Cr-Commit-Position: refs/heads/master@{#60312}
-
Z Duong Nguyen-Huu authored
This is a part of effort to port Proxy-related builtins to Torque. Spec: https://tc39.github.io/ecma262/#sec-proxy-revocation-functions Bug: v8:6664 Change-Id: I283a4d8109a31c7e91f1cea8eb7a6e819e60b1cc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1521921 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
This implements the behavior discussed and specified here: https://github.com/tc39/ecma262/issues/1461 https://github.com/tc39/ecma262/pull/1470 As part of making this change, I realized that we didn't actually toggle the behavior between the optimized and unoptimized version based on the --harmony-await-optimization flag at all and just the unoptimized version by default. This patch removes the unoptimized version and uses the optimized version as the default. The other builtins that use this flag are not touched as part of this CL, they will be updated separately. Bug: v8:8998 Change-Id: I315e1b39dda91d0127b5e567986485d713eaa78d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1525872 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Andrew Comminos authored
Consumers can use this to derive the full stack from sampled leaf nodes without having to flatten the tree. Bug: v8:8999 Change-Id: I42c638dd2c757837b0c03514c204be0182653291 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1525877Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
Bug: chromium:852420 Change-Id: I9fd2353a3120c6d1566c1f74a581d005fd34ddae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528438Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#60308}
-
Z Duong Nguyen-Huu authored
Bug: v8:8952 Change-Id: I07b3491e644634f9712e89d1566718084a3686d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1518812Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#60307}
-
Pierre Langlois authored
Bug: v8:7327 Change-Id: I2a140cf79d3be83a34401f5e4a8033fd9d89568b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526011 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Change-Id: I8fee653d2e331c2e796115b4cb88a2138e456177 Bug: v8:7327 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528730Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60305}
-
Sigurd Schneider authored
This helper can lower a parallel move a,b <- c,d for registers where the sets {a,b} and {c,d} overlap. Change-Id: I3c6ab20c075847d43628c5fd77851a3e614849c5 Bug: v8:8834 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528533 Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: -
Michael Lippautz authored
Bug: chromium:923361, v8:8834 Change-Id: I46b6ad9eaa86476963a4e2cb3a5712447f180c20 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528235 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Even in streaming mode we want to generate deterministic compile errors, in particular they should contain the function name. This CL adds a test to check that the name is present in the error message even if the blob containing the function names is not present at the time the compile error is detected. R=ahaas@chromium.org Bug: v8:8814 Change-Id: I17eb1b3bca48ee2b58b462089c140c30a3511be8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526001 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Georg Neis authored
There were four places where we did essentially the same steps in order to extract the initial map for inlining a JSCreate operation. This CL creates a function on NodeProperties for this task. As a side effect, this fixes a bug in ReduceJSCreateArray, where has_initial_map could get called when it wasn't permissible to do so. Notes: For simplicity, in one or two places where we used to get the target/newtarget constants from the types we now get them from HeapConstant nodes. Cosmetic change: rename "receiver_map" to the more accurate "root_map" in JSNativeContextSpecialization::ExtractReceiverMaps. Bug: chromium:939316 Change-Id: I8fd9eb50993be3d839ab9b18eeea28184c53eabf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528435 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Mike Stanton authored
Caused by CL: "[TurboFan] Array.prototype.map wrong ElementsKind for output array." NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Change-Id: Ibaedc9f91e3fbac4900eda6277c98a094daf90b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528532 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Frederik Gossen authored
Implements decoding of compilation hints section in {ModuleDecoderImpl}. The {wasm-module-builder.js} supports the creation of that section. The feature can be enabled with {--experimental-wasm-compilation-hints}. Bug: v8:9003 Change-Id: Ic87e19d916f2ce316de453ea8c7c48c236a6d673 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1521115Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Frederik Gossen <frgossen@google.com> Cr-Commit-Position: refs/heads/master@{#60299}
-
Ulan Degenbaev authored
This reverts commit 8f1c985c. Reason for revert: breaks mkgrokdump Original change's description: > [heap] Reduce page size to 256KB > > The page size of PPC is kept unchanged because PPC has larger > physical pages (64KB). > > Bug: chromium:852420 > > Change-Id: Ib888ea00a476ff103e00211dbb439186148ef81e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1481631 > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Junliang Yan <jyan@ca.ibm.com> > Cr-Commit-Position: refs/heads/master@{#60296} TBR=ulan@chromium.org,hpayer@chromium.org,jyan@ca.ibm.com Change-Id: I16175bea8845ac5d16dd43af1add4f2d9e94debc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:852420 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528247Reviewed-by:
-
Simon Zünd authored
The serialize set of microbenchmarks serializes Error.stack of a prepared set of error objects. When all objects have been serialized, the benchmark then wrapped around and only accessed the resulting string properties. This, of course, is a lot faster and benchmark results are heavily fluctuating when the end is reached. This CL fixes this by introducing a payload that should be similiar to the specific workload, which is executed after the end is reached. R=petermarshall@chromium.org Bug: v8:8742 Change-Id: I7183d04e7c06af0c16fe3412e902f0d33605bc25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524485Reviewed-by:
-
Ulan Degenbaev authored
The page size of PPC is kept unchanged because PPC has larger physical pages (64KB). Bug: chromium:852420 Change-Id: Ib888ea00a476ff103e00211dbb439186148ef81e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1481631 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#60296}
-
Michael Achenbach authored
Change-Id: I49aecc92054bb959278c46393ea2e5a4da262064 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528241Reviewed-by:
-
Milad Farazmand authored
The next built-in function throws a "StopIteration" when iterator is exhausted which will crash and stop the test runner. Asking it to return a "None" instead will fix the issue. Change-Id: I3ca4ff8f28f359798c9faf6f1ffbbaa6bb95f156 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524719 Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by:
-
Maciej Goszczycki authored
Change-Id: I626340e61e9c1a46e0d1c882cc4fa86454d93e8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526013 Commit-Queue: Mythri Alle <mythria@chromium.org> Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#60293}
-
peterwmwong authored
Bug: v8:8996 Change-Id: I035c380768c324d8912aa8bc414d533dbf7f3e5a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524640 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
-
Jaroslav Sevcik authored
Bug: chromium:939316 Change-Id: I2a132b6cce208e110fe30de8d75743ac7534fc94 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1525942 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Simon Zünd authored
R=jgruber@chromium.org Bug: v8:8834 Change-Id: Ib6f8e8fbc571b51fdfbb389d9fc7a38c60208c1b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528432Reviewed-by:
-
Michael Lippautz authored
Bug: chromium:923361, v8:8834 Change-Id: I6ec42aeb74bea5c0629fcdc3f95c125f5de534a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526195 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
