- 01 Sep, 2015 38 commits
-
-
cbruni authored
Move BackingStore specific implementation from builtins.cc tp ElementsAccessor BUG= Review URL: https://codereview.chromium.org/1322803002 Cr-Commit-Position: refs/heads/master@{#30526}
-
littledan authored
Move the --harmony-sloppy-let flag to staging for further testing, and update test262 for the new passing tests. Also increase the strictness of the parser, even in sloppy mode, to disallow "new legacy compat" for for (let x = 5 in {}) {} which is now a SyntaxError. BUG=v8:3305 LOG=Y R=adamk Review URL: https://codereview.chromium.org/1321013005 Cr-Commit-Position: refs/heads/master@{#30525}
-
mlippautz authored
* Enforce invariants on the way. * Unmark flaky CodeRange test. BUG=v8:4141 BUG=v8:3005 LOG=N Review URL: https://codereview.chromium.org/1325853003 Cr-Commit-Position: refs/heads/master@{#30524}
-
binji authored
Having both flags is tedious, and it is unlikely you'd ever want them separately. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1304163010 Cr-Commit-Position: refs/heads/master@{#30523}
-
alph authored
Implement a lock free version of RolloverProtectedTickClock::Now to eliminate a deadlock. BUG=chromium:521420 LOG=Y Committed: https://crrev.com/d6db8e5902af1f067f0f149844f4e92824ee93f3 Cr-Commit-Position: refs/heads/master@{#30489} Review URL: https://codereview.chromium.org/1304873011 Cr-Commit-Position: refs/heads/master@{#30522}
-
hablich authored
Follow-up of https://codereview.chromium.org/1298973007/ Fix syntax R=adamk@chromium.org, machenbach@chromium.org Review URL: https://codereview.chromium.org/1324813003 Cr-Commit-Position: refs/heads/master@{#30521}
-
bradnelson authored
Walk asm.js module ASTs, attach concrete type information in preparation for generating a WASM module. cctest test coverage (mjsunit coming in later CL). Expressions, function tables, and foreign functions have coverage. Statement coverage to be expanded in a later CL. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=test-asm-validator R=rossberg@chromium.org,titzer@chromium.org LOG=N Review URL: https://codereview.chromium.org/1322773002 Cr-Commit-Position: refs/heads/master@{#30520}
-
conradw authored
Since the constructor is also the class object itself, allowing it to retroactively become a strong object would have unintuitive consequences wrt the strength of the other functions of the class, and whether instances would be considered instances of a strong class. BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1314203002 Cr-Commit-Position: refs/heads/master@{#30519}
-
https://codereview.chromium.org/1327483002/littledan authored
Reason for revert: Fails a test262 test with --always-opt. Original issue's description: > Stage sloppy let > > Move the --harmony-sloppy-let flag to staging for further testing, and > update test262 for the new passing tests. Also increase the strictness > of the parser, even in sloppy mode, to disallow "new legacy compat" for > > for (let x = 5 in {}) {} > > which is now a SyntaxError. > > BUG=v8:3305 > LOG=Y > R=adamk > > Committed: https://crrev.com/07bc0117be8dc9e63ec14d5f9645c483d60a1bec > Cr-Commit-Position: refs/heads/master@{#30515} TBR=adamk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3305 Review URL: https://codereview.chromium.org/1324033002 Cr-Commit-Position: refs/heads/master@{#30518}
-
yurys authored
BUG=chromium:520702 LOG=N Review URL: https://codereview.chromium.org/1316213005 Cr-Commit-Position: refs/heads/master@{#30517}
-
mbrandy authored
Port 29ebcc32 Original commit message: This CL introduces HPrologue instruction which does the context allocation work and supports deoptimization. R=ishell@chromium.org, jyan@ca.ibm.com, dstence@us.ibm.com, joransiu@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1324023002 Cr-Commit-Position: refs/heads/master@{#30516}
-
littledan authored
Move the --harmony-sloppy-let flag to staging for further testing, and update test262 for the new passing tests. Also increase the strictness of the parser, even in sloppy mode, to disallow "new legacy compat" for for (let x = 5 in {}) {} which is now a SyntaxError. BUG=v8:3305 LOG=Y R=adamk Review URL: https://codereview.chromium.org/1327483002 Cr-Commit-Position: refs/heads/master@{#30515}
-
mstarzinger authored
R=machenbach@chromium.org Review URL: https://codereview.chromium.org/1302413007 Cr-Commit-Position: refs/heads/master@{#30514}
-
mstarzinger authored
This turns the absolute list of linter rules within the presubmit.py wrapper into a list relative to the default of the cpplint.py script. This has the advantage that new rules are picked up when the script is updated and that allowed violations are visible from the list. R=machenbach@chromium.org Review URL: https://codereview.chromium.org/1325833005 Cr-Commit-Position: refs/heads/master@{#30513}
-
mvstanton authored
BUG= Review URL: https://codereview.chromium.org/1326483002 Cr-Commit-Position: refs/heads/master@{#30512}
-
machenbach authored
TBR=hablich@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1320443008 Cr-Commit-Position: refs/heads/master@{#30511}
-
akos.palfi authored
Use the correct sNaN value on mips32r6 also. TEST=test-api/QuietSignalingNaNs,test-api/Threading1 BUG= Review URL: https://codereview.chromium.org/1311473007 Cr-Commit-Position: refs/heads/master@{#30510}
-
mtrofin authored
(patchset #2 id:40001 of https://codereview.chromium.org/1306823005/ )" This reverts commit f68cd33b. BUG= Review URL: https://codereview.chromium.org/1314423006 Cr-Commit-Position: refs/heads/master@{#30509}
-
mvstanton authored
Pure refactoring to further reduce the header dependency tangle. BUG= R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/1309303008 Cr-Commit-Position: refs/heads/master@{#30508}
-
bmeurer authored
R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1304363012 Cr-Commit-Position: refs/heads/master@{#30507}
-
jarin authored
This replaces the counters for use representations with simple tracking of most-general representation seen so far. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1315193010 Cr-Commit-Position: refs/heads/master@{#30506}
-
hablich authored
Revert of Stop prepending "r" to commit hashes in merge_to_branch.py (patchset #1 id:1 of https://codereview.chromium.org/1298973007/ ) Reason for revert: Result when using the script: tools/release/merge_to_branch.py File "tools/release/merge_to_branch.py", line 108 self["revision_list"] = ", ".join(self["full_revision_list"])) ^ SyntaxError: invalid syntax Original issue's description: > Stop prepending "r" to commit hashes in merge_to_branch.py > > R=machenbach@chromium.org > > Committed: https://crrev.com/e5dbfd06c3dab5934e846c40af2a8b7fb5cdf0d6 > Cr-Commit-Position: refs/heads/master@{#30483} TBR=machenbach@chromium.org,adamk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1321343002 Cr-Commit-Position: refs/heads/master@{#30505}
-
machenbach authored
TBR=bmeurer@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1308563010 Cr-Commit-Position: refs/heads/master@{#30504}
-
mstarzinger authored
Now that it is no longer needed, this also removes the invalid inclusion of "object-inl.h" within the "unique.h" header file. Note that this change still leaves 2 violations of that rule in the code, checked with the "tools/check-inline-includes.sh" tool. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1321223002 Cr-Commit-Position: refs/heads/master@{#30503}
-
mlippautz authored
Revert of heap: make array buffer maps disjoint (patchset #8 id:140001 of https://codereview.chromium.org/1316873004/ ) Reason for revert: Precautionary revert. The change is incomplete. Original issue's description: > heap: make array buffer maps disjoint > > Remove intersection from the `std::map`s representing current live > ArrayBuffers. While being simpler to understand, it poses significant > performance issue for the active ArrayBuffer users (like node.js). > > Store buffers separately, and process them together during mark-sweep phase. > > The results of benchmarks are: > > $ ./node-slow bench && ./node-fast bench > 4997.4 ns/op > 4685.7 ns/op > > NOTE: `fast` - was a patched node.js, `slow` - unpatched node.js with vanilla v8. > > BUG= > > Committed: https://crrev.com/9e3676da9ab1aaf7de3e8582cb3fdefcc3dbaf33 > Cr-Commit-Position: refs/heads/master@{#30495} TBR=hpayer@chromium.org,fedor@indutny.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1302233007 Cr-Commit-Position: refs/heads/master@{#30502}
-
machenbach authored
Revert of [turbofan] greedy: heuristic for memory operands (patchset #2 id:40001 of https://codereview.chromium.org/1306823005/ ) Reason for revert: [Sheriff] Breaks test with greedy allocator: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20-%20greedy%20allocator/builds/1318 Original issue's description: > [turbofan] greedy: heuristic for memory operands > > When we have a memory operand (HasSpillOperand() == true), and it > doesn't need a register immediately, split in an optimal position, which > is outside the outermost possible loop - just like Linear does. > > This results in some modest improvements in perf, when compared > to baseline greedy. In particular Jetstream zlib x64: 4.66%, Life > (Emscripten x64) 11%; largest regression is in AreWeFastYet x64: 8% > and Corrections (Emsccripten x32) 10% > > BUG= > > Committed: https://crrev.com/8937bfc1d165ff6d72dede1b0ce6f7c1ab9fb260 > Cr-Commit-Position: refs/heads/master@{#30498} TBR=jarin@chromium.org,bmeurer@chromium.org,mtrofin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1311813005 Cr-Commit-Position: refs/heads/master@{#30501}
-
mstarzinger authored
This CL us a pure refactoring that makes an empty compilation unit including just "isolate.h" or "contexts.h" but not "objects-inl.h" compile without warnings or errors. This is needed to further reduce the header dependency tangle. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1322883002 Cr-Commit-Position: refs/heads/master@{#30500}
-
pcc authored
The code was previously reading unsigned integers by performing an invalid cast of Operator1<intNN_t> objects to Operator1<uintNN_t> and reading the integer directly. To fix the invalid cast, we cast to the correct type and static_cast the integer to uintNN_t, which is a no-op on every reasonable target. Cleanup for cfi_vptr=1; see https://www.chromium.org/developers/testing/control-flow-integrity BUG=chromium:457523 R=bmeurer@chromium.org LOG=N Review URL: https://codereview.chromium.org/1310633004 Cr-Commit-Position: refs/heads/master@{#30499}
-
mtrofin authored
When we have a memory operand (HasSpillOperand() == true), and it doesn't need a register immediately, split in an optimal position, which is outside the outermost possible loop - just like Linear does. This results in some modest improvements in perf, when compared to baseline greedy. In particular Jetstream zlib x64: 4.66%, Life (Emscripten x64) 11%; largest regression is in AreWeFastYet x64: 8% and Corrections (Emsccripten x32) 10% BUG= Review URL: https://codereview.chromium.org/1306823005 Cr-Commit-Position: refs/heads/master@{#30498}
-
machenbach authored
Partially port https://codereview.chromium.org/1243373003/ BUG=chromium:515782 LOG=n NOTRY=true Review URL: https://codereview.chromium.org/1329553002 Cr-Commit-Position: refs/heads/master@{#30497}
-
ishell authored
This CL introduces HPrologue instruction which does the context allocation work and supports deoptimization. Review URL: https://codereview.chromium.org/1317383002 Cr-Commit-Position: refs/heads/master@{#30496}
-
fedor authored
Remove intersection from the `std::map`s representing current live ArrayBuffers. While being simpler to understand, it poses significant performance issue for the active ArrayBuffer users (like node.js). Store buffers separately, and process them together during mark-sweep phase. The results of benchmarks are: $ ./node-slow bench && ./node-fast bench 4997.4 ns/op 4685.7 ns/op NOTE: `fast` - was a patched node.js, `slow` - unpatched node.js with vanilla v8. BUG= Review URL: https://codereview.chromium.org/1316873004 Cr-Commit-Position: refs/heads/master@{#30495}
-
machenbach authored
TBR=hablich@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1307123003 Cr-Commit-Position: refs/heads/master@{#30494}
-
pcc authored
Fixes an invalid cast of an Operator1<StorePropertyParameters> object to Operator1<LanguageMode> by reading the language mode from StorePropertyParameters. This code happened to work before because StorePropertyParameters's first field has type LanguageMode. Cleanup for cfi_vptr=1; see https://www.chromium.org/developers/testing/control-flow-integrity BUG=chromium:457523 R=bmeurer@chromium.org LOG=N Review URL: https://codereview.chromium.org/1311393008 Cr-Commit-Position: refs/heads/master@{#30493}
-
mtrofin authored
We completely un-wired the greedy allocator to focus on the stackchecks in loops (splintering) work. This change re-wires greedy, still behind its flag. For now, enabling the greedy allocator disables the stackchecks in loops feature (and range splintering), so that we are at the baseline we left it at. The main contribution in this change is adapting the codebase after the live range model refactoring, whereby RegisterAllocationData's live_ranges() contains just top-level ranges, and children are accessed via their parents. BUG= Review URL: https://codereview.chromium.org/1320363002 Cr-Commit-Position: refs/heads/master@{#30492}
-
pcc authored
We were previously reading a language mode from all comparison nodes in JSGenericLowering::ReplaceWithCompareIC. This read was invalid for {,Strict}{,Not}Equal nodes, as these nodes do not have a language mode, as they derive from Operator rather than from Operator1<LanguageMode>. Because these nodes are not language mode dependent, we arbitrarily pass Strength::WEAK to CodeFactory::CompareIC. Cleanup for cfi_vptr=1; see https://www.chromium.org/developers/testing/control-flow-integrity BUG=chromium:457523 R=bmeurer@chromium.org LOG=N Review URL: https://codereview.chromium.org/1319463003 Cr-Commit-Position: refs/heads/master@{#30491}
-
alph authored
Revert of Fix CPU profiler deadlock on Windows + AMD CPU. (patchset #1 id:1 of https://codereview.chromium.org/1304873011/ ) Reason for revert: Broke a test Original issue's description: > Fix CPU profiler deadlock on Windows + AMD CPU. > > Implement a lock free version of RolloverProtectedTickClock::Now > to eliminate a deadlock. > > BUG=chromium:521420 > LOG=Y > > Committed: https://crrev.com/d6db8e5902af1f067f0f149844f4e92824ee93f3 > Cr-Commit-Position: refs/heads/master@{#30489} TBR=yurys@chromium.org,caseq@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:521420 Review URL: https://codereview.chromium.org/1303423006 Cr-Commit-Position: refs/heads/master@{#30490}
-
alph authored
Implement a lock free version of RolloverProtectedTickClock::Now to eliminate a deadlock. BUG=chromium:521420 LOG=Y Review URL: https://codereview.chromium.org/1304873011 Cr-Commit-Position: refs/heads/master@{#30489}
-
- 31 Aug, 2015 2 commits
-
-
yurys authored
The interrupts are already postponed in message handlers [1]. This CL aligns debug event listener (the mechanism that is actually used in Chrome DevTools) implementation with that. Handling interrupts on events like v8::AfterCompile leads to crashes like the one in the lined bug. This happens because in the interrupt handler we may change debugger state. [1] https://codereview.chromium.org/309533009/diff/40001/src/debug.cc BUG=chromium:520702 LOG=Y Review URL: https://codereview.chromium.org/1321263002 Cr-Commit-Position: refs/heads/master@{#30488}
-
Michael Lippautz authored
TBR=mstarzinger@chromium.org BUG=chromium:526244 LOG=N Review URL: https://codereview.chromium.org/1329493002 . Cr-Commit-Position: refs/heads/master@{#30487}
-