1. 17 Nov, 2021 1 commit
  2. 30 Jun, 2021 1 commit
  3. 11 Jun, 2021 1 commit
  4. 10 Jun, 2021 1 commit
  5. 08 Jun, 2021 1 commit
  6. 27 May, 2021 1 commit
  7. 19 May, 2021 1 commit
  8. 29 Apr, 2021 1 commit
    • Benedikt Meurer's avatar
      [debugger] Remove "Restart frame" feature. · 93f85699
      Benedikt Meurer authored
      The "Restart frame" feature was implemented as part of LiveEdit and
      primarily used to support LiveEdit of active functions, but that was
      previously disabled as part of https://crrev.com/c/2846892 because it's
      too brittle and causes crashes when using seemingly unrelated features.
      The "Restart frame" feature was also available as a context menu item
      separately in the DevTools front-end, but that was also already removed
      as part of https://crrev.com/c/2854681 earlier. So all uses are gone
      now.
      
      This change works by marking Debugger.restartFrame as deprecated and
      having it respond with a ServerError all the time. It thus allows us to
      remove a whole bunch of machinery that was essentially just put in
      various places to support the restart_fp_ magic. In particular the
      debugger no longer needs any machine specific builtins now.
      
      Bug: chromium:1195927
      Change-Id: I1153ba6b00e979620af57dd9f58aa1c035ec4484
      Fixed: chromium:1203606
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2854750Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#74276}
      93f85699
  9. 19 Apr, 2021 2 commits
    • Milad Fa's avatar
      PPC/S390 [codegen]: Add placeholders instead of no_reg · bab79d3c
      Milad Fa authored
      After https://crrev.com/c/2831872 Baseline and Compare_Baseline
      functions need to return proper registers as placeholders.
      
      More details can be found on comment section of this port:
      https://crrev.com/c/2830897
      
      Change-Id: I7f91a85f9c85ce1813540b4d525f2dce5faaf279
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2836705Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Reviewed-by: 's avatarJunliang Yan <junyan@redhat.com>
      Commit-Queue: Milad Fa <mfarazma@redhat.com>
      Cr-Commit-Position: refs/heads/master@{#74047}
      bab79d3c
    • Milad Fa's avatar
      PPC/s390: Reland "[codegen] Add static interface descriptors" · ea177a6b
      Milad Fa authored
      Port 2871e05c
      
      Original Commit Message:
      
          This is a reland of ae0752df
      
          Reland fixes:
      
            * Remove UNREACHABLE() from constexpr switch, since we don't have a
              CONSTEXPR_UNREACHABLE() (it's ok, the switch is exhaustive for the
              enum anyway).
            * Fix IsRegisterArray trait to use public inheritance and size_t for
              std::array size.
      
          Original change's description:
          > [codegen] Add static interface descriptors
          >
          > Add a new CRTP StaticCallInterfaceDescriptor class, which provides
          > static constexpr getters for a descriptor's registers, parameter counts,
          > and so on. Each CallInterfaceDescriptor subclass is changed to extend
          > StaticCallInterfaceDescriptor, with StaticCallInterfaceDescriptor itself
          > extending CallInterfaceDescriptor to still provide a dynamic lookup
          > where needed.
          >
          > StaticCallInterfaceDescriptor provides a couple of customisation points,
          > where it reads its CRTP derived descriptor's static fields and
          > functions, with default fallbacks where appropriate. With these
          > customisation points, the definition of CallInterfaceDescriptor
          > subclasses is simplified to:
          >
          >     a) Providing parameter names (as before)
          >     b) Providing parameter types (as before)
          >     c) Optionally setting flags (like kNoContext or kAllowVarArgs) as
          >        static booleans on the class.
          >     d) Optionally providing a `registers()` method that returns a
          >        std::array<Register, N> of registers that may be used for
          >        parameters (if not provided, this defaults to the implementation
          >        specific default register set).
          >
          > Parameter registers (and register count) are automagically set based on
          > the number of parameters and number of given registers, with extra magic
          > to ignore no_reg registers (to reduce ia32 special casing). The
          > CallInterfaceDescriptorData is initialized based on these static
          > functions, rather than manual per-descriptor initializers.
          >
          > This allows us to skip loading descriptors dynamically for CallBuiltin
          > in Sparkplug, and instead lets us use a bit of template magic to
          > statically set up arguments for the calls. Any other users of statically
          > known descriptors will also benefit, thanks to C++ picking the static
          > methods over the dynamic methods on the base class when available.
          >
          > Because we can remove various virtual functions and trigger heavier
          > inlining of constantly known values, binary size slightly decreases with
          > this change.
          >
          > Note that torque-generated descriptors are changed to use the same magic,
          > rather than having Torque-specific magic, for consistency.
          >
          > Bug: v8:11420
          > Change-Id: Icc5e238b6313a08734feb564204a13226b450c22
          > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2814518
          > Auto-Submit: Leszek Swirski <leszeks@chromium.org>
          > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
          > Reviewed-by: Clemens Backes <clemensb@chromium.org>
          > Reviewed-by: Igor Sheludko <ishell@chromium.org>
          > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
          > Commit-Queue: Clemens Backes <clemensb@chromium.org>
          > Cr-Commit-Position: refs/heads/master@{#73996}
      
      R=leszeks@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com
      BUG=
      LOG=N
      
      Change-Id: Id854bb901df72787ed225fc8790c3f626121ab3a
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2830897Reviewed-by: 's avatarJunliang Yan <junyan@redhat.com>
      Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Commit-Queue: Milad Fa <mfarazma@redhat.com>
      Cr-Commit-Position: refs/heads/master@{#74034}
      ea177a6b