Commit ae569cf8 authored by Milad Fa's avatar Milad Fa Committed by V8 LUCI CQ

PPC/s390: Update comments about argument count in interface descriptors

Port 2e955523

Original Commit Message:

    Comments in interface-descriptors stated that the argument count is
    without the receiver, which is no longer true (see [1]).

    [1] https://crrev.com/c/3140608

R=pthier@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com
BUG=
LOG=N

Change-Id: I1bbce6672f19a3e508676e4b23cf9910542cbb21
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3285407Reviewed-by: 's avatarPatrick Thier <pthier@chromium.org>
Reviewed-by: 's avatarJoran Siu <joransiu@ca.ibm.com>
Commit-Queue: Milad Fa <mfarazma@redhat.com>
Cr-Commit-Position: refs/heads/main@{#77949}
parent 62a0841b
......@@ -121,7 +121,7 @@ constexpr auto CallTrampolineDescriptor::registers() {
// static
constexpr auto CallVarargsDescriptor::registers() {
// r3 : number of arguments (on the stack, not including receiver)
// r3 : number of arguments (on the stack)
// r4 : the target to call
// r7 : arguments list length (untagged)
// r5 : arguments list (FixedArray)
......@@ -139,13 +139,13 @@ constexpr auto CallForwardVarargsDescriptor::registers() {
// static
constexpr auto CallFunctionTemplateDescriptor::registers() {
// r4 : function template info
// r5 : number of arguments (on the stack, not including receiver)
// r5 : number of arguments (on the stack)
return RegisterArray(r4, r5);
}
// static
constexpr auto CallWithSpreadDescriptor::registers() {
// r3 : number of arguments (on the stack, not including receiver)
// r3 : number of arguments (on the stack)
// r4 : the target to call
// r5 : the object to spread
return RegisterArray(r4, r3, r5);
......@@ -160,7 +160,7 @@ constexpr auto CallWithArrayLikeDescriptor::registers() {
// static
constexpr auto ConstructVarargsDescriptor::registers() {
// r3 : number of arguments (on the stack, not including receiver)
// r3 : number of arguments (on the stack)
// r4 : the target to call
// r6 : the new target
// r7 : arguments list length (untagged)
......@@ -179,7 +179,7 @@ constexpr auto ConstructForwardVarargsDescriptor::registers() {
// static
constexpr auto ConstructWithSpreadDescriptor::registers() {
// r3 : number of arguments (on the stack, not including receiver)
// r3 : number of arguments (on the stack)
// r4 : the target to call
// r6 : the new target
// r5 : the object to spread
......@@ -241,7 +241,7 @@ constexpr auto InterpreterDispatchDescriptor::registers() {
// static
constexpr auto InterpreterPushArgsThenCallDescriptor::registers() {
return RegisterArray(r3, // argument count (not including receiver)
return RegisterArray(r3, // argument count
r5, // address of first argument
r4); // the target callable to be call
}
......@@ -249,7 +249,7 @@ constexpr auto InterpreterPushArgsThenCallDescriptor::registers() {
// static
constexpr auto InterpreterPushArgsThenConstructDescriptor::registers() {
return RegisterArray(
r3, // argument count (not including receiver)
r3, // argument count
r7, // address of the first argument
r4, // constructor to call
r6, // new target
......
......@@ -121,7 +121,7 @@ constexpr auto CallTrampolineDescriptor::registers() {
// static
constexpr auto CallVarargsDescriptor::registers() {
// r2 : number of arguments (on the stack, not including receiver)
// r2 : number of arguments (on the stack)
// r3 : the target to call
// r6 : arguments list length (untagged)
// r4 : arguments list (FixedArray)
......@@ -139,13 +139,13 @@ constexpr auto CallForwardVarargsDescriptor::registers() {
// static
constexpr auto CallFunctionTemplateDescriptor::registers() {
// r3 : function template info
// r4 : number of arguments (on the stack, not including receiver)
// r4 : number of arguments (on the stack)
return RegisterArray(r3, r4);
}
// static
constexpr auto CallWithSpreadDescriptor::registers() {
// r2: number of arguments (on the stack, not including receiver)
// r2: number of arguments (on the stack)
// r3 : the target to call
// r4 : the object to spread
return RegisterArray(r3, r2, r4);
......@@ -160,7 +160,7 @@ constexpr auto CallWithArrayLikeDescriptor::registers() {
// static
constexpr auto ConstructVarargsDescriptor::registers() {
// r2 : number of arguments (on the stack, not including receiver)
// r2 : number of arguments (on the stack)
// r3 : the target to call
// r5 : the new target
// r6 : arguments list length (untagged)
......@@ -179,7 +179,7 @@ constexpr auto ConstructForwardVarargsDescriptor::registers() {
// static
constexpr auto ConstructWithSpreadDescriptor::registers() {
// r2 : number of arguments (on the stack, not including receiver)
// r2 : number of arguments (on the stack)
// r3 : the target to call
// r5 : the new target
// r4 : the object to spread
......@@ -241,7 +241,7 @@ constexpr auto InterpreterDispatchDescriptor::registers() {
// static
constexpr auto InterpreterPushArgsThenCallDescriptor::registers() {
return RegisterArray(r2, // argument count (not including receiver)
return RegisterArray(r2, // argument count
r4, // address of first argument
r3); // the target callable to be call
}
......@@ -249,7 +249,7 @@ constexpr auto InterpreterPushArgsThenCallDescriptor::registers() {
// static
constexpr auto InterpreterPushArgsThenConstructDescriptor::registers() {
return RegisterArray(
r2, // argument count (not including receiver)
r2, // argument count
r6, // address of the first argument
r3, // constructor to call
r5, // new target
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment