- 07 Sep, 2010 1 commit
-
-
whesse@chromium.org authored
Review URL: http://codereview.chromium.org/3351010/show Committed for Thiago Farina <tfarina@chromium.org> git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5419 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 Aug, 2010 1 commit
-
-
sgjesse@chromium.org authored
The live registers are now only stored to the expression stack with the non pointer values being stored as smis (on the 32-bit platforms these values are assumed to be 31-bit max). This makes the CEntryStub entry/exit code much simpler, and there is no longer any need for a mode (debug or normal) on it. Fix a missing live register when breaking at ARM keyed load. Review URL: http://codereview.chromium.org/3141047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5358 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 25 Aug, 2010 1 commit
-
-
sgjesse@chromium.org authored
The change of calling convention in the CallIC was not reflected in the debug break code. Without the change to the debug break code the added test crashed. Review URL: http://codereview.chromium.org/3167037 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5333 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 13 Aug, 2010 1 commit
-
-
peter.rybin@gmail.com authored
Review URL: http://codereview.chromium.org/3120011 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5264 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Jul, 2010 1 commit
-
-
peter.rybin@gmail.com authored
Review URL: http://codereview.chromium.org/3066018 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5160 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 Jul, 2010 2 commits
-
-
peter.rybin@gmail.com authored
Review URL: http://codereview.chromium.org/3012035 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5154 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
peter.rybin@gmail.com authored
Review URL: http://codereview.chromium.org/3029033 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5150 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 09 Jun, 2010 1 commit
-
-
sgjesse@chromium.org authored
These issues where unly revealed in debug mode Review URL: http://codereview.chromium.org/2733006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4827 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 08 Jun, 2010 1 commit
-
-
sgjesse@chromium.org authored
Added support for more precise break points when debugging and stepping. To achieve that additional nop instructions are inserted where breaking would otherwise be impossible. The number of nop instructions inserted are sufficient to make place for patching with a call to a debug break code stub. On Intel that is 5 nop's for 32-bit and 13 for 64-bit. Om ARM 3 nop instructions (12 bytes) are required. In order to avoid inserting nop's in to many places a simple ast checker have been added to check whether there are breakable code in a statement or expression. If it is possible to break in an expression no additional break enabeling code is inserted. Added break locations to the true and false part of a conditional expression. Added stepping tests to cover more constructs. These changes are only in the full compiler. Changed the default value for the option --debugger in teh d8 shell from true to false. The reason for this is that with --debugger turned on the full compiler will be used for all code in when running d8, which can be unexpeceted. Review URL: http://codereview.chromium.org/2693002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4820 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 May, 2010 1 commit
-
-
sgjesse@chromium.org authored
The calling convention for keyed store IC on ARM is changed to receive the arguments value, key and receiver in registers r0, r1 and r2 instead of on the stack. When calling keyed store IC with a virtual frame the arguments are passed through the virtual frame and consumed by the call. Changed the register usage in the IC code to postpone spilling the registers holding value, key and receiver to the stack until making a call into the runtime system. Runs all the tests with: --special-command="@ --nofull-compiler" --special-command="@ --always-full-compiler" --special-command="@ --noenable-vfp3" Review URL: http://codereview.chromium.org/2116003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4668 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 17 May, 2010 1 commit
-
-
mark@chromium.org authored
Chromium build. v8.gyp no longer sets any V8_TARGET_ARCH_* macro on the Mac. Instead, the proper V8_TARGET_ARCH_* macro will be set by src/globals.h in the same way as the V8_HOST_ARCH_* macro when it detects that no target macro is currently defined. The Mac build will attempt to compile all ia32 and x86_64 .cc files. #ifdef guards in each of these target-specific source files prevent their compilation when the associated target is not selected. For completeness, these #ifdef guards are also provided for the arm and mips .cc files. BUG=706 TEST=x86_64 Mac GYP/Xcode-based Chromium build (still depends on other changes) Review URL: http://codereview.chromium.org/2133003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4666 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 05 May, 2010 1 commit
-
-
sgjesse@chromium.org authored
The calling convention for keyed load IC is changed to have the key passed both in a register (r0) and on the stack. Next steps will be first to remove the key from the stack and then pass the receiver in a register (r1). Review URL: http://codereview.chromium.org/1937003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4584 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 Apr, 2010 1 commit
-
-
erik.corry@gmail.com authored
is both on top of the stack and also in r0. This makes sense because the receiver is usually in r0 anyway. We may remove it from the stack later. Also removes some spilled scopes from the code generator allowing it to keep expression temporaries in registers more. Review URL: http://codereview.chromium.org/1751019 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4518 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 06 Apr, 2010 1 commit
-
-
peter.rybin@gmail.com authored
Review URL: http://codereview.chromium.org/1118007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4351 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 19 Mar, 2010 1 commit
-
-
erik.corry@gmail.com authored
available. Using blx will allow the CPU to predict the return address fo the function, resulting in better overall performamce. This is a copy of http://codereview.chromium.org/1113002 by rodolph.perfetta@googlemail.com git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4198 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Feb, 2010 1 commit
-
-
whesse@chromium.org authored
Review URL: http://codereview.chromium.org/554152 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3830 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 Feb, 2010 1 commit
-
-
http://codereview.chromium.org/555164serya@chromium.org authored
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3775 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 Jan, 2010 1 commit
-
-
serya@chromium.org authored
Review URL: http://codereview.chromium.org/543207 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3745 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Nov, 2009 1 commit
-
-
fschneider@chromium.org authored
The constant for the return sequence length (JSReturnSequenceLength) was defined in debug.h. Since this constant are also needed outside the debugger code I moved them into assembler-xxx.h. Otherwise compiling with debuggersupport=off would fail on ARM. BUG=http://code.google.com/p/v8/issues/detail?id=533 Review URL: http://codereview.chromium.org/456001 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3383 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Nov, 2009 1 commit
-
-
sgjesse@chromium.org authored
The generation of the return sequence is now protected from having the constant pool emitted inside of it in both compilers. BUG=http://code.google.com/p/v8/issues/detail?id=491 TEST=test/mjsunit/regress/regress-491.js Review URL: http://codereview.chromium.org/362003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3215 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 15 Oct, 2009 1 commit
-
-
whesse@chromium.org authored
Fix X64 build in the case that debugger support is disabled. Change function name from IsCallInstruction to IsPatchedReturnSequence on all platforms. Review URL: http://codereview.chromium.org/267116 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3072 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Sep, 2009 1 commit
-
-
sgjesse@chromium.org authored
The main piece of this change was to add support for break on return for ARM. On ARM the normal js function return consist of the following code sequence. mov sp, fp ldmia sp!, {fp, lr} add sp, sp, #4 bx lr to a call to the debug break return entry code using the following code sequence mov lr, pc ldr pc, [pc, #-4] <debug break return entry code entry point address> bktp 0 The values of Assembler::kPatchReturnSequenceLength and Assembler::kPatchReturnSequenceLength are somewhat misleading, but they fit the current use in the debugger. Also Assembler::kPatchReturnSequenceLength is used in the IC code as well (for something which is not related to return sequences at all). I will change that in a separate changelist. For the debugger to work also added recording of the return sequence in the relocation info and handling of source position recording when a function ends with a return statement. Used the constant kInstrSize instead of sizeof(Instr). Passes all debugger tests on both simulator and hardware (only release mode tested on hardware). Review URL: http://codereview.chromium.org/199075 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2879 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 09 Sep, 2009 1 commit
-
-
sgjesse@chromium.org authored
Removed implementation of function which was no longer member of class Debug. TBR=lrn@chromium.org Review URL: http://codereview.chromium.org/199063 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2864 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 25 May, 2009 1 commit
-
-
mikhail.naganov@gmail.com authored
This issue was raised by Brett Wilson while reviewing my changelist for readability. Craig Silverstein (one of C++ SG maintainers) confirmed that we should declare one namespace per line. Our way of namespaces closing seems not violating style guides (there is no clear agreement on it), so I left it intact. Review URL: http://codereview.chromium.org/115756 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2038 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 23 Apr, 2009 1 commit
-
-
lrn@chromium.org authored
Move ia32 and arm specific files to subdirectories to make it easier to add more backends. Review URL: http://codereview.chromium.org/92068 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1782 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 21 Apr, 2009 1 commit
-
-
erik.corry@gmail.com authored
* Move ARM coverage code to ARM-specific file and add missing file to cover. Review URL: http://codereview.chromium.org/88025 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1754 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 20 Apr, 2009 1 commit
-
-
feng@chromium.org authored
ENABLE_DEBUGGER_SUPPORT is enabled by default unless it is on Android platform. On Android platform, it can also enabled by passing -DENABLE_DEBUGGER_SUPPORT flag to the compiler. This should not affect any existing build (I hope, cross my fingers) except the build in real Android environment (in other word, it only affects me now). There are lot of room for code refactoring in stead of using #ifdef all over the place. I will leave this to v8 folks. Review URL: http://codereview.chromium.org/77035 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1745 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 Apr, 2009 1 commit
-
-
erik.corry@gmail.com authored
(at the moment only if we do not need to allocate a heap number). Find a few more oportunities to avoid heap number allocation on IA32. Add some infrastructure to test coverage of generated ARM code in our tests. Review URL: http://codereview.chromium.org/67163 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1720 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 13 Feb, 2009 1 commit
-
-
sgjesse@chromium.org authored
Added a number of handle scopes to the debugger code to keep handles local to the function using them. Fixed SetDebugEventListener to actually unregister when passed a NULL pointer. Previously this NULL pointer was wrapped in a Proxy. BUG=1242702 Review URL: http://codereview.chromium.org/21347 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1269 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 09 Feb, 2009 1 commit
-
-
sgjesse@chromium.org authored
Renamed functions related to patching of code with call instructions to match the naming conversion. BUG=1240753 Review URL: http://codereview.chromium.org/20176 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1239 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 09 Dec, 2008 1 commit
-
-
sgjesse@chromium.org authored
Moved the code generation for debug break stubs from builtins* to debug*. From builtins* all code generation delegate to debug*. Added files debug-ia32.cc and debug-arm.cc for platfoem specific code generation of debugger stubs. Removed a dead file reference (frames-ia32-inl.h) from the Visual Studio project. Updated the ARM Visual Studio project to build again by adding all the RegExp files. Review URL: http://codereview.chromium.org/13657 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@947 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-