- 14 Jul, 2021 1 commit
-
-
Emanuel Ziegler authored
This is a reland of dcdaf42f. It adds CPU time metrics to the WasmModuleDecoded (except for streaming), WasmModuleCompiled and WasmModuleTieredUp events. This can later be used to provide this information as UKMs or UMAs. Bug: v8:11611 Change-Id: I813fc8de36d1445c6a887abf496ec10e1a803815 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953296Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#75715}
-
- 13 Jul, 2021 1 commit
-
-
Omer Katz authored
Reporting an event requires virtual calls. Frequent incremental events seem to cause performance regression. Mitigate by batching events reporting. See usage in crrev.com/c/2992193 Bug: chromium:1214693 Change-Id: Iff212d0e9f90a2716956458c6e828fbe87a7b780 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992712 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#75695}
-
- 14 Apr, 2021 1 commit
-
-
Ulan Degenbaev authored
Bug: chromium:1173527 Change-Id: If918b739f137b9c09030104b909e7bd2d4cd5984 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2817616Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#73953}
-
- 09 Apr, 2021 2 commits
-
-
Michael Achenbach authored
This reverts commit dcdaf42f. Reason for revert: This has problems on mac-arm64: https://ci.chromium.org/p/v8/builders/ci/V8%20Mac%20-%20arm64%20-%20release/3591 Original change's description: > [wasm] Add CPU time metrics > > This adds CPU time metrics to the WasmModuleDecoded (except for streaming), > WasmModuleCompiled and WasmModuleTieredUp events. This can later be used > to provide this information as UKMs or UMAs. > > Bug: v8:11611 > Change-Id: I36818f5efbdcae2d3ed6f27c16db21f9d8440d98 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2796952 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73882} Bug: v8:11611 Change-Id: I1c82c3e4f19b3a486538fd62665669f6c5b98438 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2818380 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73884}
-
Emanuel Ziegler authored
This adds CPU time metrics to the WasmModuleDecoded (except for streaming), WasmModuleCompiled and WasmModuleTieredUp events. This can later be used to provide this information as UKMs or UMAs. Bug: v8:11611 Change-Id: I36818f5efbdcae2d3ed6f27c16db21f9d8440d98 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2796952Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#73882}
-
- 27 Jan, 2021 1 commit
-
-
Ulan Degenbaev authored
The naming follows the scheme outlined in bit.ly/v8-gc-stats-collection and in the UMA document referenced from it. Bug: chromium:1154636 Change-Id: I872520de06e62f58d771383fd87d8aa06386bf0d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2650213Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#72364}
-
- 24 Nov, 2020 1 commit
-
-
Sara Tang authored
Removed wall_clock_time_in_us field. Bug: v8:11109 Change-Id: Ib3efa74fc741b793ef064c1d12ca1797be3a10c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2550280Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Sara Tang <sartang@microsoft.com> Cr-Commit-Position: refs/heads/master@{#71386}
-
- 09 Nov, 2020 1 commit
-
-
Sara Tang authored
As part of an effort to prepare the Recorder interface for general use, we had to make some changes to the way the existing Wasm Events are being used. In particular, - it is more fitting to use a ElapsedTimer than a TimedScope to measure the durations in src/wasm/module-[decoder|instantiate].cc - we want to rename the wall_clock_time_in_us field to duration_in_us for clarity. Because these Wasm events are already being instantiated in chromium, renaming the field requires a two-step change. This is the first of those changes. Change-Id: If1b2990f7645616a59fc21d07ac10bf00701c0e5 Bug: v8:11109 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2518619Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Emanuel Ziegler <ecmziegler@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#71053}
-
- 24 Sep, 2020 1 commit
-
-
Emanuel Ziegler authored
Ensure that events are triggered when a module is decoded, compiled, instantiated and tiered-up. This is a reland of Ib5883a338c3756c6f3488fbdd7b6861ecc2ba218. R=clemensb@chromium.org TBR=adamk@chromium.org Bug: chromium:1092417 Change-Id: I803ae3db23a5f71f26e8ec118251eccdfc551353 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2425056 Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#70113}
-
- 22 Sep, 2020 2 commits
-
-
Francis McCabe authored
This reverts commit 54b141ef. Reason for revert: closed tree due to: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20noi18n%20-%20debug/33838? Original change's description: > [wasm][ukm] Add tests for Wasm events (reland) > > Ensure that events are triggered when a module is decoded, compiled, > instantiated and tiered-up. > > This is a reland of I9dc87957fc03023c5ab1c4f49e865957c8324e1a. > > R=clemensb@chromium.org > > Bug: chromium:1092417 > Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng > Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng > Change-Id: Ib5883a338c3756c6f3488fbdd7b6861ecc2ba218 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2367866 > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70074} TBR=adamk@chromium.org,clemensb@chromium.org,ecmziegler@chromium.org Change-Id: I859c69bacfca9c790ed274140bb9e8d23de26729 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1092417 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2425104Reviewed-by:
Francis McCabe <fgm@chromium.org> Commit-Queue: Francis McCabe <fgm@chromium.org> Cr-Commit-Position: refs/heads/master@{#70075}
-
Emanuel Ziegler authored
Ensure that events are triggered when a module is decoded, compiled, instantiated and tiered-up. This is a reland of I9dc87957fc03023c5ab1c4f49e865957c8324e1a. R=clemensb@chromium.org Bug: chromium:1092417 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng Change-Id: Ib5883a338c3756c6f3488fbdd7b6861ecc2ba218 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2367866Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#70074}
-
- 01 Aug, 2020 1 commit
-
-
Ulan Degenbaev authored
Chrome is currently adding a 128-bit V8ContextToken to keep track of V8 contexts across multiple isolates and processes. Having per-isolate token exposed by V8 leads to confusion of these two tokens. This moves v8::Context::Token to v8::metrics::Recorder and changes the corresponding functions: - v8::Context::GetToken => v8::metrics::Recorder::GetContextId - v8::Context::GetByToken => v8::metrics::Recorder::GetContext This CL is purely mechanical and does not change the behaviour. Bug: chromium:1101749 Tbr: clemensb@chromium.org Change-Id: I31bbfa02ebab1c0d91b00f0d08c1b236392d14d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2330023 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#69188}
-
- 28 Jul, 2020 1 commit
-
-
Emanuel Ziegler authored
Add a framework for collecting event-based metrics like UKMs in V8 that is independent of the actual implementation. Design doc: https://docs.google.com/document/d/1vCZQCh4B05isqwJOwTPv7WqcnVp4KJITMgsHSBg35ZI/ R=ulan@chromium.org Bug: chromium:1101749 Change-Id: If3a5b954d1f0bcee4e06a03467b651feae378a5f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2288231 Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#69098}
-