- 21 Aug, 2014 17 commits
-
-
bmeurer@chromium.org authored
R=machenbach@chromium.org Review URL: https://codereview.chromium.org/485273004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23273 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
wingo@igalia.com authored
R=dslomov@chromium.org BUG= Review URL: https://codereview.chromium.org/479543003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23272 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
TBR=jarin@chromium.org Review URL: https://codereview.chromium.org/494973004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23271 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jarin@chromium.org authored
Bunch of changes were necessary: - refactor attaching the frame states/lazy bailouts in AstGraphBuilder (essentialy reland of r23096), - attaching frame state to some JS nodes in a similar way to attaching context (this is quite ugly and we should take another look at this), - new bailout point for the debugger statement, - register allocation constraints for the frame states, - generating translations and deopt entries, attaching them to safepoints, - enabled one mjsunit test for debugger state that uses the generated frame state. BUG= R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/492203002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23270 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
wingo@igalia.com authored
Thanks to Yutaka Hirano <yhirano@chromium.org> for finding the bug and providing the test case. R=rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/496663002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23269 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
commit-bot@chromium.org authored
BUG=chromium:403409,chromium:178409 R=jkummerow@chromium.org LOG=N Review URL: https://codereview.chromium.org/480763003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23268 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
verwaest@chromium.org authored
BUG= R=ulan@chromium.org Review URL: https://codereview.chromium.org/494063002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23267 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
marja@chromium.org authored
Why this is better: 1) Not needing an extra template parameter for Checkpoints ctors. This was especially confusing since the template parameter was named Parser and Parser is also used as a type name and is also a concrete type. This CL makes it clear that ParserTraits::Checkpoint is consturcted with ParserBase<ParserTraits> - that's the only sensemaking type for the ctor param anyway. 2) This CL makes ParserBase define a Checkpoint base class (which knows how to create and restore a checkpoint with ParserBase) which PreParserTraits::Checkpoint and ParserTraits::Checkpoint inherit, and not the other way around. This is a more intuitive way to implement the "base functionality + extending it" concept than the previous solution. The previous solution was to allow Traits to define a Checkpoint class and make ParserBase<Traits>::ParserCheckpoint (which defines the base functionality) inherit from it. 3) This CL moves the Checkpoint class definitions out of the SomeTraits::Type struct; SomeTraits::Type is supposed to be a collection of typedefs and not contain anything else. Checkpoints were introduced in r22925 ( https://codereview.chromium.org/443903003 ). BUG= R=wingo@igalia.com Review URL: https://codereview.chromium.org/485473004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23266 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
wingo@igalia.com authored
R=arv@chromium.org, rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/344223006 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23265 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
BUG= R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/489343002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23264 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
verwaest@chromium.org authored
BUG= R=yangguo@chromium.org Review URL: https://codereview.chromium.org/495483003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23263 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
verwaest@chromium.org authored
BUG= R=yangguo@chromium.org Review URL: https://codereview.chromium.org/491023002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23262 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
verwaest@chromium.org authored
BUG= R=yangguo@chromium.org Review URL: https://codereview.chromium.org/494663002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23261 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
verwaest@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/492433005 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23260 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
R=machenbach@chromium.org BUG=v8:3525 LOG=N Review URL: https://codereview.chromium.org/479793005 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23259 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/492213002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23258 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
TEST=mjsunit/regress/regress-crbug-405517 BUG=405517 LOG=y R=jarin@chromium.org Review URL: https://codereview.chromium.org/491863002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23255 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 20 Aug, 2014 23 commits
-
-
dslomov@chromium.org authored
R=arv@chromium.org, rossberg@chromium.org, wingo@igalia.com, yangguo@chromium.org Review URL: https://codereview.chromium.org/486763002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23252 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23251 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
verwaest@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/489063002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23250 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
arv@chromium.org authored
This extracts the parsing of the ObjectLiteralProperty into its own function. This is in preparation for adding support for parsing classes. BUG=None LOG=Y R=dslomov@chromium.org, marja@chromium.org Review URL: https://codereview.chromium.org/458613004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23249 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
hpayer@chromium.org authored
BUG= R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/490943002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23248 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
wingo@igalia.com authored
Add new "Name" type to API that is a supertype of Symbol and String. Object::SetDeclaredAccessor, Object::SetAccessorProperty, Template::Set, Template::SetAccessorProperty, and Template::SetDeclaredAccessor now take a Name as the property name instead of a String. Add Object::SetAccessor, Template::SetNativeDataProperty, and ObjectTemplate::SetAccessor overloads that can define accessors for symbol-named properties. R=dcarney@chromium.org, rossberg@chromium.org BUG=v8:3394 TEST=cctest/test-api/TestSymbolProperties LOG=Y Review URL: https://codereview.chromium.org/459413002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23247 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
arv@chromium.org authored
In ES6 duplicate properties are allowed BUG= LOG=Y Review URL: https://codereview.chromium.org/492793002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23246 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
verwaest@chromium.org authored
BUG= R=yangguo@chromium.org Review URL: https://codereview.chromium.org/488073002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23245 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rmcilroy@chromium.org authored
This broke ReleaseOverReservedPages on Windows ia32. TBR=hpayer@chromium.org Review URL: https://codereview.chromium.org/493703002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23244 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
Jacob.Bramley@arm.com authored
The `right == 0` checks only worked for `0 <= right < 32`. This patch replaces the checks with simple tests for negative results. The attached test can detect this error, but the test relies on a broken flag (--noopt-safe-uint32-operations), so it is skipped for now. See issue 3487 for details. BUG= R=ulan@chromium.org Review URL: https://codereview.chromium.org/487913005 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23243 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rmcilroy@chromium.org authored
Add serializer support for builtins pointed by inner pointer and root objects pointed to by code for the out-of-line constant pool. This is required for test-serialize tests which fail at the DCHECK on L1874 of serialize.cc otherwise. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/475753002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23242 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rmcilroy@chromium.org authored
The OOL constant pool places constants in the old pointer space rather than the code space which makes test-heap/ReleaseOverReservedPages fail. Modify SizeOfFirstPage to increase the initial size of old-pointer space by the size of the constant pool and decrease the code space by a corresponding amount. R=hpayer@chromium.org Review URL: https://codereview.chromium.org/479553002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23241 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
verwaest@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/489033002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23240 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
arv@chromium.org authored
This removes the duplicate property checker and updates the tests. BUG=v8:3498 LOG=Y R=marja@chromium.org Review URL: https://codereview.chromium.org/459463002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23239 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
R=rtoy@chromium.org BUG=v8:3479 LOG=N Review URL: https://codereview.chromium.org/465353002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23238 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ulan@chromium.org authored
R=wingo@igalia.com TBR=hpayer@chromium.org BUG= Review URL: https://codereview.chromium.org/494683002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23237 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
verwaest@chromium.org authored
BUG= R=yangguo@chromium.org Review URL: https://codereview.chromium.org/491873002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23236 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
verwaest@chromium.org authored
BUG= R=yangguo@chromium.org Review URL: https://codereview.chromium.org/494583003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23235 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
TBR=yanggou@chromium.org Review URL: https://codereview.chromium.org/488103002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23232 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
sigurds@chromium.org authored
Reland Fixes: * Remove usage of C++11 vector members. * Guard tests by V8_TURBO_TARGET. Changes: * Make context specialization clean up after itself. * Add UpdateToAndIncrement to Inputs::iterator. Uses:iterator already provides this member function. * Allow next node id in graph to be set. R=titzer@chromium.org, mstarzinger@chromium.org Review URL: https://codereview.chromium.org/484083003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23231 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
R=verwaest@chromium.org BUG=405499 LOG=N Review URL: https://codereview.chromium.org/491843002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23230 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
The bit counting functions provided by CompilerIntrinsics were undefined for zero, which was easily overlooked and unsafe in general. Also their implementation was kinda hacky and mostly untested. Fixed the implementation and moved the functions to base/bits.h. TEST=base-unittests,cctest,compiler-unittests,mjsunit R=hpayer@chromium.org Review URL: https://codereview.chromium.org/494633002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23229 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
R=jkummerow@chromium.org BUG=405491 LOG=N Review URL: https://codereview.chromium.org/468803004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23228 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-