Commits · e5f187995def57ee138d1a5c50d79c8c45e545cb · Linshizhi / V8

20 Nov, 2013 29 commits

Mark flaky debug test as failing. · e5f18799

yangguo@chromium.org authored Nov 20, 2013

The issues are known. For the time being, we mark it as failing.

R=machenbach@chromium.org
BUG=v8:2921, v8:3005
LOG=N

Review URL: https://codereview.chromium.org/77723008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17938 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e5f18799

MIPS: Remove the first_right_arg hack for HMod. · 29e47d1f

plind44@gmail.com authored Nov 20, 2013

Port r17919 (23e9644)

Original commit message:
Generate a proper subgraph in BuildBinaryOperation instead.

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/78663002

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17937 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

29e47d1f

Reland r17907 - Make it possible to add more than one piece of embedder data to isolates" · 840bc42d

jochen@chromium.org authored Nov 20, 2013

This will allow for using gin and blink bindings in the same
process.

Over r17907, I changed the order of fields in Isolate to be stable across different platforms, since the ABI defined packing is not the same on
all targets, and I initialize the embedder data field in Isolate.

BUG=317398
R=svenpanne@chromium.org, dcarney@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/78453002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17935 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

840bc42d

Update benchmark test suite. · 42f920cf

yangguo@chromium.org authored Nov 20, 2013

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/67763007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17934 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

42f920cf

Increase precision when finding the remainder after division by pi/2. · 2c7ebfa7

yangguo@chromium.org authored Nov 20, 2013

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/66703005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17933 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2c7ebfa7

Do not recompile existing functions when enabling allocation tracking · e7511b62

yurys@chromium.org authored Nov 20, 2013

Now that we don't have special hooks for the allocations in the generated code there is no need to recompile existing functions when enabling allocation tracking.

BUG=chromium:27798
LOG=N
R=loislo@chromium.org, mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/67743006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17932 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e7511b62

Re-enable EnsureAllocationSiteDependentCodesProcessed. · 1e8c7c56

mvstanton@chromium.org authored Nov 20, 2013

The problem was that we don't use crankshaft on non-sse2 builds.
(on ARM non-vfp3).

R=danno@chromium.org

Review URL: https://codereview.chromium.org/77963002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17930 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1e8c7c56

MaterializedLiteral expressions need to cache expression depth. · b90d87c3

mvstanton@chromium.org authored Nov 20, 2013

A problem arises in recursive literal expressions due to recent
changes that defer allocation of constant literal properties
from parse time. We were calculating expression depth as a
side-effect of a lazy constant property build, but subsequent
calls for the depth always returned 1. Cache the correct depth
in the MaterializedLiteral instead.

(Related-to/very-partial-revert-of
https://codereview.chromium.org/61873003)

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/78493002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17929 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b90d87c3

Force 'git cl upload' in push-to-trunk forced mode. · 718b3864

machenbach@chromium.org authored Nov 20, 2013

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/77853003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17926 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

718b3864

Replace hard-coded stack frame size literals with StandardFrameConstants::kFixedFrameSizeFromFp · df38e6f9

rmcilroy@chromium.org authored Nov 20, 2013

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/60763006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17925 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

df38e6f9

ARM: Optimize AccessArgumentsAt · 2b1aeec5

m.m.capewell@googlemail.com authored Nov 20, 2013

Optimize register constraints and code generated for AccessArgumentsAt
Lithium instruction.

TEST=none
BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/78093004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17923 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2b1aeec5

Use SimpleLoadField for JSObjectFieldAccessors, rather than compiling a new stub. · 6557c85f

verwaest@chromium.org authored Nov 20, 2013

R=dslomov@chromium.org

Review URL: https://chromiumcodereview.appspot.com/76403002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17922 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6557c85f

Activate Hydrogen-generated KeyedLoadDictionary ICs · adb39abd

danno@chromium.org authored Nov 20, 2013

R=ulan@chromium.org

Review URL: https://chromiumcodereview.appspot.com/59813011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17921 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

adb39abd

Remove the first_right_arg hack for HMod. · d38abc3b

bmeurer@chromium.org authored Nov 20, 2013

Generate a proper subgraph in BuildBinaryOperation instead.

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/77053003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17919 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d38abc3b

Removed unused --preallocate-message-memory flag. · 8f88467b

svenpanne@chromium.org authored Nov 20, 2013

It results in a lot of dead code, and Isolate::PrintStack itself
crashes most of the time when something went wrong earlier.
Furthermore, we have plans do get better information into the
minidump, anyway.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/78003002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17918 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8f88467b

Convert constant numbers at compile time. · 4c4d911c

bmeurer@chromium.org authored Nov 20, 2013

TEST=mjsunit/number-tostring
R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/77553005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17917 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4c4d911c

Revert r17907 - Make it possible to add more than one piece of embedder data to isolates · bd099373

jochen@chromium.org authored Nov 20, 2013

> This will allow for using gin and blink bindings in the same process
>
> BUG=317398
> R=svenpanne@chromium.org, dcarney@chromium.org
> LOG=y
>
> Review URL: https://codereview.chromium.org/77913003

BUG=none
R=svenpanne@chromium.org
TBR=svenpanne@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/78093005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17915 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bd099373

Make BuildBinaryOperation use ReturnValue instead of ReturnInstruction. · defee14d

bmeurer@chromium.org authored Nov 20, 2013

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/78183002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17914 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

defee14d

Replace unsafe uses of Add<> with AddUncasted<>. · 6826b747

bmeurer@chromium.org authored Nov 20, 2013

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/78213002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17913 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6826b747

Don't generate useless string checks for string adds. · da6d5586

bmeurer@chromium.org authored Nov 20, 2013

If we know that one side of a string add is definitely a string
(i.e. if it's a string constant), then we don't need to emit a
string check for the argument.

This adds a new BuildCheckString() method to the graph builder,
which does "the right thing".

TEST=mjsunit/string-add
R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/78063002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17912 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

da6d5586

Remove deprecated v8::SetResourceConstraints without Isolate parameter · 782040d2

rmcilroy@chromium.org authored Nov 20, 2013

LOG=Y
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/62193003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17910 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

782040d2

Remove deprecated v8-defaults.h and defaults.cc. · 57dc3139

rmcilroy@chromium.org authored Nov 20, 2013

BUG=312241
LOG=Y
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/59823008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17909 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

57dc3139

Make it possible to add more than one piece of embedder data to isolates · 4515fb5c

jochen@chromium.org authored Nov 20, 2013

This will allow for using gin and blink bindings in the same process

BUG=317398
R=svenpanne@chromium.org, dcarney@chromium.org
LOG=y

Review URL: https://codereview.chromium.org/77913003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17907 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4515fb5c

faster stack frame generation for accessor property ics · c595853b

dcarney@chromium.org authored Nov 20, 2013

this is implemented for intel platforms only, as they are the only ones which show speed up with this change

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/48303002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17903 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c595853b

Reset overwrite mode for BinaryOpStub unless we can actually make use of it. · 54dc61a5

bmeurer@chromium.org authored Nov 20, 2013

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/77943002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17899 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

54dc61a5

Prepare push to trunk. Now working on version 3.23.9. · 15582e24

machenbach@chromium.org authored Nov 20, 2013

R=danno@chromium.org
BUG=

Review URL: https://codereview.chromium.org/77673004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17896 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15582e24

Quit running EnsureAllocationSiteDependentCodesProcessed test until · daf4e658

mvstanton@chromium.org authored Nov 20, 2013

it's failure is diagnosed.

R=danno@chromium.org

Review URL: https://codereview.chromium.org/77923002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17894 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

daf4e658

Add forced mode to push-to-trunk script. · 8b382597

machenbach@chromium.org authored Nov 20, 2013

This CL depends on https://codereview.chromium.org/65933003/.

BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/67763005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17893 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8b382597

Refactor and improve bug line generation for push-to-trunk. · 6fcd94cc

machenbach@chromium.org authored Nov 20, 2013

BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/65933003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17892 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6fcd94cc

19 Nov, 2013 11 commits

MIPS: Fixed crashes exposed though fuzzing. · 79de22a5

plind44@gmail.com authored Nov 19, 2013

Port r17886 (e2fb3ed)

Original commit message:
The %_OneByteSeqStringSetChar intrinsic expects its arguments to be checked before being called for efficiency reasons, but the fuzzer provided no such checks. Now the intrinsic is robust to bad input if FLAG_debug_code is set.

R=plind44@gmail.com, yangguo@chromium.org
TEST=test/mjsunit/regress/regress-320948.js
BUG=chromium:320948
LOG=Y

Review URL: https://codereview.chromium.org/68793008

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17891 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

79de22a5

Turn ASSERTs to CHECKs in test-heap.cc · a5f910eb

danno@chromium.org authored Nov 19, 2013

This fixes unused variable compile failures in release builds introduced in r17887.

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/76413004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17888 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a5f910eb

Test that AllocationSite::dependent_code doesn't leak code objects. · 25fdcf27

mvstanton@chromium.org authored Nov 19, 2013

Verify that code objects are treated weakly by the AllocationSite
dependent_code field.

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/61923006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17887 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

25fdcf27

Fixed crashes exposed though fuzzing. · 06c76203

danno@chromium.org authored Nov 19, 2013

The %_OneByteSeqStringSetChar intrinsic expects its arguments to be checked before being called for efficiency reasons, but the fuzzer provided no such checks. Now the intrinsic is robust to bad input if FLAG_debug_code is set.

R=yangguo@chromium.org
TEST=test/mjsunit/regress/regress-320948.js
BUG=chromium:320948
LOG=Y

Review URL: https://codereview.chromium.org/72813004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17886 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

06c76203

MIPS: Remove unused StubType's, freeing 2 bits in Code objects. · 1cfcf25e

plind44@gmail.com authored Nov 19, 2013

Port r17867 (a305bd3)

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/60763005

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17885 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1cfcf25e

MIPS: Properly initialize desc->origin in the MIPS assembler. · 44f3f410

plind44@gmail.com authored Nov 19, 2013

Port r17865 (5b2e594)

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/76163003

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17884 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

44f3f410

Revert 17877 - Introduce a v8::Platform class that bundles embedder callbacks · e744b82f

jochen@chromium.org authored Nov 19, 2013

This also reverts 17879 and 17880.

BUG=v8:3015
TBR=svenpanne@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/76323002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17881 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e744b82f

Remove faulty CHECK() statement. · 28b80759

jochen@chromium.org authored Nov 19, 2013

TBR=svenpanne@chromium.org
BUG=none
LOG=n

Review URL: https://codereview.chromium.org/67463003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17880 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

28b80759

Fix typo in header guard of v8-platform.h · 611e1185

jochen@chromium.org authored Nov 19, 2013

TBR=svenpanne@chromium.org
BUG=none
LOG=n

Review URL: https://codereview.chromium.org/76313002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17879 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

611e1185

Fix push-to-trunk runtime call. · 12755f7f

machenbach@chromium.org authored Nov 19, 2013

This broke after a recent refactoring.

BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/76193002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17878 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

12755f7f

Introduce a v8::Platform class that bundles embedder callbacks · c24ce076

jochen@chromium.org authored Nov 19, 2013

Also provide a default implementation to use in cctests.

For now, there are just two thread releated callbacks. In future CLs, I will
move callbacks registered e.g. via V8::SetFooCallback over.

BUG=v8:3015
R=svenpanne@chromium.org, danno@chromium.org
LOG=no

Review URL: https://codereview.chromium.org/75283002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17877 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c24ce076