- 01 Feb, 2017 1 commit
-
-
Michael Achenbach authored
Reland of: https://codereview.chromium.org/2592663004/ BUG=chromium:656900 TBR=yangguo@chromium.org, glider@chromium.org, titzer@chromium.org Change-Id: I89b5c6b7a4214e25b4fea6d2ee33cd31b47320cc Reviewed-on: https://chromium-review.googlesource.com/435319Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#42846}
-
- 31 Jan, 2017 2 commits
-
-
machenbach authored
Revert of [test] Add back lsan leak detection (patchset #4 id:60001 of https://codereview.chromium.org/2592663004/ ) Reason for revert: Breaks mac asan. Need to keep leak check off on mac. Original issue's description: > [test] Add back lsan leak detection > > BUG=chromium:662388 > TBR=yangguo@chromium.org, glider@chromium.org, titzer@chromium.org > > Review-Url: https://codereview.chromium.org/2592663004 > Cr-Commit-Position: refs/heads/master@{#42815} > Committed: https://chromium.googlesource.com/v8/v8/+/e196d00df587b6513eb79059cd96e259dd0a763f TBR=yangguo@chromium.org,glider@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:662388 Review-Url: https://codereview.chromium.org/2667993002 Cr-Commit-Position: refs/heads/master@{#42816}
-
machenbach authored
BUG=chromium:662388 TBR=yangguo@chromium.org, glider@chromium.org, titzer@chromium.org Review-Url: https://codereview.chromium.org/2592663004 Cr-Commit-Position: refs/heads/master@{#42815}
-
- 01 Dec, 2016 3 commits
-
-
machenbach authored
BUG=chromium:603131 LOG=y Committed: https://crrev.com/6b9c49cac101d1a373ae1a098b7959f8aff848ac Review-Url: https://codereview.chromium.org/2533813002 Cr-Original-Commit-Position: refs/heads/master@{#41407} Cr-Commit-Position: refs/heads/master@{#41410}
-
machenbach authored
Revert of [build] Use MSVS 2015 by default. (patchset #5 id:80001 of https://codereview.chromium.org/2533813002/ ) Reason for revert: Breaks CI dbg builder: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug%20builder/builds/13817 Original issue's description: > [build] Use MSVS 2015 by default. > > BUG=chromium:603131 > LOG=y > > Committed: https://crrev.com/6b9c49cac101d1a373ae1a098b7959f8aff848ac > Cr-Commit-Position: refs/heads/master@{#41407} TBR=jochen@chromium.org,vogelheim@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:603131 Review-Url: https://codereview.chromium.org/2538493007 Cr-Commit-Position: refs/heads/master@{#41409}
-
machenbach authored
BUG=chromium:603131 LOG=y Review-Url: https://codereview.chromium.org/2533813002 Cr-Commit-Position: refs/heads/master@{#41407}
-
- 21 Nov, 2016 1 commit
-
-
thestig authored
Instead of directly using v8_enable_inspector_override from build_overrides/v8.gni in all the GN configs, set a v8_enable_inspector variable based on v8_enable_inspector_override and use that everywhere. This is the more common pattern seen in over projects, and reduces the need to include //build_overrides/v8.gni in many files. Review-Url: https://codereview.chromium.org/2520683002 Cr-Commit-Position: refs/heads/master@{#41156}
-
- 12 Oct, 2016 1 commit
-
-
machenbach authored
BUG=chromium:635948 Review-Url: https://codereview.chromium.org/2393863002 Cr-Commit-Position: refs/heads/master@{#40194}
-
- 28 Jul, 2016 1 commit
-
-
machenbach authored
The isolate_driver automatically adds referenced shared libraries. They don't need to be listed explicitly. The hard-coded location blocks the GN transition as the library location is different in GYP and GN. BUG=chromium:474921 NOTRY=true Review-Url: https://codereview.chromium.org/2190543003 Cr-Commit-Position: refs/heads/master@{#38113}
-
- 04 Jul, 2016 1 commit
-
-
machenbach authored
BUG=chromium:474921 Review-Url: https://codereview.chromium.org/2109293004 Cr-Commit-Position: refs/heads/master@{#37492}
-
- 30 Jun, 2016 3 commits
-
-
machenbach authored
BUG=chromium:474921 Committed: https://crrev.com/3cfc9f209ed0c173319659114859b7e848812fd7 Review-Url: https://codereview.chromium.org/2105353002 Cr-Original-Commit-Position: refs/heads/master@{#37414} Cr-Commit-Position: refs/heads/master@{#37425}
-
machenbach authored
Revert of [gn] Fix valgrind config (patchset #1 id:1 of https://codereview.chromium.org/2109403002/ ) Reason for revert: Breaks... Original issue's description: > [gn] Fix valgrind config > > BUG=chromium:474921 > NOTRY=true > NOTREECHECKS=true > TBR=vogelheim@chromium.org, jochen@chromium.org > > Committed: https://crrev.com/e97c990a2b1fd0b5b90832a7f182daa25fee8291 > Cr-Commit-Position: refs/heads/master@{#37418} TBR=vogelheim@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:474921 Review-Url: https://codereview.chromium.org/2109423002 Cr-Commit-Position: refs/heads/master@{#37419}
-
machenbach authored
BUG=chromium:474921 NOTRY=true NOTREECHECKS=true TBR=vogelheim@chromium.org, jochen@chromium.org Review-Url: https://codereview.chromium.org/2109403002 Cr-Commit-Position: refs/heads/master@{#37418}
-
- 15 Jun, 2016 1 commit
-
-
machenbach authored
Fix after: https://codereview.chromium.org/2042253002/ https://codereview.chromium.org/2049743002/ Using the data file is the default now and it shouldn't be overridden in v8's build_overrides. Also the isolate logic now needs to include the gni file specifying the flag. BUG=chromium:616033 TBR=jochen@chromium.org, vogelheim@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2062363002 Cr-Commit-Position: refs/heads/master@{#36998}
-
- 07 Jun, 2016 1 commit
-
-
machenbach authored
BUG=chromium:474921 TBR=vogelheim@chromium.org, jochen@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2041303002 Cr-Commit-Position: refs/heads/master@{#36774}
-
- 06 Jun, 2016 1 commit
-
-
machenbach authored
This makes the isolate-driver script rebase all paths to be relative to the isolate-file location. This is an assumption of the go binaries and is needed for batcharchive to work. In gyp, actions were executed relative to the gyp file that specified them, while in gn it's relative to the product dir. BUG=chromium:474921 Review-Url: https://codereview.chromium.org/2039873002 Cr-Commit-Position: refs/heads/master@{#36746}
-
- 03 Jun, 2016 2 commits
-
-
machenbach authored
This adds corresponding *_run targets for all swarming isolate actions existing in gyp. This also wires all targets together under gn_all. BUG=chromium:474921 NOTRY=true Review-Url: https://codereview.chromium.org/2033813004 Cr-Commit-Position: refs/heads/master@{#36714}
-
machenbach authored
BUG=chromium:474921 Review-Url: https://codereview.chromium.org/2034633004 Cr-Commit-Position: refs/heads/master@{#36694}
-