Commit 9cf7cb4c authored by machenbach's avatar machenbach Committed by Commit bot

Revert of [test] Add back lsan leak detection (patchset #4 id:60001 of...

Revert of [test] Add back lsan leak detection (patchset #4 id:60001 of https://codereview.chromium.org/2592663004/ )

Reason for revert:
Breaks mac asan. Need to keep leak check off on mac.

Original issue's description:
> [test] Add back lsan leak detection
>
> BUG=chromium:662388
> TBR=yangguo@chromium.org, glider@chromium.org, titzer@chromium.org
>
> Review-Url: https://codereview.chromium.org/2592663004
> Cr-Commit-Position: refs/heads/master@{#42815}
> Committed: https://chromium.googlesource.com/v8/v8/+/e196d00df587b6513eb79059cd96e259dd0a763f

TBR=yangguo@chromium.org,glider@chromium.org,titzer@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:662388

Review-Url: https://codereview.chromium.org/2667993002
Cr-Commit-Position: refs/heads/master@{#42816}
parent e196d00d
......@@ -61,11 +61,6 @@ template("v8_isolate_run") {
} else {
asan = "0"
}
if (is_lsan) {
lsan = "1"
} else {
lsan = "0"
}
if (is_msan) {
msan = "1"
} else {
......@@ -163,8 +158,6 @@ template("v8_isolate_run") {
"--config-variable",
"is_gn=1",
"--config-variable",
"lsan=$lsan",
"--config-variable",
"msan=$msan",
"--config-variable",
"tsan=$tsan",
......
......@@ -75,7 +75,6 @@
'--config-variable', 'has_valgrind=<(has_valgrind)',
'--config-variable', 'icu_use_data_file_flag=<(icu_use_data_file_flag)',
'--config-variable', 'is_gn=0',
'--config-variable', 'lsan=<(lsan)',
'--config-variable', 'msan=<(msan)',
'--config-variable', 'tsan=<(tsan)',
'--config-variable', 'coverage=<(coverage)',
......
# Do not add new suppressions below.
# TODO(machenbach): Delete this file as soon as it is empty.
# cctest
leak:v8::internal::Debug::NextAsyncTaskId
leak:v8::internal::wasm::DecodeWasmModule
leak:v8::internal::wasm::WasmInterpreter::WasmInterpreter
leak:v8::internal::WasmDebugInfo::SetBreakpoint
# debugger
leak:v8_inspector::WasmTranslation::TranslatorImpl::DisassemblingTranslator::AddFakeScript
leak:v8::internal::compiler::JumpThreading::ApplyForwarding
# mjsunit
leak:v8::internal::FuncNameInferrer::FuncNameInferrer
leak:v8::internal::JSArrayBuffer::SetupAllocatingData
# unittests
leak:v8::internal::Isolate::FindOrAllocatePerThreadDataForThisThread
......@@ -403,14 +403,7 @@ def SetupEnvironment(options):
)
if options.asan:
os.environ['ASAN_OPTIONS'] = ":".join([
'detect_leaks=1',
symbolizer,
])
os.environ['LSAN_OPTIONS'] = ":".join([
'suppressions=%s' % os.path.join(
BASE_DIR, 'tools', 'memory', 'lsan', 'suppressions.txt'),
])
os.environ['ASAN_OPTIONS'] = symbolizer
if options.sancov_dir:
assert os.path.exists(options.sancov_dir)
......
......@@ -27,12 +27,5 @@
],
},
}],
['lsan==1', {
'variables': {
'files': [
'../memory/lsan/suppressions.txt',
],
},
}],
],
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment