1. 28 Nov, 2020 1 commit
  2. 09 Sep, 2020 1 commit
  3. 14 Aug, 2020 1 commit
  4. 09 Mar, 2020 1 commit
    • Dan Elphick's avatar
      [api] Create v8::String::NewFromLiteral that returns Local<String> · b097a8e5
      Dan Elphick authored
      String::NewFromLiteral is a templated function that takes a char[N]
      argument that can be used as an alternative to String::NewFromUtf8 and
      returns a Local<String> rather than a MaybeLocal<String> reducing the
      number of ToLocalChecked() or other checks.
      
      Since the string length is known at compile time, it can statically
      assert that the length is less than String::kMaxLength, which means that
      it can never fail at runtime.
      
      This also converts all found uses of NewFromUtf8 taking a string literal
      or a variable initialized from a string literal to use the new API. In
      some cases the types of stored string literals are changed from const
      char* to const char[] to ensure the size is retained.
      
      This API does introduce a small difference compared to NewFromUtf8. For
      a case like "abc\0def", NewFromUtf8 (using length -1 to infer length)
      would treat this as a 3 character string, whereas the new API will treat
      it as a 7 character string.
      
      As a drive-by fix, this also fixes all redundant uses of
      v8::NewStringType::kNormal when passed to any of the String::New*
      functions.
      
      Change-Id: Id96a44bc068d9c4eaa634aea688e024675a0e5b3
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2089935
      Commit-Queue: Dan Elphick <delphick@chromium.org>
      Reviewed-by: 's avatarMathias Bynens <mathias@chromium.org>
      Reviewed-by: 's avatarMythri Alle <mythria@chromium.org>
      Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
      Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#66622}
      b097a8e5
  5. 10 Jan, 2020 1 commit
  6. 22 May, 2019 1 commit
  7. 15 May, 2019 1 commit
  8. 15 Oct, 2018 1 commit
    • Maya Lekova's avatar
      [async-await] Fix INIT hook with --harmony-await-optimization · 860ddfc0
      Maya Lekova authored
      Split the runtime function for initializing a promise into AwaitPromisesInit
      and AwaitPromisesInitOld, the former not firing the INIT hook and being used
      by the AwaitOptimized builtin. In addition to this the AsyncHooks now caches
      all the previously inited promises and checks that the init hook is not fired
      twice for the same promise.
      
      Modified test expectations for the new async ids in the async hooks tests.
      
      Bug: v8:8300
      Change-Id: If4a17e501b2a233578fa70b6442f219473f001d9
      Reviewed-on: https://chromium-review.googlesource.com/c/1280442
      Commit-Queue: Maya Lekova <mslekova@chromium.org>
      Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#56642}
      860ddfc0
  9. 23 Jul, 2018 2 commits
  10. 19 Jul, 2018 1 commit
  11. 10 Jul, 2018 1 commit
  12. 05 Jul, 2018 1 commit
  13. 04 Jul, 2018 3 commits
  14. 21 Jun, 2018 2 commits
  15. 06 Jun, 2018 2 commits