[async] Implement error handling when running async hooks

Bug: chromium:860788
Change-Id: I5311cd670b57edf5b63173a10cf84a575e1fcd04
Reviewed-on: https://chromium-review.googlesource.com/1128750
Commit-Queue: Maya Lekova <mslekova@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54343}

src/async-hooks-wrapper.cc

@@ -211,6 +211,9 @@ void AsyncHooks::PromiseHookDispatch(PromiseHookType type,
 
   HandleScope handle_scope(hooks->isolate_);
 
+  TryCatch try_catch(hooks->isolate_);
+  try_catch.SetVerbose(true);
+
   Local<Value> rcv = Undefined(hooks->isolate_);
   Local<Value> async_id =
       promise
@@ -247,6 +250,10 @@ void AsyncHooks::PromiseHookDispatch(PromiseHookType type,
       wrap->promiseResolve_function()->Call(rcv, 1, args);
     }
   }
+
+  if (try_catch.HasCaught()) {
+    Shell::ReportException(hooks->isolate_, &try_catch);
+  }
 }
 
 }  // namespace v8

test/mjsunit/regress/regress-crbug-860788.js

+// Copyright 2018 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --expose-async-hooks
+
+try {
+Object.prototype.__defineGetter__(0, function(){});
+assertThrows("x");
+} catch(e) { print("Caught: " + e); }
+
+try {
+(function() {
+  let asyncIds = [], triggerIds = [];
+  let ah = async_hooks.createHook({
+    init(asyncId, type, triggerAsyncId, resource) {
+      if (type !== 'PROMISE') { return; }
+      assertThrows("asyncIds.push(asyncId);");
+      assertThrows("triggerIds.push(triggerAsyncId)");
+    },
+  });
+  ah.enable();
+  async function foo() {}
+  foo();
+})();
+} catch(e) { print("Caught: " + e); }
+try {
+  var obj = {prop: 7};
+  assertThrows("nonexistant(obj)");
+} catch(e) { print("Caught: " + e); }