- 17 Sep, 2019 5 commits
-
-
Andreas Haas authored
The element segment encoding in the bulk memory proposal changed recently. With this CL the V8 implementation gets up to date again. R=thibaudm@chromium.org Bug: v8:9658 Change-Id: I4f45d04369400356a6f3aaed9570c7870f5f97bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1778022Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#63836}
-
Jakob Kummerow authored
Adding a %SimulateNewspaceFull runtime function speeds up this test from 7m21s to 0.3s (on arm.optdebug with --jitless). Bonus content: - speed up mjsunit/md5 by 23x (5m25s -> 7.5s) - speed up mjsunit/string-replace-gc by 8x (1m37s -> 12s) Bug: v8:9700, v8:9396 Change-Id: Id00d0b83b51192edf1d5493b49b79b5d76e78087 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1807355Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#63829}
-
Georg Neis authored
- There was no use of DisallowDeferredHandleDereference, so remove the corresponding assertion scope and related code. - Make DeferredHandleScope::Detach return a unique_ptr rather than a raw pointer for clarity. - Store DeferredHandles in compilation info as unique_ptr rather than shared_ptr, as it's never shared. - Remove some unused methods. Change-Id: I8327399fd291eba782820dd7a62c3bbdffedac4d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1805645 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Andreas Haas authored
R=clemensh@chromium.org Bug: chromium:1003241 Change-Id: I2c37404746bd4807040c787490fc7851ea6988d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1807359Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#63825}
-
Frank Tang authored
Bug: v8:9742 Change-Id: Ifd162c4c8c52efff7da98281c9dfed53a473026c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1808405 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#63818}
-
- 16 Sep, 2019 16 commits
-
-
Frank Tang authored
Bug: v8:9727 Change-Id: I634902e89c0c79fb95994e0a3a971cbc7889c09c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803788 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#63816}
-
Frank Tang authored
Bug: v8:9613 Change-Id: Ie91a5bd39c82b6baf33fd84dee8420d2c4a5f504 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803783 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Bug: v8:8460 Change-Id: I8e72aa194cfc9797f0451d54638b6ba152d32971 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1797269Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#63814}
-
Georg Neis authored
We used to have two special cases for named accesses on the global proxy, one based on seeing the global proxy constant in the graph and on based on seeing the global proxy map either in the feedback or in the graph. A change I made a while ago accidentally disabled the second one. This CL restores that. Moreover, given how things are set up now (this might have been different before), the first optimization is subsumed by the second one, so this CL also removes the first one. Finally, this CL records an accumulator hint in the case of a load, which improves precision of the serializer for concurrent inlining. Tbr: tebbi@chromium.org Bug: v8:7790 Change-Id: I255afc6c79e5c5c900b3ccfcd8459d836d21e42b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801954 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#63806}
-
Joshua Litt authored
The first land did not correctly handle exceptions for already evaluated modules. Original description: Implements AsyncModules in SourceTextModule. However, there is no support in the parser or D8 for actually creating / resolving AsyncModules. Also adds a flag '--top-level-await,' but the only external facing change with the flag enabled is that Module::Evaluate returns a promise. Bug: v8:9344 Change-Id: I24725816ee4a6c3616c3c8b08a75a60ca9f27727 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1797658 Commit-Queue: Joshua Litt <joshualitt@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#63803}
-
Clemens Hammacher authored
This randomizes new memory allocations and reservations. It's currently used to test far jump tables in wasm better, but might be helpful generally for testing arbitrary virtual memory layouts. R=mstarzinger@chromium.org Bug: v8:9477 Change-Id: Ie60b7c6dd3c4cd0f3b9eb8e2172912e0851c357d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803340 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Bug: v8:3770,v8:9666 Change-Id: I7b7652887d6b60fbb80e1100834bc7c9df0544d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1792909 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Martyn Capewell <martyn.capewell@arm.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#63801}
-
Artem Serov authored
This is a reland of 2869d9de Original change's description: > [turbofan,arm64] Add float loads poisoning. > > Also extend load poisoning testing for arm and arm64. > > This is a port of I1ef202296744a39054366f2bc424d6952c3bbe9d, > originally introduced for arm. > > Change-Id: I7d317bba6be633dd1e563daa7231d3c5e930f8e4 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1691032 > Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63519} Change-Id: I8155456f6ad571897f6274a86e58fec6cd66ee7d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1800583Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This CL adds a flag to reduce the initial code space reservation size (--wasm-max-initial-code-space-reservation), and adds a test which creates at least four separate code spaces and calls between them. R=mstarzinger@chromium.org Bug: v8:9477 Change-Id: I1b4c430266962eb94dbe4b381f46b03c2ec07fc2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1782999 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Joshua Litt authored
Bug: v8:9647 Change-Id: Ib6449fadc42130a019788ba3a22e93bfd0de789b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803514 Commit-Queue: Joshua Litt <joshualitt@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#63796}
-
Dan Elphick authored
Changes the Array(Includes|IndexOf)(Holey|Packed)Doubles builtins to first check the input array is not empty before attempting to cast it to a FixedDoubleArray as an empty array of doubles can be backed by a FixedArray. Bug: chromium:1004061 Change-Id: I12f302afa9596fb8a5581849662cd67fcc06f92b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1806676Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#63794}
-
Victor Gomes authored
Disable a flaky test. This is a reland of cbf028e8 Bug: v8:9714 Change-Id: Ifc136ad80bd7f2a0ae67a15e688a3d08ceed3c44 Cq-Include-Trybots: luci.v8.try:v8_linux_gc_stress_dbg Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1806915 Auto-Submit: Victor Gomes <victorgomes@google.com> Reviewed-by:
-
Maya Lekova authored
Bug: chromium:1003730 Change-Id: Id8ca302b0b17ce08821507bb686bf241416eee67 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1806913 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Ross McIlroy authored
The current JSObject type is too specific as it can also be passed proxy objects. BUG=chromium:1003919,v8:6949 Change-Id: I2766868543827fc5ee6f99f3b120c7ffe9cfed39 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803651 Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#63787}
-
Jakob Kummerow authored
This reimplements the "--time" option of run-tests.py to print the 20 slowest tests, on top of json_test_results infrastructure just like the bots do it. Additionally this CL speeds up a bunch of slow tests. Bug: v8:9396 Change-Id: I40797d2c8c3bfdd310b72f15cd1a035844b7c6f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803635 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#63786}
-
Victor Gomes authored
Uses templates to dispath the allocation flag statically. Bug: v8:9714 Change-Id: I1998ae47be2f7d872d34b3bc2390d01cbfad6afa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801848 Auto-Submit: Victor Gomes <victorgomes@google.com> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
- 13 Sep, 2019 13 commits
-
-
Shu-yu Guo authored
Install intrinsic default prototypes for Intl.ListFormat, Intl.PluralRules, Intl.RelativeTimeFormat, and Intl.Segmenter. Observable when attempting to construct cross-realm via a new.target with a non-Object .prototype property. Bug: v8:9712 Change-Id: I77ae75e5ea1ee8e9a01cf5788b664a5945aa1f7e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801252Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#63774}
-
Ng Zhi An authored
Bug: v8:8460 Change-Id: I2a96d5bad3dbcfe6a437931d7e9756646610f74b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796319Reviewed-by:
-
Frank Tang authored
By rolling icu to faee8bc which contains the upstream CLDR fix. Bug: v8:992694 Change-Id: I073d15396fa0e7c5054aa4e0806e5842228955f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1799424Reviewed-by:
-
Clemens Hammacher authored
After https://crrev.com/c/1800575 and https://crrev.com/c/1803343, which tried to fix this on occuring compile errors, this CL systematically adds the <memory> include to each header that uses {std::unique_ptr}. R=sigurds@chromium.org TBR=mlippautz@chromium.org,alph@chromium.org,rmcilroy@chromium.org,verwaest@chromium.org Bug: v8:9396 Change-Id: If7f9c3140842f9543135dddd7344c0f357999da0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803349Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#63767}
-
Frank Tang authored
Bug: v8:9464 Change-Id: Ibdc6f9797661e357e01c2f02565eeca12abbf8ae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801251Reviewed-by:
-
Clemens Hammacher authored
If the jump is too large for a near jump, we patch the far jump table instead, and patch the (near) jump table to jump to the far jump table slot. R=mstarzinger@chromium.org Bug: v8:9477 Change-Id: Ic9a929b405492c1cfe744738e0807ad4357c53ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1799543 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Joey Gouly authored
Make TryEmitCbzOrTbz a template, so it can be used for Word64 as well as Word32. 0.09% reduction of embedded builtins size with a arm64 ptr-compr build. Some of the unittests weren't ported to Word64 as they don't pass, this is due to VisitWordCompare missing a loop to remove Word64Equal comparisons against 0. This can be added in a different CL if needed. Change-Id: I927129d934083b71abe5b77991c39286470a228d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1792908 Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Reviewed-by:
-
Clemens Hammacher authored
The {JumpTableAssembler} should not include {wasm-code-manager.h}. It only depends on assembler headers in {src/codegen}. This removes the {flush_i_cache} parameter which is always set anyway, removes the last include from {src/wasm} and updates the DEPS file to forbid such includes for the future. R=mstarzinger@chromium.org Bug: v8:9396, v8:9477 Change-Id: Id57b35c93155c3eac7c4c9b6a41d3a1c98c0dddc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801846 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Clemens Hammacher authored
This reverts commit 7b7df7db. Reason for revert: Still breaks gc-stress bots: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/24466 Original change's description: > Reland "[Heap] Create a fast path for young allocations." > > Disable a flaky test. > > This is a reland of cbf028e8 > > Original change's description: > > [Heap] Create a fast path for young allocations. > > > > Bug: v8:9714 > > Change-Id: I3be6ea615142c8282bb67370626c7596cedf826c > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1800304 > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Commit-Queue: Victor Gomes <victorgomes@google.com> > > Auto-Submit: Victor Gomes <victorgomes@google.com> > > Cr-Commit-Position: refs/heads/master@{#63729} > > Bug: v8:9714 > Change-Id: Ifbd8617be1b8c58cb1552fe88c52eafd9d6e9c7d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801840 > Commit-Queue: Victor Gomes <victorgomes@google.com> > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Auto-Submit: Victor Gomes <victorgomes@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63744} TBR=ulan@chromium.org,verwaest@chromium.org,victorgomes@google.com Change-Id: Ie041a7ff25adb9edc7c44ebb259912e66dfb9da1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9714 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801852Reviewed-by:
-
Victor Gomes authored
Disable a flaky test. This is a reland of cbf028e8 Original change's description: > [Heap] Create a fast path for young allocations. > > Bug: v8:9714 > Change-Id: I3be6ea615142c8282bb67370626c7596cedf826c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1800304 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Victor Gomes <victorgomes@google.com> > Auto-Submit: Victor Gomes <victorgomes@google.com> > Cr-Commit-Position: refs/heads/master@{#63729} Bug: v8:9714 Change-Id: Ifbd8617be1b8c58cb1552fe88c52eafd9d6e9c7d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801840 Commit-Queue: Victor Gomes <victorgomes@google.com> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Victor Gomes <victorgomes@google.com> Reviewed-by:
-
Tobias Tebbi authored
This reverts commit 9ce67926. Reason for revert: This was never intended to stay. Original change's description: > [turbofan] temporarily disable const-based load elimination > > This is a safe to merge hot-fix to tackle https://crbug.com/983764. > To be reverted after merging to M77. > > Bug: chromium:983764 > Change-Id: I3cd27481f224b352ef6bcf9dde21a8f77616acff > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1786285 > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63570} TBR=tebbi@chromium.org,mslekova@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:983764 Change-Id: I9c07eab384818aaeecab0224cec0f6b5310e9e09 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801839Reviewed-by:
-
Igor Sheludko authored
Bug: v8:9708 Change-Id: I91e429e478ad70dc2212f9f78830d10941fa47e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1800581Reviewed-by:
-
Dmitry Gozman authored
Currently, debugger pauses on async call schedule and then waits for Debugger.pauseOnAsyncCall with parentStackTraceId to actually schedule the pause. This CL combines these two steps: - For local async tasks, it just stores m_taskWithScheduledBreak at the time of schedule, to be able to pause once this task is run. - For external async tasks, it plumbs "should_pause" boolean in V8StackTraceId from the point of schedule to the point of execution, and schedules a pause once externalAsyncTaskStarted is called with "should_pause" set to true. This approach greatly simplifies the implementation, and reduced frontend to a single "breakOnAsyncCall: true" parameter in Debugger.stepInto. Drive-by: introduce hasScheduledBreakOnNextFunctionCall() to make SetBreakOnNextFunctionCall management more robust. Note: artificial pauses at async call schedule time are gone from test expectations - we now only pause when user actually wants to pause, which makes protocol much simpler. See also design doc linked in the bug. BUG=chromium:1000475 Change-Id: I2d16f79c599fe196b2aaeca8223c63437a2954a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1783724 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#63737}
-
- 12 Sep, 2019 6 commits
-
-
Frank Tang authored
harmony_intl_bigint shipped in m76 harmony_intl_date_format_range shipped in m76 harmony_intl_datetime_style shipped in m76 harmony_intl_numberformat_unified shipped in m77 Bug: v8:9272, v8:9273, v8:9274 Change-Id: Icc640e011021e691373bc61725013578b7185e50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1799263 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Frank Tang authored
Bug: v8:9464 Change-Id: I3252de850bbaa5fdb15f5fc2103f1ebb7be3e1ea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1799396 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Irina Yatsenko authored
Change-Id: I162b3cac024fba180ff191c8497da9a958c38167 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1797657 Commit-Queue: Irina Yatsenko <irinayat@microsoft.com> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#63731}
-
Ng Zhi An authored
Drive by fix of type of expected value in a test Bug: v8:9626 Change-Id: I1bb44082b873383ea75e7089828bc68c9d4e0df0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1757503Reviewed-by:
-
Ng Zhi An authored
The point of this test is to check for OOB access traps, the read/write of the entire backing buffer is not useful to this test, and causes the test to be really slow, especially on arm simulator. This change cuts the runtime of the test from ~7.5min to ~1.5min. Bug: v8:7783 Bug: v8:9396 Change-Id: Id57648e920b7631d8c481d2a43ded1c16cd2d1d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1793905 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
TNodified: * EmitCreateShallowArrayLiteral * EmitCreateShallowObjectLiteral Also propagated the TNodification of AllocationSite. Previously it was used a lot with nullptr, and that changed to {}. Bug: v8:6949, v8:9396 Change-Id: I8ed04d2d346f5960bba23a233c3dd244ad7f122a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795346 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
