- 17 Oct, 2018 9 commits
-
-
Clemens Hammacher authored
Instead of specifying the byte length of a section manually, just compute it automatically from the bytes given. Manual computation is particularly difficult because of the macros involved, which can expand to several bytes. This is not a pure refactoring, it also fixes several occasions where we calculated the length wrong. Drive-by: Add some ENTRY_COUNT macro uses. This is the fourth CL in a series to improve our module decoder tests and make them more readable. R=titzer@chromium.org Bug: v8:8238 Change-Id: I0d2ceb751fc8e5625ffdf4189d4b5253aecc2541 Reviewed-on: https://chromium-review.googlesource.com/c/1283075 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#56718}
-
Peter Marshall authored
This is preparation to allow for a non-sampling events processor which receives ticks from a source not driven by a timer. This will allow us to have more deterministic testing of the CPU profiler. It also allows different implementations for a wall time and CPU time triggered sampler. Change-Id: I2e9db9580ec70f05094e59c2c1e5efc28c8f7da8 Reviewed-on: https://chromium-review.googlesource.com/c/1280436Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#56717}
-
Hai Dang authored
This CL extends IterableToListWithSymbolLookup with fast paths for spreading keys/values iterators of JSMap, and values iterator of JSSet (which is also the iterator of Set.prototype.keys() and Set.prototype[Symbol.iterator]()). The fast paths are only taken if the target still has original iteration behavior. For iterators it is also required that the iterator is not partially consumed. After spreading, to be spec-compliant, the iterator is exhausted. Tests are added. Bug: v8:7980 Change-Id: Ida74e5ecbbc5ba5488d13a40f2c4bda14c781cbf Reviewed-on: https://chromium-review.googlesource.com/c/1276632Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Hai Dang <dhai@google.com> Cr-Commit-Position: refs/heads/master@{#56716}
-
Michael Achenbach authored
This skips the slowest tests in stress and noopt variants. TBR=sigurds@chromium.org NOTRY=true Bug: v8:7783 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic471a2ab3e6806c4c60b81c0cdddfb44b199dd26 Reviewed-on: https://chromium-review.googlesource.com/c/1286334 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#56715}
-
Clemens Hammacher authored
Function declarations reference a previously defined or imported signature. Make this visible when declaring empty functions. Also rename IMPORT_SIG_INDEX to SIG_INDEX since it can also reference a locally defined signature. This is the third CL in a series to improve our module decoder tests and make them more readable. R=titzer@chromium.org Bug: v8:8238 Change-Id: Ibfd9ea39ea35bacdb453602f8985fb3306455de4 Reviewed-on: https://chromium-review.googlesource.com/c/1282958Reviewed-by:
-
Takuto Ikuta authored
Bug: chromium:753973 Change-Id: Ib30bd11ebabfd364d6cee6d31b11c01744e13520 Reviewed-on: https://chromium-review.googlesource.com/c/1286389Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#56713}
-
Michael Achenbach authored
This reverts commit 37871a02. Reason for revert: Root cause was fixed. Original change's description: > [release] Ignore binary-size tracking on auto-rolls > > NOTRY=true > > Bug: chromium:893991 > Change-Id: I490c02266a367d93495a2de7516486aca2c8e26c > Reviewed-on: https://chromium-review.googlesource.com/c/1273118 > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56524} TBR=machenbach@chromium.org,hablich@chromium.org,mslekova@chromium.org NOTRY=true Bug: chromium:893991 Change-Id: I0ac21d38320cefdaf724035d58577dc35315c9eb Reviewed-on: https://chromium-review.googlesource.com/c/1286333Reviewed-by:
-
Marja Hölttä authored
BUG=v8:8179 Change-Id: I29c5a5359a6e682ec6d94e9779f921889546b6a7 Reviewed-on: https://chromium-review.googlesource.com/c/1278393Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#56711}
-
Jakob Kummerow authored
To prevent correctness fuzzers from finding spurious differences between architectures, we need to mock out the maximum length of all TypedArrays. This patch adds the two new types BigInt64Array and BigUint64Array to the existing list. Bug: chromium:894864 Change-Id: I5cdeeafa597b09aee2d9b4d368c07f10008baf58 Reviewed-on: https://chromium-review.googlesource.com/c/1285399 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
- 16 Oct, 2018 31 commits
-
-
Tobias Tebbi authored
Motivated by https://crrev.com/c/1196693, this allows to declare runtime functions with return type never in Torque. For example: extern runtime ReThrow(Context, Object) : never; Change-Id: I5dd8fe0ca22c778364bfcf1caf52180039c5be7e Reviewed-on: https://chromium-review.googlesource.com/c/1282957 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#56709}
-
Johannes Henkel authored
This will be more consistent with other creation methods, as discovered in https://chromium-review.googlesource.com/c/chromium/src/+/1281166/4/headless/lib/browser/protocol/protocol_string.h Sorry about the Churn. And it turns out I was wrong I'll have to send one more PR for two other renames. Sorry! Bug: chromium:891377 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I10ed870bcf065c1913971ec8c194fa1c8149a2b4 Reviewed-on: https://chromium-review.googlesource.com/c/1284789Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#56708}
-
Frank Tang authored
This is to implement a new change in the proposal '14. If style is "narrow" and type is not "unit", throw a RangeError exception.' in #sec-Intl.ListFormat See also https://github.com/tc39/proposal-intl-list-format/issues/16 https://github.com/tc39/proposal-intl-list-format/pull/27 and https://github.com/tc39/test262/pull/1860 Bug: v8:8302 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I0a3dc99eeb18082f359c24c472889d8b6e905225 Reviewed-on: https://chromium-review.googlesource.com/c/1277660 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Frank Tang <ftang@chromium.org> Reviewed-by:
Daniel Ehrenberg <littledan@chromium.org> Cr-Commit-Position: refs/heads/master@{#56707}
-
Caitlin Potter authored
Adds 2 counts to see how often this occurs on the web, both the throwing version (strict mode), and the no-op sloppy mode case, to help determine if the proposal at https://github.com/tc39/ecma262/pull/1307 is web compatible. This is the V8 side of required changes. The Chromium-side CL: https://crrev.com/c/1280618 BUG=v8:8175 R=littledan@chromium.org, cbruni@chromium.org, jkummerow@chromium.org, yangguo@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Id12336c2e566093bb554b6d4624c9301fbc4a0f7 Reviewed-on: https://chromium-review.googlesource.com/c/1255549 Commit-Queue: Caitlin Potter <caitp@igalia.com> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#56706}
-
Jakob Kummerow authored
with internal::Address. This is in preparation for the upcoming changes to internal::Object. The public API is unchanged, and there should be no change in behavior either. Most of the casts newly introduced here will disappear again once the migration is complete. Bug: v8:3770 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I2990b06a2511ccc5de3f98fd95a805f30ed589ab Reviewed-on: https://chromium-review.googlesource.com/c/1036612Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Frank Tang authored
Bug: v8:6891 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I0b82b194cb7089aeaa322ed4e45008db6890e7a1 Reviewed-on: https://chromium-review.googlesource.com/c/1266995Reviewed-by:
-
Clemens Hammacher authored
Ensure that {min} is smaller than {max}, and auto-compute {max} as {arraysize(data)}. We had two tests which did not actually test anything. This is the second CL in a series to improve our module decoder tests and make them more readable. R=titzer@chromium.org Bug: v8:8238 Change-Id: Ie467fa54609bc5fd860608085a2d58ed8341f5e7 Reviewed-on: https://chromium-review.googlesource.com/c/1282956Reviewed-by: -
Clemens Hammacher authored
First CL in a series to improve our module decoder tests and make them more readable. R=titzer@chromium.org Bug: v8:8238 Change-Id: Ie6ac83fbe2f873bfda8597ab3dd9ec4c0fb548ad Reviewed-on: https://chromium-review.googlesource.com/c/1283054Reviewed-by:
-
Sergiy Byelozyorov authored
This will allow us to determine whether tests are not printing anything or whether our infrastructure is failing to retrieve the stdout. TBR=machenbach@google.com No-Try: true Bug: chromium:891314 Change-Id: I0786e77b4db9f247e02a25924acd6d6773c0db9f Reviewed-on: https://chromium-review.googlesource.com/c/1282962 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#56701}
-
Jakob Gruber authored
This is a reland of 65070355 Original change's description: > [ia32,root] Add indirect calls and jumps through virtual register > > This adds a temporary mechanism for isolate-independent calls and > jumps. The problem was that - as ia32 doesn't have a scratch register > - Call and Jump cannot call through a register. This CL adds a > so-called virtual register (= a pointer-sized field) on IsolateData. > > The virtual register can be removed once pc-relative calls are > implemented and all builtins have been embedded. > > Bug: v8:6666 > Change-Id: I1f9d8a25643fad0b3919dd813dbe219d20fcc6bc > Reviewed-on: https://chromium-review.googlesource.com/c/1282991 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56693} TBR=sigurds@chromium.org Bug: v8:6666 Change-Id: If463e68036673c7873d0d5e1a8a01ef31263cbfa Reviewed-on: https://chromium-review.googlesource.com/c/1283052 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#56700}
-
peterwmwong authored
This also includes ports of Array.p.toString and Array.p.toLocaleString. Many parts of the old JS implementation are preserved, because TypedArray.p.join still relies on it. These will be removed once TypedArray.p.join is ported to Torque. To simplify implementation, special handling of extremely sparse arrays has been removed. Performance improvements vary by array size, elements, and sparse-ness. Some quick numbers and graphs are here: https://docs.google.com/spreadsheets/d/125VLmRMudk8XaomLCsZQ1ewc94WCqht-8GQwU3s9BW8/edit#gid=2087673710 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.v8.try:v8_linux_noi18n_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia4069a068403ce36676c37401d349aefc976b045 Reviewed-on: https://chromium-review.googlesource.com/c/1196693 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#56699}
-
Sigurd Schneider authored
Change-Id: I861babb77f224626f6cdb88a7be08db75f5cf327 Bug: v8:6666 Reviewed-on: https://chromium-review.googlesource.com/c/1283089Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#56698}
-
Marja Hölttä authored
BUG=v8:8179 Change-Id: I528e64fafff2dc00808c48107799d39603f0ca48 Reviewed-on: https://chromium-review.googlesource.com/c/1275823 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Michael Achenbach authored
NOTRY=true Bug: chromium:830557 Change-Id: Ic67ab462f7be1787613ad42219f81760a96a3731 Reviewed-on: https://chromium-review.googlesource.com/c/1282955Reviewed-by:
-
Sigurd Schneider authored
Change-Id: I7691c12acc1b2d0be3e35cf699bb16df4ca84b6e Bug: v8:6666 Reviewed-on: https://chromium-review.googlesource.com/c/1280435 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This reverts commit 65070355. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20noi18n%20-%20debug/23308 Original change's description: > [ia32,root] Add indirect calls and jumps through virtual register > > This adds a temporary mechanism for isolate-independent calls and > jumps. The problem was that - as ia32 doesn't have a scratch register > - Call and Jump cannot call through a register. This CL adds a > so-called virtual register (= a pointer-sized field) on IsolateData. > > The virtual register can be removed once pc-relative calls are > implemented and all builtins have been embedded. > > Bug: v8:6666 > Change-Id: I1f9d8a25643fad0b3919dd813dbe219d20fcc6bc > Reviewed-on: https://chromium-review.googlesource.com/c/1282991 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56693} TBR=sigurds@chromium.org,jgruber@chromium.org,ishell@chromium.org Change-Id: I782651140eee3e75d57ad57d614a981e420fdfeb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6666 Reviewed-on: https://chromium-review.googlesource.com/c/1283051Reviewed-by:
-
Jakob Gruber authored
This adds a temporary mechanism for isolate-independent calls and jumps. The problem was that - as ia32 doesn't have a scratch register - Call and Jump cannot call through a register. This CL adds a so-called virtual register (= a pointer-sized field) on IsolateData. The virtual register can be removed once pc-relative calls are implemented and all builtins have been embedded. Bug: v8:6666 Change-Id: I1f9d8a25643fad0b3919dd813dbe219d20fcc6bc Reviewed-on: https://chromium-review.googlesource.com/c/1282991 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#56693}
-
Sigurd Schneider authored
Change-Id: If476aa8a759bbf6360ef1fc68dbc3e624f8731e5 Bug: v8:6666 Reviewed-on: https://chromium-review.googlesource.com/c/1282971Reviewed-by:
-
Georg Neis authored
Bug: v8:895691 Change-Id: Ic92cb250555d097b01f894b4b7b9ae5b2eea6668 Reviewed-on: https://chromium-review.googlesource.com/c/1282990 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Change-Id: Ibc8a086c5761c732b454fbb6cc1e06abb9f5e90f Bug: v8:7777 Reviewed-on: https://chromium-review.googlesource.com/c/1283032Reviewed-by:
-
🎉 Mathias Bynens authoredThis is a reland of 0d91db0b. Proposal repository: https://github.com/tc39/proposal-well-formed-stringify Intent to ship: https://groups.google.com/d/msg/v8-users/IRu3bAC_pLM/pFwz2ti1AgAJ TBR=gsathya@chromium.org Bug: v8:7782 Change-Id: I53d006650e2b4099a111d2e5bc067e4a2c7cf4a0 Reviewed-on: https://chromium-review.googlesource.com/c/1282993Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#56689}
-
Sigurd Schneider authored
Change-Id: Ie77197db54b6d9117ba3e8823e1308e9419f766d Bug: v8:8312 Reviewed-on: https://chromium-review.googlesource.com/c/1282227 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Adam Klein authored
All of the places where MicrotasksScope is placed on the stack are callbacks from JavaScript, so microtasks would never run microtasks inside one of these methods. Change-Id: I6dc36971189d6479138b58b90e3b9acae0c3ef73 Reviewed-on: https://chromium-review.googlesource.com/c/1277721Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
Previously when class names were computed and set as part of StoreDataPropertyInLiteral calls, it was observable to static fields as these static fields are initialized right after the classes were constructed but before the class names were installed. This caused the name property to be undefined for this case. Instead, this patch always forces the creation of a name property on the class constructor when static class fields are used. This patch does kill the class boilerplate optimization, but currently all static class fields are installed using a runtime call to CreateDataProperty so this isn't any worse when using static class fields. In the future, this can be optimized away by storing the name on the boilerplate. There is spec discussion here: https://github.com/tc39/proposal-class-fields/issues/85 There isn't a resolution yet, there's still discussion about whether to have the name be undefined always for static class field initializers. But, I don't think that's useful as it would always kill our boilerplate optimization (like this patch does ..., but without the future optimization potential). Bug: v8:5367 Change-Id: I14afdf7ece3f2d9fa3c659d2c0bc3806e0b17abb Reviewed-on: https://chromium-review.googlesource.com/c/1281002Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
This does not change the behavior, just makes it more explicit rather than relying on the "presubmit" string being present in the builder name, which is about to be deprecated. R=machenbach@chromium.org, tandrii@chromium.org No-Try: true No-Tree-Checks: true Bug: chromium:893955 Change-Id: I99724b42510a93012dd40e338b1ff8f4047c1276 Reviewed-on: https://chromium-review.googlesource.com/c/1280582Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:6666, v8:7777 Change-Id: I842e61731a6df22f9bcdaa92cb6841af5c8ef796 Reviewed-on: https://chromium-review.googlesource.com/c/1280228Reviewed-by:
-
Michael Achenbach authored
This reverts commit c45bc57d. Reason for revert: Seen output once, that is enough. Original change's description: > [test] Temporary debug output for hanging tests > > TBR=sigurds@chromium.org,sergiyb@chromium.org > > Bug: v8:8292 > Change-Id: Ic03e2884ef645231807762f6b0210e69c5f9ac74 > Reviewed-on: https://chromium-review.googlesource.com/c/1282604 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56674} TBR=machenbach@chromium.org,sigurds@chromium.org,sergiyb@chromium.org Change-Id: Id5a2414682a9795998b86369368276e95c11394c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8292 Reviewed-on: https://chromium-review.googlesource.com/c/1283112Reviewed-by:
-
Tobias Tebbi authored
This bug surfaced in builds with some versions of libstdc++ (use_custom_libcxx=false), because of an additional debug check in std::min_element. Change-Id: I799c0a282101373ecf743eed61f911886ca23dc8 Reviewed-on: https://chromium-review.googlesource.com/c/1282989Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#56682}
-
Dan Elphick authored
In preparation for sharing RO_SPACE between all Isolates within a process, this first pulls RO_SPACE out of the Startup snapshot and puts it in its own ReadOnly snapshot. The snapshot is first populated with the read-only roots. After that the StartupSerializer serializes as before but starting from the first mutable root. References to objects in the ReadOnly snapshot that aren't themselves roots are added to a new cache called ReadOnlyObjectCache which functions like the PartialSnapshotCache but lives in the ReadOnlySerializer rather than the StartupSerializer. These cache entries are referenced using a new bytecode: ReadOnlyObjectCache. (To make room for this, the ApiReference bytecode has been moved). To reduce code duplication, the StartupSerializer has been refactored to create a new base class RootSerializer, which ReadOnlySerializer also subclasses. The base class is responsible primarily for keeping track of already serialized roots and visiting the roots. Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Iff26042886130ae22eccf2e11b35f6f226f4a792 Bug: v8:8191 Reviewed-on: https://chromium-review.googlesource.com/c/1244676 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Hai Dang authored
This improves the performance of ExtractFixedArray and CloneFastJSArray for double arrays, which in turn improve the performance of cloning double arrays with slice() or spreading. This, however, does not improve performance of spreading holey double arrays, because spreading needs extra work to convert holes to undefined. Bug: v8:7980 Change-Id: Ib8aed74abbb0b06982a3b754e134fa415cb7de2d Reviewed-on: https://chromium-review.googlesource.com/c/1280308Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Change-Id: Ibacdc7b41a96fc7c7d4ff44552fe6d86ec2ef1aa Bug: v8:8312 Reviewed-on: https://chromium-review.googlesource.com/c/1282605 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
