- 18 Aug, 2017 7 commits
-
-
Albert Mingkun Yang authored
Fix MaxIndex in test-gap-resolver.cc so that the above check doesn't fire. Change-Id: I6588800281d797f3f8b33ced4c1b03315196fe44 Reviewed-on: https://chromium-review.googlesource.com/618809Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Albert Mingkun Yang <albertnetymk@google.com> Cr-Commit-Position: refs/heads/master@{#47421}
-
Ben L. Titzer authored
This CL is a precursor to the callback-based enumeration of frame summaries. It removes the reliance of FrameInspector on having a cached copy of the FrameSummary, instead unpacking it to instance variables so that clients of FrameInspector do not need to get information from two sources (the FrameSummary and the FrameInspector itself). R=yangguo@chromium.org Bug: Change-Id: Ib388566c2e1a1147ee0a581323932982a29ae4ff Reviewed-on: https://chromium-review.googlesource.com/618334 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#47420}
-
Ben L. Titzer authored
This is a followup to moving the ModuleEnv to the compiler directory and making it immutable. R=mtrofin@chromium.org, ahaas@chromium.org Bug: Change-Id: I0f5ec1b697bdcfad0b4dc2bca577cc0f40de8dc0 Reviewed-on: https://chromium-review.googlesource.com/616762 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
Mircea Trofin <mtrofin@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#47419}
-
Ben L. Titzer authored
This CL (finally) makes the contract between the compiler and the module environment clear. In order to compile a function, the caller must provide an instance of the compiler::ModuleEnv struct, which contains references to code, function and signature tables, memory start, etc. R=mtrofin@chromium.org,ahaas@chromium.org Bug: Change-Id: I68e44d5da2c5ad44dad402029c2e57f2d5d25b4f Reviewed-on: https://chromium-review.googlesource.com/613880Reviewed-by:
-
Benedikt Meurer authored
The MapGuard node sits in the effect chain as a hint for other optimization passes that a certain value has a certain (set of) map(s) guarded by checks on the control chain. This is useful to learn from explicit control flow inserted for polymorphic property accesses, and then used as part of the polymorphic inlining. This change improves the score on the Octane/DeltaBlue benchmark by around 7-8% and the score on the Octane/Richards benchmark by like 3% on average. Bug: v8:5267 Change-Id: Id0b0b2c72e6a9342d5750a0d62cf6be6fb8c5916 Also-By: jarin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/620586 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#47417}
-
Marja Hölttä authored
Just to get the RuntimeCallstats data. To be reverted soon. BUG=v8:5516 NOTREECHECKS=true Change-Id: I4bb436900a79bb383bf8132002a129b601efdfe3 Reviewed-on: https://chromium-review.googlesource.com/618987Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#47416}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/bee933a..4fc2460 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/f90f6a5..d36e2d9 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/cd8447f..d9436e5 TBR=machenbach@chromium.org,hablich@chromium.org Change-Id: Ia1315802b2fa557ce964d517b232a57eb72340eb Reviewed-on: https://chromium-review.googlesource.com/620389Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#47415}
-
- 17 Aug, 2017 30 commits
-
-
Ulan Degenbaev authored
The race happens during evacuation when multiple threads access the main space capacity to check CanExpandOldGeneration. Bug: chromium:694255 Change-Id: I63dbb71cc3a894f85ee11411a5dc01d53daefa11 Reviewed-on: https://chromium-review.googlesource.com/618876 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#47414}
-
Ali Ijaz Sheikh authored
Some preperatory refactoring to allow observation of inline allocations from Old Space. BUG=chromium:633920 Change-Id: Ia1232591860729fcd8942d816aa454171d3aec33 Reviewed-on: https://chromium-review.googlesource.com/617923Reviewed-by:
-
Ulan Degenbaev authored
This also starts black allocation earlier if concurrent marking compile time flag is on. Bug: chromium:694255 Change-Id: I73c02676e5149fae10e5f9301ad585926e223a1d Reviewed-on: https://chromium-review.googlesource.com/618893Reviewed-by:
-
Franziska Hinkelmann authored
This is a reland of a50b6751 Original change's description: > [runtime] Port TypedArraySetFormArrayLike to C++ > > Bug: v8:6704 > Change-Id: I316f085801f4fb6a792124f9a6f80a16e6d43162 > Reviewed-on: https://chromium-review.googlesource.com/616721 > Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#47369} Bug: v8:6704 Change-Id: Id07f141f5f695e871248b4e5dcde0e7aa04e5493 TBR=bmeurer@chromium.org Change-Id: Id07f141f5f695e871248b4e5dcde0e7aa04e5493 Reviewed-on: https://chromium-review.googlesource.com/619214 Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Reviewed-by:
Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#47411}
-
Ulan Degenbaev authored
VERIFY_HEAP does not necessarily imply DEBUG. Bug: chromium:694255 TRB: mlippautz@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I1699288bd9d826ea1d577dd4fc2de81ee450add7 Reviewed-on: https://chromium-review.googlesource.com/618892 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
This patch changes how space size and capacity are updated in GC: - space capacity changes only when a page added/removed from the space. - space size is reset to zero before sweeping and incremented by page->live_bytes_count_ for each to-be-swept page. - space size is refined after sweeping using the accurate page->allocated_bytes counter produces by the sweeper. Invariants: 1. space.capacity = sum [page.size | for page in space]. 2. After marking, before sweeping: a) space.size = sum [page.live_bytes_count | for page in space]. 3. After sweeping, before marking ends: a) space.size = sum [page.allocated_bytes | for page in space]. b) page.allocated_bytes >= (sum [object.size | for object in page] + page.linear_allocation_area). c) page.area_size = (page.allocated_bytes + page.wasted_memory + sum [free_list_entry.size | for free_list_entry in page]. 3.b becomes equality if the mutator is not doing array trimming, object slack tracking during sweeping. Bug: chromium:694255 Change-Id: Ic8d16a8171187a113fee2df8bf3c2a4c5e77bc08 Reviewed-on: https://chromium-review.googlesource.com/618889 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: -
Ali Ijaz Sheikh authored
There is no need to add speed-bumps for incremental marking purposes for allocations from CompactionSpaces. This path was getting reached for Parallel Scavenges. Bug: Change-Id: I1f0f315549206bc86f8c48e202c29c18d212369b Reviewed-on: https://chromium-review.googlesource.com/617920Reviewed-by:
-
Marja Hölttä authored
The bug was that we didn't track using await as a class name inside arrow function formal parameters, and hence didn't recognize the error in this case: async(x = class await {}) => {} BUG=v8:6714 Change-Id: Iabe6c947a4f621fb72361671d77f4765ba1a9578 Reviewed-on: https://chromium-review.googlesource.com/616776Reviewed-by: -
Adam Klein authored
Before this patch, the parser mixed mixed "Null" and "Empty" as names for null placeholder instances in ParserBase. Confusingly, those meant different things in case of Statements. This patch uses "Null" anywhere the meaning is "== nullptr" in the Parser. It also makes use of std::nullptr_t and templatized IsNull() methods to reduce the amount of boilerplate needed in both the Parser and PreParser. Change-Id: I1451ba56d1a56466beb7e0c91dcf8e2bb7084413 Reviewed-on: https://chromium-review.googlesource.com/618167 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#47406}
-
Jaroslav Sevcik authored
This improves delta blue by about >5%. Unfortunately, this still does not help load and check elimination because we do not learn maps from control flow. Change-Id: I49a97dbc40576b9bc80c87ec2b459e37ba9b4440 Bug: v8:5267 Reviewed-on: https://chromium-review.googlesource.com/618328 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#47405}
-
Adam Klein authored
This patch handles C-style, as well as for-in/of loops. for-await loops will be changed in a followup. Bug: v8:6724 Change-Id: I264b8c2d41c0318e796839bf204f7d77b6d24dd8 Reviewed-on: https://chromium-review.googlesource.com/617410Reviewed-by:
-
Caitlin Potter authored
Move the desugaring into BytecodeGenerator per TODOs. BUG=v8:6472 R=tebbi@chromium.org, rmcilroy@chromium.org, jgruber@chromium.org Change-Id: Ic482bee18d6e6fe73de4c5f9abaf4feda7be2dd5 Reviewed-on: https://chromium-review.googlesource.com/550396Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Caitlin Potter <caitp@igalia.com> Cr-Commit-Position: refs/heads/master@{#47403}
-
Ross McIlroy authored
Have asm.js instantiate failures tail call the function object again, which has been reset to the CompileLazy builtin, rather than explicitly calling the CompileLazy runtime function. This ensures that we call any optimized code or respect the optimization marker on the feedback vector, and can introduce DCHECKS in Compiler::Compile to this effect. Change-Id: I69a1de006c4da8f667a3e8ae8cf69ecf241dae9a Reviewed-on: https://chromium-review.googlesource.com/618714 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#47402}
-
Albert Mingkun Yang authored
Make it consistent so that registers in all architecture have a member function called `bit()`. Bug: Change-Id: Ie6323f81d4ecab1557259a43a30100d8da8b35f1 Reviewed-on: https://chromium-review.googlesource.com/618872 Commit-Queue: Albert Mingkun Yang <albertnetymk@google.com> Reviewed-by:
-
Ben Noordhuis authored
glibc before 2.17 has a bug that makes it impossible to execute binaries that have single-byte thread-local variables: % node --version node: error while loading shared libraries: cannot allocate memory in static TLS block Work around that by making the one instance in the V8 code base an int. See: https://sourceware.org/bugzilla/show_bug.cgi?id=14898 See: https://github.com/nodesource/distributions/issues/513 See: https://github.com/nodejs/build/pull/809 Change-Id: Iefd8009100cd93e26cf8dc5dc03f2d622b423385 Reviewed-on: https://chromium-review.googlesource.com/612351 Commit-Queue: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-by:Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#47400}
-
Ross McIlroy authored
This is a reland of 21da12a9 Original change's description: > [Compiler] Remove CompileDebugCode and EnsureBytecode and replace with Compile > > Removes the Compiler::CompileDebugCode and Compiler::EnsureBytecode functions > and replaces them with a Compiler::Compile(Handle<SharedFunctionInfo> shared) > function. The code in compiler.cc is refactored to use this function to compile > the SharedFunctionInfo when compiling a JSFunction. > > Also does some other cleanup: > - Removes CompileUnoptimizedFunction and inlines into new Compiler function > - Moves code to create top level SharedFunctionInfo into CompilerTopLevel and > out of FinalizeUnoptimizedCompile. > > BUG=v8:6409 > > Change-Id: Ic54afcd8eb005c17f3ae6b2355060846e3091ca3 > Reviewed-on: https://chromium-review.googlesource.com/613760 > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#47394} TBR=yangguo@chromium.org TBR=jarin@chromium.org Bug: v8:6409 Change-Id: If2eae66a85f129e746a5ca5c04935540f3f86b04 Reviewed-on: https://chromium-review.googlesource.com/618886Reviewed-by:
-
Enrico Bacis authored
This CL introduces 6 tests that verify that the effects of a grow_memory instruction executed inside a function are visible also from the caller of the function. The tests verify that: * the current_memory instruction returns the correct value after returning from a function that grew memory; * accessing a memory page that has been created inside a function does not trap in the caller; * when a function grows the memory and then store something in the grown memory, the caller always reads from the grown memory. This checks that the memory start address gets updated in the caller (the memory buffer could in fact be relocated by the grow_memory instruction). These tests are implemented for direct and indirect function calls. R=ahaas@chromium.org,clemensh@chromium.org Change-Id: Iac8db0fa7a6dd6f530e090af5423fc165d87e863 Reviewed-on: https://chromium-review.googlesource.com/616150 Commit-Queue: Enrico Bacis <enricobacis@google.com> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#47398}
-
Ross McIlroy authored
This reverts commit 21da12a9. Reason for revert: Failing on arm64 simulator Original change's description: > [Compiler] Remove CompileDebugCode and EnsureBytecode and replace with Compile > > Removes the Compiler::CompileDebugCode and Compiler::EnsureBytecode functions > and replaces them with a Compiler::Compile(Handle<SharedFunctionInfo> shared) > function. The code in compiler.cc is refactored to use this function to compile > the SharedFunctionInfo when compiling a JSFunction. > > Also does some other cleanup: > - Removes CompileUnoptimizedFunction and inlines into new Compiler function > - Moves code to create top level SharedFunctionInfo into CompilerTopLevel and > out of FinalizeUnoptimizedCompile. > > BUG=v8:6409 > > Change-Id: Ic54afcd8eb005c17f3ae6b2355060846e3091ca3 > Reviewed-on: https://chromium-review.googlesource.com/613760 > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#47394} TBR=rmcilroy@chromium.org,yangguo@chromium.org,jarin@chromium.org,leszeks@chromium.org Change-Id: I4ba63e82417a185f1528ff2633eb6c8872fbbfe5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6409 Reviewed-on: https://chromium-review.googlesource.com/618687Reviewed-by:
-
Ivica Bogosavljevic authored
Bug: Change-Id: I5b5477b55f42cdfa7978bbe6b8610302f0ec41fb Reviewed-on: https://chromium-review.googlesource.com/612085Reviewed-by:
Miran Karić <Miran.Karic@imgtec.com> Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@imgtec.com> Cr-Commit-Position: refs/heads/master@{#47396}
-
Enrico Bacis authored
The WASM spec maximum memory size is higher than internal V8 maximum object size. When a memory object grows above this limit (and only in that case), we should signal an error. This worked for not-exported memory; however when growing exported memory, the code was comparing the V8 memory limit with the maximum number of pages defined in the module, instead of the current number of pages + the number of new required pages. This lead to signaling errors even when growing exported memory below the V8 limit if the maximum number of pages specified in the module was higher than the V8 limit. GrowMemoryBuffer already checks that we do not grow a memory buffer past the maximum size specified as parameter, so we can pass it the minimum between the the V8 limit and the maximum number of pages specified in the module. This CL introduces a test in test/mjsunit/wasm/import-memory.js that triggers the problematic path and a patch to fix it. R=ahaas@chromium.org,clemensh@chromium.org,gdeepti@chromium.org Change-Id: I5a8da420418b394d61e1ba3cdf4408c3c09e61b6 Reviewed-on: https://chromium-review.googlesource.com/600217Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Enrico Bacis <enricobacis@google.com> Cr-Commit-Position: refs/heads/master@{#47395}
-
Ross McIlroy authored
Removes the Compiler::CompileDebugCode and Compiler::EnsureBytecode functions and replaces them with a Compiler::Compile(Handle<SharedFunctionInfo> shared) function. The code in compiler.cc is refactored to use this function to compile the SharedFunctionInfo when compiling a JSFunction. Also does some other cleanup: - Removes CompileUnoptimizedFunction and inlines into new Compiler function - Moves code to create top level SharedFunctionInfo into CompilerTopLevel and out of FinalizeUnoptimizedCompile. BUG=v8:6409 Change-Id: Ic54afcd8eb005c17f3ae6b2355060846e3091ca3 Reviewed-on: https://chromium-review.googlesource.com/613760 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Igor Sheludko authored
'9. Let targetName be ? Get(Target, "name").' didn't produce required side effects. Bug: v8:6712 Change-Id: Iebf007b4e93ebbf9c6c85c9729d972a8c1a7b129 Reviewed-on: https://chromium-review.googlesource.com/616727Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#47393}
-
Yang Guo authored
R=cbruni@chromium.org Bug: v8:6726 Change-Id: If56ce1a0b00b98ede2bb101cb9697ec516d19e81 Reviewed-on: https://chromium-review.googlesource.com/616641Reviewed-by:
-
Predrag Rudic authored
This CL solves recent clang compilation error: "src/wasm/function-body-decoder.cc:1418:18: error: comparison of two values with different enumeration types in switch statement ('v8::internal::wasm::ControlKind' and 'ControlKind')" Bug: Change-Id: I6cb32bb3d42256a80d6f9222f5450ee93ce1021a Reviewed-on: https://chromium-review.googlesource.com/615247Reviewed-by:Ben Titzer <titzer@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#47391}
-
Marja Hölttä authored
Here the token cannot be Token::INIT since it's coming from the Scanner. Scanner never returns Token::INIT, and Token::INIT is only used internally in the AST. Bug: Change-Id: I185e6d3330651b7ee784b916908e7d8d803b63b9 Reviewed-on: https://chromium-review.googlesource.com/616282 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Leszek Swirski authored
In graph building, use liveness information to only create Phis for live registers when merging two environments, or when preparing a loop header. Similarly, only create loop exit value nodes for live registers when exiting a loop. Bug: v8:6701 Change-Id: Id6ac6a5518e6f1762530d871e92a46f42397928b Reviewed-on: https://chromium-review.googlesource.com/615173 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Leszek Swirski authored
The accumulator should never be alive when jumping back to a loop header, or jumping out of a loop. This means that as far as far as TurboFan is concerned, we never need to create Phis or LoopExitValues for the accumulator, as its value should not escape the loop. For safety, this also augments the IsLivenessValid DCHECK in the liveness analysis to check that the accumulator is not live in these cases, and amends the bytecode analysis tests to kill the accumulator where necessary to ensure this. As a drive-by, added some comments to the more complex bytecode analysis tests, since figuring out what they were for and how to fix them took a non-trivial amount of time. Change-Id: Idecf76a36681d724134c59768650c23cc6b0e9ef Reviewed-on: https://chromium-review.googlesource.com/615168 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Yang Guo authored
R=rmcilroy@chromium.org Bug: v8:6409 Change-Id: I8205ca3e9587f4cb1d35d7edc1aa320814020ac4 Reviewed-on: https://chromium-review.googlesource.com/616665Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/179cd37..bee933a Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/b153f21..cd8447f Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/5bad4f2..874d630 TBR=machenbach@chromium.org,hablich@chromium.org Change-Id: I6ad7178725c0eb5ab3420796d42ca6ca1dfdf286 Reviewed-on: https://chromium-review.googlesource.com/618488Reviewed-by:
-
jing.bao authored
I32x4 Neg, Eq/Ne/GtS/GeS/GtU/GeU Reconstruct ro/RRO macro instructions with AVX_OP3_WITH_TYPE Bug: Change-Id: I3e391f489717db3456b884c6df0b1756497a1846 Reviewed-on: https://chromium-review.googlesource.com/616463Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
-
- 16 Aug, 2017 3 commits
-
-
Caitlin Potter authored
Bug: v8:5855 Change-Id: Ie783318b2297f85a9f102e1266dfc1fac406435a Reviewed-on: https://chromium-review.googlesource.com/466107 Commit-Queue: Caitlin Potter <caitp@igalia.com> Reviewed-by:
-
Franziska Hinkelmann authored
This reverts commit a50b6751. Reason for revert: Regression Original change's description: > [runtime] Port TypedArraySetFormArrayLike to C++ > > Bug: v8:6704 > Change-Id: I316f085801f4fb6a792124f9a6f80a16e6d43162 > Reviewed-on: https://chromium-review.googlesource.com/616721 > Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#47369} TBR=franzih@chromium.org,bmeurer@chromium.org Change-Id: Ibafeae41c85b6d7848b26dac7468057e1cea4769 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6704 Reviewed-on: https://chromium-review.googlesource.com/617480Reviewed-by:
-
Adam Klein authored
This patch simplifies and reduces code duplication & dead branches in PatternRewriter, especially relating to handling of destructuring assignments. It also adds additional DCHECKs to capture invariants. It should have no change in behavior. Change-Id: I02bc6c30a1cae8a60c4c5e9033b90953d136212e Reviewed-on: https://chromium-review.googlesource.com/612511 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
-
