• Leszek Swirski's avatar
    [turbofan] Never generate loop exit phis for the accumulator · 1a302730
    Leszek Swirski authored
    The accumulator should never be alive when jumping back to a loop
    header, or jumping out of a loop. This means that as far as far as
    TurboFan is concerned, we never need to create Phis or LoopExitValues
    for the accumulator, as its value should not escape the loop.
    
    For safety, this also augments the IsLivenessValid DCHECK in the
    liveness analysis to check that the accumulator is not live in these
    cases, and amends the bytecode analysis tests to kill the accumulator
    where necessary to ensure this.
    
    As a drive-by, added some comments to the more complex bytecode analysis
    tests, since figuring out what they were for and how to fix them took a
    non-trivial amount of time.
    
    Change-Id: Idecf76a36681d724134c59768650c23cc6b0e9ef
    Reviewed-on: https://chromium-review.googlesource.com/615168
    Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
    Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47388}
    1a302730
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...