- 24 Apr, 2019 14 commits
-
-
Sigurd Schneider authored
This reverts commit fa6ec3cb. Reason for revert: v8:9169, v8:9170 https://ci.chromium.org/p/v8/builders/ci/V8%20Linux/31457 https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64/31417 https://ci.chromium.org/p/v8/builders/ci/V8%20Win32%20-%20debug/19919 Original change's description: > [cpu-profiler] Split out debug mode for CPU profiler naming > > Adds a new flag to CpuProfiler to control whether or not "debug" names > (potentially inferred from scope) are used for captured frames > associated with a SharedFunctionInfo instance. > > Bug: v8:9135 > Change-Id: I104f3246431dc6336de4e4688c0d98c86e0bb776 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1566169 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60972} TBR=ulan@chromium.org,alph@chromium.org,yangguo@chromium.org,petermarshall@chromium.org,acomminos@fb.com Change-Id: I573194b5affd31fd0748b9ef3c45052e8ab420f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9135 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581639Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60973}
-
Andrew Comminos authored
Adds a new flag to CpuProfiler to control whether or not "debug" names (potentially inferred from scope) are used for captured frames associated with a SharedFunctionInfo instance. Bug: v8:9135 Change-Id: I104f3246431dc6336de4e4688c0d98c86e0bb776 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1566169Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#60972}
-
Michael Lippautz authored
Removes APIs: - MarkIndependent - IsIndependent - MarkActive - RegisterExternalReference All weak persistent handles are now treated as independent. Users of traced handles should already use v8::EmbedderHeapTracer. This reverts commit 49954eb5. Bug: chromium:923361 Change-Id: I0b9fcd678964331f926f6b725f70eb64268ca33f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578462 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
The current logic sometimes skips the request for a code logging stack guard request, even though no such request is pending. This happens if the previous stack guard already executed, but a foreground task is still pending. This CL fixes this by re-requesting a stack guard interrupt when the first code is added to the vector of outstanding code to be logged. Plus minor drive-by fix. R=mstarzinger@chromium.org Bug: v8:9163 Change-Id: I4937f3983f15e7122141b04ddb1432cd1f78828b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578461 Auto-Submit: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60970}
-
Michael Starzinger authored
R=titzer@chromium.org TEST=mjsunit/regress/regress-9165 BUG=v8:9165 Change-Id: If6d7d56bf164a85675590e69bf9857c11fc1b218 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578463Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#60969}
-
Santiago Aboy Solanes authored
... for * in ("", "Tagged", "Signed"). Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:7703 Change-Id: I6891fea9596058e7290df7a6b6775dd8a184ea2f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578500Reviewed-by:Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#60968}
-
Sergiy Belozorov authored
R=machenbach@chromium.org, tmrts@chromium.org Bug: chromium:841700 Change-Id: I9852ccc573eda6b1bab7a7db295f7fd6e7410581 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1570010 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60967}
-
Clemens Hammacher authored
This is an attempt to work around a potential toolchain bug. Disassembly of FlushICache: 00000000 <_ZN2v88internal11CpuFeatures11FlushICacheEPvj>: 0:·b5c0 ··push··{r6, r7, lr} 2:·af01 ··add·r7, sp, #4 4:·2702 ··movs··r7, #2 6:·4401 ··add·r1, r0 8:·f2c0 070f ··movt··r7, #15 c:·2200 ··movs··r2, #0 e:·df00 ··svc·0 10:·bdc0 ··pop·{r6, r7, pc} Bug: chromium:952759 Change-Id: I6a618607f58c394c364b2ebd9f11684871a8beee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1579542 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60966}
-
Clemens Hammacher authored
They were introduced in https://crrev.com/c/559674, but never used. R=neis@chromium.org Bug: v8:8834 Change-Id: I773bc1ba14c7a1d5adc1a483f539221f18042361 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578505Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60965}
-
Toon Verwaest authored
Change-Id: I34dc911d205ab507f668bfd422eb1838f660a6bf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1571624 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
Bug: v8:8880 Change-Id: I8693def4aea26a5a9430f4c49d701fae14b2f27b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578502Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#60963}
-
Michael Achenbach authored
This prepares removing the special timeout of 200 on the bots. First we temporarily set 200 on v8 side to remove the flag on the infra side. Afterwards we'll remove the v8-side code, tested in CQ. TBR=tmrts@chromium.org Bug: v8:9145 Change-Id: I61578da02ab8c101d0d6c916106ad5a8bc6841cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581259Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60962}
-
v8-ci-autoroll-builder authored
Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/c46d4fa..43898ad [spec] Fix off-by-one error in table grow size limit (#1005) (Andreas Rossberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/43898ad TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: Ibfc45cc4f5bc81e72c3340d830f059b5493f069e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581082Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#60961}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7dae72d..5160e91 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/fb33e51..429d9b4 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/6d9913a..0d82718 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/9f893b9..a53e931 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ic65275bf40a1d69ef176c24b3cf75f7de5d84085 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1580800Reviewed-by:
-
- 23 Apr, 2019 24 commits
-
-
Z Duong Nguyen-Huu authored
Bug: chromium:953888 Change-Id: If2aa613bac18e61ac733102b45b0ebb6553eae1a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1579539Reviewed-by:
-
Michael Achenbach authored
Change-Id: I574f647245d215b03a59b6c3dd6889e94f4d7708 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578507Reviewed-by:
-
Sathya Gunasekaran authored
In the PerformPromise{All, Race, AllSettled} operations, the resolve property of the constructor is looked up only once. In the implementation, for the fast path, where the constructor's resolve property is untainted, the resolve function is set to undefined. Since undefined can't be a valid value for the resolve function, we can switch on it (in CallResolve) to directly call the PromiseResolve builtin. If the resolve property is tainted, we do an observable property lookup, save this value, and call this property later (in CallResolve). I ran this CL against the test262 tests locally and they all pass: https://github.com/tc39/test262/pull/2131 Spec: - https://github.com/tc39/ecma262/pull/1506 - https://github.com/tc39/proposal-promise-allSettled/pull/40 Bug: v8:9152 Change-Id: Icb36a90b5a244a67a729611c7b3315d2c29de6e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1574705 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#60957}
-
Michael Achenbach authored
TBR=tmrts@chromium.org Bug: v8:9145,v8:9098 Change-Id: Ib2170819f6d9aa00174fefb6bef4b0a27c11acfc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578503Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60956}
-
andrew-cc-chen authored
Change-Id: I2bc21a353c871652daeac87eae62e1e6ae740b49 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1529638Reviewed-by:
-
Michael Lippautz authored
This reverts commit 1ebf5f72. Reason for revert: Breaks TSAN Original change's description: > [api,heap] Remove deprecated Persistent APIs > > Removes APIs: > - MarkIndependent > - IsIndependent > - MarkActive > - RegisterExternalReference > > All weak persistent handles are now treated as independent. Users of > traced handles should already use v8::EmbedderHeapTracer. > > Bug: chromium:923361 > Change-Id: Ic90a647fe2ce9db92197ad6560e4907290805592 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578459 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60953} TBR=ulan@chromium.org,mlippautz@chromium.org Change-Id: I8281daf30b67c1b71ef6e65d8f13a59230ba0334 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:923361 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578900Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#60954}
-
Michael Lippautz authored
Removes APIs: - MarkIndependent - IsIndependent - MarkActive - RegisterExternalReference All weak persistent handles are now treated as independent. Users of traced handles should already use v8::EmbedderHeapTracer. Bug: chromium:923361 Change-Id: Ic90a647fe2ce9db92197ad6560e4907290805592 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578459 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Shiyu Zhang authored
Change-Id: I9480650b23da4f5aa38a0634c1a7662bf88189d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1551407Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> Cr-Commit-Position: refs/heads/master@{#60952}
-
Takuto Ikuta authored
As a preparation of trusty -> xenial migration, let me specify os dimension explicitly here. I added os dimension for the linux builders having tests property. I will change this dimension gradually with gradual swarming test bots trusty -> xenial migration. Currently this should not change ubuntu's version of bots running tests because v8 recipe module has default Ubuntu-14.04 dimension for linux. https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/v8/api.py?l=428&rcl=927948978a7a101fca66f07a784aeb3ddb6650c9 Bug: chromium:954890 Change-Id: Ib2404c5aaa54d6e8e47341394d6a757a9d99874a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578659 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
The {Vector} class stores the size in a {size_t} since a while, but many accessors and constructors still accept an {int}. This CL removes all {int} uses except for the explicit {length()} accessor. It also adds a comment to avoid this accessor if possible. The {StrLength} function still has several users outside of vector.h, which I plan to remove in a follow-up CL. R=mstarzinger@chromium.org Bug: v8:8834 Change-Id: I33c5b0e8b8b2cb3531716c1d99e4516a13d6ba1f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578480Reviewed-by: -
Clemens Hammacher authored
This CL fixes some issues with GC. 1) It removes dead code from the set of potentially dead code to avoid considering the same code for GC again and again. 2) It resets the {new_potentially_dead_code_size_} counter to avoid triggering too many GCs. 3) When code becomes dead after GC, do not unconditionally free it; just decrement its ref count (there might still be {WasmCodeRefScope}s holding the code alive). 4) Update the comment of the ref count to be more accurate. R=titzer@chromium.org Bug: v8:8217 Change-Id: I28e5a1fed74411b8473bb66ddbad3ffe7643f266 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1574518 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Clemens Hammacher authored
This adds two counters for collecting the absolute size of freed code, and the percent of total generated code per module. R=titzer@chromium.org Bug: v8:8217 Change-Id: Ia065081104fbff6459791c919e0b18677ba45cc3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1573698 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Sergiy Belozorov authored
This is dead code as no benchmarks seem to be using it and removing this additional logic will reduce maintenance cost for the perf infrastructure. R=machenbach@chromium.org, tmrts@chromium.org No-Try: true No-Tree-Checks: true Change-Id: I952af069d4d18d63624510b4c461fa1891703db9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1570008 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
-
Sergiy Belozorov authored
This is part of the refactoring to allow exporting more information about test execution to the recipes and upload this information to ChromePerf. This fixes running secondary even after primary run fails, which will allow us to differentiate between test and infra failures as latter ones will also affect refbuilds and re-runs without patch. R=machenbach@chromium.org, tmrts@chromium.org Bug: chromium:841700 Change-Id: I29ce49d2f8c5e73158f1d41a73c51f2b35929f36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1570006 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This is the next step to test the GC better: We zap the code region of {WasmCode} objects which are detected to be unused. This is tested in the future variant, so ClusterFuzz has a chance to catch missing references. R=titzer@chromium.org Bug: v8:8217 Change-Id: I75a63384a2a8e2ed68b9447e6ee4faa24037da93 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1571622Reviewed-by: -
Sergiy Belozorov authored
This is part of the refactoring to allow exporting more information about test execution to the recipes and upload this information to ChromePerf. R=machenbach@chromium.org,tmrts@chromium.org No-Try: true No-Tree-Checks: true Bug: chromium:841700 Change-Id: Iab400e8922231d8eac91a6fa22ce8f45053f7ac6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1569442Reviewed-by:
-
Michael Starzinger authored
The WebAssembly JavaScript Interface specifies[1] that exported functions are not constructors, hence do not have the "prototype" property. This is not true for asm.js exported functions which are expected to look like normal functions (or constructors). [1] https://webassembly.github.io/spec/js-api/index.html#exported-function-exotic-objects R=clemensh@chromium.org TEST=mjsunit/regress/regress-crbug-935800 BUG=chromium:935800 Change-Id: Idecacfb7f5d4668540589af95fd59872334c21a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578499 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL implements the first set of diagnostic notifications. When Torque compilation fails, the language server translates the Torque error into a diagnostics notification and pushes it to the client. Note that per specification, the server is responsible to manage the state of all published diagnostics. This means that the server is also responsible for clearing out previous notifications if they become stale. Bug: v8:8880 Change-Id: Ief46dc1d94d1e5b7fa3e0048df494bfc05974031 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1569434Reviewed-by:
-
Michael Achenbach authored
This prints the current v8-specific processes on linux whenever the test driver emits a heart beat (i.e. no output for 30 seconds). This is to investigate the cause of currently hanging tests on linux. Bug: v8:9145 Change-Id: I857bb6d1c5f0b0917c64cdc0aa6076c6633f9dd6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578438 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
EmbeddedVector lives on the stack only, and should not be implicitly copied or assigned. This also removes remaining uses of the removed Vector::set_start method. R=sigurds@chromium.org Bug: v8:9142 Change-Id: I829e6ffad6b1a30baa6c874265e92d615dd0c981 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578458Reviewed-by:
-
Georg Neis authored
Before: 0x352ac49c2eb4 f4 4d898df0f10600 REX.W movq [r13+0x6f1f0] (WAAT??? What are we accessing here???),r9 After: 0x352ac49c2eb4 f4 4d898df0f10600 REX.W movq [r13+0x6f1f0],r9 Change-Id: I5f9af797de3c84117fd123204d9094251d18d07b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1571618Reviewed-by:
-
Michael Achenbach authored
NOTRY=true TBR=sigurds@chromium.org Bug: v8:8963 Change-Id: Idf19be92f7f039a14838c87695666d5f6963e6a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1575585Reviewed-by:
-
Matheus Marchini authored
R=bmeurer@chromium.org, jgruber@chromium.org, yangguo@chromium.org Bug: v8:9122 Change-Id: I6336d2fc0249269a749d99dcae7c172b2ccaac75 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1570582Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b5c9a27..7dae72d Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/d8ce959..fb33e51 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/8dfc0bc..6d9913a TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I94dc1ff83c0c6bbbe46ee83065895810b19f6dc8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578278Reviewed-by:
-
- 21 Apr, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/f20b8e9..c46d4fa [spec] Work around Sphinx/Latex issue (#1004) (Andreas Rossberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/c46d4fa TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: Id928f05d1ccec2f24d8bbe6eaca6bc646c58f6fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1576818Reviewed-by:
-
- 20 Apr, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c0da152..b5c9a27 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/9f474a8..d8ce959 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ifaea2c06ec5dd338d0ab6d9775a6cce30647d40d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1575828Reviewed-by:
-
