Skip to content

V
V8
Switch branch/tag
  1. 13 Aug, 2018 1 commit
  3. 12 Jul, 2018 1 commit
  5. 10 Jul, 2018 1 commit
  7. 03 Jul, 2018 1 commit
  9. 29 Jun, 2018 1 commit
  11. 28 Jun, 2018 1 commit
  13. 22 Jun, 2018 1 commit
  15. 20 Jun, 2018 1 commit
    • jgruber's avatar
      [builtins] Properly handle cctest heap creation in embedded builds · f86365dc
      jgruber authored 
      Some cctests force fresh creation of heap constants, even though the
cctest binary itself is an embedded snapshot build (i.e.: a snapshot
blob exists, and a binary-embedded blob exists). This breaks a few
assumptions, for example that off-heap builtins have a single,
canonical off-heap code range.

Unfortunately this isn't that easy to fix. I see a few alternatives:

1. In builtins setup, if an embedded blob exists, regenerate the
builtins for their metadata (things like the safepoint table offset),
and then replace them by off-heap trampolines.

2. As above, but deserialize the trampolines from the snapshot blob.

3. As above, but pack required metadata into the embedded blob and
create trampolines from there.

4. Act as if the embedded blob does not exist.

Alternative 1 does not work because the generated code can be slightly
different at at runtime vs. mksnapshot-time. Alternative 2 is out
because we do not have access to the snapshot blob in TestIsolate
setup. Alternative 3 is probably the preferred option but would be a
more involved change.

This CL takes path 4. It's not an optimal solution, but it can be
replace by alternative 3 later.

TBR=ulan@chromium.org

Bug: v8:7718, v8:7751
Change-Id: I36c024cb0179615011c886ed3978bc95f0d197ac
Reviewed-on: https://chromium-review.googlesource.com/1098924Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53886}
      f86365dc
  17. 19 Jun, 2018 2 commits
  19. 18 Jun, 2018 1 commit
  21. 15 Jun, 2018 1 commit
  23. 13 Jun, 2018 1 commit
  25. 12 Jun, 2018 1 commit
  27. 07 Jun, 2018 1 commit
  29. 04 Jun, 2018 1 commit
  31. 24 May, 2018 1 commit
  33. 23 May, 2018 1 commit
    • Peter Marshall's avatar
      [cpu-profiler] Add a new profiling mode with a more detailed call tree. · ecae80cd
      Peter Marshall authored 
      The current profiling mode (called kLeafNodeLineNumbers in this CL)
produces a tree, with each node representing a stack frame that is seen
in one or more samples taken during profiling. These nodes refer to a
particular function in a stack trace, but not to a particular line or
callsite within that function.

This CL adds a new more (called kCallerLineNumbers) which produces a
different profile tree, where each stack trace seen during profiling,
including the line number, has a unique path in the tree.

The profile tree was previously keyed on CodeEntry*. Now it is keyed on
the pair of CodeEntry* and line_number, meaning it has distinct nodes
for those combinations which exist, and each distinct stack trace that
was sampled is represented in the tree.

For optimized code where we have inline frames, there are no line
numbers for the inline frames in the stack trace, causing duplicate
branches in the tree with kNoLineNumberInfo as the reported line number.
This will be addressed in follow-ups.

Bug: v8:7018
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I512e221508f5b50ec028306d212263b514a9fb24
Reviewed-on: https://chromium-review.googlesource.com/1013493
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53298}
      ecae80cd
  35. 17 May, 2018 1 commit
  37. 09 May, 2018 2 commits
  39. 08 May, 2018 1 commit
  41. 07 May, 2018 1 commit
  43. 03 May, 2018 1 commit
  45. 27 Apr, 2018 2 commits
  47. 06 Apr, 2018 1 commit
  49. 05 Apr, 2018 2 commits
  51. 04 Apr, 2018 1 commit
  53. 27 Mar, 2018 1 commit
  55. 22 Mar, 2018 1 commit
    • Leszek Swirski's avatar
      Reland^2: Remove SFI code field · 51ded9d3
      Leszek Swirski authored 
      This is a reland of d8f564ea

TBR=mstarzinger@chromium.org,yangguo@chromium.org,jgruber@chromium.org

Original change's description:
> Reland: Remove SFI code field
>
> Remove the SharedFunctionInfo code field, inferring the code object
> from the function_data field instead. In some cases, the function_data
> field can now hold a Code object (e.g. some WASM cases).
>
> (Reland of https://chromium-review.googlesource.com/952452)
>
> TBR=mstarzinger@chromium.org
>
> Bug: chromium:783853
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
> Change-Id: I10ea5be7ceed1b51362a2fad9be7397624d69343
> Reviewed-on: https://chromium-review.googlesource.com/970649
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#52136}

Bug: chromium:783853
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I5187851b923e9a92f43daf8cb99e662786cbb839
Reviewed-on: https://chromium-review.googlesource.com/975942
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52159}
      51ded9d3
  57. 20 Mar, 2018 3 commits
  59. 19 Mar, 2018 1 commit
  61. 12 Mar, 2018 1 commit
  63. 09 Mar, 2018 2 commits
  65. 08 Mar, 2018 1 commit