1. 06 Oct, 2017 1 commit
  2. 01 Sep, 2017 1 commit
  3. 09 Aug, 2017 1 commit
  4. 03 Mar, 2017 1 commit
    • clemensh's avatar
      [wasm] Fix importing wasm functions which are being debugged · eb36a7db
      clemensh authored
      If the imported wasm function is being debugged (i.e. redirects to the
      interpreter), call it via the JS_TO_WASM stub, such that we can disable
      the breakpoint later by patching the exported function.
      
      This also contains a drive-by fix in wasm-translation.cc (for the case
      that all known positions are bigger than the requested one).
      
      R=titzer@chromium.org, kozyatinskiy@chromium.org
      BUG=v8:5971, v8:5822
      
      Review-Url: https://codereview.chromium.org/2720813002
      Cr-Commit-Position: refs/heads/master@{#43583}
      eb36a7db
  5. 02 Feb, 2017 1 commit
  6. 27 Jan, 2017 1 commit
    • clemensh's avatar
      [inspector] Expose GetPossibleBreakpoints for wasm · c6663ef1
      clemensh authored
      and add an inspector test for it. Also test that a breakpoint can be
      set on each reported position, and that it is also hit during
      execution.
      This CL also fixes two little things which were uncovered by the new
      test.
      
      R=yangguo@chromium.org, titzer@chromium.org, kozyatinskiy@chromium.org
      BUG=v8:5822
      
      Review-Url: https://codereview.chromium.org/2655653003
      Cr-Commit-Position: refs/heads/master@{#42722}
      c6663ef1
  7. 06 Dec, 2016 3 commits
    • clemensh's avatar
      [inspector] Split V8DebuggerScript implementation for wasm · a9017cb0
      clemensh authored
      Make some methods on V8DebuggerScript virtual and provide the
      implementations ActualScript for scripts which are backed by scripts on
      V8's side, and WasmVirtualScript for wasm scripts.
      
      The added test case ensures that we at least don't crash on the attempt
      to get breakable locations for wasm "scripts", which we did previously.
      Returning a reasonable result for wasm will be implemented in a
      follow-up commit.
      
      R=yangguo@chromium.org, jgruber@chromium.org
      BUG=chromium:667767,chromium:613110
      
      Review-Url: https://codereview.chromium.org/2532433003
      Cr-Commit-Position: refs/heads/master@{#41527}
      a9017cb0
    • clemensh's avatar
      [inspector] [wasm] Add folder structure to wasm urls · 2da865d8
      clemensh authored
      It turns out that showing a five-digit number of resources blocks the
      UI for a few minutes, and it remains very laggy even after that.
      This CL adds another component to the path of wasm scripts if the
      module contains more than 300 functions. The additional component will
      be the function index rounded down to the next multiple of 100.
      Example URL before:
      wasm://wasm/wasm-0284f1c6/wasm-0284f1c6-26337
      Example URL after:
      wasm://wasm/wasm-0284f1c6/26300/wasm-0284f1c6-26337
      
      This avoids showing a five-digit number of entries in the resources view.
      
      R=kozyatinskiy@chromium.org, titzer@chromium.org, yangguo@chromium.org
      BUG=chromium:659715
      
      Review-Url: https://codereview.chromium.org/2555433002
      Cr-Commit-Position: refs/heads/master@{#41522}
      2da865d8
    • clemensh's avatar
      [inspector] Introduce debug::WasmScript · 12cdb31b
      clemensh authored
      *and* report all "virtual" wasm scripts right when the wasm script is
      registered at the inspector.
      
      WasmScript is a subtype of Script, with the cast checking that it is
      actually a wasm script.
      This layout makes it quite easy to implement functionality that is only
      available for wasm scripts, and allows to later directly use the
      WasmCompiledModule instead of the i::Script for backing the
      debug::WasmScript. We might also add virtual methods to
      provide different implementations for GetSourcePosition, Source and
      others.
      
      DisassembleWasmFunction now also becomes a method of this class instead
      of a static function on the DebugInterface.
      
      The WasmTranslation now uses the new WasmScript type instead of the
      Script wrapper, and also registers all virtual wasm scripts immediately
      when the wasm script is made public to the inspector (when the wasm
      module is created).
      
      R=yangguo@chromium.org,dgozman@chromium.org,titzer@chromium.org
      BUG=chromium:613110,chromium:659715
      
      Review-Url: https://codereview.chromium.org/2531163010
      Cr-Commit-Position: refs/heads/master@{#41519}
      12cdb31b
  8. 05 Dec, 2016 2 commits
    • clemensh's avatar
      [debug] Remove DebugInterface class · e6bd3063
      clemensh authored
      It only contained type definitions and static functions, so we
      can also just make it a namespace.
      
      R=kozyatinskiy@chromium.org, yangguo@chromium.org
      
      Review-Url: https://codereview.chromium.org/2549133002
      Cr-Commit-Position: refs/heads/master@{#41501}
      e6bd3063
    • clemensh's avatar
      [inspector] Split off interface-types.h · f5fb2da6
      clemensh authored
      This CL adds a new header src/debug/interface-types.h, moves the
      definition of Location from the debug-interface.h to this new header,
      and adds a new definition for the WasmDisassembly types.
      This allows to use the types in other implementation files or headers
      without having to include the entire debug-interface.h, reducing build
      dependencies and compile time (especially for incremental builds).
      
      The WasmDisassembly type replaces the old
      std::pair<std::string, std::vector<std::tuple<...>>>, which was a bit
      hard to unravel.
      
      R=yangguo@chromium.org, kozyatinskiy@chromium.org, titzer@chromium.org
      
      Review-Url: https://codereview.chromium.org/2529383002
      Cr-Commit-Position: refs/heads/master@{#41488}
      f5fb2da6
  9. 16 Nov, 2016 1 commit
    • clemensh's avatar
      [inspector] Introduce translation of wasm frames · d4a42a5f
      clemensh authored
      This allows to show wasm source (disassembled wasm code) in DevTools.
      See design doc for details.
      
      More tests for the disassembly will have to follow. Also, the text
      format (generated by V8) will be changed.
      
      BUG=chromium:659715
      R=yangguo@chromium.org, kozyatinskiy@chromium.org, titzer@chromium.org, dgozman@chromium.org
      
      Review-Url: https://codereview.chromium.org/2493773003
      Cr-Commit-Position: refs/heads/master@{#41055}
      d4a42a5f