[inspector] removed unused code from JavaScriptSourceFrame

And fixed gcc compilation.

BUG=none
R=alph@chromium.org,dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2668363002
Cr-Commit-Position: refs/heads/master@{#42895}

src/inspector/debugger-script.js

@@ -390,8 +390,8 @@ DebuggerScript._frameMirrorToJSCallFrame = function(frameMirror)
             details = {
                 "functionName": ensureFuncMirror().debugName(),
                 "location": {
-                    "lineNumber": line(),
-                    "columnNumber": column(),
+                    "lineNumber": ensureLocation().line,
+                    "columnNumber": ensureLocation().column,
                     "scriptId": String(script.id())
                 },
                 "this": thisObject,
@@ -449,22 +449,6 @@ DebuggerScript._frameMirrorToJSCallFrame = function(frameMirror)
         return location;
     }
 
-    /**
-     * @return {number}
-     */
-    function line()
-    {
-        return ensureLocation().line;
-    }
-
-    /**
-     * @return {number}
-     */
-    function column()
-    {
-        return ensureLocation().column;
-    }
-
     /**
      * @return {number}
      */
@@ -477,15 +461,6 @@ DebuggerScript._frameMirrorToJSCallFrame = function(frameMirror)
         return 0;
     }
 
-    /**
-     * @return {number}
-     */
-    function sourceID()
-    {
-        var script = ensureScriptMirror();
-        return script.id();
-    }
-
     /**
      * @param {string} expression
      * @return {*}
@@ -515,9 +490,6 @@ DebuggerScript._frameMirrorToJSCallFrame = function(frameMirror)
     }
 
     return {
-        "sourceID": sourceID,
-        "line": line,
-        "column": column,
         "contextId": contextId,
         "thisObject": thisObject,
         "evaluate": evaluate,

src/inspector/debugger_script_externs.js

@@ -29,9 +29,6 @@ var RawLocation;
 var JavaScriptCallFrameDetails;
 
 /** @typedef {{
-        sourceID: function():(number),
-        line: function():number,
-        column: function():number,
         contextId: function():number,
         thisObject: !Object,
         evaluate: function(string):*,

src/inspector/java-script-call-frame.cc

@@ -61,18 +61,6 @@ int JavaScriptCallFrame::callV8FunctionReturnInt(const char* name) const {
   return result.As<v8::Int32>()->Value();
 }
 
-int JavaScriptCallFrame::sourceID() const {
-  return callV8FunctionReturnInt("sourceID");
-}
-
-int JavaScriptCallFrame::line() const {
-  return callV8FunctionReturnInt("line");
-}
-
-int JavaScriptCallFrame::column() const {
-  return callV8FunctionReturnInt("column");
-}
-
 int JavaScriptCallFrame::contextId() const {
   return callV8FunctionReturnInt("contextId");
 }

src/inspector/java-script-call-frame.h

@@ -49,9 +49,6 @@ class JavaScriptCallFrame {
   }
   ~JavaScriptCallFrame();
 
-  int sourceID() const;
-  int line() const;
-  int column() const;
   int contextId() const;
 
   bool isAtReturn() const;

src/inspector/v8-debugger.cc

@@ -152,6 +152,7 @@ String16 V8Debugger::setBreakpoint(const ScriptBreakpoint& breakpoint,
                       toV8String(m_isolate, breakpoint.condition))
                 .FromMaybe(false);
   DCHECK(success);
+  USE(success);
 
   v8::Local<v8::Function> setBreakpointFunction = v8::Local<v8::Function>::Cast(
       m_debuggerScript.Get(m_isolate)
@@ -186,6 +187,7 @@ void V8Debugger::removeBreakpoint(const String16& breakpointId) {
                 toV8String(m_isolate, breakpointId))
           .FromMaybe(false);
   DCHECK(success);
+  USE(success);
 
   v8::Local<v8::Function> removeBreakpointFunction =
       v8::Local<v8::Function>::Cast(
@@ -224,6 +226,7 @@ void V8Debugger::setBreakpointsActivated(bool activated) {
                       v8::Boolean::New(m_isolate, activated))
                 .FromMaybe(false);
   DCHECK(success);
+  USE(success);
   v8::Local<v8::Function> setBreakpointsActivated =
       v8::Local<v8::Function>::Cast(
           m_debuggerScript.Get(m_isolate)

src/inspector/wasm-translation.cc

@@ -36,6 +36,7 @@ class WasmTranslation::TranslatorImpl {
   virtual void Init(Isolate*, WasmTranslation*, V8DebuggerAgentImpl*) = 0;
   virtual void Translate(TransLocation*) = 0;
   virtual void TranslateBack(TransLocation*) = 0;
+  virtual ~TranslatorImpl() {}
 
   class RawTranslator;
   class DisassemblingTranslator;
@@ -60,7 +61,7 @@ class WasmTranslation::TranslatorImpl::DisassemblingTranslator
   void Init(Isolate* isolate, WasmTranslation* translation,
             V8DebuggerAgentImpl* agent) override {
     // Register fake scripts for each function in this wasm module/script.
-    Handle<debug::WasmScript> script = script_.Get(isolate);
+    Local<debug::WasmScript> script = script_.Get(isolate);
     int num_functions = script->NumFunctions();
     int num_imported_functions = script->NumImportedFunctions();
     DCHECK_LE(0, num_imported_functions);