1. 18 Aug, 2020 1 commit
  2. 17 Aug, 2020 1 commit
  3. 13 Aug, 2020 1 commit
  4. 10 Aug, 2020 1 commit
  5. 03 Aug, 2020 1 commit
  6. 01 Aug, 2020 1 commit
  7. 30 Jul, 2020 2 commits
  8. 29 Jul, 2020 1 commit
  9. 27 Jul, 2020 2 commits
  10. 24 Jul, 2020 1 commit
  11. 22 Jul, 2020 1 commit
  12. 21 Jul, 2020 2 commits
  13. 20 Jul, 2020 2 commits
  14. 17 Jul, 2020 1 commit
  15. 16 Jul, 2020 1 commit
  16. 14 Jul, 2020 2 commits
  17. 08 Jul, 2020 1 commit
  18. 22 Jun, 2020 1 commit
  19. 17 Jun, 2020 1 commit
  20. 16 Jun, 2020 1 commit
    • Marja Hölttä's avatar
      [bootstrapper] Remove erroneous DCHECK · 30c60f38
      Marja Hölttä authored
      The DCHECK is true in the current V8 / Chrome. However, an embedder
      can create a snapshot where the object in question has dictionary
      properties (by using the object as a prototype). When reading the
      snapshot, in the object already has dictionary properties, and adding a
      property to it won't change it.
      
      The erroneous DCHECK was used to assert that adding a property to an
      object won't turn it to dictionary mode. But now it's in the wrong
      place, since this part of the code is executed after reading the
      snapshot in.
      
      The corresponding DCHECKs which are executed when setting up the objects
      before snapshot creation are still valid.
      
      Fixing the behavior wrt whether the object should turn dictionary
      mode or whether it should turn back is beyond the scope of this CL.
      
      See https://github.com/nodejs/node-v8/issues/160
      
      Bug: v8:10479
      Change-Id: Ie62c80495d4f4494eeb3a16b5bfe02305c0cac95
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2246577Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
      Commit-Queue: Marja Hölttä <marja@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#68357}
      30c60f38
  21. 02 Jun, 2020 1 commit
  22. 28 May, 2020 1 commit
  23. 27 May, 2020 1 commit
  24. 13 May, 2020 2 commits
  25. 12 May, 2020 2 commits
  26. 08 May, 2020 1 commit
  27. 07 May, 2020 1 commit
  28. 06 May, 2020 1 commit
  29. 05 May, 2020 1 commit
  30. 04 May, 2020 1 commit
  31. 30 Apr, 2020 1 commit
  32. 28 Apr, 2020 2 commits
    • Jakob Gruber's avatar
      Reland "[snapshot] Expose the serializer through %SerializeDeserializeNow" · bce121c7
      Jakob Gruber authored
      This is a reland of ad5b005e
      
      Original change's description:
      > [snapshot] Expose the serializer through %SerializeDeserializeNow
      >
      > ... in order to exercise the snapshot/ component from mjsunit tests
      > and fuzzers.
      >
      > * Since the serializer and deserializer can now be called at any time
      > instead of only in a tightly controlled environment, several
      > assumptions (such as an empty execution stack, no microtasks, no
      > handles) no longer hold and had to be made configurable through
      > SerializerFlags.
      >
      > * Root iteration now skips more root categories which were previously
      > guaranteed to be empty (e.g. the stack, microtask queue, handles).
      >
      > * The %SerializeDeserializeNow runtime function triggers
      > serialization, deserialization, and heap verification on the current
      > isolate and native context.
      >
      > Support is not yet complete and will be extended in future work. Once
      > all mjsunit tests successfully run, we can add a new test mode to
      > stress serialization.
      >
      > Bug: v8:10416
      > Change-Id: Ie7ff441a761257dd7f256d0a33e73227850074ac
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2159495
      > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > Reviewed-by: Dan Elphick <delphick@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#67423}
      
      Tbr: delphick@chromium.org,ulan@chromium.org
      Bug: v8:10416
      Change-Id: Ibed04c0f0b72fabcf811d8b18a1479391a11568b
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2170090Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarDan Elphick <delphick@chromium.org>
      Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#67426}
      bce121c7
    • Nico Hartmann's avatar
      Revert "[snapshot] Expose the serializer through %SerializeDeserializeNow" · 451854fa
      Nico Hartmann authored
      This reverts commit ad5b005e.
      
      Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20shared/36070?
      
      Original change's description:
      > [snapshot] Expose the serializer through %SerializeDeserializeNow
      > 
      > ... in order to exercise the snapshot/ component from mjsunit tests
      > and fuzzers.
      > 
      > * Since the serializer and deserializer can now be called at any time
      > instead of only in a tightly controlled environment, several
      > assumptions (such as an empty execution stack, no microtasks, no
      > handles) no longer hold and had to be made configurable through
      > SerializerFlags.
      > 
      > * Root iteration now skips more root categories which were previously
      > guaranteed to be empty (e.g. the stack, microtask queue, handles).
      > 
      > * The %SerializeDeserializeNow runtime function triggers
      > serialization, deserialization, and heap verification on the current
      > isolate and native context.
      > 
      > Support is not yet complete and will be extended in future work. Once
      > all mjsunit tests successfully run, we can add a new test mode to
      > stress serialization.
      > 
      > Bug: v8:10416
      > Change-Id: Ie7ff441a761257dd7f256d0a33e73227850074ac
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2159495
      > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > Reviewed-by: Dan Elphick <delphick@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#67423}
      
      TBR=ulan@chromium.org,jgruber@chromium.org,delphick@chromium.org
      
      Change-Id: Ie30b94c9ec6e4463bed6cc87dd6525f469fdf84a
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:10416
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2170089Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
      Commit-Queue: Nico Hartmann <nicohartmann@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#67424}
      451854fa