Commits · d773d05ba6e4327799ed4b2e48f3e7c589ccfb8d · Linshizhi / V8

12 Jun, 2014 31 commits

MIPS: Fix r21780 - “Fixed flooring division by a power of 2, once again...” · d773d05b

plind44@gmail.com authored Jun 12, 2014

Initialize scratch register for all possible code paths.

TEST=mjsunit/compiler/division-by-constant.js
BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/333713002

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21822 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d773d05b

Make timestamp of fuzz harness archives finer grained. · ed61b85c

mstarzinger@chromium.org authored Jun 12, 2014

R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/329303004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21821 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ed61b85c

For-of calls [Symbol.iterator]() on RHS to get iterator · dfb1c7dc

wingo@igalia.com authored Jun 12, 2014

R=rossberg@chromium.org
BUG=http://code.google.com/p/v8/issues/detail?id=2735
LOG=N

Review URL: https://codereview.chromium.org/332663004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21820 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

dfb1c7dc

Drop dependency on Isolate* from platform.h · 52640018

jochen@chromium.org authored Jun 12, 2014

BUG=none
R=dcarney@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/328993003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21819 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

52640018

Remove forced type changes when they can't deopt · 649057e0

m.m.capewell@googlemail.com authored Jun 12, 2014

Hydrogen attempts to force representation changes on certain operations in order
to deoptimise on the change rather than the operation. However, these forced
changes are often unnecessary on 64-bit platforms, and cause poor code
generation, so this patch makes some of them conditional on whether it's
possible for deoptimisation to occur in the change.

On ARM64, this prevents sequences like:
                  ;;; <@46,#89> smi-tag
0x7ff282c7f050   144  lsl x4, x4, #32
                  ;;; <@48,#90> smi-untag
0x7ff282c7f054   148  asr x5, x4, #32
                  ;;; <@50,#31> mul-const-i-s
0x7ff282c7f058   152  lsl w6, w5, #3

BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/303263010

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21818 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

649057e0

Optimize prototype chain when creating initial maps for functions used as constructors · 301ae7dd

jkummerow@chromium.org authored Jun 12, 2014

Review URL: https://codereview.chromium.org/332783002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21817 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

301ae7dd

Add non-miss slow path to LoadIC_Normal. · 918efd7e

jkummerow@chromium.org authored Jun 12, 2014

This avoids endless IC patching cycles between "normal" and "nonexistent" handlers when objects having and not having the property are seen alternatingly

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/328353002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21816 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

918efd7e

MIPS: Fix unsigned comparison. · 5c96e2cf

plind44@gmail.com authored Jun 12, 2014

TEST=mjsunit/regress/regress-3380
BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/329223006

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21815 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5c96e2cf

Rewrite GetPropertyAttribute to use the LookupIterator · fd80653a

verwaest@chromium.org authored Jun 12, 2014

BUG=
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/321543004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21814 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fd80653a

X87: Reland 21774: Generate KeyedLoadGeneric with Hydrogen · 6a8d820f

weiliang.lin@intel.com authored Jun 12, 2014

Port r21781 (4869c528)

BUG=
R=danno@chromium.org

Review URL: https://codereview.chromium.org/336543002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21813 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6a8d820f

Revert "Active use of Hydrogen-generated generic KeyedLoad IC" · 7e67361e

danno@chromium.org authored Jun 12, 2014

Due to mirror-object test failure (although I'm pretty sure I was framed)

R=mstarzinger@chromium.org
TBR=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/328333002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21812 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7e67361e

Active use of Hydrogen-generated generic KeyedLoad IC · dc0236cf

danno@chromium.org authored Jun 12, 2014

R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/330023002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21811 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

dc0236cf

Don't use LOG() from platform. · 79a9eaf9

jochen@chromium.org authored Jun 12, 2014

All places that use OS::Allocate either CHECK() that the result is non-NULL,
or use a reasonable fallback if they can't mmap memory.

BUG=none
R=mstarzinger@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/326323002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21810 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

79a9eaf9

build fix after r21807 · 0ffe8b10

dcarney@chromium.org authored Jun 12, 2014

TBR=mstarzinger@chromium.org

BUG=

Review URL: https://codereview.chromium.org/333503005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21809 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0ffe8b10

Grow big old generation slower. · 9f80d076

hpayer@chromium.org authored Jun 12, 2014

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/324403008

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21808 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9f80d076

remove this == null · 99d9abaf

dcarney@chromium.org authored Jun 12, 2014

R=danno@chromium.org

BUG=chromium:381910

Review URL: https://codereview.chromium.org/336483002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21807 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

99d9abaf

Sign extend the dehoisted key at the definition point for x64 port only; for... · 4d4485e4

haitao.feng@intel.com authored Jun 12, 2014

Sign extend the dehoisted key at the definition point for x64 port only; for x32 port, we need to sign extend the dehoisted key at the use points.

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/328553005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21806 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4d4485e4

Add v8::Promise::Then. · d757f378

rossberg@chromium.org authored Jun 12, 2014

Blink needs v8::Promise::Then to implement ScriptPromise::then.
Blink-side CL: https://codereview.chromium.org/316453002

BUG=371288
LOG=Y
R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/314553002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21805 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d757f378

Do away with variable length memcpy to Set/Get registers in simulator · 3419aefe

svenpanne@chromium.org authored Jun 12, 2014

About a 32% boost.

Before - 5:31

Richards: 84.5
DeltaBlue: 128
Crypto: 65.3
RayTrace: 203
EarleyBoyer: 149
RegExp: 23.4
Splay: 121
NavierStokes: 98.9
----
Score (version 7): 93.8

After - 4:10

Richards: 107
DeltaBlue: 175
Crypto: 93.9
RayTrace: 258
EarleyBoyer: 186
RegExp: 32.7
Splay: 165
NavierStokes: 124
----
Score (version 7): 124

R=jacob.bramley@arm.com, svenpanne@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=21448

Review URL: https://codereview.chromium.org/213943002

Patch from Fritz Koenig <frkoenig@google.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21804 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3419aefe

Revert "Revert "Reland 21774: Generate KeyedLoadGeneric with Hydrogen"" · 634cb5e8

danno@chromium.org authored Jun 12, 2014

This CL tickled an unrelated arm64 bug which was is fixed separately.

The MIPS port (originally landed 21784) is also included.

TBR=verwaest@chromium.org

Review URL: https://codereview.chromium.org/331633002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21803 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

634cb5e8

Remove duplicate code in SetPropertyPostInterceptor · 9fa48abd

verwaest@chromium.org authored Jun 12, 2014

BUG=
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/314673002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21802 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9fa48abd

Revert "Rename kIs64BitArch with kRequiresCodeRange." · 546b3e55

danno@chromium.org authored Jun 12, 2014

TBR=haitao.feng@intel.com

Review URL: https://codereview.chromium.org/325343003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21801 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

546b3e55

Rename kIs64BitArch with kRequiresCodeRange. · 1562d8e3

haitao.feng@intel.com authored Jun 12, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/335473003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21800 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1562d8e3

Remove unnecessary HCompareNumericAndBranch when generating HShr instruction. · 4891950b

haitao.feng@intel.com authored Jun 12, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/334573003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21799 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4891950b

Fix register mixup in arm64's Crankshafted typeof() == 'object' · 87323779

danno@chromium.org authored Jun 12, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/330593003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21798 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

87323779

Add @@iterator for generator objects · 8e165acb

wingo@igalia.com authored Jun 12, 2014

R=arv@chromium.org, rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/328093002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21797 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8e165acb

Revert "MIPS: Reland 21774: Generate KeyedLoadGeneric with Hydrogen" · 07f6d619

machenbach@chromium.org authored Jun 12, 2014

This reverts commit r21784 as the original CL also got reverted.

BUG=
TBR=danno@chromium.org

Review URL: https://codereview.chromium.org/329973002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21794 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

07f6d619

filter cross context eval · 44b0e211

dcarney@chromium.org authored Jun 12, 2014

R=verwaest@chromium.org

BUG=

Review URL: https://codereview.chromium.org/294073002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21793 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

44b0e211

Revert "Reland 21774: Generate KeyedLoadGeneric with Hydrogen" · c17e7929

danno@chromium.org authored Jun 12, 2014

Due to lingering arm64 failures in Test262

TBR=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/332663003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21790 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c17e7929

Fix detection of VFP3D16 on Galaxy Tab 10.1. · 0d11cb3e

bmeurer@chromium.org authored Jun 12, 2014

BUG=v8:3387
LOG=y
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/329963002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21789 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0d11cb3e

Drop unused v8threads include from platform files · 8eacf4e7

jochen@chromium.org authored Jun 12, 2014

BUG=none
R=marja@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/323303002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21788 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8eacf4e7

11 Jun, 2014 9 commits

X87: add OWNERS file · 3c4a6d1b

weiliang.lin@intel.com authored Jun 11, 2014

BUG=
R=danno@chromium.org

Review URL: https://codereview.chromium.org/323413002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21785 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3c4a6d1b

MIPS: Reland 21774: Generate KeyedLoadGeneric with Hydrogen · 6b318947

palfia@homejinni.com authored Jun 11, 2014

Port r21781 (4869c528)

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/327373002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21784 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6b318947

Whitespace change to trigger bots. · 6803022a

machenbach@chromium.org authored Jun 11, 2014

BUG=
TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/330573002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21783 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6803022a

Whitespace change to trigger bots. · b4226acc

machenbach@chromium.org authored Jun 11, 2014

BUG=
TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/330563002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21782 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b4226acc

Reland 21774: Generate KeyedLoadGeneric with Hydrogen · 905d777d

danno@chromium.org authored Jun 11, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/57123002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21781 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

905d777d

MIPS: Fixed flooring division by a power of 2, once again... · b0b10ec7

plind44@gmail.com authored Jun 11, 2014

Port r21769 (52e191b)

Original commit message:
Avoid right shifts by zero bits: On ARM it actually means shifting by
32 bits (correctness issue) and on other platforms they are useless
(performance issue). This is fix for the fix in r20544.

BUG=v8:3259
LOG=y
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/322403006

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21780 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b0b10ec7

Drop globals.h include from platform.h · 4e336430

jochen@chromium.org authored Jun 11, 2014

Also delete dead cpu-features-implied-by-platform code.

BUG=none
R=jkummerow@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/326333002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21779 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4e336430

verwaest@chromium.org authored Jun 11, 2014

BUG=
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/324383005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21778 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7bbe963a

MIPS: Revert 21774: "Generate KeyedLoadGeneric with Hydrogen" · ea9c67d6

plind44@gmail.com authored Jun 11, 2014

Port r21776 (10a4872)

Original commit message:
Due to arm64 and GCMole failures

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/329723007

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21777 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ea9c67d6