- 12 May, 2020 25 commits
-
-
Milad Farazmand authored
Port b931af5d R=thibaudm@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Idb61dd337187a8afd4e3b8705b80dab98eb11fa5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2195796Reviewed-by: Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#67749}
-
Tobias Tebbi authored
Bug: v8:7793 Change-Id: Id2a93f8ac8c512dbc5cdeb43a97e04d8d6684954 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2196130 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#67748}
-
Jakob Kummerow authored
in wasm-compiler.cc. Bug: v8:10506 Change-Id: I056344d64a58a53db46540f958dc4256243e0547 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2196342 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#67747}
-
Mike Stanton authored
ScriptContextTableRef::lookup() isn't called. BUG=v8:7790 Change-Id: I8a89de2dff7b7e4ef7b37f54a0bd0fcae27d1a1d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2196183 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#67746}
-
Jakob Kummerow authored
Bug: v8:7748 Change-Id: I736aaebb08be1d43662058f0ffde8b877b025017 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2193852Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#67745}
-
Omer Katz authored
This CL adds 2 new values to the EmbedderStackState enum with more explicit names. The old values are updated as aliases to the new values and marked as soon to be deprecated. This CL also moves the enum to v8-platform.h so that it can be reused by cppgc. Depracating individual values in an enum is supported by GCC only since version 6. Thus new macros were needed for the deprecation (which delegate to the existing macros when supported). GCC versions older than 6 are still used by the CQ bots. Bug: chromium:1056170 Change-Id: Id1ea73edfbbae282b0d8a3bb103dbbbf8ebd417e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2188971 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#67744}
-
Leszek Swirski authored
This reverts commit 6fba287c. Reason for revert: Not the cause. Original change's description: > Revert "[heap] Refactor Heap::PerformGarbageCollection" > > This reverts commit d0dbee47. > > Reason for revert: Breaks MSVC bot (https://cr-buildbucket.appspot.com/build/8880517266974148704) > > Original change's description: > > [heap] Refactor Heap::PerformGarbageCollection > > > > This ensures that PerformGarbageCollection runs completely within a > > LocalHeap safepoint. External prologues and epilogues that may trigger > > GC and run JS are moved outside. > > > > Bug: v8:10315 > > > > Change-Id: I5c0081f0791ba5d27152c119a2a0d454056656d3 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190756 > > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#67736} > > TBR=ulan@chromium.org,mlippautz@chromium.org,dinfuehr@chromium.org > > Change-Id: I62e62d3f4cd50a3e8f0037902f158baef68cb3b1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: v8:10315 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2195823 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67739} TBR=ulan@chromium.org,mlippautz@chromium.org,leszeks@chromium.org,dinfuehr@chromium.org Bug: v8:10315 Change-Id: I8b9046c51fd43ca48066250085f589f6aa81d5f5 # Reland without changes. No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I8b9046c51fd43ca48066250085f589f6aa81d5f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2196301 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#67743}
-
Leszek Swirski authored
This reverts commit 3df36990. Reason for revert: Breaks MSVC bot (https://cr-buildbucket.appspot.com/build/8880517266974148704) Original change's description: > cppgc: Port ObjectStartBitmap > > This ports ObjectStartBitmap from Blink. > > Bug: chromium:1056170 > Change-Id: Ib959d9ac1c5e1e34ffa6418f77956e993c570ffc > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2181331 > Commit-Queue: Anton Bikineev <bikineev@chromium.org> > Reviewed-by: Omer Katz <omerkatz@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67735} TBR=ulan@chromium.org,mlippautz@chromium.org,bikineev@chromium.org,omerkatz@chromium.org Change-Id: Iaea15b11c0ee7b599fe1f275aded7414bce428ac No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2196321Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#67742}
-
Dominik Inführ authored
This is a reland of 7f29c48e After fixing TSAN failures in https://crrev.com/c/2192661 and https://crrev.com/c/2193712, this CL and be relanded without changes. Original change's description: > [heap] Remove sweeping state in incremental marking > > Remove the SWEEPING state from incremental marking. Sweeping is now > always completed when starting incremental marking. Before this change > there needed to be a safepoint each for starting marking and completing > sweeping. Now both happens within a single safepoint. > > Bug: v8:10315 > Change-Id: Iad2835554865f2de24376372affe9a98992d1fa0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190419 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67678} Bug: v8:10315 Change-Id: Ic949d125e72c4d17fd427d08d4b6f9056721eee9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2196182Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#67741}
-
Thibaud Michaud authored
Multi-value "if" works out of the box in Liftoff. R=ahaas@chromium.org Bug: v8:10408 Change-Id: Ia3666ccd4faaa32f373020a3335a0304823f8881 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2196123Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#67740}
-
Leszek Swirski authored
This reverts commit d0dbee47. Reason for revert: Breaks MSVC bot (https://cr-buildbucket.appspot.com/build/8880517266974148704) Original change's description: > [heap] Refactor Heap::PerformGarbageCollection > > This ensures that PerformGarbageCollection runs completely within a > LocalHeap safepoint. External prologues and epilogues that may trigger > GC and run JS are moved outside. > > Bug: v8:10315 > > Change-Id: I5c0081f0791ba5d27152c119a2a0d454056656d3 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190756 > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67736} TBR=ulan@chromium.org,mlippautz@chromium.org,dinfuehr@chromium.org Change-Id: I62e62d3f4cd50a3e8f0037902f158baef68cb3b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10315 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2195823Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#67739}
-
Georg Neis authored
A prototype map can't be deprecated. Bug: v8:7790 Change-Id: I26ef4d9648985417212dcf4df0d47568861e9bc2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2196124 Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#67738}
-
Jakob Gruber authored
We don't yet support serialization of optimized code, so whenever the serializer encounters an 'unexpected' Code object, it aborts. Snapshot::ClearReconstructableDataForSerialization does not clear weak links created through compilation dependencies. These links make Code objects reachable even though recompilable data has been cleared from JSFunctions/SFIs/JSRegExps. Forcing a full deopt of the entire isolate is the simple of way of solving this until serialization support for optimized code has been implemented. Bug: v8:10416,v8:10500,v8:10518 Change-Id: Ie1386cc9fa983b435825afa15441df38409bff98 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2196122 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67737}
-
Ulan Degenbaev authored
This ensures that PerformGarbageCollection runs completely within a LocalHeap safepoint. External prologues and epilogues that may trigger GC and run JS are moved outside. Bug: v8:10315 Change-Id: I5c0081f0791ba5d27152c119a2a0d454056656d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190756 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#67736}
-
Anton Bikineev authored
This ports ObjectStartBitmap from Blink. Bug: chromium:1056170 Change-Id: Ib959d9ac1c5e1e34ffa6418f77956e993c570ffc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2181331 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#67735}
-
Thibaud Michaud authored
R=clemensb@chromium.org,ahaas@chromium.org Bug: v8:10408 Change-Id: I436416e32d814b08543aa2dffbcf8464ec75923f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190423 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67734}
-
Jakob Gruber authored
Prior to this CL we still implemented a HasProperty-GetProperty sequence when accessing named captures in GetSubstitution. This was briefly part of the spec (we also threw an exception when the property was not present), but since late 2017 the GetProperty call has been unconditional. See https://tc39.es/ecma262/#sec-getsubstitution. Bug: v8:10513 Change-Id: Id82c06958b0b0feffc6eede580b99ab8676a0dae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2195821 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#67733}
-
Marja Hölttä authored
There's no need for them to be in NativeContext. This CL moves the rest of the Promise-related SFIs. Bug: v8:10482 Change-Id: I7eb926be14bf44fb3cd01cb96b4769eff1c2911b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190752 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#67732}
-
Georg Neis authored
R=dinfuehr@chromium.org Bug: v8:10315 Change-Id: I595bc76907c9f0f437d460916aec804b55895376 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2195822Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#67731}
-
Pan, Tao authored
Add inlined bytecode size to candidate print, both bytecode size and inlined bytecode size decide whether candidate to be inlined. Change-Id: I6d659bb59819b0e9daad5289f47f329aa3ce9f7e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2191631Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#67730}
-
Ulan Degenbaev authored
Change-Id: I3d5d856d86deb283173c7b6f0f302e3c4e4b67fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190755 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#67729}
-
Dominik Inführ authored
Map::bit_field needs to be set with relaxed store. The concurrent marker accesses the has_prototype_slot bit in Map::bit_field to calculate header size. Bug: v8:10315 Change-Id: Ie7ebb9316b8c703adfddf10df25949b872ce0c8d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2194012Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#67728}
-
Ulan Degenbaev authored
This changes "v8[.gc],devtools.timeline" to "devtools.timeline,v8[.gc" in some of the GC trace events because perfetto requires all categories to be predefined. Change-Id: I0e9a91c826f4e620f4946a1a96713aa2b45da26f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2193591 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#67727}
-
Milad Farazmand authored
As discussed under https://crrev.com/c/1981505, Test requires an executable CODE_SPACE and is thus incompatible with jitless mode. Change-Id: Icddad50a3484f0cfc5fb4abd7175058d50bc06d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2193911Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#67726}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/10edae4..1b904cc Rolling v8/third_party/aemu-linux-x64: fPXztkM0sEne8uTSiAXBgjYK_46aVSqohP1kVE4u-u8C..5LzaFiFYMxwWXcgus5JjF74yr90M5oz9IMo29pTdoLgC Rolling v8/third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/2244b5e..716366f Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/4ca83c7..e9a8d37 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/aaf5669..454f4ba Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/e3f0319..a09ea70 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ic8d837b9b9d623b938e085045f35a0c558bb9794 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2195125Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#67725}
-
- 11 May, 2020 15 commits
-
-
Shu-yu Guo authored
Bug: v8:10516 Change-Id: I0a75b32ca4b90dc5a6c2f2f3ec66b183dc3ff99e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2191411 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#67724}
-
Ng Zhi An authored
Making them private was a way to hide the constructor, we can explicitly delete them, which give a better compilation error message as well. Also see: https://stackoverflow.com/q/55205874 Bug: v8:10488 Change-Id: Ic08acf0f9eb16bd2e90c3a707036befe7c9d193c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2191866Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67723}
-
Ng Zhi An authored
See https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-equals-default.html and https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html. Also see https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++-dos-and-donts.md#prefer-to-use. Bug: v8:10488 Change-Id: Id377cab4db7ff211e800b2078ab91c3deb9a1b21 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2191350Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67722}
-
Ng Zhi An authored
Same implementation as the one for x64 in https://crrev.com/c/2186630. Bug: v8:10501 Change-Id: If2b6c0fdc649afba3449d9579452cf7047a55a54 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2188556Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67721}
-
Shu-yu Guo authored
This reverts commit 902f48bd. Reason for revert: Made TSAN unhappy: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20isolates/9480 Original change's description: > [wasm][debug] Fix tier down for multiple isolates > > If multiple isolates are using the same module, we need to keep it > tiered down as long as any isolate still has a debugger open. > Also, we cannot short-cut the {NativeModule::TierDown} method, since the > previously triggered tier down might not have finished yet. > For now, each isolate starts an independent tier down (i.e. a full > recompilation). We could optimize this later by skipping functions that > are already tiered down, or are already scheduled for tier down, but we > still need to wait for tier-down to finish on each isolate. > > R=thibaudm@chromium.org > > Bug: v8:10359 > Change-Id: I7ea6a6f5d3977e48718ac5bc94f9831541f6173f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190758 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67716} TBR=clemensb@chromium.org,thibaudm@chromium.org Change-Id: Ibf650e8b6143471b44f2822c1737e7de5f8bdb20 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10359 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2194372Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#67720}
-
Seth Brenith authored
This CL is pretty mechanical; I just iterated through some Torque classes making the following changes: - Use @generateCppClass if it seems easy to - Use @generatePrint if the existing printer doesn't do anything special - Fix up any imprecise field types It also includes two minor changes to implementation-visitor: - Add a new -inl.h file with the things needed for torque-generated/class-definitions-tq.cc so we don't need to keep changing the compiler when we add @generateCppClass. - Avoid emitting incorrect accessors for ExternalPointers. This isn't strictly necessary for correctness, as the accessors defined in C++ already hide the ones inherited from generated code, but it makes me feel safer. Change-Id: I4d5a8ba6f86ebff57a0d147619212a3993b087c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2185824Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#67719}
-
Ng Zhi An authored
See https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html for more on this warning. Bug: v8:10488 Change-Id: Ifa9443609fa30fa2d8f9fb9ed00ce9353fa9aa49 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2189910Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67718}
-
Igor Sheludko authored
... when the element is read-only in one of the prototypes: * the length should not be updated, * in strict mode the store operation should throw TypeError. Bug: chromium:1055138 Change-Id: I7fc08e22c83f8a9848053cfe20851dc1b82f0e3d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2172090 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#67717}
-
Clemens Backes authored
If multiple isolates are using the same module, we need to keep it tiered down as long as any isolate still has a debugger open. Also, we cannot short-cut the {NativeModule::TierDown} method, since the previously triggered tier down might not have finished yet. For now, each isolate starts an independent tier down (i.e. a full recompilation). We could optimize this later by skipping functions that are already tiered down, or are already scheduled for tier down, but we still need to wait for tier-down to finish on each isolate. R=thibaudm@chromium.org Bug: v8:10359 Change-Id: I7ea6a6f5d3977e48718ac5bc94f9831541f6173f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190758 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#67716}
-
Santiago Aboy Solanes authored
If a node is reduced in-place (i.e not replaced by another node) we check its inputs, and if we Recurse on at least one input we return early. If this happens, we weren't revisiting its uses. This CL changes this since we could have been missing revisiting of some uses. Change-Id: I7683a0747cec38484a047c6032980b5676b2d886 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2174505 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#67715}
-
Jakob Kummerow authored
With bounds checks, null checks, and a test case. Bug: v8:7748 Change-Id: I9e7d68ecd883bd0279f22d11c1dc73cc8716a4cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2192659 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#67714}
-
Michael Lippautz authored
Bug: chromium:1056170 Change-Id: I99d073e268f5779f0985d6197432c50036060b60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2192663 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Anton Bikineev <bikineev@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#67713}
-
Manos Koukoutos authored
Add br_on_null opcode, encoding, decoding, and elementary tests. Bug: v8:7748 Change-Id: Id771ea7f57694e1c1bffc83c4232132bf9ad9dbd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190424 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#67712}
-
Santiago Aboy Solanes authored
It will now return true for 32-bit constants as well. When enabling this, two errors popped up: one in dissassembler where we might have null hosts, and one in remembered set where we should be compressing the address before storing. As a drive-by: make ppc use full objects until their pointer compression implementation is fully done. Bug: v8:7703 Change-Id: I70f05f952d4e1305fe1fe030755f01f74ea5e5dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187622Reviewed-by: Junliang Yan <jyan@ca.ibm.com> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#67711}
-
Dominik Inführ authored
Need to use relaxed store for initializing bit_field. The concurrent marker accesses the has_prototype_slot bit in Map::bit_field to calculate header size. Bug: v8:10315 Change-Id: I1eebd4a6f42b9263de7e424957b32884f7b910ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2193712 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#67710}
-