• Leszek Swirski's avatar
    Reland "[heap] Refactor Heap::PerformGarbageCollection" · 040e8324
    Leszek Swirski authored
    This reverts commit 6fba287c.
    
    Reason for revert: Not the cause.
    
    Original change's description:
    > Revert "[heap] Refactor Heap::PerformGarbageCollection"
    >
    > This reverts commit d0dbee47.
    >
    > Reason for revert: Breaks MSVC bot (https://cr-buildbucket.appspot.com/build/8880517266974148704)
    >
    > Original change's description:
    > > [heap] Refactor Heap::PerformGarbageCollection
    > >
    > > This ensures that PerformGarbageCollection runs completely within a
    > > LocalHeap safepoint. External prologues and epilogues that may trigger
    > > GC and run JS are moved outside.
    > >
    > > Bug: v8:10315
    > >
    > > Change-Id: I5c0081f0791ba5d27152c119a2a0d454056656d3
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190756
    > > Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
    > > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
    > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#67736}
    >
    > TBR=ulan@chromium.org,mlippautz@chromium.org,dinfuehr@chromium.org
    >
    > Change-Id: I62e62d3f4cd50a3e8f0037902f158baef68cb3b1
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: v8:10315
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2195823
    > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#67739}
    
    TBR=ulan@chromium.org,mlippautz@chromium.org,leszeks@chromium.org,dinfuehr@chromium.org
    
    Bug: v8:10315
    Change-Id: I8b9046c51fd43ca48066250085f589f6aa81d5f5
    
    # Reland without changes.
    
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Change-Id: I8b9046c51fd43ca48066250085f589f6aa81d5f5
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2196301
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67743}
    040e8324
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...