- 22 Jul, 2020 17 commits
-
-
Georg Neis authored
Make ArrayBuiltinsAssembler::GenerateConstructor use the JSArray::kInitialMaxFastElementArray constant instead of trying to manually compute it and end up with a different result depending on the build. This brings the code in sync with CodeStubAssembler::CreateArray and with Turbofan's JSCallReducer. Change-Id: I7fcc955166484a91f8982b359b94d9a586fdb50a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2312780 Commit-Queue: Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#68995}
-
Richard Stotz authored
The design of this change was discussed here: https://docs.google.com/document/d/12otOj6SyXMXj0Dnnx9B6MGLMRwHPhg6RIZRazVw3tFA/ Bug: v8:10720 Change-Id: I8292dcf7272bdf4526a2d630b49fc374cdb01bdc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2304570 Commit-Queue: Richard Stotz <rstz@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#68994}
-
Milad Farazmand authored
Change-Id: I7989934f7f8a1332045a6ed708b02fbc3424c829 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2310911Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#68993}
-
Maya Lekova authored
This reverts commit d8f8a7e2. Reason for revert: Breaks code_serializer variant - https://cr-buildbucket.appspot.com/build/8874070652992164976 Original change's description: > Reland "[flags] warn about contradictory flags" > > This is a reland of b8f91666 > Difference to previous CL: Additional functionality to specify > incompatible flags based on GN variables and extra-flags, used > to fix the issues that came up on the waterfall. > > This also changes the rules regarding repeated flags: While > explicitly repeated flags are allowed for boolean values as long > as they are identical, repeated flags or explicit flags in the > presence of an active implication are disallowed for non-boolean > flags. The latter simplifies specifying conflict rules in > variants.py. Otherwise a rule like > > INCOMPATIBLE_FLAGS_PER_EXTRA_FLAG = { > "--gc-interval=*": ["--gc-interval=*"], > } > > wouldn't work because specifying the same GC interval twice > wouldn't actually count as a conflict. This was an issue with > test/mjsunit/wasm/gc-buffer.js, which specifies > --gc-interval=500 exactly like the extra flag by the stress bot. > > Also, this now expands contradictory flags checking to d8 flags > for consistency. > > Original change's description: > > [flags] warn about contradictory flags > > > > Design Doc: https://docs.google.com/document/d/1lkvu8crkK7Ei39qjkPCFijpNyxWXsOktG9GB-7K34jM/ > > > > Bug: v8:10577 > > Change-Id: Ib9cfdffa401c48c895bf31caed5ee03545beddab > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2154792 > > Reviewed-by: Clemens Backes <clemensb@chromium.org> > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Reviewed-by: Georg Neis <neis@chromium.org> > > Reviewed-by: Tamer Tas <tmrts@chromium.org> > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#68168} > > Bug: v8:10577 > Change-Id: I268e590ee18a535b13dee14eeb15ddd0a9ee8341 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235115 > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68989} TBR=machenbach@chromium.org,neis@chromium.org,clemensb@chromium.org,tebbi@chromium.org,tmrts@chromium.org Change-Id: I7969065b0edbc463a94e530485bc2ab623d77b62 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10577 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2312782Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#68992}
-
Maya Lekova authored
The object is passed now as an v8::ApiObject instead of unwrapped C++ pointer and the embedder should do the unwrapping. Bug: chromium:1052746 Change-Id: If5671c5fdbbe8d58435c7bd9aceccf5e17f8ea21 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2304571Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:10693 Change-Id: I2ffc99bfb9e96afd740fc1a095ccca61b7c5ce19 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2289970 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68990}
-
Tobias Tebbi authored
This is a reland of b8f91666 Difference to previous CL: Additional functionality to specify incompatible flags based on GN variables and extra-flags, used to fix the issues that came up on the waterfall. This also changes the rules regarding repeated flags: While explicitly repeated flags are allowed for boolean values as long as they are identical, repeated flags or explicit flags in the presence of an active implication are disallowed for non-boolean flags. The latter simplifies specifying conflict rules in variants.py. Otherwise a rule like INCOMPATIBLE_FLAGS_PER_EXTRA_FLAG = { "--gc-interval=*": ["--gc-interval=*"], } wouldn't work because specifying the same GC interval twice wouldn't actually count as a conflict. This was an issue with test/mjsunit/wasm/gc-buffer.js, which specifies --gc-interval=500 exactly like the extra flag by the stress bot. Also, this now expands contradictory flags checking to d8 flags for consistency. Original change's description: > [flags] warn about contradictory flags > > Design Doc: https://docs.google.com/document/d/1lkvu8crkK7Ei39qjkPCFijpNyxWXsOktG9GB-7K34jM/ > > Bug: v8:10577 > Change-Id: Ib9cfdffa401c48c895bf31caed5ee03545beddab > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2154792 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68168} Bug: v8:10577 Change-Id: I268e590ee18a535b13dee14eeb15ddd0a9ee8341 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235115 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Reviewed-by:
-
Maya Lekova authored
This reverts commit 6af09b1b. Reason for revert: Breaks Win debug builder - https://ci.chromium.org/p/v8/builders/ci/V8%20Win32%20-%20debug/26384? Original change's description: > [offthread] Add a write lock to the string table > > Adds an initial implementation of a concurrency support for the string > table, allowing it to be read without holding a lock, and written to > while holding a lock. > > This is an initial prototype of _roughly_ how the concurrency would > work; there are still a few holes (e.g. around deserialization). This > is predominantly to assess the main-thread runtime impact of the more > complex string table access. > > Bug: v8:10729 > Change-Id: I5c6c35e6fca309efd6ee79804c16972aae1ab3ab > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2306804 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68985} TBR=ulan@chromium.org,leszeks@chromium.org,ishell@chromium.org,verwaest@chromium.org Change-Id: I001dc81f1d4031bf0451766452a43176df997354 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10729 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2312776Reviewed-by:
-
Victor Gomes authored
Change-Id: Ic973a3f7eb5a73635f32386fffc9f23c1e147256 Bug: chromium:1107879 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2310364 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/master@{#68987}
-
Jakob Gruber authored
Bug: v8:8888 Change-Id: I953284f9d9c68b5691f7ae7a9665d867bcdff8d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2312098 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#68986}
-
Leszek Swirski authored
Adds an initial implementation of a concurrency support for the string table, allowing it to be read without holding a lock, and written to while holding a lock. This is an initial prototype of _roughly_ how the concurrency would work; there are still a few holes (e.g. around deserialization). This is predominantly to assess the main-thread runtime impact of the more complex string table access. Bug: v8:10729 Change-Id: I5c6c35e6fca309efd6ee79804c16972aae1ab3ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2306804Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#68985}
-
Toan Pham authored
Some platforms disable reading of bytes in the .text section, so move the metadata into a separate .rodata section. Bug: v8:10707 Change-Id: I30ef7a180f489f175c31f9d4dcd02115c9f516c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2301113 Commit-Queue: Toan Pham <toanpham@google.com> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#68984}
-
Jakob Gruber authored
This CL introduces a new pipeline mode in which each optimization triggers both a Turbofan and an NCI compilation job. The TF code is installed, the NCI code is inserted into the code cache for future consumption by other contexts. --turbo-nci enables this mode. The old configuration (with NCI replacing TF) is still available under the --turbo-nci-as-highest-tier flag. This flag remains useful for testing purposes. Drive-by: Refactor tracing in compiler.cc. Bug: v8:8888 Change-Id: I62522e61788762250ff717eef84eae914e266f3b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2299360 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#68983}
-
Santiago Aboy Solanes authored
We want to use LoadObjectField's version that it is templated (as the non-templated one uses Node*). If we remove slopiness, we are forcing to TNodify when porting the non-templated calls to the templated ones. Bug: v8:9708, v8:6949 Change-Id: Ic564e3f03f1900718a0ec5503da911650bbac1fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2310353Reviewed-by:
-
Nico Hartmann authored
Add synchronized accessors for ScriptContextTable on NativeContext. Add corresponding cctest. Bug: v8:7790 Change-Id: If390f3d4a72441a8b4323e9413d7627cd15514c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2299372 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#68981}
-
Santiago Aboy Solanes authored
If we insert a second SIMPLE_PROPERTY_ARRAY we move from kWeakRef encoding to kFullTransitionArray encoding. As always, we are searching in the meantime in a background thread. Bug: v8:7790 Change-Id: I5e3d85657dda4c199e50b9c35e7f617f1821a8f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2243218Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#68980}
-
Nico Hartmann authored
This CL makes the ScriptContextTable concurrently accessible from the background thread (in particular ScriptContextTable::get_context). A cctest is added to check synchronization with tsan. Bug: v8:7790 Change-Id: I2e2dc8c6a7cfa369787959c4d5ed5f357f4720fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2260567Reviewed-by:
-
- 21 Jul, 2020 23 commits
-
-
Ng Zhi An authored
The load splat, load extend, load zero macros are essentially the same, consolidate them into a single macro. Change-Id: Ic812043b37524deb3a9e6ddc223bb95ae77e1d4d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2304715 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#68978}
-
Milad Farazmand authored
Change-Id: I818534bc2fedd127689bf82f2cdd3a4f2f8c31e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2310574Reviewed-by:
-
Frank Tang authored
Per change in https://github.com/tc39/ecma402/pull/459/ Bug: v8:10732 Change-Id: I2ef21e8b450cbf9c61f987c61f3ba7d6959db81a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2309149Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#68976}
-
Ng Zhi An authored
v128.const (kExprS128) is the only constant expression supported (similar to the other value types). Bug: v8:10731 Change-Id: I9b11b47a851903dfd79d3590eff67b615057f81c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2308389 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Bug: chromium:1107901 Change-Id: Ieacea3dd60e80143a0cbeebf4ab5f91d3888e1a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2310351 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Prototype in TurboFan x64 and interpreter, bailout in Liftoff. Suggested in https://github.com/WebAssembly/simd/pull/237. Bug: v8:10713 Change-Id: I5346c351fb2ec5240b74013e62aef07c46d5d9b6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2300924Reviewed-by:
-
Igor Sheludko authored
... behind --trace-zone-type-stats flag. Per-object-type statistics requires the following GN args: v8_enable_precise_zone_stats = true use_rtti = true When precise zone stats is enabled, the used zone memory value is calculated more precisely, in particular it takes into account the state of the active segment. By default, the used memory in the active segment is not taken into account because of performance overhead. Bug: v8:10572 Change-Id: I938d9e264cfe6a8b63a89db87d187d8e2be63c8b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2281006 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#68972}
-
Arnaud Robin authored
On desktop systems, we use a very basic tiering strategy: Everything is initially compiled with Liftoff, and once that is done, the module can start being used. Concurrently to the execution, we re-compile all code with TurboFan, and hot-swap each function once TurboFan finishes. We should start using a more dynamic strategy where each function is tiered-up when judged necessary. This change will then tier-up each liftoff function once it has been called 5 times. I then added a counter in the native module, that is updated directly from Liftoff code, and a runtime call is then made when the counter reaches the goal. R=clemensb@chromium.org CC=thibaudm@chromium.org Bug: v8:10728 Change-Id: I8dc2b02fdff8d97781bb1cf496886594b3d7f644 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2306803 Commit-Queue: Arnaud Robin <arobin@google.com> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Michael Lippautz authored
V8 already depends on cppgc_base which means that unittests does not need to depend on cppgc_for_testing any longer. Move the cppgc_for_testing dependency to the stand-alone cppgc_unittests binary Bug: v8:10674 Change-Id: I07bfe30901eb1683d2e0ee0189f73b5244884f27 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2310249 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#68970}
-
Georg Neis authored
This reverts commit f44900d2. Reason for revert: caused performance regressions on Nexus 7!? https://bugs.chromium.org/p/chromium/issues/detail?id=1105420 Original change's description: > [turbofan] Prettify a condition > > Change-Id: I3800486f18a3693c9e2d3ace0a6f8ee626efc84e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2289780 > Commit-Queue: Georg Neis <neis@chromium.org> > Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> > Auto-Submit: Georg Neis <neis@chromium.org> > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68756} TBR=neis@chromium.org,nicohartmann@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1105420 Change-Id: Icc97c7c2fff79bb4860a9c36f6d2d3f531e524b5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2310250 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
When a reservation of exactly 4GB is requested on a 32-bit platform, we can simply pretend that we tried and failed. Fixed: chromium:1107234 Change-Id: I9a3f4dbd31064aff620337aa291768fe47174fb4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2308346 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Tamer Tas authored
R=rmcilroy@chromium.org,machenbach@chromium.org,jkummerow@chromium.org Bug: chromium:1099623 Change-Id: I7f79549a5de171dd2d85c86b3c4114f8aa2250b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2308344 Auto-Submit: Tamer Tas <tmrts@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
Drive-by: Improve comment, use << operator where possible Change-Id: I5d2bff57a3f19a0fbb746136a897bf50e1173775 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2308337Reviewed-by:
-
Clemens Backes authored
Move wrapper compilation to the jobs API. Moving function compilation is much more complex and will be done in a follow-up CL. R=ahaas@chromium.org CC=krivoy@chromium.org Bug: chromium:1101340 Change-Id: I0749e52a88264b725bba28252a6c76ae3338bb0e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2301933Reviewed-by:
-
Jakob Gruber authored
With work on NCI proceeding, it makes sense to test multiple pipeline configurations. The nci variant (passes --turbo-nci) now spawns dedicated NCI compilation jobs and inserts generated code into the code cache. The nci_as_highest_tier variant (passes --turbo-nci-as-highest-tier) simply replaces TF with NCI code (no extra jobs, no extra caching). This mode stresses NCI generated code more than the nci variant, in which NCI code only runs on cache hits. Bug: v8:8888 Change-Id: I4c2a43cce5271a6c288e7aba195dcc9daed6af9d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2299361 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#68964}
-
Victor Gomes authored
This regression is due to miscalculating the mapped_count in escape-analysis-reducer. Since NewArguemntsElements contains the entire arguments count instead of the rest argument size, we need to subtract (or add in the case of the reversed arguments stack) the formal parameter count to the index. Change-Id: I865018573fc3b0f0d20f7286653b7f6803cbe665 Bug: chromium:1106667 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2304576 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Clemens Backes authored
Most code comments use lowercase. This CL fixes the few that used uppercase, for consistency. R=thibaudm@chromium.org Change-Id: Ib02c8202f049a968662c91ade2252df24326a943 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2308336Reviewed-by:
-
Manos Koukoutos authored
They have been replaced with {array,struct}.new_with_rtt. Also, rework tests that used those instructions. Bug: v8:7748 Change-Id: I2aaccb1958bf2b8d6cad4969abc612216856393d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2307318 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: -
Clemens Backes authored
For debugging code, disable opcode merging. Otherwise, the effect of the first merged opcode would not be observable when stepping. R=thibaudm@chromium.org Bug: v8:10350 Change-Id: Id656c9dee8f9676bf3d7881f3782e5ead76b5e71 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2306802 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Adds new histogram V8.TimeToSafepoint to measure the time needed to reach a global safepoint/stop-the-world. Bug: v8:10315 Change-Id: I77701b26dfd47e04d64c4ecba3c47530ff8b9485 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2308390Reviewed-by:
-
Leszek Swirski authored
Split the capacity calculation logic and the allocation logic for StringTable resizing (both shrinking and enlarging). This allows us to: a) Precalculate the new size, without potentially first shrinking then resizing again, b) Make the final size calculation more explicit, b) In the future, maybe allow the allocation to happen outside a lock, and the rehashing to be inside it, for a concurrent string table. Change-Id: Ie41773520f2b20d9d244c151a153ed784f17283e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2307218 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: -
Clemens Backes authored
We currently still merge opcodes (i.e. i32 comparisons plus a br_if). This CL adds a test for this, which checks for the current behaviour. A follow-up CL will fix this and update the expected output accordingly. R=thibaudm@chromium.org Bug: v8:10350 Change-Id: I846aa931a3ec1a27043f04e830503d5732ae473e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2307232Reviewed-by:
-
Manos Koukoutos authored
Also remove traces of array.new_sub Bug: v8:7748 Change-Id: I96a922a16406960a80af0788e9cad5aa5692000a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2307237 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
