Commit 1cb7c707 authored by Michael Lippautz's avatar Michael Lippautz Committed by Commit Bot

cppgc: Fix ODR violation in unittests target

V8 already depends on cppgc_base which means that unittests does not
need to depend on cppgc_for_testing any longer.

Move the cppgc_for_testing dependency to the stand-alone
cppgc_unittests binary

Bug: v8:10674
Change-Id: I07bfe30901eb1683d2e0ee0189f73b5244884f27
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2310249
Auto-Submit: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Reviewed-by: 's avatarAnton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68970}
parent 92135e06
......@@ -35,6 +35,7 @@ v8_executable("cppgc_unittests") {
deps = [
":cppgc_unittests_sources",
"../..:cppgc_for_testing",
"//testing/gmock",
"//testing/gtest",
]
......@@ -85,7 +86,6 @@ v8_source_set("cppgc_unittests_sources") {
]
deps = [
"../..:cppgc_for_testing",
"//testing/gmock",
"//testing/gtest",
]
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment