- 19 May, 2020 1 commit
-
-
Ng Zhi An authored
The lowering for anytrue was assuming that the input nodes are all integers. The regression test added in https://crrev.com/c/2194471 calls anytrue with float operands, this was causing the lowering to generate cmpl instructions with a float register and an immediate, which is wrong. The fix is to use GetReplacementsWithType on the input nodes, but only if the input were floats, since we use Word32Equal. Drive-by clean up of comments in the aforementioned regression test. Bug: v8:10535 Change-Id: I4de89516c178e9003a4c745808d831be87918381 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2203400 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#67878}
-
- 18 May, 2020 33 commits
-
-
Ng Zhi An authored
Bug: v8:9886 Change-Id: I22af3c19ef6371d31f0f95c58730ceb3e7effafa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207653Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67877}
-
Hannes Payer authored
Change-Id: I70328a944b78591d106d752197b096cb86c32573 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2206735 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#67876}
-
Ng Zhi An authored
The codegen uses a bunch of vpmax to try and keep set bits around. The datatype for vpmax does not need to change for each instruction, since vpmax U32 will persist set bits just as well. This simplifies the instruction sequences for S1x8 and S1x16 anytrue. I added a test to check a special case when a f64x2 contains -0.0 (top bit set). A previous attempt to optimize codegen used floating point compare, which does not distinguish between 0.0 and -0.0. So -0.0 will compare equals to 0.0, and incorrect return 0 for anytrue. Change-Id: I66013796af08a666009e6b2d774ea7ee7bdfe1ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2203113 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Port 99e4ef48 Original Commit Message: Only for arm and arm64 now. The ia32 and x64 ones are more complicated and will be included in subsequent changes. R=zhin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I3bcdae0d47d2e024cfb6e80ba460306ec5e2d434 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2205884Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#67874}
-
Ng Zhi An authored
This is a reland of edf90ee8 The fix here is to call GetUnusedRegister with {}, in liftoff-assembler-ia32.h emit_i8x16_shri_u. Original change's description: > [wasm-simd][liftoff][ia32][x64] Implement i8x16 shr > > The code sequence is the same as TurboFan, only wrapped in a template to > share the implementation. > > Bug: v8:9909 > Change-Id: I9c1b37bbfafe91d1bd8edd7f9dafd86ff1c07623 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2202723 > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67842} Bug: v8:9909 Change-Id: Id56a612cd6580c68a5129e71d7a0e7b29d64b368 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2204080Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67873}
-
Ng Zhi An authored
Making them private was a way to hide the constructor, we can explicitly delete them, which give a better compilation error message as well. Also see: https://stackoverflow.com/q/55205874 Bug: v8:10488 Change-Id: I8a116637608fcc6a93d6fc4f5ee014d2db863669 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2204156Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67872}
-
Manos Koukoutos authored
- Add a default, move, and copy constructor for SsaEnv and use them when possible. - Bring the Split method signature in line with Steal and Unimplemented. Changes: Change-Id: I626142fbd1c1ed15c1852b9bfc8b39a0e936b839 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2204278 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Dan Elphick authored
Moves several functions missed in https://chromium-review.googlesource.com/c/v8/v8/+/2203206. Bug: v8:10473, v8:10506 Change-Id: I882410cefe496054b71db24a65133224dc52f23c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207144 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Maya Lekova authored
Bug: v8:9994 Change-Id: I662182a252c2aab053f6c821bf281f613316700a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207143 Commit-Queue: Maya Lekova <mslekova@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Auto-Submit: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Richard Stotz authored
Bug: v8:10520 Change-Id: If24a2d74b6e1837b4c29383e4c537e872404e0a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2201764 Commit-Queue: Richard Stotz <rstz@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#67868}
-
Maya Lekova authored
Enhance gcmole --verbose printing with the GC suspect. Bug: v8:9986 Change-Id: Ia1454d4edec334eabb31a764583e4ee559f0fe07 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207174Reviewed-by:
-
Richard Stotz authored
Bug: v8:10520 Change-Id: Iad8d35e58b766a9e4d3013f90fd4d7fb68708fa7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2201577 Commit-Queue: Richard Stotz <rstz@chromium.org> Reviewed-by:
-
Clemens Backes authored
Asynchronicity can be tricky, in particular if the debugger is enabled while wasm compilation is happening. We seem to have open issues in streaming compilation there. As a first step, which CL adds more tests for async compilation (non-streaming). R=thibaudm@chromium.org Bug: v8:10531 Change-Id: Idf16790a91aad437ceb981485512a2f52b791bac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2206736Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67865}
-
Jakob Gruber authored
This is a reland of 69f42d40 Original change's description: > [nci] Add Construct_WithFeedback builtin > > This builtin essentially acts like InterpreterAssembler::Construct. It > collects full feedback, then tail-calls either the array constructor > or the construct builtin. > > For now, it is only used in generic lowering, if the --turbo-nci flag > is passed. One of the next steps will be to measure performance impact > of feedback collection. If minimal, we may want to enable it > unconditionally in generic lowering. > > Bug: v8:8888 > Change-Id: I8a460a2b5954c26fa72658045a8423c5eee6b611 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2198775 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Auto-Submit: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67850} Tbr: neis@chromium.org Bug: v8:8888 Change-Id: Ib1a81da998c848d63c0119b3a4e90fc917b15e94 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2206738 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#67864}
-
Richard Stotz authored
Bug: v8:10520 Change-Id: Id06c35f8004519cd778af12ad67aaee2d506609a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207135 Commit-Queue: Richard Stotz <rstz@chromium.org> Reviewed-by:
-
Omer Katz authored
Bug: chromium:1056170 Change-Id: I8f1fbf1f9995fbd3f89564542209b828bf7118ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190428Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#67862}
-
Santiago Aboy Solanes authored
There are some 'mode' still pending removal. Bug: v8:9708, v8:10506, v8:6949 Change-Id: Ie1dc0397241bf046ac9737666e700b98018b2ff5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2202906 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#67861}
-
Jakob Gruber authored
This reverts commit 69f42d40. Reason for revert: The last PS introduced a bug https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20-%20fyi/15897. Original change's description: > [nci] Add Construct_WithFeedback builtin > > This builtin essentially acts like InterpreterAssembler::Construct. It > collects full feedback, then tail-calls either the array constructor > or the construct builtin. > > For now, it is only used in generic lowering, if the --turbo-nci flag > is passed. One of the next steps will be to measure performance impact > of feedback collection. If minimal, we may want to enable it > unconditionally in generic lowering. > > Bug: v8:8888 > Change-Id: I8a460a2b5954c26fa72658045a8423c5eee6b611 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2198775 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Auto-Submit: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67850} TBR=neis@chromium.org,jgruber@chromium.org,tebbi@chromium.org Change-Id: I3af168373978d773385b9eda9bc1e243e3cbea09 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8888 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2206737Reviewed-by:
-
Jakob Gruber authored
... and other unused methods. Bug: v8:9708 Change-Id: Ie3658878024fcddcd5503c6462e5ad873eba19b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2206733 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#67859}
-
Richard Stotz authored
Bug: v8:10520 Change-Id: I0b4867d9b705058536b0f4640a9a87059db3aca7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2201576 Commit-Queue: Richard Stotz <rstz@chromium.org> Reviewed-by:
-
Dan Elphick authored
Splits out MemoryAllocator and CodeRangeAddressHint into memory-allocator.h Bug: v8:10473, v8:10506 Change-Id: I0855f23dd0374ddd68493ee05af7a3a00c84660d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2203206 Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#67857}
-
Thibaud Michaud authored
R=ahaas@chromium.org Bug: v8:10408 Change-Id: I1ca62c1cdf3025dcd0df7cdbe6735cc3491c48e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2201578 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Clemens Backes authored
We constantly fight against scrambled output with --print-wasm-code and other flags. Passing --single-threaded only partially mitigates this, because there could still be multiple isolates (e.g. Workers), and we sometimes failed to really execute in a single thread if that flag was set. Hence this CL solves the problem in a more fundamental way: Whenever a {StdoutStream} is constructed, it implicitly takes a global recursive mutex. The recursive mutex is needed because we still have some printing methods that don't take a stream as parameter, and instead create their own instance of {StdoutStream}, which should not crash of course. The overhead of taking a mutex should be acceptable, since output to stdout mostly happens if special tracing flags have been passed, and is slow anyway. This CL ensures that the {StdoutStream} is used at least for --print-code, --print-wasm-code, and --trace-turbo-graph. More flags can later be ported on demand. The {JSHeapBroker} class was modified to not contain a {StdoutStream}, but instead create one on demand. R=mlippautz@chromium.org, tebbi@chromium.org CC=ahaas@chromium.org Bug: v8:10506 Change-Id: Ib9cf8d76aa79553b4215bb7775e6d47a8179aafa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2201767Reviewed-by:Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67855}
-
Jakob Kummerow authored
When the intention is to handle every case, *and* when we can be reasonably sure that no invalid enum values will occur (e.g. from reading untrusted data), then we shouldn't have a "default:" case in a switch statement so that the compiler will warn us when a case is missing. Bug: v8:10506 Change-Id: Iefdebd54802611e7ec3479afa3c4e6506f97a095 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2204284 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
This moves page post-processinng into NotifyOldGenerationExpansion and introduces a new CanExpandOldGenerationBackground. Bug: v8:10536 Change-Id: I54761226487434955f8a0dadf7c4dbb31c7955e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2204283Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#67853}
-
Santiago Aboy Solanes authored
Bug: v8:10506 Change-Id: I171a587176f4a1a3c98d407e8b6a3b63bbf1ad6a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2202993 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#67852}
-
Santiago Aboy Solanes authored
To do this: * Create specialized ParameterToTagged versions of Smi and IntPtT * Unify and generalize ExtractFixedArray Bug: v8:9708, v8:10506 Change-Id: Ic23c6f4bb250076f12d6e8622ebc0b4d4cbeaac8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2202982Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#67851}
-
Jakob Gruber authored
This builtin essentially acts like InterpreterAssembler::Construct. It collects full feedback, then tail-calls either the array constructor or the construct builtin. For now, it is only used in generic lowering, if the --turbo-nci flag is passed. One of the next steps will be to measure performance impact of feedback collection. If minimal, we may want to enable it unconditionally in generic lowering. Bug: v8:8888 Change-Id: I8a460a2b5954c26fa72658045a8423c5eee6b611 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2198775 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
-
Zhao Jiazhong authored
Port 0ba8b716 https://crrev.com/c/2202356 Port 67a337b5 https://crrev.com/c/2202718 Port 99e4ef48 https://crrev.com/c/2202722 Change-Id: I435c9859b9ef341682814bb989fe91ba8cae3d86 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2203896Reviewed-by:
-
Clemens Backes authored
For debugging (either with --print-wasm-code, or inspecting the current code object in a debugger) it's helpful to also see the debug side table, if available. This CL adds print support for that, and uses it when printing wasm code, and after generating a new debug side table. R=thibaudm@chromium.org Bug: v8:10359 Change-Id: I700b6eacb80f015212115e91b94c513e88c04288 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2202902 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
Also, change its 'locals' field to a ZoneVector. This is needed for 'let' as per [wasm-gc]. Bug: v8:7748 Change-Id: I9e6ca7f7e483b4bc13b64643107297be31af0e35 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2202995 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Peter Marshall authored
Makes it clearer what this does. Added comments to explain it. Change-Id: I90b0686f8a607cea32c482591b924e9103f7f445 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2205693 Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#67846}
-
Manos Koukoutos authored
Changes: Cleanup: - Make sure read_value_type has the same interface as other read_* functions, i.e., returns the decoded value and writes the consumed length into a pointer. - DecodeLocals is now an instance method. - DecodeLocals should fail when given a wrong number of locals. Add tests to catch that. - Fix a buggy test. Refactoring in preparation of introducing the 'let' instruction as per [wasm-gc]: - DecodeLocals does not consume any input and can start from any pc. - DecodeLocals gives the option of not appending the decoded locals to local_types_. - Separate locals initialization from signature. Bug: v8:7748 Change-Id: Iaaff87fdb9abe0ddd716484ea3fa87779d2d1a2f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2202992 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
- 15 May, 2020 6 commits
-
-
Milad Farazmand authored
Port 67a337b5 Original Commit Message: Implement for x64, ia32, arm64, and arm. R=zhin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I8b512992a3cc583f31f433db037fabf65714628a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2204542Reviewed-by:
-
Zhi An Ng authored
This reverts commit edf90ee8. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Win32%20-%20debug%20builder/36129? Original change's description: > [wasm-simd][liftoff][ia32][x64] Implement i8x16 shr > > The code sequence is the same as TurboFan, only wrapped in a template to > share the implementation. > > Bug: v8:9909 > Change-Id: I9c1b37bbfafe91d1bd8edd7f9dafd86ff1c07623 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2202723 > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67842} TBR=clemensb@chromium.org,zhin@chromium.org Change-Id: I04b9993040fa8a1dd69a4fa892a35273682d3efa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9909 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2204550Reviewed-by:
-
Ng Zhi An authored
The code sequence is the same as TurboFan, only wrapped in a template to share the implementation. Bug: v8:9909 Change-Id: I9c1b37bbfafe91d1bd8edd7f9dafd86ff1c07623 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2202723 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Michael Lippautz authored
This allows embedding objects in each other and recursively trace through them. Bug: chromium:1056170 Change-Id: I4e4ae4c1669109c01003cb6b69797cf271a74033 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2198977Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Only for arm and arm64 now. The ia32 and x64 ones are more complicated and will be included in subsequent changes. Bug: v8:9909 Change-Id: I6597efbccd780e12234f8674e09e60bb3f803630 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2202722 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Port 0ba8b716 Original Commit Message: Implemented for x64, ia32, arm64, arm. R=zhin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I45caa3fbf643e3caa7b452383155fa32d3ca399e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2204333Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#67839}
-
