• Manos Koukoutos's avatar
    [wasm] Refactor/cleanup DecodeLocals, read_value_type · a4d295ad
    Manos Koukoutos authored
    Changes:
    Cleanup:
    - Make sure read_value_type has the same interface as other
      read_* functions, i.e., returns the decoded value and writes
      the consumed length into a pointer.
    - DecodeLocals is now an instance method.
    - DecodeLocals should fail when given a wrong number of locals.
      Add tests to catch that.
    - Fix a buggy test.
    
    Refactoring in preparation of introducing the 'let'
    instruction as per [wasm-gc]:
    - DecodeLocals does not consume any input and can start from any pc.
    - DecodeLocals gives the option of not appending the decoded
      locals to local_types_.
    - Separate locals initialization from signature.
    
    Bug: v8:7748
    Change-Id: Iaaff87fdb9abe0ddd716484ea3fa87779d2d1a2f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2202992
    Commit-Queue: Manos Koukoutos <manoskouk@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67845}
    a4d295ad
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...