- 30 Aug, 2022 5 commits
-
-
Frank Tang authored
PR https://github.com/tc39/proposal-temporal/pull/2266 Disallow arbitrary integers for the reference ISO year in PlainMonthDay Spec text: https://tc39.es/proposal-temporal/#sec-temporal-createtemporalmonthday Also add missed assertion of calling ISODateTimeWithinLimits Bug: v8:11544 Change-Id: Idd18428f3e6e6af53c2c207652688af269746782 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855703Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#82804}
-
Frank Tang authored
Subtract timeZone.[[OffsetNanoseconds]] from epochNanoseconds before calling the IsValidEpochNanoseconds() for the case of 4. If timeZone.[[OffsetNanoseconds]] is not undefined Bug: v8:11544 Change-Id: Icea2d8390a9db01054956f8c57b47dc5a88446d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855980Reviewed-by:
-
Frank Tang authored
Validate fractionalSecondDigits after truncation https://github.com/tc39/proposal-temporal/pull/2297 Spec text: https://tc39.es/proposal-temporal/#sec-temporal-tosecondsstringprecision Bug: v8:11544 Change-Id: I648f087f4fa2cfd6245c7946cfa625a7c5e3b3b9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855702 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Frank Tang authored
Disallow negative day lengths as round result PR https://github.com/tc39/proposal-temporal/pull/2261 Also fix the missing extraValues=<"day"> to GetTemporalUnit Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.zoneddatetime.prototype.round Bug: v8:11544 Change-Id: Ibc963d5d93dde30f29df707ef3b3ecea99cd4a60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855704Reviewed-by:
-
Frank Tang authored
https://github.com/tc39/proposal-temporal/pull/2225 Call ToTemporalOverflow in ToTemporalDate and ToTemporalDateTime Spec Text: https://tc39.es/proposal-temporal/#sec-temporal-totemporaldate https://tc39.es/proposal-temporal/#sec-temporal-totemporaldatetime Bug: v8:11544 Change-Id: I3d2846e2efc214ea5385be58cb49e319369b5900 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855705Reviewed-by:
-
- 27 Aug, 2022 2 commits
-
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/adba7dfd9c..8dcc0e19 Also add "Intl402" (notice the uppercase I) to the excluded dirs for noi18n because of https://github.com/tc39/test262/pull/3638 Bug: v8:7834 Change-Id: Ibd53c7917a4fd8d1b27989e3c040c5ab47a66e50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3857450Reviewed-by:
-
Frank Tang authored
Sync https://github.com/tc39/proposal-temporal/pull/2269 Add AO MaybeFormatCalendarAnnotation Use MaybeFormatCalendarAnnotation in TemporalDateToString TemporalDateTimeToString TemporalZonedDateTimeToString Spec text: https://tc39.es/proposal-temporal/#sec-temporal-maybeformatcalendarannotation https://tc39.es/proposal-temporal/#sec-temporal-temporaldatetostring https://tc39.es/proposal-temporal/#sec-temporal-temporaldatetimetostring https://tc39.es/proposal-temporal/#sec-temporal-temporalzoneddatetimetostring Bug: v8:11544 Change-Id: Ia361b1cba1b2e9db77125a8888054cfd89626611 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855699 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
- 26 Aug, 2022 3 commits
-
-
Frank Tang authored
This reverts commit a165e82e. Reason for revert: SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../../src/objects/js-temporal-objects.cc:3837:22 Original change's description: > [Temporal] Use double/int32_t instead of int64_t for duration parsing > > Use double instead of int64_t and int32_t in duration parsing result > so we can parse very large duration fields as infinity and throw RangeError in later stages. The three fractional parts can hold up value from 0 to 999,999,999 so we use int32_t to hold it. Other part could be infinity so we use double to hold it. Also rearrange the order of the three int32_t in the struct ParsedISO8601Duration after all the double > > Bug: v8:11544 > Change-Id: I7e5b02f7c7bbb60997f1419f016aed61dd3e0d6c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3840761 > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82754} Bug: v8:11544 Change-Id: Ia9d0a014463b00640d43b051753a554f42171c2b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3858575Reviewed-by:
-
Frank Tang authored
Use double instead of int64_t and int32_t in duration parsing result so we can parse very large duration fields as infinity and throw RangeError in later stages. The three fractional parts can hold up value from 0 to 999,999,999 so we use int32_t to hold it. Other part could be infinity so we use double to hold it. Also rearrange the order of the three int32_t in the struct ParsedISO8601Duration after all the double Bug: v8:11544 Change-Id: I7e5b02f7c7bbb60997f1419f016aed61dd3e0d6c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3840761Reviewed-by:
-
Frank Tang authored
Also add AO: ToISOWeekOfYear Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.calendar.prototype.weekofyear https://tc39.es/proposal-temporal/#sec-temporal-toisoweekofyear Note- this is only the non-intl version. intl version in https://tc39.es/proposal-temporal/#sup-temporal.calendar.prototype.weekofyear will be implemented in later cl. PR https://github.com/tc39/proposal-temporal/pull/2378 Sync spec text for ToISODayOfYear and ToISODayOfWeek in the comment and add DCHECK for assertion. Bug: v8:11544 Change-Id: If07ff76551707d17d125e41bc624c12da6efa45a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3531567 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
- 18 Aug, 2022 4 commits
-
-
Frank Tang authored
Add a version of BalanceDuration which take two TimeDurationRecord and add them internally after converting to BigInt as nanoseconds so it will not overflow the double. Use "std::isinf()" instead of "!std::isfinite()" Inspired by https://github.com/tc39/proposal-temporal/issues/2380#issuecomment-1219194995 Bug: v8:11544 Change-Id: I29e06fa857ff43f2668e1e4ffd07735ff6efee42 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3837852 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/main@{#82576}
-
Frank Tang authored
Use SNPrintf to handle bigger unit duration fields. Spec Text: https://tc39.es/proposal-temporal/#sec-temporal-temporaldurationtostring Fix test: https://github.com/tc39/test262/blob/main/test/built-ins/Temporal/Duration/prototype/toString/precision-formatted-as-decimal-number.js Bug: v8:11544 Change-Id: I63a6e823652a0826216593cd153ef5103f94e7a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3834437Reviewed-by:
-
Frank Tang authored
Fix BalanceDuration to pass relativeTo to BalancePossiblyInfiniteDurationResult and then pass to NanosecondsToDays. The bug is introduced in https://chromium-review.googlesource.com/c/v8/v8/+/3781117 The spec text in 4-a of BalancePossiblyInfiniteDuration is "a. Let result be ? NanosecondsToDays(nanoseconds, relativeTo)." but the code wrote "a. Let result be ? NanosecondsToDays(nanoseconds, *undefined*)." Spec Text: https://tc39.es/proposal-temporal/#sec-temporal-balancepossiblyinfiniteduration Bug: v8:11544 Change-Id: I3ea9a3b71521cdcc210e9db370d6e849fcde56ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3834431 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Frank Tang authored
Spec text: https://tc39.es/proposal-temporal/#sec-temporal-parsetemporaldurationstring Bug: v8:11544 Change-Id: I2d54759c07529f95c7a27c334ee5d3fa6760b2e0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3835292Reviewed-by:
-
- 17 Aug, 2022 4 commits
-
-
Frank Tang authored
1. Add if/throw based on IsValidEpochNanoseconds() in DisambiguatePossibleInstants, ParseTemporalInstant, GetIANATimeZoneEpochValueAsArrayOfInstantForUTC, GetIANATimeZoneEpochValueAsArrayOfInstant, JSTemporalTimeZone::GetPossibleInstantsFor, and InterpretISODateTimeOffset( 2. Add assert IsValidEpochNanoseconds in GetISOPartsFromEpoch 3. Fix ISODateTimeWithinLimits These changes are syncing of the following PRs: https://github.com/tc39/proposal-temporal/pull/2277 https://github.com/tc39/proposal-temporal/pull/2084 https://github.com/tc39/proposal-temporal/pull/2312 https://github.com/tc39/proposal-temporal/pull/2273 https://github.com/tc39/proposal-temporal/pull/2117 Spec Text: https://tc39.es/proposal-temporal/#sec-temporal-disambiguatepossibleinstants https://tc39.es/proposal-temporal/#sec-temporal-parsetemporalinstant https://tc39.es/proposal-temporal/#sec-temporal.timezone.prototype.getpossibleinstantsfor https://tc39.es/proposal-temporal/#sec-temporal-interpretisodatetimeoffset https://tc39.es/proposal-temporal/#sec-temporal-getisopartsfromepoch https://tc39.es/proposal-temporal/#sec-temporal-isodatetimewithinlimits Bug: v8:11544 Change-Id: I38244d039f33e294b698d470b587b1b44b72fa09 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3831150Reviewed-by:
-
Frank Tang authored
See issues in https://github.com/tc39/test262/issues/3553 and https://github.com/tc39/proposal-temporal/issues/2165 Bug: v8:11544 Change-Id: Iefe6353e95178e1241a7f29c80b24baad2a8428d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3835266 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Frank Tang authored
Pass undefined for option in calendar monthDayFromFields and yearMonthFromFields https://github.com/tc39/proposal-temporal/issues/1685 Bug: v8:11544 Change-Id: I3fd37e176bd83dc0b01d92a3c323d2933291c49b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3835262Reviewed-by:
-
Frank Tang authored
Bug: v8:11544 Change-Id: Iaf285f431e742e607e09d37c47a94d3f86806b13 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3833434Reviewed-by:
-
- 16 Aug, 2022 1 commit
-
-
Frank Tang authored
TotalDurationNanoseconds previously return a double to represent the total duration nanoseconds, but the value could be easily bigger than the precise value a double can represent. A double can precisely represent integer to 2^53, which is only about 104 days if that value is nanoseconds. So we need to change the return type to BigInt. Refactor BalanceDuration to merge common code. Change JSTemporalDuration::Compare to use the BigInt version of TotalDurationNanoseconds Change the call site of TotalDurationNanoseconds in RoundDuration Add newly defined BalancePossiblyInfiniteDuration and change BalanceDuration to call it. Spec text: https://tc39.es/proposal-temporal/#sec-temporal-balancepossiblyinfiniteduration https://tc39.es/proposal-temporal/#sec-temporal-balanceduration https://tc39.es/proposal-temporal/#sec-temporal-totaldurationnanoseconds Split from changes in cl/3750098 Bug: v8:11544 Change-Id: Ia4ca8f9bdba49c3a5e54edeef0d2a5833b0002a2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3824658Reviewed-by:
-
- 13 Aug, 2022 1 commit
-
-
Frank Tang authored
Also change Intl.DateTimeFormat to take temporal objects for format. Design doc: https://docs.google.com/document/d/1gI_Jd9ztnkqhQnDTR4GaI3JOFdMNJW2kQK_UaBPvMug Implement the intl enabled Temporal.Instant.prototype.toLocaleString, Temporal.PlainDate.prototype.toLocaleString Temporal.PlainDateTime.prototype.toLocaleString Temporal.PlainMonthDay.prototype.toLocaleString Temporal.PlainTime.prototype.toLocaleString Temporal.PlainYearMonth.prototype.toLocaleString Temporal.ZonedDateTime.prototype.toLocaleString Implement AOs: HandleDateTimeTemporalDate, HandleDateTimeTemporalYearMonth, HandleDateTimeTemporalMonthDay, HandleDateTimeTemporalTime HandleDateTimeTemporalDateTime, HandleDateTimeTemporalInstant, HandleDateTimeTemporalZonedDateTime, HandleDateTimeOthers, HandleDateTimeValue Spec Text: https://tc39.es/proposal-temporal/#sec-temporal-handledatetimevaluetemporaldate https://tc39.es/proposal-temporal/#sec-temporal-handledatetimevaluetemporalyearmonth https://tc39.es/proposal-temporal/#sec-temporal-handledatetimevaluetemporalmonthday https://tc39.es/proposal-temporal/#sec-temporal-handledatetimevaluetemporaltime https://tc39.es/proposal-temporal/#sec-temporal-handledatetimevaluetemporaldatetime https://tc39.es/proposal-temporal/#sec-temporal-handledatetimevaluetemporalinstant https://tc39.es/proposal-temporal/#sec-temporal-handledatetimevaluetemporalzoneddatetime https://tc39.es/proposal-temporal/#sec-temporal-handledatetimeothers https://tc39.es/proposal-temporal/#sec-temporal-handledatetimevalue https://tc39.es/proposal-temporal/#sup-temporal.instant.prototype.tolocalestring https://tc39.es/proposal-temporal/#sup-temporal.plaindate.prototype.tolocalestring Temporal.PlainDateTime.prototype.toLocaleString https://tc39.es/proposal-temporal/#sup-temporal.plainmonthday.prototype.tolocalestring https://tc39.es/proposal-temporal/#sup-temporal.plaintime.prototype.tolocalestring https://tc39.es/proposal-temporal/#sup-temporal.plainyearmonth.prototype.tolocalestring https://tc39.es/proposal-temporal/#sup-temporal.zoneddatetime.prototype.tolocalestring Remove the output_range parameter and use the is_null() of MaybeHandle<T> for to check the optional return. Bug: v8:11544 Change-Id: Ia9ffe7a71c8fb68391581eb5ef7620708e2bd1f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3791526 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
- 12 Aug, 2022 3 commits
-
-
Frank Tang authored
Also add AOs: DifferenceTemporalPlainDateTime, DifferenceTemporalZonedDateTime, Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.plaindatetime.prototype.since https://tc39.es/proposal-temporal/#sec-temporal.plaindatetime.prototype.until https://tc39.es/proposal-temporal/#sec-temporal.zoneddatetime.prototype.since https://tc39.es/proposal-temporal/#sec-temporal.zoneddatetime.prototype.until https://tc39.es/proposal-temporal/#sec-temporal-differencetemporalplaindatetime https://tc39.es/proposal-temporal/#sec-temporal-differencetemporalzoneddatetime split from cl/3750098 Bug: v8:11544 Change-Id: I326d91a897fcd7e39de2fb2bfecfc5bfd920eb44 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3827313Reviewed-by:
-
Frank Tang authored
This is a reland of commit cf765fc3 Original change's description: > [Temporal] Use double instead of int32_t for input of BalanceTime > > To avoid overflow int32_t in the math of balancing time. > > Bug: v8:13182, v8:11544 > Change-Id: Ib76cf95bbd4f9b47efd6921a67b09d3024e72b13 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3827310 > Reviewed-by: Adam Klein <adamk@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82409} Bug: v8:13182, v8:11544 Change-Id: I7550b3a7186beed0e32e95a41cae87030d0c5a7c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3827671 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Adam Klein authored
This reverts commit cf765fc3. Reason for revert: fixes more tests than expected in test262: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20shared/49412/overview Original change's description: > [Temporal] Use double instead of int32_t for input of BalanceTime > > To avoid overflow int32_t in the math of balancing time. > > Bug: v8:13182, v8:11544 > Change-Id: Ib76cf95bbd4f9b47efd6921a67b09d3024e72b13 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3827310 > Reviewed-by: Adam Klein <adamk@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82409} Bug: v8:13182, v8:11544 Change-Id: Id7dd491b4485d13b0e2cc6aae8603479c7949ce8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3827670 Auto-Submit: Adam Klein <adamk@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#82413}
-
- 11 Aug, 2022 5 commits
-
-
Frank Tang authored
To avoid overflow int32_t in the math of balancing time. Bug: v8:13182, v8:11544 Change-Id: Ib76cf95bbd4f9b47efd6921a67b09d3024e72b13 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3827310Reviewed-by:
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/e41d581c6d..adba7dfd9c Bug: v8:7834 Change-Id: I1150ce8da79c452b9bbf662d9486a79a64148509 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3824881Reviewed-by:
-
Frank Tang authored
This reverts commit d9f58973. Reason for revert: Break UBSAN Original change's description: > [Temporal] Mark fixed tests > > Bug: v8:11544 > Change-Id: Iefd64619e6361683e70fdac26d155aa8d27da9e5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3824751 > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82405} Bug: v8:11544 Change-Id: I5501bf416345a69508a07f4bbe70bb300f49c296 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3827663Reviewed-by:
Frank Tang <ftang@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/main@{#82406}
-
Frank Tang authored
Bug: v8:11544 Change-Id: Iefd64619e6361683e70fdac26d155aa8d27da9e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3824751Reviewed-by:
-
Frank Tang authored
Remove the unnecessary int64_t version of RoundNumberToIncrement and remove the unneeded RoundHalfAwayFromZero. Change the type of the increment to double from int64_t. split from cl/3750098 Bug: v8:11544 Change-Id: I591486c472e9c1343306ff9a1d0384d06fe01835 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3824194 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
- 10 Aug, 2022 1 commit
-
-
Frank Tang authored
Change to use Handle<Object> instead of Handle<String> for calendar and offset_string. Spec text: https://tc39.es/proposal-temporal/#sec-temporal-torelativetemporalobject Bug: v8:11544 Change-Id: Ia9051f176e0e91a362b0c6b9edf6fea5a53ddcf2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3808256Reviewed-by:
-
- 03 Aug, 2022 1 commit
-
-
Frank Tang authored
Correct the wrong parameter passing in the 3rd PrepareTemporalFields calls Spec text: https://tc39.es/proposal-temporal/#sec-temporal.plaindate.prototype.with https://tc39.es/proposal-temporal/#sec-temporal.plainyearmonth.prototype.with https://tc39.es/proposal-temporal/#sec-temporal.plainmonthday.prototype.with Bug: v8:11544 Change-Id: I8acd7059cedf6924eee36ed5cb7892b636c8c72a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3807905Reviewed-by:
-
- 29 Jul, 2022 1 commit
-
-
Frank Tang authored
Bug: v8:7834 Change-Id: I79646de331fde36626dd5604b38ef8dc60dafc3d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3793003 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
- 28 Jul, 2022 1 commit
-
-
Frank Tang authored
This is a reland of commit 33043888 Original change's description: > [test262] Roll test262 > > https://chromium.googlesource.com/external/github.com/tc39/test262/+log/3ddfa0cd..e41d581c > > Bug: v8:7834 > Change-Id: Id1c5b07f109ab6f60498eb7185becc508d16af1e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3786907 > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/main@{#81980} Bug: v8:7834 Change-Id: Ic7e0378b11a05161b69965cff06985b9a2d954fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3788719Reviewed-by:
-
- 27 Jul, 2022 3 commits
-
-
Frank Tang authored
TC39 2022-07-22 decided to take PR701 to skip order check on DateTimeFormat formatRange and formatRangeToParts See https://github.com/tc39/ecma402/pull/701 https://docs.google.com/presentation/d/1UUvbf3FFu9PGtrPAKPdMad9DZuVFLIvkAsAxyJZyvxM for details. Bug: v8:13094 Change-Id: I9ade938726f2a79e0ab2b5deb7fe36c001f2722f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779042Reviewed-by:
-
Frank Tang authored
Remove the range check of formatRange, formatRangeToParts on NumberFormat and selectRange on PluralRules Bug: v8:10776 Change-Id: Ifede7d61db6414d5b338b22bd188406e5f7d98b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779041Reviewed-by:
-
Frank Tang authored
Call Intl function which call ICU TimeZone for the calculation of timezone other than UTC Bug: v8:11544 Change-Id: Idc355aaeccc0bed026a7117bb366ee914fa29733 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3783074 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
- 26 Jul, 2022 2 commits
-
-
Deepti Gandluri authored
This reverts commit 33043888. Reason for revert: Test262 fails on UBSan: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20UBSan/22371/overview Original change's description: > [test262] Roll test262 > > https://chromium.googlesource.com/external/github.com/tc39/test262/+log/3ddfa0cd..e41d581c > > Bug: v8:7834 > Change-Id: Id1c5b07f109ab6f60498eb7185becc508d16af1e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3786907 > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/main@{#81980} Bug: v8:7834 Change-Id: I34d4b36209226d32b416608fbf2ab4c0f8702566 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3788426 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Auto-Submit: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/main@{#81981}
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/3ddfa0cd..e41d581c Bug: v8:7834 Change-Id: Id1c5b07f109ab6f60498eb7185becc508d16af1e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3786907Reviewed-by:
-
- 25 Jul, 2022 1 commit
-
-
Frank Tang authored
Also add AOs: ParseTemporalRelativeToString, DefaultTemporalLargestUnit, CalculateOffsetShift, UnbalanceDurationRelative, BalanceDurationRelative, Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.duration.compare https://tc39.es/proposal-temporal/#sec-temporal.duration.prototype.round https://tc39.es/proposal-temporal/#sec-temporal.duration.prototype.total https://tc39.es/proposal-temporal/#sec-temporal-parsetemporalrelativetostring https://tc39.es/proposal-temporal/#sec-temporal-defaulttemporallargestunit https://tc39.es/proposal-temporal/#sec-temporal-calculateoffsetshift https://tc39.es/proposal-temporal/#sec-temporal-unbalancedurationrelative https://tc39.es/proposal-temporal/#sec-temporal-balancedurationrelative Bug: v8:11544 Change-Id: I3b20bdb7cec30f6a8503603169643678988f4dcf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3750322 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
- 22 Jul, 2022 1 commit
-
-
Frank Tang authored
Add a second implementation of BalanceDuration which the nanoseconds could be very large and beyong the precision could be handled by double and passed in by BigInt, and values of other time fields are 0. Bug: v8:11544 Change-Id: Ib794c6c78b81b8338434314fa5033cf1e991d32b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3781117 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
- 19 Jul, 2022 1 commit
-
-
Frank Tang authored
Change the return value to fallback while the property is not one specified in the value. https://github.com/tc39/proposal-intl-numberformat-v3/pull/92 Bug: v8:13053 Change-Id: I40e430152c71258f1ff85fec1d69928937d0ad99 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3759224 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
