- 20 Feb, 2017 1 commit
-
-
titzer authored
This makes it easier to implement asynchronous compilation by hiding all the implementation details of both synchronous and asynchronous compilation within wasm-module.cc, whereas before the code in wasm-js.cc actually implemented asynchronous compilation in terms of synchronous. BUG= Review-Url: https://codereview.chromium.org/2695813005 Cr-Commit-Position: refs/heads/master@{#43310}
-
- 13 Feb, 2017 1 commit
-
-
Marja Hölttä authored
R=mstarzinger@chromium.org BUG=v8:5294 Change-Id: If2cdb4d38829e69ddd8aecb99c99c3a03050f57c Reviewed-on: https://chromium-review.googlesource.com/441824 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#43158}
-
- 28 Jan, 2017 1 commit
-
-
bradnelson authored
Return a regular JSObject in the asm.js -> wasm case. BUG=v8:5877 R=mtrofin@chromium.org,aseemgarg@chromium.org,titzer@chromium.org Review-Url: https://codereview.chromium.org/2664493002 Cr-Commit-Position: refs/heads/master@{#42757}
-
- 26 Jan, 2017 1 commit
-
-
bradnelson authored
Also show size when --trace-asm-time is on. BUG= R=mtrofin@chromium.org Review-Url: https://codereview.chromium.org/2658703003 Cr-Commit-Position: refs/heads/master@{#42678}
-
- 13 Jan, 2017 3 commits
-
-
mtrofin authored
We weren't throwing LinkError where appropriate progress BUG=v8:5835 Review-Url: https://codereview.chromium.org/2629523007 Cr-Commit-Position: refs/heads/master@{#42342}
-
bradnelson authored
We allocate console timing messages for now, as previously skipping this tickled unrelated flake. Use a fixed message to make them consistent in predictable mode. BUG=v8:4203 TBR=titzer@chromium.org Review-Url: https://codereview.chromium.org/2628173003 Cr-Commit-Position: refs/heads/master@{#42303}
-
bradnelson authored
This directs all asm.js traffic via the Wasm backend. Make asm.js console output less noisy. R=titzer@chromium.org,aseemgarg@chromium.org BUG=v8:4203 Review-Url: https://codereview.chromium.org/2624813002 Cr-Original-Original-Commit-Position: refs/heads/master@{#42194} Committed: https://chromium.googlesource.com/v8/v8/+/946cc371ed4b34d1a9f5cc615b14c41b652562ad Review-Url: https://codereview.chromium.org/2624813002 Cr-Original-Commit-Position: refs/heads/master@{#42244} Committed: https://chromium.googlesource.com/v8/v8/+/3169fb94c98953f002908974a606b51a35178046 Review-Url: https://codereview.chromium.org/2624813002 Cr-Commit-Position: refs/heads/master@{#42300}
-
- 12 Jan, 2017 5 commits
-
-
bradnelson authored
Revert of [wasm][asm.js] Disable success messages for asm.js (patchset #2 id:20001 of https://codereview.chromium.org/2628703003/ ) Reason for revert: Trigger flaky test. Original issue's description: > [wasm][asm.js] Disable success messages for asm.js > > These interfere with layout tests. > > BUG=v8:4203 > R=titzer@chromium.org,jochen@chromium.org > > Review-Url: https://codereview.chromium.org/2628703003 > Cr-Commit-Position: refs/heads/master@{#42241} > Committed: https://chromium.googlesource.com/v8/v8/+/9e60e7ac365d45f3211314f1ecff395f418de770 TBR=jochen@chromium.org,titzer@chromium.org,bradnelson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4203 Review-Url: https://codereview.chromium.org/2629033003 Cr-Commit-Position: refs/heads/master@{#42254}
-
bradnelson authored
Revert of [wasm][asm.js] Do same work even when not printing asm info. (patchset #1 id:1 of https://codereview.chromium.org/2629043002/ ) Reason for revert: Triggers flaky tests. Original issue's description: > [wasm][asm.js] Do same work even when not printing asm info. > > Skipping this work seems to perturb a gc-stress issue. > More investigation is likely needed. > > BUG=v8:4203 > R=danno@chromium.org > > Review-Url: https://codereview.chromium.org/2629043002 > Cr-Commit-Position: refs/heads/master@{#42248} > Committed: https://chromium.googlesource.com/v8/v8/+/785cedf1ee6671399c2b2b7f6c6a8119f55195b4 TBR=danno@chromium.org,bradnelson@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4203 Review-Url: https://codereview.chromium.org/2623383002 Cr-Commit-Position: refs/heads/master@{#42252}
-
bradnelson authored
Reland of [wasm][asm.js] Do same work even when not printing asm info. (patchset #1 id:1 of https://codereview.chromium.org/2627223002/ ) Reason for revert: Triggers flaky tests. Original issue's description: > Revert of [wasm][asm.js] Do same work even when not printing asm info. (patchset #1 id:1 of https://codereview.chromium.org/2629043002/ ) > > Reason for revert: > Triggers flaky tests. > > Original issue's description: > > [wasm][asm.js] Do same work even when not printing asm info. > > > > Skipping this work seems to perturb a gc-stress issue. > > More investigation is likely needed. > > > > BUG=v8:4203 > > R=danno@chromium.org > > > > Review-Url: https://codereview.chromium.org/2629043002 > > Cr-Commit-Position: refs/heads/master@{#42248} > > Committed: https://chromium.googlesource.com/v8/v8/+/785cedf1ee6671399c2b2b7f6c6a8119f55195b4 > > TBR=danno@chromium.org,bradnelson@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4203 > > Review-Url: https://codereview.chromium.org/2627223002 > Cr-Commit-Position: refs/heads/master@{#42250} > Committed: https://chromium.googlesource.com/v8/v8/+/636df54873c966eceed4264cabc2360b76221e26 TBR=danno@chromium.org,bradnelson@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4203 Review-Url: https://codereview.chromium.org/2626953003 Cr-Commit-Position: refs/heads/master@{#42251}
-
bradnelson authored
Revert of [wasm][asm.js] Do same work even when not printing asm info. (patchset #1 id:1 of https://codereview.chromium.org/2629043002/ ) Reason for revert: Triggers flaky tests. Original issue's description: > [wasm][asm.js] Do same work even when not printing asm info. > > Skipping this work seems to perturb a gc-stress issue. > More investigation is likely needed. > > BUG=v8:4203 > R=danno@chromium.org > > Review-Url: https://codereview.chromium.org/2629043002 > Cr-Commit-Position: refs/heads/master@{#42248} > Committed: https://chromium.googlesource.com/v8/v8/+/785cedf1ee6671399c2b2b7f6c6a8119f55195b4 TBR=danno@chromium.org,bradnelson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4203 Review-Url: https://codereview.chromium.org/2627223002 Cr-Commit-Position: refs/heads/master@{#42250}
-
bradnelson authored
Skipping this work seems to perturb a gc-stress issue. More investigation is likely needed. BUG=v8:4203 R=danno@chromium.org Review-Url: https://codereview.chromium.org/2629043002 Cr-Commit-Position: refs/heads/master@{#42248}
-
- 11 Jan, 2017 1 commit
-
-
bradnelson authored
These interfere with layout tests. BUG=v8:4203 R=titzer@chromium.org,jochen@chromium.org Review-Url: https://codereview.chromium.org/2628703003 Cr-Commit-Position: refs/heads/master@{#42241}
-
- 10 Jan, 2017 1 commit
-
-
bradnelson authored
Asm.js warnings / info is non-canonical. It may be useful to suppress it in golden file tests (for instance LayoutTests). BUG=v8:4203 R=mtrofin@chromium.org Review-Url: https://codereview.chromium.org/2625833003 Cr-Commit-Position: refs/heads/master@{#42204}
-
- 20 Dec, 2016 2 commits
-
-
titzer authored
R=clemensh@chromium.org CC=rossberg@chromium.org BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2591753002 Cr-Commit-Position: refs/heads/master@{#41866}
-
clemensh authored
The new object will hold information which is shared by all clones of a WasmCompiledModule, e.g. the decoded asm.js offset table, and in the future also breakpoints. From there, we can set them on each new instantiation of any clone. While already changing lots of the code base, I also renamed all getters from "get_foo" to "foo", to conform to the style guide. R=titzer@chromium.org, yangguo@chromium.org BUG=v8:5732 Review-Url: https://codereview.chromium.org/2591653002 Cr-Commit-Position: refs/heads/master@{#41862}
-
- 19 Dec, 2016 1 commit
-
-
jochen authored
BUG=chromium:675114 R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2583113002 Cr-Commit-Position: refs/heads/master@{#41796}
-
- 14 Dec, 2016 2 commits
-
-
bradnelson authored
Printing an asm.js success message and timings is useful, but also non-deterministic. Making the message stable unless a flag is passed. This will avoid making it a hassle in the future to create LayoutTests that use asm.js and verify console output. BUG=v8:4203 R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2574273002 Cr-Commit-Position: refs/heads/master@{#41700}
-
bradnelson authored
Adding timing info going to the console about asm.js Rename ConvertAsmToWasm -> CompileAsmViaWasm, to be more precise. Add enum for wasm data elements. BUG=v8:4203 R=titzer@chromium.org,yangguo@chromium.org Review-Url: https://codereview.chromium.org/2577453003 Cr-Commit-Position: refs/heads/master@{#41695}
-
- 12 Dec, 2016 1 commit
-
-
bradnelson authored
Generalize Messages to include an error level. Add a parameter to AddMessageHandler to select which error levels to receive, using a mask (default being just errors, i.e. the current behavior). BUG=v8:4203 R=dgozman@chromium.org,machenbach@chromium.org,danno@chromium.org,bmeurer@chromium.org,jochen@chromium.org Review-Url: https://codereview.chromium.org/2526703002 Cr-Commit-Position: refs/heads/master@{#41648}
-
- 06 Dec, 2016 1 commit
-
-
bradnelson authored
The asm-wasm-builder started allocating SharedFunctionInfos, this makes it bad we'd passed Script by pointer (due to ignorance). Switching to Handle<Script>. R=clemensh@chromium.org,titzer@chromium.org BUG=v8:5716 Review-Url: https://codereview.chromium.org/2552873003 Cr-Commit-Position: refs/heads/master@{#41529}
-
- 30 Nov, 2016 1 commit
-
-
bradnelson authored
Make the AsmWasmBuilder drive the process of typing and potentially parsing function bodies. This will allow us to keep only a single asm.js function's AST in memory as we convert to WebAssembly. This is needed to keep our memory footprint low. Add some additional output to a few tests that's helpful to see which stage they fail at. BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 LOG=N R=marja@chromium.org,adamk@chromium.org,aseemgarg@chromium.org,titzer@chromium.org Review-Url: https://codereview.chromium.org/2398023002 Cr-Commit-Position: refs/heads/master@{#41372}
-
- 22 Nov, 2016 1 commit
-
-
clemensh authored
We had error messages that exceeded the current limit of 100 characters, resulting in the newline being cut off. This CL also reverts http://crrev.com/2503423006 since it did not fix this issue. BUG=chromium:660016 R=machenbach@chromium.org, titzer@chromium.org Review-Url: https://codereview.chromium.org/2523703002 Cr-Commit-Position: refs/heads/master@{#41192}
-
- 17 Nov, 2016 1 commit
-
-
clemensh authored
This hopefully avoids multiple error messages appearing on the same line. R=titzer@chromium.org, machenbach@chromium.org BUG=chromium:660016 Review-Url: https://codereview.chromium.org/2503423006 Cr-Commit-Position: refs/heads/master@{#41070}
-
- 11 Nov, 2016 1 commit
-
-
titzer authored
This CL moves all heap-allocated WASM data structures, both ones that are bonafide JSObjects and ones that are FixedArrays only, into a consistent place with consistent layout. Note that not all accessors are complete, and I haven't fully spread the new static typing goodness to all places in the code. R=ahaas@chromium.org,rossberg@chromium.org CC=gdeepti@chromium.org,mtrofin@chromium.org,clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2490663002 Cr-Commit-Position: refs/heads/master@{#40913}
-
- 12 Oct, 2016 1 commit
-
-
clemensh authored
For the asm.js to WASM pipeline, the current stack traces only show low-level WASM information. This CL maps this back to asm.js source positions. It does so by attaching the asm.js source Script to the compiled WASM module, and emitting a delta-encoded table which maps from WASM byte offsets to positions within that Script. As asm.js code does not throw exceptions, we only store a mapping for call instructions. The new AsmJsWasmStackFrame implementation inherits from WasmStackFrame, but contains the logic to provide the source script and the position inside of it. What is still missing is the JSFunction object returned by CallSite.getFunction(). We currently return null. R=jgruber@chromium.org, titzer@chromium.org BUG=v8:4203 Review-Url: https://codereview.chromium.org/2404253002 Cr-Commit-Position: refs/heads/master@{#40205}
-
- 29 Sep, 2016 1 commit
-
-
titzer authored
R=bradnelson@chromium.org,mtrofin@chromium.org,mstarzinger@chromium.org BUG= Review-Url: https://codereview.chromium.org/2383463002 Cr-Commit-Position: refs/heads/master@{#39861}
-
- 27 Sep, 2016 1 commit
-
-
titzer authored
[0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 Review-Url: https://codereview.chromium.org/2345593003 Cr-Original-Commit-Position: refs/heads/master@{#39678} Cr-Commit-Position: refs/heads/master@{#39795}
-
- 23 Sep, 2016 2 commits
-
-
machenbach authored
Revert of [wasm] Master CL for Binary 0xC changes. (patchset #26 id:490001 of https://codereview.chromium.org/2345593003/ ) Reason for revert: Main suspect for tsan: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/11893 Also changes layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/10036 +mips builder: https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder/builds/4032 Original issue's description: > [wasm] Master CL for Binary 0xC changes. > > [0xC] Convert to stack machine semantics. > [0xC] Use section codes instead of names. > [0xC] Add elements section decoding. > [0xC] Decoding of globals section. > [0xC] Decoding of memory section. > [0xC] Decoding of imports section. > [0xC] Decoding of exports section. > [0xC] Decoding of data section. > [0xC] Remove CallImport bytecode. > [0xC] Function bodies have an implicit block. > [0xC] Remove the bottom label from loops. > [0xC] Add signatures to blocks. > [0xC] Remove arities from branches. > Add tests for init expression decoding. > Rework compilation of import wrappers and how they are patched. > Rework function indices in debugging. > Fix ASM->WASM builder for stack machine. > Reorganize asm.js foreign functions due to import indices change. > > R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org > BUG=chromium:575167 > LOG=Y > > Committed: https://crrev.com/76eb976a67273b8c03c744f64ad850b0432554b9 > Cr-Commit-Position: refs/heads/master@{#39678} TBR=ahaas@chromium.org,bradnelson@chromium.org,mtrofin@chromium.org,rossberg@chromium.org,bradnelson@google.com,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2361053004 Cr-Commit-Position: refs/heads/master@{#39685}
-
titzer authored
[0xC] Convert to stack machine semantics. [0xC] Use section codes instead of names. [0xC] Add elements section decoding. [0xC] Decoding of globals section. [0xC] Decoding of memory section. [0xC] Decoding of imports section. [0xC] Decoding of exports section. [0xC] Decoding of data section. [0xC] Remove CallImport bytecode. [0xC] Function bodies have an implicit block. [0xC] Remove the bottom label from loops. [0xC] Add signatures to blocks. [0xC] Remove arities from branches. Add tests for init expression decoding. Rework compilation of import wrappers and how they are patched. Rework function indices in debugging. Fix ASM->WASM builder for stack machine. Reorganize asm.js foreign functions due to import indices change. R=ahaas@chromium.org,rossberg@chromium.org,bradnelson@chromium.org BUG=chromium:575167 LOG=Y Review-Url: https://codereview.chromium.org/2345593003 Cr-Commit-Position: refs/heads/master@{#39678}
-
- 19 Sep, 2016 1 commit
-
-
bradnelson authored
Handle the case of asm.js modules that return a single function instead of a collection of them. R=mtrofin@chromium.org TEST=mjsunit/asm/asm-wasm BUG=v8:4203 BUG=v8:5356 Review-Url: https://codereview.chromium.org/2348383003 Cr-Commit-Position: refs/heads/master@{#39515}
-
- 12 Sep, 2016 1 commit
-
-
mtrofin authored
Moved the compilation/instantiation pipeline to work off the module object (JSObject), making the compiled module data (the FixedArray) an implementation detail. This: - simplifies the code by removing duplicate decode->compile->instantiate sequences - sets up the stage for "dressing up" the runtime model with stronger typed APIs - helps relanding this CL: https://codereview.chromium.org/2305903002/. It turns out that GCs during the cloning/instantiation events cause trouble, and centering the source of truth on the module object helps address this issue. In the process, clarified cctest setup for wasm-capable isolates, and changed signatures for consistency (using ModuleOrigin througout). BUG= Review-Url: https://codereview.chromium.org/2320723005 Cr-Commit-Position: refs/heads/master@{#39360}
-
- 01 Sep, 2016 1 commit
-
-
mtrofin authored
This unblocks avoiding the separate code template. In the upcoming CL doing away with code templates, We need to track instances through the module object, which needs to be separate from the compiled module data, which is then shared with the first instance. This CL ensures we have the object available in the asm.js scenario, too. Note that this CL also unifies the error messaging when module decoding fails. BUG=v8:5316 Review-Url: https://codereview.chromium.org/2299873002 Cr-Commit-Position: refs/heads/master@{#39097}
-
- 23 Aug, 2016 1 commit
-
-
bradnelson authored
Make use of %IsAsmWasmCode in place of Wasm.instantiateModuleFromAsm, in order to reduce the surface area of the Wasm object, and to focus on testing asm.js coming in via the parser. Ignore extra CONST_LEGACY assignment introduced by the parser when modules have the form: (function Foo(a, b, c) {..}); This requires both a validator and AsmWasmBuilder change. Move stdlib use collection to import time, to reject modules that import a function, even if not used. BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 LOG=N R=jpp@chromium.org,titzer@chromium.org Review-Url: https://codereview.chromium.org/2264913002 Cr-Commit-Position: refs/heads/master@{#38806}
-
- 22 Aug, 2016 2 commits
-
-
bradnelson authored
Check remaining asm.js stdlib functions for validitity at instatiation. Fail when a member is referenced, even if not used. BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 LOG=N R=jpp@chromium.org,titzer@chromium.org Review-Url: https://codereview.chromium.org/2267633002 Cr-Commit-Position: refs/heads/master@{#38796}
-
marja authored
This makes us able to get rid of dependencies to parser.h from places which only need the ParseInfo, and also gets rid of the curious Parser <-> Compiler circular dependency. Also IWYUd where necessary. BUG= Review-Url: https://codereview.chromium.org/2268513002 Cr-Commit-Position: refs/heads/master@{#38777}
-
- 19 Aug, 2016 1 commit
-
-
bradnelson authored
Record which asm.js stdlib members are used and add a check that NaN is actually correctly set. Other stdlib members to be added in a later change. Also add a stdlib argument to Wasm.instantiateModuleFromAsm, in preparation for that function to be replaced by normal asm.js instantiation. BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 LOG=N R=jpp@chromium.org,titzer@chromium.org Review-Url: https://codereview.chromium.org/2251433002 Cr-Commit-Position: refs/heads/master@{#38760}
-
- 18 Aug, 2016 1 commit
-
-
marja authored
Rebuilding (after touching certain files) is crazy slow because includes are out of control. Fixing it: - Don't include stuff in headers unless necessary. - Include the stuff you need, not some other stuff that happens to include the stuff you need. BUG=v8:5294 Review-Url: https://codereview.chromium.org/2246203005 Cr-Commit-Position: refs/heads/master@{#38708}
-
- 14 Jul, 2016 1 commit
-
-
mtrofin authored
Implemented the WebAssembly.Module and WebAssembly.Instance in terms of the WasmModule::CompileFunctions and WasmModule::Instantiate APIs. Added negative tests - for invalid module object. BUG= Review-Url: https://codereview.chromium.org/2121593002 Cr-Commit-Position: refs/heads/master@{#37775}
-
- 13 Jul, 2016 1 commit
-
-
jpp authored
BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 TEST=mjsunit/wasm/* LOG=N Review-Url: https://codereview.chromium.org/2134333003 Cr-Commit-Position: refs/heads/master@{#37729}
-