[asmjs] Avoid truncation of error messages

We had error messages that exceeded the current limit of 100
characters, resulting in the newline being cut off.
This CL also reverts http://crrev.com/2503423006 since it did not fix
this issue.

BUG=chromium:660016
R=machenbach@chromium.org, titzer@chromium.org

Review-Url: https://codereview.chromium.org/2523703002
Cr-Commit-Position: refs/heads/master@{#41192}

src/asmjs/asm-js.cc

@@ -157,8 +157,7 @@ MaybeHandle<FixedArray> AsmJs::ConvertAsmToWasm(ParseInfo* info) {
                        info->literal());
   if (!typer.Validate()) {
     DCHECK(!info->isolate()->has_pending_exception());
-    PrintF("Validation of asm.js module failed: %s", typer.error_message());
-    Flush();
+    PrintF("Validation of asm.js module failed: %s\n", typer.error_message());
     return MaybeHandle<FixedArray>();
   }
   v8::internal::wasm::AsmWasmBuilder builder(info->isolate(), info->zone(),

src/asmjs/asm-typer.cc

@@ -25,7 +25,7 @@
                    ? -1                                        \
                    : script_->GetLineNumber(node->position()); \
     base::OS::SNPrintF(error_message_, sizeof(error_message_), \
-                       "asm: line %d: %s\n", line + 1, msg);   \
+                       "asm: line %d: %s", line + 1, msg);     \
     return AsmType::None();                                    \
   } while (false)
 

src/asmjs/asm-typer.h

@@ -346,7 +346,7 @@ class AsmTyper final {
   std::uintptr_t stack_limit_;
   bool stack_overflow_ = false;
   ZoneMap<AstNode*, AsmType*> node_types_;
-  static const int kErrorMessageLimit = 100;
+  static const int kErrorMessageLimit = 128;
   AsmType* fround_type_;
   AsmType* ffi_type_;
   char error_message_[kErrorMessageLimit];