- 07 Jan, 2020 1 commit
-
-
Sigurd Schneider authored
This CL improves whitespace precision of coverage around try blocks; previously a small portion of whitespace could be reported as uncovered between try blocks and catch and/or finally blocks. Change-Id: I763ae3d15106c88f2278cf8893c12b0869a62528 Fixed: v8:10030 Bug: v8:10030 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1962265Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#65593}
-
- 02 Jan, 2020 2 commits
-
-
Joshua Litt authored
The native context can differ from the current isolates raw_native_context, so this DCHECK was never valid. Bug: chromium:1033966 Change-Id: Iecbbdf33a8645ffd6e8768f4ba0eb0292eca269f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1982582Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Joshua Litt <joshualitt@chromium.org> Cr-Commit-Position: refs/heads/master@{#65577}
-
Peter Marshall authored
This reverts commit 6ce3046e. Reason for revert: Flaky test failures, see flako run: https://ci.chromium.org/p/v8/builders/try.triggered/v8_flako/b8893085619399726256 Original change's description: > [wasm] Add support to tier down/up Wasm NativeModule > > This is the first part of switching between Liftoff and Turbofan in > debugging Wasm. In this CL, we implemented the logic to tier down/up all > functions in module. > > Bug: v8:9654 > Change-Id: Ia25103ca29963afa103c124ff5f159f197c2b2b0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1970470 > Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65529} TBR=clemensb@chromium.org,bmeurer@chromium.org,duongn@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:9654, v8:10086 Change-Id: I44a4c2bde87ba5e4e83859e3e3c96103249b585f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1981501 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#65573}
-
- 26 Dec, 2019 1 commit
-
-
Joshua Litt authored
Fixes a potential overflow when using the runtime's StringCompareSequence by checking the string length first. Bug: chromium:1032906 Change-Id: I7cb94473ae8331dd2ecf1fa98034829bebf8a9ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1973936 Commit-Queue: Joshua Litt <joshualitt@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#65558}
-
- 20 Dec, 2019 1 commit
-
-
Tobias Tebbi authored
This reverts commit 91e3243d. Reason for revert: This deopts to the wrong point. Original change's description: > Extend GetIterator bytecode to perform JSReceiver check on object[Symbol.iterator]() > > Current GetIterator bytecode loads and calls @@iterator property on a > given object. This change extends the bytecode functionality to check > whether the value returned after calling @@iterator property is a valid > JSReceiver. The bytecode throws SymbolIteratorInvalid exception if the > returned value is not a valid JSReceiver. This change absorbs the > functionality of additional two bytecodes - JumpIfJSReceiver and > CallRuntime, that are part of the iterator protocol in the GetIterator > bytecode. > > Bug: v8:9489 > Change-Id: I9e84cfe85eeb9a1b8a97ca0595375ac26ba1bbfd > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1792905 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Commit-Queue: Swapnil Gaikwad <swapnilgaikwad@google.com> > Cr-Commit-Position: refs/heads/master@{#63704} TBR=rmcilroy@chromium.org,leszeks@chromium.org,tebbi@chromium.org,swapnilgaikwad@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:9489 Change-Id: I9324b5b01ead29912ad793a1e7b4d009643d7901 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1960288Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#65541}
-
- 19 Dec, 2019 4 commits
-
-
Shu-yu Guo authored
Change unregister tokens to be held weakly instead of strongly. This enables the use case for an object to be used as its own unregister token. To avoid using an ephemeron table, FinalizationGroup's key_map is changed to key off unregister tokens' identity hashes. Because hashes may collide, a single key list may rarely contain multiple tokens. When a FinalizationGroup WeakCell's token becomes unreachable, during GC, it is removed from the the doubly linked key list and removed from the key map if it had a unique key. Bug: v8:8179 Change-Id: If88fd2ab196e3f9a287990ae345117a0abb2f04d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1970493 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#65532}
-
Z Nguyen-Huu authored
This is the first part of switching between Liftoff and Turbofan in debugging Wasm. In this CL, we implemented the logic to tier down/up all functions in module. Bug: v8:9654 Change-Id: Ia25103ca29963afa103c124ff5f159f197c2b2b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1970470 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65529}
-
Shu-yu Guo authored
The spec was normatively changed to simplify var scopes for parameter expressions. Previously there was a per-parameter var scope in sloppy mode so direct evals could introduce vars that did not escape the parameter position. That semantics is complex both for the programmer and implementation and has resulted in bugs in the past. Furthermore, it has never been fully interoperable (with Safari in particular). The spec was instead changed to be simpler: to have a single var scope for sloppy evals in parameters that encloses the parameter scope and body scope. This simplification lets us remove expression-scope-reparenter. Drive-by removal of stale reference to PatternRewriter. Bug: v8:7532 Change-Id: Iade5594abe0009f7f3f6a1adad18628b17e1e779 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1962471Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#65517}
-
Igor Sheludko authored
... in object literals. Bug: chromium:1034973 Change-Id: Ie357eef4c46f87486f2c3756ba1c288ad25a93df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1974070Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#65515}
-
- 18 Dec, 2019 4 commits
-
-
Maya Lekova authored
Fixed: chromium:1035331 Change-Id: I6ef31910b2e22e4687412c45cc14c98669c6bd3f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1973733Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#65502}
-
Thibaud Michaud authored
This is a reland of c509bb8c Original change's description: > Cache native modules in the wasm engine by their wire bytes. This is to > prepare for sharing {Script} objects between multiple {WasmModuleObject} > created from the same bytes. This also saves unnecessary compilation > time and memory. > > R=clemensb@chromium.org > > Bug: v8:6847 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1916603 > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65296} R=clemensb@chromium.org Bug: v8:6847 Change-Id: I8839c9ec96dc4141cf3c30916a62ccf86f5463ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1960287 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65500}
-
Clemens Backes authored
This reverts commit cb2090cd. Reason for revert: Still fails with custom snapshot: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/29200 Original change's description: > [test] Enable compiler/deopt-array-builtins on gc_stress > > Bug: v8:10035 > Change-Id: I296e6b8a087e081d2f4d2fa15067e755e2ee3585 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1970212 > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Commit-Queue: Mythri Alle <mythria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65493} TBR=mythria@chromium.org,mslekova@chromium.org Change-Id: I4d7c1537136ed1d5c42f7a7c6c94db8987c9b9ec No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10035 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1973734Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65496}
-
Mythri A authored
Bug: v8:10035 Change-Id: I296e6b8a087e081d2f4d2fa15067e755e2ee3585 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1970212Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#65493}
-
- 17 Dec, 2019 6 commits
-
-
Maya Lekova authored
Add a --max-serializer-nesting flag which defaults to 25. Fixed: chromium:1034768 Change-Id: Ib68f26ce4bf53db297b25d16a046d275beaec642 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1969895 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#65486}
-
Maya Lekova authored
Bug: chromium:1034203 Change-Id: I225fa6416d443802b063e149da6e6fca0a176bb1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1969898 Auto-Submit: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#65479}
-
Clemens Backes authored
If --perf-prof is specified, we commit the whole code range at once, and never update the {total_committed_code_space_} counter (see {WasmCodeManager::Commit} and {WasmCodeManager::Decommit}). Hence we should also not decrement that counter when the native module dies. R=jkummerow@chromium.org Bug: chromium:1032753 Change-Id: I9a40f1a1322485d7142ed56f5c9365305aa0e056 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1969790Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65476}
-
Toon Verwaest authored
Objects in arrays take the shape of the object right before as feedback to speed up object creation. If a subsequent object with the same shape has a member that also has the same shape, that member can cause the feedback map to be deprecated. To avoid confusion, we now update (dedeprecate) the feedback map before use. Thanks a bunch Seth Brenith for figuring out the issue! Bug: chromium:1029077 Change-Id: I047b1acfd4906616a2302f253ab9cd29272bdc79 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1970211 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#65474}
-
Mythri A authored
In this test we expect that the feedback vector is not flushed so we retain what we have learnt from the earlier executions. If we flush the earlier feedback the code might deoptimize again and the test fails. Hence adding --no-stress-flush-bytecode and --no-flush-bytecode flags. Bug: v8:10035 Change-Id: Ia71748e83d64a731f595fed7f5b85a8dafa2b31a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1969850 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#65472}
-
Maya Lekova authored
MapRef::GetStrongValue now returns an Optional to account for the case where we can't figure out the name of the bound function during serialization. We could reach out to the heap in the future in this case. Fixed: chromium:1034203 Change-Id: I9fa81921b5dbd8bc9f68aa3c10921bc01b695a6b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1967386Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#65470}
-
- 16 Dec, 2019 1 commit
-
-
Clemens Backes authored
The {cmp} instruction might add an entry to the constant pool at a time where we didn't expect any entries to be added. This can be fixed by moving the {CheckConstPool} call *after* the {cmp}. R=mslekova@chromium.org Bug: chromium:1034394 Change-Id: If075ad0b02e2973a734d70d9e58c205bd14e6a33 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1967380Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65463}
-
- 13 Dec, 2019 1 commit
-
-
Michael Starzinger authored
R=clemensb@chromium.org Change-Id: Ibd6790a222590fd4dce9f918219a19f01c2e1e0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1960293Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#65439}
-
- 12 Dec, 2019 2 commits
-
-
Nico Hartmann authored
Bug: chromium:1029530 Change-Id: I12aa4c238387f6a47bf149fd1a136ea83c385f4b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1962278 Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#65434}
-
Mythri A authored
With bytecode flushing and the current OSR triggering mechanism which stores OSR nesting level on bytecode array it is possible to trigger OSR on a closure that doesn't have feedback vector. Bug: chromium:1031479 Change-Id: I4c62486f6b0eb6d6f9c96f98c1c1b275f3e6d6d5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1962850 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#65431}
-
- 11 Dec, 2019 3 commits
-
-
Toon Verwaest authored
This reverts commit 3b753563. Reason for revert: breaks in multiple places: https://bugs.chromium.org/p/chromium/issues/detail?id=1029368 https://bugs.chromium.org/p/chromium/issues/detail?id=1029361 Original change's description: > Reland "[runtime] Cache prototype chain enumerable keys in PrototypeInfo" > > This is a reland of 5253d7bf > > Original change's description: > > [runtime] Cache prototype chain enumerable keys in PrototypeInfo > > > > This CL adds a prototype_chain_enum_cache to cache the enumeration of a > > prototype and its entire chain on the PrototypeInfo. It can improve for-in > > performance via simply merging the receiver enumeration with this cache. > > > > It improves the score of JetStream2-tagcloud-SP case by ~9% on IA Chromebook. > > > > Contributed by tao.pan@intel.com > > > > Change-Id: Ib40bfe41e772672337155584672f06fa1ba1e70d > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1870844 > > Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> > > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#65224} > > Change-Id: I93b74727c46abbaab163324c50fbd977fcc9bb36 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955232 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> > Cr-Commit-Position: refs/heads/master@{#65377} TBR=verwaest@chromium.org,shiyu.zhang@intel.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I5b0d544e802ffda6a6804931087f37cb112805ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1962273Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#65418}
-
Deepti Gandluri authored
Bug: chromium:1027441 Change-Id: Ieac67e06aebf57a11327cbd34dd31f62cbe540b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1957847 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65415}
-
Thibaud Michaud authored
Check aliased FP registers when constructing the {to_be_live} set from multiple predecessors. R=sigurds@chromium.org Bug: chromium:1029642 Change-Id: I3db7b705ad5689bd8321aebc5e9c5f364951870b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1958054Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#65412}
-
- 09 Dec, 2019 3 commits
-
-
Leszek Swirski authored
We use the compilation entry point as a caching scope for deserializing lookups, to avoid redundantly iterating over parent scopes when accessing the same variable multiple times. However, this caching scope messes with lookups that are looking for lexical name conflicts, as opposed to just resolving variables. In particular, it messes with name conflict lookups and sloppy block function hoisting checks, when there are other scopes in the way, e.g. function f() { let x; try { throw 0; } catch (x) { // This catch is the entry scope // Naive use of caches will find the catch-bound x (which is // a VAR), and declare 'no conflict'. eval("var x;"); // Naive use of caches will find the catch-bound x (which is // a VAR), and determine that this function can be hoisted. eval("{ function x() {} }"); } } Previously, we worked around this by avoiding cache uses for these lookups, but this had the issue of instead caching the same variable multiple times, on different scopes. In particular, we saw: function f() { with ({}) { // This with is the entry scope, any other scope would do // though. // The conflict check on `var f` caches the function name // variable on the function scope, the subsequent 'real' // lookup of `f` caches the function name variable on the // entry i.e. with scope. eval("var f; f;"); } } With this patch, we change the caching behaviour to cache on the first non-eval declaration scope above the eval -- in the above examples, this becomes the parent function "f". For compilations with no intermediate non-decl scopes (no with or catch scopes between the function and eval) this becomes equivalent to the existing entry-point-based caching. This means that normal lookups do have to (sometimes) iterate more scopes, and we do have to be careful when using the cache to not use it for lookups in these intermediate scopes (a new IsOuterScope DCHECK guards against this), but we can now safely ignore the cache scope when doing the name-collision lookups, as they only iterate up to the outer non-eval declaration scope anyway. Bug: chromium:1026603 Bug: chromium:1029461 Change-Id: I9e7a96ce4b8adbc7ed47a49fba6fba58b526235b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955731 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#65391}
-
Leszek Swirski authored
This reverts commit 026a0c21. Reason for revert: Reverting due to https://crbug.com/1029461 Original change's description: > [parser] Fix variable caching for conflict lookup > > During conflict lookup (for lexical variables and sloppy block function > hoisting), we cache the looked-up variable on the current scope if the > lookup goes through a ScopeInfo. However, for variable lookup during > scope analysis, we use the "entry point" as the cache. > > Since both lookups can create Variables, this can cause us to create > duplicate variables, e.g. a duplicate function name variable in the > attached test. > > Instead, for ScopeInfo conflict lookups we can cache the result on the > function's outer scope, which shoud be equivalent to the entry point. > > As a (necessary) drive-by, we can terminate the lookup early if we find > a VAR with the same name, as we can safely assume that its existence > means that it doesn't conflict, which means that our variable can't > conflict either. > > Bug: chromium:1026603 > Change-Id: I19f80f65597ba6573ebe0b48aa5698f55e5c3ea1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1928861 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65138} TBR=leszeks@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1026603 Bug: chromium:1029461 Change-Id: Id7f5dd342e32e1bb57c51b3748feff32ee0ba41d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1958014Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#65390}
-
Zhang, Shiyu authored
This is a reland of 5253d7bf Original change's description: > [runtime] Cache prototype chain enumerable keys in PrototypeInfo > > This CL adds a prototype_chain_enum_cache to cache the enumeration of a > prototype and its entire chain on the PrototypeInfo. It can improve for-in > performance via simply merging the receiver enumeration with this cache. > > It improves the score of JetStream2-tagcloud-SP case by ~9% on IA Chromebook. > > Contributed by tao.pan@intel.com > > Change-Id: Ib40bfe41e772672337155584672f06fa1ba1e70d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1870844 > Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65224} Change-Id: I93b74727c46abbaab163324c50fbd977fcc9bb36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955232Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> Cr-Commit-Position: refs/heads/master@{#65377}
-
- 05 Dec, 2019 2 commits
-
-
Gus Caplan authored
In 5742da05, the toString property was accidentally applied to all NativeError prototypes, when it should only be inherited from Error.prototype. Refs: https://github.com/tc39/ecma262/issues/1794 Bug: v8:10017 Change-Id: I2af9a31f463deb9871dd7a4a5a2e4dd7485ed38c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1933054Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#65355}
-
Maya Lekova authored
Also make return and unconditional jumps kill the environment instead of clearing it. This was still leftover from before we introduced liveness and prevented sharing as well. Bug: v8:7790 Change-Id: Ic79d64c9eaedf608d26e3265d4b27d21f7f3dfe1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948710 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#65345}
-
- 04 Dec, 2019 5 commits
-
-
Maya Lekova authored
Bug: v8:10035 Change-Id: Ie4172d366a90b9d7ee2256aadc96835311775aac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1950970 Auto-Submit: Maya Lekova <mslekova@chromium.org> Commit-Queue: Francis McCabe <fgm@chromium.org> Reviewed-by:
Francis McCabe <fgm@chromium.org> Cr-Commit-Position: refs/heads/master@{#65338}
-
Maya Lekova authored
Bug: v8:10032 Change-Id: Iff7ea0ce0f60b734a6f97b5bde068fa30a4774af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1950484 Auto-Submit: Maya Lekova <mslekova@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#65330}
-
Michael Starzinger authored
This fixes the operation functions (i.e. WebIDL interface member and namespace member operations) for WebAssembly to not have 'prototype' properties and not be marked as constructors. R=ahaas@chromium.org TEST=mjsunit/wasm/js-api BUG=chromium:1027945 Change-Id: I4db753a9ca570b95c45cb033c36de65bcafafe8f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1950483Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#65329}
-
Maya Lekova authored
Bug: v8:7790 Change-Id: I75be15cae0b7ddc3ad5650008fdb3af0df7157f9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1950486 Commit-Queue: Maya Lekova <mslekova@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#65328}
-
Clemens Backes authored
Imports can also have associated names, and in fact we generate these names for asm.js. Thus in logging, just append this name to the generated signature. R=jkummerow@chromium.org Bug: chromium:1030103 Change-Id: I3969bcf8d1d17f4256b5a0643acdf8a24766f889 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948705 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#65321}
-
- 03 Dec, 2019 3 commits
-
-
Nico Hartmann authored
Bug: chromium:1029576 Change-Id: If647f764da2682a0f278b9b8060d0665fab1c40c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948711 Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#65312}
-
Emanuel Ziegler authored
The following changes were introduced with the recent proposal update: - OOB access with 0 length traps - Double drop of segments is allowed - Dropped segments are treated like having size 0 (OOB error) - Active segments are dropped right after initialization R=ahaas@chromium.org Change-Id: I4e9fc4d9212841c7d858585c672143f99287520d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1946355Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#65305}
-
Igor Sheludko authored
Bug: chromium:1029658 Change-Id: I4cb201bbf0a05d2673fcb8a5d19e34a969294c5e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1946335 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#65304}
-
- 02 Dec, 2019 1 commit
-
-
Jakob Kummerow authored
CSA::TryLookupElement must check the upper bound for dictionary-mode indices. The "stable map + accessor" branch of FastGetOwnValuesOrEntries must construct its LookupIterator such that it handles the named/indexed distinction correctly. Bug: chromium:1029338,chromium:1029369 Change-Id: I17e74ed24c260c5cfc20c61616e75db7d347f7a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943164 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#65301}
-