- 09 May, 2022 21 commits
-
-
Marja Hölttä authored
Builtins are not snapshotted, but instead we insert "builtin wrappers" into the snapshot, and create references to the corresponding builtin when deserializing. Subclassing builtins will be implemented in a follow-up CL. First version: https://chromium-review.googlesource.com/c/v8/v8/+/3630080 Fix: initialize builtin_objects_handle_ Bug: v8:11525,v8:12820 Change-Id: Ia2b5d41af5d7f577f1b02356b22a8760963009e4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3635718Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#80430}
-
henrika authored
Bug: v8:11043 Change-Id: I8cbdd8a5f68bdadbe7fc44414c6d46cdd57e6802 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3627512Reviewed-by:
-
Peter Kasting authored
Many uses of "volatile" are deprecated in C++20 because they don't actually do anything. Remove "volatile" in these cases. Bug: chromium:1284275 Change-Id: I64a3989d73f25e0cd933375dd6fa0b3f2b3acb54 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3630343 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#80428}
-
Camillo Bruni authored
In preparation of renaming i::CodeEventDispatcher to i::Logger Bug: v8:12795, chromium:1316443 Change-Id: I28e129130852d41cf5e464e083bc27cff97a0fff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3623543Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#80427}
-
Camillo Bruni authored
In the previous refactoring --filter was accidentally filtering out paths that matched <regexp>. This CL restores the original behavior where only the matching paths are kept. Bug: v8:12821, v8:11113 Change-Id: I7e7d7b793107fbf9b4944b1674874150803f4bb4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3623539 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#80426}
-
Clemens Backes authored
Multiple code spaces are cheaper on 32-bit systems, because we can directly call between them. Over-reservation on the other hand increases the chance for OOMs. Hence reduce the code space estimation (used for the initial reservation) on 32-bit systems. Numbers were obtained from an older Epic module, Photoshop, and AutoCAD. I'll keep an eye on the {V8.WasmModuleNumberOfCodeSpaces} counter. R=ahaas@chromium.org Change-Id: Ide804eaf46e8ba9bb48fcb41f23f1facc910645e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3634778 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Clemens Backes authored
This adds a typedef for LegacyOOMErrorCallback, which is identical to OOMErrorCallback. Embedders will need to switch to LegacyOOMErrorCallback so that we can change the definition of OOMErrorCallback (see https://crbug.com/1323177). R=mlippautz@chromium.org Bug: chromium:1323177 Change-Id: I92312a577ca49e0174f2bb6b914cc11c3a0b0fc1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3632305Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#80424}
-
jameslahm authored
This is a reland of https://chromium-review.googlesource.com/c/v8/v8/+/3607389. The previous revert is https://chromium-review.googlesource.com/c/v8/v8/+/3610448. Reason for revert: https://crbug.com/v8/12838. The original CL has merge conflicts and cannot be relanded, so this CL is newly opened. This CL moves cctest/test-log to unittests/logging/log-unittest , fixes the flaky tests in https://bugs.chromium.org/p/v8/issues/detail?id=12838 and updates the unittests status for log-unittest. Flaky Tests: - https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20stress-incremental-marking/7287/overview - flaky LogTest.Issue539892 is caused by in stress-incremental-marking mode, Heap::MarkCompact will trigger CodeMovingGCEvent in https://source.chromium.org/chromium/chromium/src/+/main:v8/src/heap/heap.cc;l=2586;drc=52f06e6b43ff95eccf79e0a5df8d4d83c029130a for FakeCodeEventLogger which was already destructed when Heap::PerformGarbageCollection task was handled in DefaultPlatform::PumpMessageLoop. This should be fixed by removing FakeCodeEventLogger in LogTest.Issue539892. - flaky LogTest.LogAccessorCallbacks is caused by the data race in Sampler::DoSample. This should be fixed in https://chromium- review.googlesource.com/c/v8/v8/+/3616429. -https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20TSAN/41327/overview - flaky LogTest.ExternalLogEventListenerWithInterpretedFramesNativeStack is caused by the data race of i::FLAG_* which were written again after setting up the isolate. This should be fixed by only writting i::FLAG_* before setting up the Isolate. - https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64/47277/overview - flaky LogTest.BuiltinsNotLoggedAsLazyCompile is caused by the data race in Sampler::DoSample. This should be fixed in https://chromium- review.googlesource.com/c/v8/v8/+/3616429. Bug: v8:12781 Change-Id: I3f736d4ffb3b8f147006bebe92285684b0c3952a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3616424Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: 王澳 <wangao.james@bytedance.com> Cr-Commit-Position: refs/heads/main@{#80423}
-
Clemens Backes authored
This reverts commit 71dbb03e. Reason for revert: gc-stress failures: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/38357 Original change's description: > [web snapshot] Recognize builtins > > Builtins are not snapshotted, but instead we insert "builtin wrappers" > into the snapshot, and create references to the corresponding builtin > when deserializing. > > Subclassing builtins will be implemented in a follow-up CL. > > Bug: v8:11525,v8:12820 > Change-Id: If72695d46bdfc8bf7e477471be1264b668551854 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3630080 > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Commit-Queue: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80419} Bug: v8:11525,v8:12820 Change-Id: I49f65103ad7b367c5bccb498f698e9afb29b1fec No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3634799 Auto-Submit: Clemens Backes <clemensb@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Owners-Override: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#80422}
-
jameslahm authored
... Profiler::Remove. In Profiler::Insert and Profiler::Remove, TSAN cannot figure out that when head_ and tail_ equals, Profiler::Insert will always execute before Profiler::Remove, and tsan will report data race between buffer_[head] write and buffer_[base::Relaxed_Load(&tail_)]. This CL changes the tail_ atomic load and store memory order to gurantee that buffer_ read and write always after and before tail_ load and store, which gives tsan more constraint. Bug: v8:12838 Change-Id: I50296ffa4606b288e9ad9edc15d42f21ca1c7d2a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3626454Reviewed-by:
-
Jakob Linke authored
New trace events: - finished OSR compilation. - entry into OSR code. Since the latter now happens without a trip into runtime, tracing is a bit more involved - we need to check FLAG_trace_osr in generated code, and call a runtime function if it is set. Drive-by: Slightly reorganize other OSR tracing. Bug: v8:12161 Change-Id: I3096424ca7d47a19802281a0e0a39f7f3394c12b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3629331 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Jakob Linke <jgruber@chromium.org> Commit-Queue: Jakob Linke <jgruber@chromium.org> Reviewed-by:
-
Marja Hölttä authored
Builtins are not snapshotted, but instead we insert "builtin wrappers" into the snapshot, and create references to the corresponding builtin when deserializing. Subclassing builtins will be implemented in a follow-up CL. Bug: v8:11525,v8:12820 Change-Id: If72695d46bdfc8bf7e477471be1264b668551854 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3630080Reviewed-by:
-
Camillo Bruni authored
There are currently several flags to tune V8's optimisation level: --sparkplug, --maglev, --opt This CL tries to make this simpler by introducing yet another flag. --max-opt limits the maximum optimisation tier and avoids the common error to mistake --no-opt with no dynamic optimisations. Settings: --max-opt=999 Allow all optimisations, default configuration. Any number > 3 will do, as long as no other tier will be added. --max-opt=0 Allow only ignition --max-opt=1 Allow up to sparkplug --max-opt=2 Allow up to maglev --max-opt=3 Allow up to turbofan Bug: v8:12825 Change-Id: Iff9a0fcccdf05e9770168053a1430303613a7299 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3605816 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:Jakob Linke <jgruber@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#80418}
-
Tobias Tebbi authored
Bug: chromium:1323114 Change-Id: I2ec6c7d5eb5ef08914cfc1fac52d0128ecb27c53 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3630081Reviewed-by:
-
Jakob Linke authored
Turn on fuzzing for Maglev to get additional test coverage. Bug: v8:7700 Change-Id: I5b72d851639e31dff1bd91361cd81ad448c2d69e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3629334 Auto-Submit: Jakob Linke <jgruber@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Anton Bikineev authored
Allocation granularity (8 bytes on 64bit platforms) is already subsumed by whatever range size we choose. Bug: chromium:1029379 Change-Id: Iab95e6f36955c9ffbbe9ea0c98cb9d1f8dd0337b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3629869Reviewed-by:
-
Patrick Thier authored
With the introduction of the StringForwardingTable, there are no concurrent transitions of strings happening anymore. - Remove String migration sentinel maps + helper methods - Remove CanMigrateInParallel() - Remove MigrateStringMapUnderLockIfNeeded() and simplify MakeThin() There is still unused code I didn't remove in this CL, as we might need it later for shared struct features: YIELD_PROCESSOR for spinlocks and Relaxed_Memcmp(). Bug: v8:12007 Change-Id: Iaa09ef93d2ee612e42cd73395a06eada22fe7dae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3629545 Commit-Queue: Patrick Thier <pthier@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7b99cdb..9c02936 Rolling v8/third_party/fuchsia-sdk/sdk: version:8.20220507.2.1..version:8.20220508.2.1 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Idf098b319032d00e79ef810dcdf0c0c6505e05b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3634008 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80413}
-
Frank Tang authored
Change kUTCTimeZoneIndex to int32_t from uint32_t And compare index against 0. Bug: v8:11544 Change-Id: Ib7dd55cab796d1d9a4b0e2869b098520265a04f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3632678 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/main@{#80412}
-
Lu Yahan authored
Change-Id: I824985690124c74c4287befb4e202100322758e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3629740 Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by:
ji qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#80411}
-
Lu Yahan authored
Port commit 738f4b69 Change-Id: I1f8e36f2db7a4b5a88a2fa5b726df1dfa997f28e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3631835 Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by:
-
- 08 May, 2022 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/3606e28..7b99cdb Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/778ecbc..0f76f22 Rolling v8/third_party/fuchsia-sdk/sdk: version:8.20220506.0.1..version:8.20220507.2.1 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Idc5476c9e69aecb4bf59088cab219a5ba3246889 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3631293 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80409}
-
- 07 May, 2022 3 commits
-
-
Liu Yu authored
Port commit bd22e3be Bug: v8:12284 Change-Id: I195bf1fd71161bcbeee798f7d8fc1f8f3c5a75e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3630581 Auto-Submit: Yu Liu <liuyu@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/main@{#80408}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a1147fb..3606e28 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/7979ffe..778ecbc Rolling v8/third_party/fuchsia-sdk/sdk: version:8.20220504.0.1..version:8.20220506.0.1 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/3e15bc0..cd2b9e3 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Id4bbc1ed926a4f3571378464ee5d21c527ea843a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3631292 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80407}
-
Frank Tang authored
Also add the basic version of GetIANATimeZoneEpochValue AO which only implement UTC. Verison to support other TimeZone will come later w/ intl work which depends on ICU. Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.timezone.prototype.getpossibleinstantsfor https://tc39.es/proposal-temporal/#sec-temporal-getianatimezoneepochvalue Bug: v8:11544 Change-Id: Ib603530d1c70f7a2b85691860a815d44b48eece2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3624980 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/main@{#80406}
-
- 06 May, 2022 15 commits
-
-
Frank Tang authored
This is a reland of commit 4251c285 Change the test262.status by moving test which passing on no_i18n but not on ALWAYS: 1) Change the [FAIL] of that test in the ALWAYS section to [SKIP]. 2) Add the same test the no_i18n section as [PASS] Original change's description: > [Temporal] Add TimeZone get*Transition and getPlainDateTimeFor > > Also add non-intl (only support UTC) version of AO: > GetIANATimeZoneNextTransition, GetIANATimeZonePreviousTransition > (support of other timezone in Intl will come later) > > Spec Text: > https://tc39.es/proposal-temporal/#sec-temporal.timezone.prototype.getplaindatetimefor > https://tc39.es/proposal-temporal/#sec-temporal.timezone.prototype.getnexttransition > https://tc39.es/proposal-temporal/#sec-temporal.timezone.prototype.getprevioustransition > https://tc39.es/proposal-temporal/#sec-temporal-getianatimezonenexttransition > https://tc39.es/proposal-temporal/#sec-temporal-getianatimezoneprevioustransition > > > Bug: v8:11544 > Change-Id: I17d5a60638dcd8543e5d9f22c6560b311f2f402a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3534450 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Adam Klein <adamk@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80383} Bug: v8:11544 Change-Id: Ieddadbc9d0708bda24f88dd2083b0dbe7dc1b9f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3632607 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Samuel Groß authored
This reverts commit 31d78380. Reason for revert: Appears to cause WebGL test failures. See https://crrev.com/c/3629696 Original change's description: > Reland "[sandbox] Enable sandboxed pointers on Desktop" > > This is a reland of commit 48481a67 > > Original change's description: > > [sandbox] Enable sandboxed pointers on Desktop > > > > Bug: chromium:1218005 > > Change-Id: I3df750ee9101779952d8b1ae630c4d3b7563084b > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3578645 > > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > > Commit-Queue: Samuel Groß <saelo@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#80376} > > Bug: chromium:1218005 > Change-Id: Iaf7bc81393da5c1381a361a9de129affaa019670 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3629348 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Samuel Groß <saelo@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80394} Bug: chromium:1218005 Change-Id: I09c12a1f8b0fe6f84fcef10e17ec95856dac3e62 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3630084Reviewed-by:
-
Junliang Yan authored
Change-Id: Iaef2492a49701d1cd57d0a90fba8e260f60e9739 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3632511Reviewed-by:
Milad Farazmand <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#80403}
-
Junliang Yan authored
Change-Id: I7ff756acb4cbd272d60fedd527e22d47dabaac52 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3632510 Commit-Queue: Junliang Yan <junyan@redhat.com> Reviewed-by:
-
Chong Gu authored
Bug: fuchsia:99205 Change-Id: If60cd1c0b24e7c52be82e4c2297b88d9d2482ef4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3630280 Auto-Submit: Chong Gu <chonggu@google.com> Reviewed-by:
-
Thibaud Michaud authored
R=clemensb@chromium.org CC=gdeepti@chromium.org Bug: v8:12284 Change-Id: Ied63b2c7b57210f2cf2e1580520405ce1be5dc33 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3625979Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#80400}
-
Frank Tang authored
This is a reland of commit 2b140a9f Original change's description: > [Temporal] Add Calendar.prototype.yearMonthFromFields > > Add AO: IsValidISOMonth, RegulateISOYearMonth, ISOYearMonthFromFields > Spec Text: > https://tc39.es/proposal-temporal/#sec-temporal-isvalidisomonth > https://tc39.es/proposal-temporal/#sec-temporal-regulateisoyearmonth > https://tc39.es/proposal-temporal/#sec-temporal-isoyearmonthfromfields > https://tc39.es/proposal-temporal/#sec-temporal.calendar.prototype.yearmonthfromfields > > > Bug: v8:11544 > Change-Id: I1baadbbe54fb0c3fd45750eddb13b790465c3a3b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3408773 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Adam Klein <adamk@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80384} Bug: v8:11544 Change-Id: Ic5831c7094cd235526d93010cd722110f2951d77 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3631706Reviewed-by:
-
Igor Sheludko authored
This reverts commit e8cac377. Reason for revert: breaking Mac arm64 bots Original change's description: > [rwx][mac] Enable fast W^X on Apple Silicon (M1) > > Bug: v8:12797 > Change-Id: I53bb803dd77db5bdd42b1a1b4b568e63857adf31 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3598861 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80396} Bug: v8:12797 Change-Id: Ieb31d44d40a3b7c4e0b8f3914fcb89346ee3e2f8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3630083 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Igor Sheludko <ishell@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80398}
-
Clemens Backes authored
The no_condition / kNoCondition not only has the flaw that it's a special case which represents an illegal / nonexisting condition, and thus needs special handling in all methods which get a condition as input (this check is often missing), it is also weird in that every negative condition value must be considered a "no condition". It turns out that this "no condition" is rarely used, and can easily be avoided by duplicating methods, or storing a {base::Optional<Condition>} instead (not needed anywhere yet). This is a follow-up to https://crrev.com/c/3629553. R=tebbi@chromium.org, pthier@chromium.org Bug: v8:12425 Change-Id: Id2270b1660fcb0aff0a8460961b57068ed1c3c73 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3632102Reviewed-by:Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/main@{#80397}
-
Igor Sheludko authored
Bug: v8:12797 Change-Id: I53bb803dd77db5bdd42b1a1b4b568e63857adf31 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3598861Reviewed-by:
-
Clemens Backes authored
Those conditions are rarely used and not properly supported everywhere. If needed, we should duplicate methods instead, or pass a {base::Optional<Condition>}. This is a follow-up to https://crrev.com/c/3629129. R=tebbi@chromium.org CC=sroettger@chromium.org Bug: v8:12425 Change-Id: Ia67c3d4f575b0f7dd0ae125971959cf68f2fefc7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3629553Reviewed-by: -
Samuel Groß authored
This is a reland of commit 48481a67 Original change's description: > [sandbox] Enable sandboxed pointers on Desktop > > Bug: chromium:1218005 > Change-Id: I3df750ee9101779952d8b1ae630c4d3b7563084b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3578645 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Samuel Groß <saelo@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80376} Bug: chromium:1218005 Change-Id: Iaf7bc81393da5c1381a361a9de129affaa019670 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3629348Reviewed-by:
-
Jakob Linke authored
Added IR members: For updating the interrupt budget: Jump, JumpLoop, Return and JumpFromInlined apply a delta to the interrupt budget. For OSR: JumpLoop needs its loop depth and the feedback slot (where cached OSR code lives). This CL also adds code to maintain the interrupt budget in ML code. Future tasks are documented in TODOs. Bug: v8:7700 Change-Id: I240dc3ea76a1e60fda45e1d39b0b5f57dd9c566b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3610423 Auto-Submit: Jakob Linke <jgruber@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Peter Kasting authored
This is deprecated in C++20. Use constexprs and explicit casts to work around. Bug: chromium:1284275 Change-Id: I6a3974f3c678cb797081938622036a12a99c5d1b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3630349 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Michael Lippautz authored
- Repurpose flag `treat_global_objects_as_roots` when taking a heap snapshot for toggling whether internals should be exposed (to `hide_internals`). - Use the toggle in creating heap snapshots for exposing class names as object names for C++ objects that have not explicitly been given a name. Change-Id: I77d71babfdfe53269964fe81ed985037a431c28b Bug: chromium:1321620 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3623740Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80391}
-
