Commit 91ab0528 authored by Samuel Groß's avatar Samuel Groß Committed by V8 LUCI CQ

Revert "Reland "[sandbox] Enable sandboxed pointers on Desktop""

This reverts commit 31d78380.

Reason for revert: Appears to cause WebGL test failures. See https://crrev.com/c/3629696

Original change's description:
> Reland "[sandbox] Enable sandboxed pointers on Desktop"
>
> This is a reland of commit 48481a67
>
> Original change's description:
> > [sandbox] Enable sandboxed pointers on Desktop
> >
> > Bug: chromium:1218005
> > Change-Id: I3df750ee9101779952d8b1ae630c4d3b7563084b
> > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3578645
> > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> > Commit-Queue: Samuel Groß <saelo@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#80376}
>
> Bug: chromium:1218005
> Change-Id: Iaf7bc81393da5c1381a361a9de129affaa019670
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3629348
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Commit-Queue: Samuel Groß <saelo@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#80394}

Bug: chromium:1218005
Change-Id: I09c12a1f8b0fe6f84fcef10e17ec95856dac3e62
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3630084Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
Auto-Submit: Samuel Groß <saelo@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80404}
parent f4edc9cc
......@@ -501,17 +501,6 @@ if (v8_enable_sandbox == "") {
v8_enable_external_code_space
}
# Enable sandboxed pointers on desktop when the sandbox is enabled.
if (v8_enable_sandbox) {
# When sanitizers are enabled, PartitionAlloc forwards allocations to malloc
# instead of allocating from its Pools and so isn't compatible with the
# sandbox. As such, disable the sandbox there. See https://crbug.com/1323174
if (!is_asan && !is_hwasan && !is_lsan && !is_tsan && !is_msan) {
v8_enable_sandboxed_pointers =
target_os != "fuchsia" && target_os != "android"
}
}
# Enable all available sandbox features if sandbox future is enabled.
if (v8_enable_sandbox_future) {
v8_enable_sandboxed_pointers = true
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment