- 11 Sep, 2018 21 commits
-
-
Florian Sattler authored
Change-Id: I6d20cb2febdcf8c937d5b37557a701d9c6c45fd2 Reviewed-on: https://chromium-review.googlesource.com/1177720 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55786}
-
Frank Tang authored
Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng;luci.chromium.try:linux_chromium_rel_ng Change-Id: Idf89e9d79e9b063c7d01e2b133826b9127910f4e Reviewed-on: https://chromium-review.googlesource.com/1205835 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55785}
-
Michael Achenbach authored
This enables cctest, unittests, fuzzer and inspector on Android. The cctest suite requires extra resource-fetching logic for the bytecode-generator expectation files. Bug: chromium:866862 Cq-Include-Trybots: luci.v8.try:v8_android_arm64_n5x_rel_ng Change-Id: If3da853a62c047388476a7f38e32e64e2859f186 Reviewed-on: https://chromium-review.googlesource.com/1213208 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#55784}
-
Clemens Hammacher authored
This reverts commit 6afe7d18. Reason for revert: Failures (-2e+66 vs. -2e+66): https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20debug/22148 Original change's description: > [Liftoff] Implement f32.copysign and f64.copysign > > These are two of the few missing instructions. This CL implements them > for ia32 and x64, and bails out on other platforms. > On x64, we are using the BTR instruction since we cannot have 64-bit > immediates. > > Drive-by: Fix naming of existing bt/bts instructions on x64. > > R=titzer@chromium.org > > Bug: v8:6600 > Change-Id: Ib8532ca811160cd61f4ba7c06b04ce093861c872 > Reviewed-on: https://chromium-review.googlesource.com/1174383 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Ben Titzer <titzer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55780} TBR=titzer@chromium.org,clemensh@chromium.org Change-Id: I4377c13346b42b65e8db04cbd15fc2f906113f65 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6600 Reviewed-on: https://chromium-review.googlesource.com/1219446Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55783}
-
Frank Tang authored
Bug: v8:8150 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: If2157d486ac164fcfd0efdc5469357fbad72e0de Reviewed-on: https://chromium-review.googlesource.com/1215271 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I9734259c9f41378ac216d5a222f0f7c71fcb5fa6 Reviewed-on: https://chromium-review.googlesource.com/1219023Reviewed-by:
-
Clemens Hammacher authored
These are two of the few missing instructions. This CL implements them for ia32 and x64, and bails out on other platforms. On x64, we are using the BTR instruction since we cannot have 64-bit immediates. Drive-by: Fix naming of existing bt/bts instructions on x64. R=titzer@chromium.org Bug: v8:6600 Change-Id: Ib8532ca811160cd61f4ba7c06b04ce093861c872 Reviewed-on: https://chromium-review.googlesource.com/1174383 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55780}
-
Clemens Hammacher authored
The macro has been deprecated since 2016, and it keeps confusing me, so let's just remove it completely from the code base. R=leszeks@chromium.org TBR=mstarzinger@chromium.org, verwaest@chromium.org, jgruber@chromium.org Bug: v8:8015 Change-Id: Ibe1122fd9d2624bc94873d9c51dc8499c54a04fd Reviewed-on: https://chromium-review.googlesource.com/1209322Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55779}
-
Marja Hölttä authored
BUG=v8:7308 Change-Id: I564f340096e64b3d17f9367aea031148a40faf40 Reviewed-on: https://chromium-review.googlesource.com/1218742Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#55778}
-
Michael Starzinger authored
This adds the ability to import exception into a module at instantiation time. Only a {WasmExceptionObject} that has been exported by another module instance can be imported, all other values are rejected. Note that currently there is no signature check being performed to make sure the imported exception matches the expected type. Also the identity of imported exceptions is not yet preserved. Furthermore the engine does not yet match thrown exception objects on a global level across modules. Hence imported exceptions will (wrongly) behave as completely new types within the module. R=clemensh@chromium.org TEST=mjsunit/wasm/exceptions-import,unittests/WasmModuleVerifyTest BUG=v8:8091 Change-Id: If247762b949a1ba4a87d13bc3e790a45dbc67815 Reviewed-on: https://chromium-review.googlesource.com/1216402 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: -
Florian Sattler authored
This patch removes unnecessary copies and adds reserves to vectors that are filled in a loop afterwards. Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I4e13c0445a9760e09ef03a62ae48be622ebecc6b Reviewed-on: https://chromium-review.googlesource.com/1209783Reviewed-by:
-
Frank Tang authored
Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I334a6eca81c02bdb90b2054f085bf57dec5f9a9d Reviewed-on: https://chromium-review.googlesource.com/1215645Reviewed-by:
-
Frank Tang authored
Manually roll ICU to 7ca3ffa to pick up an upstream fix for quarter handling. Remove the hack that prevent unexpected behavior in ICU and remove the skip of failing tests. Bug: v8:8151,v8:7869 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ic9a56679bf1eb9dc18c739161838d518fd664d6f Reviewed-on: https://chromium-review.googlesource.com/1214522Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
-
Frank Tang authored
Bug: v8:7684 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I48490187d4cb967b3567ff12306aad094698d0ee Reviewed-on: https://chromium-review.googlesource.com/1218062Reviewed-by:
-
Ross McIlroy authored
Moves some functions that used to be simple, but now do more complex logic out of the inlined headers into .cc to avoid having to export all the functions they depend on as V8_PRIVATE_EXPORT for tests. Also mark them as V8_PRIVATE_EXPORT for tests along with a couple in ast.h BUG=v8:8041 Change-Id: I6e94ca160cd3d84a0d1b099167a7b9862f08b122 Reviewed-on: https://chromium-review.googlesource.com/1216642Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#55772}
-
Georg Neis authored
Bug: v8:7790 Change-Id: I7f66333d43b057746e279851010681c4ecd36ba1 Reviewed-on: https://chromium-review.googlesource.com/1215626Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#55771}
-
Jaroslav Sevcik authored
This inserts unreachable node after uncoditional deopt in bit-to-word conversion and wires it as an input to the dead-value. This fixes a problem, where a floating dead-value was inserted by a change of bit-to-word (which always fails because bit cannot be converted to word). Without the unrachable node (which this CL inserts in the effect chain after deopt), the dead value was scheduled before the uncoditional deoptimization and crash at runtime. Unfortunately, I do not know how to construct a test that does not end up in an infinite loop. Bug: chromium:878805 Change-Id: Ia03060949f6a9b914807f5614fadcf2271911998 Reviewed-on: https://chromium-review.googlesource.com/1196663Reviewed-by:
-
Simon Zünd authored
This CL adds a new "Call" stub that can be used by builtins that will call the same JS call-back function often (e.g. compare function in Array.p.sort). The checks have to be done upfront once, but can then be omitted. R=jgruber@chromium.org Bug: v8:7861 Change-Id: Id6e4ca27c3d488a7b1f708cbcb4cbe6cc382513e Reviewed-on: https://chromium-review.googlesource.com/1208574 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#55769}
-
Frank Tang authored
The ICU API for maximizing and minimizing a locale ID takes ICU format locale id as an input so that a BCP 47 language tag must be converted to the corresponding ICU locale id. Bug: v8:7982 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I1cb1dacbf057bbc8bb8beb9b62d1ec4becd82624 Reviewed-on: https://chromium-review.googlesource.com/1150934Reviewed-by:
-
jgruber authored
In many cases, the condition already explains the assertion and a string message clutters the code without adding value. This wrapper macro is actually very useful in such cases. Change-Id: I44f27c1c9255f5fc80453c92565f07f8f3cbacae Reviewed-on: https://chromium-review.googlesource.com/1216183Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/0e1589b..b34c179 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/c869f29..c80faf4 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/25c380c..727453b TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: If839c89bcb13325a129d3c9dd9afced27617f09e Reviewed-on: https://chromium-review.googlesource.com/1217727 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#55766}
-
- 10 Sep, 2018 19 commits
-
-
Ujjwal Sharma authored
This reverts commit dd5ea32a. Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ic902fb239cc4b83563a2d92a2ae2e1569d21f549 Reviewed-on: https://chromium-review.googlesource.com/1217642Reviewed-by:
-
Michael Lippautz authored
Split off from https://chromium-review.googlesource.com/c/v8/v8/+/1196484 Bug: chromium:879045 Change-Id: I58b1a2ad10729f54c9a452dcfecd7511660460f6 Reviewed-on: https://chromium-review.googlesource.com/1216285 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#55764}
-
Igor Sheludko authored
Only read-only pages don't have properly initialized reservation object. Bug: v8:8096 Change-Id: I83f4baa414dc2ca5a397a9897088060b6cac4783 Reviewed-on: https://chromium-review.googlesource.com/1216562Reviewed-by:
-
Georg Neis authored
Such as: - JSArray (length) - Root strings, code objects, oddballs Bug: v8:7790 Change-Id: Ibed83be71b013c090c5a2b6a342c8771ad06916c Reviewed-on: https://chromium-review.googlesource.com/1215224 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
jgruber authored
The motivation behind this change is that the WasmArgumentsAdaptor builtin needed too many registers on ia32 and was blocking work on adding a root register. Bug: v8:6666 Change-Id: I9d39af96e8520acc092f5ef4b7f0a159fe4e3b12 Reviewed-on: https://chromium-review.googlesource.com/1209788 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... in order to avoid page allocator filtering when notifying leak sanitizer. Bug: v8:8015 Change-Id: I2a3222030dbbf0c467808d0f397a064c40324189 Reviewed-on: https://chromium-review.googlesource.com/1216182Reviewed-by:
-
jgruber authored
To support all possible cases, we must limit the number of register args for TFS builtins on ia32 to 3. Out of the 6 allocatable registers, esi is taken as the context register and ebx is the root register. One register must remain available to store the jump/call target. Thus 3 registers remain for arguments. The reason this applies to TFS builtins specifically is because this becomes relevant for builtins used as targets of Torque function pointers (which must have a register available to store the target). Bug: v8:6666 Change-Id: I17d9450cc29c983ddaffc2deb36f45c1c414e166 Reviewed-on: https://chromium-review.googlesource.com/1209287 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL adds naming convention errors for: - Variable names - Torque Macro/Builtin names - Parameter names R=tebbi@chromium.org Bug: v8:7793 Change-Id: Icfe20e53524234f0b4534f0102aff6b14121dfbc Reviewed-on: https://chromium-review.googlesource.com/1213184 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
-
Dan Elphick authored
Previously the builtins table had a value for every single OperandScale/Bytecode combination regardless of whether it was valid. This change makes it so that only valid bytecode handlers are stored in the builtins table. This prevents placeholders being serialized into the snapshot (and embedded into the binary) saving 9KB in CODE_SPACE/OLD_SPACE and 2.5KB in the embedded data as well as 66 entries in the builtins table. To do this, it generates a new header file bytecodes-builtins-list.h which is created from the BYTECODE_LIST and OPERAND_SCALE_LIST macros. Since list macros cannot be used to conditionally generate elements in the C-preprocessor, this is done by generator executable, compiled from interpreter/generate-flat-headers.cc. Additionally the generator creates the flat bytecode list so that it is transposed from the previous result, i.e. the results are grouped by bytecode and then operand scale rather than operand scale then bytecode. This should give better locality for commonly used bytecodes and may allow less commonly used ExtraWide bytecodes to never be mapped into memory at all. The cost to storing the handlers densely is that looking up a handler now requires a binary search through the builtins table, but this should only happen during debugging. It is also fixable at least for non-wide handlers and could be improved for wide ones if the need arises. Bug: v8:8068 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Iaad22a952e2858f508030c5ddc082f91bf59f667 Reviewed-on: https://chromium-review.googlesource.com/1209304 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Georg Neis authored
- Provide MapData::SerializeDescriptors method for serializing the whole descriptor array. - Trigger this in JSObjectData::SerializeAsBoilerplate. - Further make things more consistent across the broker. Bug: v8:7790 Change-Id: Ie6499da8857f7c6561f7c44922aeffcea4876be7 Reviewed-on: https://chromium-review.googlesource.com/1199102 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Georg Neis authored
- Provide getters for all member variables. - Add missing flags for cycle detection. - Be more consistent in stylistic matters. Bug: v8:7790 Change-Id: I87c3901b203acc4254ec48f5cc895b2e68ff32aa Reviewed-on: https://chromium-review.googlesource.com/1196431 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Sreten Kovacevic authored
Issues that caused failure of this test have been resolved with commit https://chromium-review.googlesource.com/c/v8/v8/+/1213183, so it can be re-enabled. Change-Id: I441998e5e63fce7a7e718b593c8e58a71841b78e Reviewed-on: https://chromium-review.googlesource.com/1215168Reviewed-by:
-
Florian Sattler authored
Bug: v8:8015 Change-Id: I3a3bd587e1f126b533a1eaea1ff9f74c2d0102b0 Reviewed-on: https://chromium-review.googlesource.com/1209847Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55753}
-
Michael Starzinger authored
This new instance type will be used for wrapper objects representing exported exceptions. Currently the objects are empty and only serve as an identity for exported exceptions. Eventually they will also need to reference the signature underlying the exception to perform a signature check upon import. R=clemensh@chromium.org TEST=mjsunit/wasm/exceptions-import BUG=v8:8091 Change-Id: Ifdd561fc000090f4a985aeb45549fd7110849646 Reviewed-on: https://chromium-review.googlesource.com/1215166 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Sreten Kovacevic authored
* Enable Liftoff wasm cctests on BE for mips and mips64 * Fix issues that were introduced with these tests and that are linked with Load/Store instructions * Change endianness on GetGlobal and SetGlobal, as done in TF * Skip I32Binop tests that fail with OOM error and seem to not be related directly to this task Bug: v8:6600 Change-Id: Ib62ca5e3c681326d28e70a5157d8646e0c8d0b51 Reviewed-on: https://chromium-review.googlesource.com/1213183 Commit-Queue: Sreten Kovacevic <skovacevic@wavecomp.com> Reviewed-by:
Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Reviewed-by:
-
Tobias Tebbi authored
This CL makes sure, that logical operators (||, &&) always have return type never. Together with a check that never is never passed as a function argument, this prevents faulty evaluation as in !(x || y). Before, the logical operators had a behavior similar to (bool labels Taken, NotTaken), with a fast exit if the left-hand side allowed shor-circuit evaluation, but returning the right-hand side otherwise. Since we want to allow existing (a || b || c) patterns in the codebase, this requires weakening the restriction that the left- and right-hand side need to have the same type. Now the possibilites are: bool, never never, bool never, never bool, bool constexpr bool, constexpr bool Bug: v8:8137 Change-Id: I9576b337dc4008ac58b4625e77fef4e73bcdd6e3 Reviewed-on: https://chromium-review.googlesource.com/1215162Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#55750}
-
Clemens Hammacher authored
If there are many workers and we are very unlucky, the cmpxchg loop can in fact fail for more than 5 times. This CL removes this unneeded limitation to avoid spurious failures. R=mstarzinger@chromium.org Bug: chromium:824443 Change-Id: I0a6adde1330c8a8389a42b36bf44e516fae8c574 Reviewed-on: https://chromium-review.googlesource.com/1213170Reviewed-by:
-
Clemens Hammacher authored
R=mstarzinger@chromium.org Bug: v8:8015, chromium:824443 Change-Id: I017e8bf9033fba1afdddcc5e3057860519dfc119 Reviewed-on: https://chromium-review.googlesource.com/1213210Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/66badbd..25c380c TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Iaf3e13ec8f9174321c61016c622a046a71ef6335 Reviewed-on: https://chromium-review.googlesource.com/1214867 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
