• Jaroslav Sevcik's avatar
    [turbofan] Insert unreachable node after unconditional deopt. · 3cfaca63
    Jaroslav Sevcik authored
    This inserts unreachable node after uncoditional deopt in bit-to-word
    conversion and wires it as an input to the dead-value.
    
    This fixes a problem, where a floating  dead-value was inserted by a change
    of bit-to-word (which always fails because bit cannot be converted to word).
    Without the unrachable node (which this CL inserts in the effect chain after
    deopt), the dead value was scheduled before the uncoditional deoptimization
    and crash at runtime.
    
    Unfortunately, I do not know how to construct a test that does not end up in
    an infinite loop.
    
    Bug: chromium:878805
    Change-Id: Ia03060949f6a9b914807f5614fadcf2271911998
    Reviewed-on: https://chromium-review.googlesource.com/1196663Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#55770}
    3cfaca63
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...