1. 21 Jun, 2021 1 commit
  2. 18 Jun, 2021 1 commit
  3. 17 Jun, 2021 2 commits
  4. 11 Jun, 2021 1 commit
  5. 02 Jun, 2021 1 commit
  6. 01 Jun, 2021 1 commit
  7. 31 May, 2021 1 commit
  8. 28 May, 2021 1 commit
  9. 27 May, 2021 2 commits
  10. 19 May, 2021 1 commit
    • Benedikt Meurer's avatar
      [inspector] Derive breakpoint hint based on resolved location. · ea3ee6da
      Benedikt Meurer authored
      When setting a breakpoint on a line (in the DevTools front-end), the
      front-end sends a columnNumber of 0 and the inspector automatically
      resolves the actual location (in bytecode execution order). In order
      to also support changing source code, the inspector memorizes a text
      hint, and uses that to adjust the location upon reload. This hint was
      however taken based on the original line and column numbers, rather than
      the resolved location, which causes trouble when syntactic order doesn't
      match execution order, as in case of `await o.m()`.
      
      In order to address that we now remember the textual hint based on the
      resolved location.
      
      Fixed: chromium:1081162
      Also-By: kimanh@chromium.org
      Change-Id: I7d08373440693b7abc18c29c1a05929d771d3031
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2905606
      Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
      Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
      Reviewed-by: 's avatarKim-Anh Tran <kimanh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#74675}
      ea3ee6da
  11. 12 May, 2021 2 commits
  12. 10 May, 2021 1 commit
  13. 07 May, 2021 1 commit
    • Sigurd Schneider's avatar
      Fix monitor for arrow functions · 9c40b865
      Sigurd Schneider authored
      Our current logic for the console API's monitor implementation relies on
      JavaScript's arguments array. In arrow functions, this results in an
      error, resulting missing print statements from monitor.
      
      This CL at least re-enables the print statements, but does not print the
      arguments in the case of arrow functions.
      
      Change-Id: Ibf6c2a0fb5e0cc911c257520a59a875992fe3777
      Bug: chromium:1206137
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2880216Reviewed-by: 's avatarPhilip Pfaffe <pfaffe@chromium.org>
      Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#74437}
      9c40b865
  14. 06 May, 2021 2 commits
  15. 04 May, 2021 1 commit
  16. 30 Apr, 2021 2 commits
  17. 29 Apr, 2021 1 commit
    • Benedikt Meurer's avatar
      [debugger] Remove "Restart frame" feature. · 93f85699
      Benedikt Meurer authored
      The "Restart frame" feature was implemented as part of LiveEdit and
      primarily used to support LiveEdit of active functions, but that was
      previously disabled as part of https://crrev.com/c/2846892 because it's
      too brittle and causes crashes when using seemingly unrelated features.
      The "Restart frame" feature was also available as a context menu item
      separately in the DevTools front-end, but that was also already removed
      as part of https://crrev.com/c/2854681 earlier. So all uses are gone
      now.
      
      This change works by marking Debugger.restartFrame as deprecated and
      having it respond with a ServerError all the time. It thus allows us to
      remove a whole bunch of machinery that was essentially just put in
      various places to support the restart_fp_ magic. In particular the
      debugger no longer needs any machine specific builtins now.
      
      Bug: chromium:1195927
      Change-Id: I1153ba6b00e979620af57dd9f58aa1c035ec4484
      Fixed: chromium:1203606
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2854750Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#74276}
      93f85699
  18. 26 Apr, 2021 2 commits
  19. 23 Apr, 2021 1 commit
  20. 21 Apr, 2021 1 commit
  21. 16 Apr, 2021 3 commits
  22. 14 Apr, 2021 2 commits
  23. 12 Apr, 2021 2 commits
  24. 09 Apr, 2021 2 commits
  25. 07 Apr, 2021 1 commit
    • Benedikt Meurer's avatar
      [inspector] Skip special __proto__ property if already present. · 0d5f6a49
      Benedikt Meurer authored
      The inspector has some magic to add a special __proto__ property to
      object value mirrors as long as the object itself has a [[Prototype]].
      However it doesn't check whether the object already has a regular
      property named __proto__ and thus confuses the front-end by sending two
      properties with the same name.
      
      Fixed: chromium:1193250
      Change-Id: I75a1cd78ba94aeda4afedcc0f1e69b8dadb6673f
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2810784
      Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
      Commit-Queue: Yang Guo <yangguo@chromium.org>
      Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#73836}
      0d5f6a49
  26. 11 Mar, 2021 1 commit
    • Benedikt Meurer's avatar
      [inspector] Properly filter by column number for inline scripts. · 81b91591
      Benedikt Meurer authored
      Previously `setBreakpointByUrl` and friends would only filter based on
      line number to find matching scripts. But that didn't work when there
      were multiple scripts in the same line (i.e. minified HTML), and we'd
      end up setting multiple breakpoints in different inline scripts, looking
      for the next possible break location in each of them individually.
      
      Fixed: chromium:1183664
      Also-By: pfaffe@chromium.org, kimanh@chromium.org
      Change-Id: I957811d30aa71609a38da75f33a24c0f720116f6
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2749155
      Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
      Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
      Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
      Reviewed-by: 's avatarKim-Anh Tran <kimanh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#73332}
      81b91591
  27. 08 Mar, 2021 1 commit
  28. 05 Mar, 2021 2 commits