1. 03 May, 2019 1 commit
    • Johannes Henkel's avatar
      [DevTools] Add V8InspectorSession::state(), which returns binary (CBOR). · 9d7c1947
      Johannes Henkel authored
      Keep the existing method for compatibility, by converting
      to json from CBOR using the inspector_protocol_encoding library,
      via a v8 specific interface library that directs routines for
      converting between strings and doubles to v8's implementations.
      
      This change also brings in the encoding.h / encoding.cc files from the
      upstream inspector_protocol project. The only modification here
      are the header guards, and the namespace. I will fix roll.py to
      make it so that we pick up future changes.
      
      third_party/inspector_protocol/BUILD.gn is specific to v8, by necessity.
      third_party/inspector_protocol/.clang-format is a copy of the upstream
      file. If we don't put this, we'll find ourselves auto-formatting the roll,
      which is annoying.
      
      This is a reland of
      https://chromium-review.googlesource.com/c/v8/v8/+/1590627 with the
      only modification in the DEPS file; this time I'm including
      third_party/inspector_protocol/encoding/encoding{.h,cc} in addition to
      the relative include there. Not sure why this is needed but I'm hoping
      it gets me past the presubmit which may resolve the include path
      relative to the V8 base (the ../../third_party is needed for when V8 is
      embedded into Chromium).
      
      Change-Id: Ic76b2b5faa7e1cbdceb15aff3f369e9a303e3e85
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593646Reviewed-by: 's avatarAlexei Filippov <alph@chromium.org>
      Reviewed-by: 's avatarDmitry Gozman <dgozman@chromium.org>
      Commit-Queue: Johannes Henkel <johannes@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#61214}
      9d7c1947
  2. 02 May, 2019 2 commits
    • Johannes Henkel's avatar
      Revert "[DevTools] Add V8InspectorSession::state(), which returns binary (CBOR)." · c27c369a
      Johannes Henkel authored
      This reverts commit b7134d3a.
      
      Reason for revert: breaks presubmit
      
      Original change's description:
      > [DevTools] Add V8InspectorSession::state(), which returns binary (CBOR).
      > 
      > Keep the existing method for compatibility, by converting
      > to json from CBOR using the inspector_protocol_encoding library,
      > via a v8 specific interface library that directs routines for
      > converting between strings and doubles to v8's implementations.
      > 
      > This change also brings in the encoding.h / encoding.cc files from the
      > upstream inspector_protocol project. The only modification here
      > are the header guards, and the namespace. I will fix roll.py to
      > make it so that we pick up future changes.
      > 
      > third_party/inspector_protocol/BUILD.gn is specific to v8, by necessity.
      > third_party/inspector_protocol/.clang-format is a copy of the upstream
      > file. If we don't put this, we'll find ourselves auto-formatting the roll,
      > which is annoying.
      > 
      > Change-Id: I20fa8759164e7a39f8a7c30e0d2a3f8a7e4be227
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1590627
      > Reviewed-by: Alexei Filippov <alph@chromium.org>
      > Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
      > Commit-Queue: Johannes Henkel <johannes@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#61187}
      
      TBR=dgozman@chromium.org,alph@chromium.org,caseq@chromium.org,johannes@chromium.org
      
      Change-Id: I67f297ef8454499036c94bf88e0d23657a579140
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1592130Reviewed-by: 's avatarDmitry Gozman <dgozman@chromium.org>
      Commit-Queue: Johannes Henkel <johannes@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#61189}
      c27c369a
    • Johannes Henkel's avatar
      [DevTools] Add V8InspectorSession::state(), which returns binary (CBOR). · b7134d3a
      Johannes Henkel authored
      Keep the existing method for compatibility, by converting
      to json from CBOR using the inspector_protocol_encoding library,
      via a v8 specific interface library that directs routines for
      converting between strings and doubles to v8's implementations.
      
      This change also brings in the encoding.h / encoding.cc files from the
      upstream inspector_protocol project. The only modification here
      are the header guards, and the namespace. I will fix roll.py to
      make it so that we pick up future changes.
      
      third_party/inspector_protocol/BUILD.gn is specific to v8, by necessity.
      third_party/inspector_protocol/.clang-format is a copy of the upstream
      file. If we don't put this, we'll find ourselves auto-formatting the roll,
      which is annoying.
      
      Change-Id: I20fa8759164e7a39f8a7c30e0d2a3f8a7e4be227
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1590627Reviewed-by: 's avatarAlexei Filippov <alph@chromium.org>
      Reviewed-by: 's avatarDmitry Gozman <dgozman@chromium.org>
      Commit-Queue: Johannes Henkel <johannes@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#61187}
      b7134d3a