Skip to content

V
V8
Switch branch/tag
  1. 24 Jun, 2021 4 commits
  3. 23 Jun, 2021 2 commits
  5. 22 Jun, 2021 1 commit
  7. 18 Jun, 2021 1 commit
  9. 16 Jun, 2021 1 commit
  11. 10 Jun, 2021 2 commits
  13. 08 Jun, 2021 1 commit
  15. 27 May, 2021 2 commits
  17. 24 May, 2021 1 commit
  19. 21 May, 2021 1 commit
  21. 20 May, 2021 1 commit
  23. 18 May, 2021 1 commit
  25. 14 May, 2021 1 commit
  27. 10 May, 2021 1 commit
  29. 06 May, 2021 1 commit
    • Clemens Backes's avatar
      Fix data race in array sorting · 9c5623c7
      Clemens Backes authored 
      For copying the SharedArrayBuffer content, we cannot use a simple
{memcpy} because that produces data races with thread concurrently
modifying the content. Instead, use a custom {Relaxed_Memcpy} that uses
proper relaxed atomics. The implementation is slightly optimized to do
word-sized loads and stores where possible. If we still get performance
regressions, we can optimize it further in follow-up CLs.

R=ulan@chromium.org
CC=mlippautz@chromium.org

Bug: v8:11704, chromium:1205290
Change-Id: Ie34afc5c22ec5496c0fe822d55d4788031f06c54
Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2874652
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74403}
      9c5623c7
  31. 30 Apr, 2021 1 commit
  33. 29 Apr, 2021 1 commit
  35. 28 Apr, 2021 2 commits
  37. 27 Apr, 2021 2 commits
  39. 26 Apr, 2021 1 commit
  41. 24 Apr, 2021 1 commit
    • Daniel Lehmann's avatar
      [wasm] Add missing scopes for code modification · eb57c722
      Daniel Lehmann authored 
      This is the second CL in a line of two (see crrev.com/c/2835237) to
bring write-protection to the WebAssembly code space. The previous CL
changed the page permissions from W^X (only either writable or
executable can be active, but never both) to write-protection (due to
concurrent execution in the main thread). However, write-protection
still did not work, because in several places the code space is
modified without properly switching it to writable beforehand.

This CL fixes --wasm-write-protect-code-memory such that it can now be
enabled again (with potentially high overhead due to frequent page
protection switches). For that, it adds the missing switching to
writable by adding {NativeModuleModificationScope} objects (similar to
the already existing {CodeSpaceWriteScope} objects for Apple M1
hardware).

This CL also fixes a race condition between checking for the current
writable permission and actually setting the permission, by protecting
the counter of currently active writers with the same lock as the
{WasmCodeAllocator} itself. (Before multi-threaded compilation, this
was not necessary.)

Finally, this CL also changes the {Mutex} protecting the
{WasmCodeAllocator} to a {RecursiveMutex} because it can be requested
multiple times in the call hierarchy of the same thread, which would
cause a deadlock otherwise. Since {TryLock()} of a {RecursiveMutex}
never fails, this also removes the (now failing) DCHECKs.

R=clemensb@chromium.org
CC=​​jkummerow@chromium.org

Bug: v8:11663
Change-Id: I4db27ad0a9348021b0b663dbe88b3432a4d8d6b5
Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng
Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2835238
Commit-Queue: Daniel Lehmann <dlehmann@google.com>
Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74163}
      eb57c722
  43. 23 Apr, 2021 1 commit
  45. 21 Apr, 2021 1 commit
  47. 14 Apr, 2021 1 commit
  49. 07 Apr, 2021 1 commit
  51. 31 Mar, 2021 1 commit
  53. 23 Mar, 2021 1 commit
  55. 22 Mar, 2021 3 commits
  57. 16 Mar, 2021 1 commit
  59. 12 Mar, 2021 1 commit
    • Clemens Backes's avatar
      [logging] Fix printing of single-byte enums · d8c8387a
      Clemens Backes authored 
      We still get e.g. ClusterFuzz reports with enums printed as
non-printable single-character strings (see linked bug).
This CL fixes this, and also includes the integral enum value for enum
that come with their own output operator.

This makes error messages strictly better, at the cost of some more code
per enum which is being used in a CHECK/DCHECK.
Note that binary size of release builds is not affected, since we do not
print the values there.

R=nicohartmann@chromium.org

Bug: v8:11384, chromium:1187484
Change-Id: I066b32f68440096babed9b629c7ffe3f2285cba8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756226Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73373}
      d8c8387a