- 11 Jun, 2018 4 commits
-
-
Clemens Hammacher authored
For errors, it just printed "Failure: expected <Error()> found <Error()>" and completely omitted the specific error type and the message. The new output is: Failure: expected: Error(Error: my explicit error) found: Error(ReferenceError: ffi is not defined) R=mstarzinger@chromium.org Change-Id: Ie17a97e4413c4585b9560fd1c408018ee8c06701 Reviewed-on: https://chromium-review.googlesource.com/1092746Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53625}
-
Matheus Marchini authored
ExistingCodeLogger was behaving incorrectly when the CodeEventHandler API was used in combination with --interpreted-frames-native-stack. Instead of collecting copied trampolines as InterpretedFunction:functionName, they were being collected as Builtin:IntepreterEntryTrampolines. This patch adds special handling for copied trampolines when using ExistingCodeLogger. R=yangguo@google.com Change-Id: I3ee4be03800122d28d53b51b20c60dcf6263e4c1 Reviewed-on: https://chromium-review.googlesource.com/1087813Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#53624}
-
jgruber authored
Internal references create absolute pointers within the code and must therefore be disallowed for embedded builtins to remain position-independent. Drive-by: remove related cctest. This test used to be relevant before embedding was fully implemented, but by now it is useless and rather misleading since it gives a false sense of safety. Bug: v8:6666 Change-Id: I57a62274b57c3ef1303d5114c68e2a9b1f92bda4 Reviewed-on: https://chromium-review.googlesource.com/1092732 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#53623}
-
Sathya Gunasekaran authored
OrderedHashTableHandler (to be renamed to OrderedHashTable) is the interface that abstracts away the two different ordered hash tables. All operations on the two ordered hash tables must be performed through this new interface so that we can seamlessly migrate from one table to another behind the scenes. Bug: v8:6443, v8:7569 Change-Id: Ifc0a38974605b63e0a2a36b4aafb8dc68a081f4a Reviewed-on: https://chromium-review.googlesource.com/1059865 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#53622}
-
- 08 Jun, 2018 24 commits
-
-
Michael Achenbach authored
NOTRY=true Bug: chromium:846711 Change-Id: I5d7f366db2e80fbe539b34a5dcb7475e4e38bd29 Reviewed-on: https://chromium-review.googlesource.com/1088694Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#53621}
-
Dominik Inführ authored
The GC now stores EphemeronHashTables in a Worklist. Bug: chromium:844008 Change-Id: I6ad95b3b49484901d75c6fd92b59065c438fcd03 Reviewed-on: https://chromium-review.googlesource.com/1093092 Commit-Queue: Dominik Inführ <dinfuehr@google.com> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#53620}
-
Dominik Inführ authored
JSWeakCollections used to be chained in a singly-linked list. The GC now stores the JSWeakCollection's backing store EphemeronHashTable in a Worklist. This should allow easier parallelization in the future. Bug: chromium:844008 Change-Id: Icc0c1b537c23e8d24dc5b27452fb8106562c9a09 Reviewed-on: https://chromium-review.googlesource.com/1092496 Commit-Queue: Dominik Inführ <dinfuehr@google.com> Reviewed-by:
-
Sathya Gunasekaran authored
Bug: v8:7834 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I1fcbcf0b019a0fbf0f17a676bd31a686a6d5377d Reviewed-on: https://chromium-review.googlesource.com/1091880 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#53618}
-
Rodrigo Bruno authored
Bug: chromium:845409 Change-Id: Id8b89e6dac48bba9065ac9f04ce48f951aa2186b Reviewed-on: https://chromium-review.googlesource.com/1092860 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by:
-
Ulan Degenbaev authored
The mock histogram functions cannot be cleared and can be called on isolate tear down if incremental marking is in progress. Bug: chromium:850508 Tbr: mlippautz@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I99e52aaa81c863f71e195aeed691b37da9e71da6 Reviewed-on: https://chromium-review.googlesource.com/1093073Reviewed-by:
-
Ulan Degenbaev authored
Bug: chromium:850508 Tbr: mlippautz@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I99adf68c4b3e26decf3b68c8062ce74cbf27874d Reviewed-on: https://chromium-review.googlesource.com/1093071Reviewed-by:
-
Ulan Degenbaev authored
This adds the following histograms recorded corresponding to V8.GCFinalizeMC phases: - V8.GCFinalizeMC.Clear - V8.GCFinalizeMC.Epilogue - V8.GCFinalizeMC.Evacuate - V8.GCFinalizeMC.Finish - V8.GCFinalizeMC.Mark - V8.GCFinalizeMC.Prologue - V8.GCFinalizeMC.Sweep Bug: chromium:850508 Change-Id: I47adc125a9a28436d09e35db68a8e8198cbee2dd Reviewed-on: https://chromium-review.googlesource.com/1091311 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#53614}
-
Dominik Inführ authored
Emit full header and key/value-pairs. Bug: chromium:844008 Change-Id: Ia94b841ff97d024d6ba27b1bcc2f993f95fc11fa Reviewed-on: https://chromium-review.googlesource.com/1092698Reviewed-by:
-
Tobias Tebbi authored
Reland "[turbofan] enable switch jump tables with --no-untrusted-code-mitigations, also for stubs and Wasm" But for builtins, jump tables are disabled to be compatible with embedded builtins. This is a reland of 884bec9f Original change's description: > [turbofan] enable switch jump tables with --no-untrusted-code-mitigations, > also for stubs and Wasm > > Bug: chromium:845851 > Change-Id: I9b860dc26f8b35d629235b82fc5fffe04bf10493 > Reviewed-on: https://chromium-review.googlesource.com/1076151 > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53525} Bug: chromium:845851 Change-Id: I66c300f875a46a3f2a68730fda94b8196f38aa97 Reviewed-on: https://chromium-review.googlesource.com/1087468 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL implements NumberIsNaN in Torque and removes it from the CodeStubAssembler. It is currently used in TypedArray.p.sort and Array.p.sort. R=jgruber@chromium.org Change-Id: Iaaa81901f89c0df68997d4501607b302a0449012 Reviewed-on: https://chromium-review.googlesource.com/1092532 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#53611}
-
Clemens Hammacher authored
Since we never extract pools from a {DisjointAllocationPool}, the {Allocate} method can just return an {AddressRange}, and also {Merge} just needs to merge a single {AddressRange}. Drive-by: Make {AddressRange} a proper struct, for DCHECKs and better accessors. R=mstarzinger@chromium.org Bug: v8:7754 Change-Id: I19fd02b2c6d8eb5316a5e994835b89be9cfa792b Reviewed-on: https://chromium-review.googlesource.com/1090723 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
jgruber authored
This class can contain members and functions common across all platforms. Bug: v8:6666 Change-Id: I8f232f806457164a2401f74c7140fd035ad05096 Reviewed-on: https://chromium-review.googlesource.com/1086940 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Rodrigo Bruno authored
Bug: chromium:845409 Change-Id: If1fbb03258fdfae528069ba37bbef0395ddb230d Reviewed-on: https://chromium-review.googlesource.com/1090920Reviewed-by:
-
Igor Sheludko authored
Bug: v8:5269, v8:7703 Change-Id: I0b766ab4ca55edc05d1849745fd3604be6c726d6 Reviewed-on: https://chromium-review.googlesource.com/1087460 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Théotime Grohens authored
This CL moves the DataViewGetFloat32 and DataViewGetFloat64 getters from runtime to Torque. Change-Id: Ic85ec7bcb4e48f679c24e28121b7c543454e7cde Reviewed-on: https://chromium-review.googlesource.com/1088919Reviewed-by:
-
Igor Sheludko authored
Change-Id: I308c05feace7b1bb69d12a35243340724a96a49b Reviewed-on: https://chromium-review.googlesource.com/1090491Reviewed-by:
-
Sigurd Schneider authored
This CL updates the d3.js library to version 5.4. The most notable change is that the library can now distinguish between click and drag events if an element supports both selection via click and displacement via drag. Curiously, npm created a 'package-lock.json', which is ~500 lines, and which is supposed to be checked into the repository according to documentation. Change-Id: Ifabd236296d951f390e0a1516d89e73138ce1713 Reviewed-on: https://chromium-review.googlesource.com/1076234Reviewed-by:
-
Michael Starzinger authored
This makes sure that reloc entries with WASM_STUB_CALL mode can be shared within the constant pool. Call sites to such stubs never need to be patched individually and absolute addresses of such call targets can be shared when they are put into constant pools. This applies to ARM, ARM64 and PPC architectures only. R=clemensh@chromium.org BUG=chromium:850413 Change-Id: I657248f61f122f1a3d6d30ebd14326df45f67540 Reviewed-on: https://chromium-review.googlesource.com/1091055Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#53603}
-
Dominik Inführ authored
This is a reland of 4f945599 Original change's description: > Add Visitor for EphemeronHashTable > > JSWeakCollection does not have any weak references anymore. Special > handling of Ephemerons can now be implemented in > VisitEphemeronHashTable. > > Bug: chromium:844008 > Change-Id: I9f4d8ad6a32cc7a55b715803f6a83ff8d2743ce8 > Reviewed-on: https://chromium-review.googlesource.com/1090274 > Commit-Queue: Dominik Inführ <dinfuehr@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53584} Bug: chromium:844008 Change-Id: I9d2953d55eb0affba4fede5ec37369c1eb6574f5 Reviewed-on: https://chromium-review.googlesource.com/1092370Reviewed-by:
-
Michael Achenbach authored
Bug: v8:7812 Change-Id: Ia5a9c68e0aeb9d993ca2cd5f855ff39e172890e8 Reviewed-on: https://chromium-review.googlesource.com/1090282Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
jgruber authored
Currently, nosnap builds do not run mksnapshot and thus do not have a chance to generate the embedded blob. In theory we could support this, but let's just ensure we don't crash for now. Bug: v8:6666,v8:7835 Change-Id: I7d3b1f772b296ae3bcaed1604e0d1e44834da1c0 Reviewed-on: https://chromium-review.googlesource.com/1092491Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2e17643..41d1fdd Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/93a962f..09b82f4 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e89dcf7..8e6f58c Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/adae55a..5131d44 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Icdea3ae3d892ccb6132196903753a40e19e3ba95 Reviewed-on: https://chromium-review.googlesource.com/1091477 Reviewed-by: <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#53599}
-
Kanghua Yu authored
Before: movl r10,0x1 REX.W movq [rbp-0x40],r10 After: REX.W movq [rbp-0x40],0x1 Change-Id: Iebc77e14a947fd89f7ed4702cea703c15dcb6718 Reviewed-on: https://chromium-review.googlesource.com/1092159Reviewed-by:Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#53598}
-
- 07 Jun, 2018 12 commits
-
-
Ben Smith authored
This updates 'hello-world.cc' sample. Change-Id: Id1f3fd222ddd89946e3ab50a8eff5c6477d1f665 Reviewed-on: https://chromium-review.googlesource.com/1089816 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#53597}
-
Joyee Cheung authored
Bug: v8:7807 Change-Id: Ie86329580551b3364da6fdf7f5bd1cdceb8ad88d Reviewed-on: https://chromium-review.googlesource.com/1091498Reviewed-by:
-
Aseem Garg authored
The globals tests for simd are failing on mips big endian. Will re-enable after fixing. R=clemensh@chromium.org BUG=v8:6020 Change-Id: I8a8a17c4e947b69ccc2eb6bbe79c308b1129d1af Reviewed-on: https://chromium-review.googlesource.com/1089814 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by:
-
Dominik Inführ authored
This is a reland of 3b93e695 Original change's description: > Add InstanceType for EphemeronHashTable > > This will allow the GC to differentiate between regular HashTables and EphemeronHashTables. > > Bug: chromium:844008 > Change-Id: I2f9009ac25eb117de03786b110dd362b829c5e9e > Reviewed-on: https://chromium-review.googlesource.com/1089066 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Dominik Inführ <dinfuehr@google.com> > Cr-Commit-Position: refs/heads/master@{#53577} TBR=tebbi@chromium.org Bug: chromium:844008 Change-Id: Ia5da3d15e28ace94063f9db4fdd4997d88696501 Reviewed-on: https://chromium-review.googlesource.com/1091090 Commit-Queue: Dominik Inführ <dinfuehr@google.com> Reviewed-by:
-
Joran Siu authored
z/Architecture Principles of Operation details LOCR/LOCGR to be RRF-c format, with the operands printed in the form LOCR/LOCGR R1,R2,M3, where M3 is binary encoded in bits 16-20. Current disassembler is printing the operands in the wrong order, and extracting the Mask from the wrong bits. R=jyan@ca.ibm.com, michael_dawson@ca.ibm.com Change-Id: I30baaab16ab3dbf879df381cd1f0978a66a214a6 Reviewed-on: https://chromium-review.googlesource.com/1091139Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Joran Siu <joransiu@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#53593}
-
Joyee Cheung authored
Proposal repo: https://github.com/tc39/proposal-symbol-description Add new Builtin SymbolPrototypeDescriptionGetter. Bug: v8:7807 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I7353bd00b172e91d8624e3373d2a4b55aced8b5c Reviewed-on: https://chromium-review.googlesource.com/1088871 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Vasili Skurydzin authored
Change-Id: I7736314257bba44b4336d584020744c05874aa64 Reviewed-on: https://chromium-review.googlesource.com/1067607Reviewed-by:
-
Igor Sheludko authored
This CL introduces CSA::TailCallJSCode() for tail calling code objects with JSCall linkage. Bug: v8:5269, v8:7703 Change-Id: I97370dc4355dc658a9cd62166efcbe7f03d6daca Reviewed-on: https://chromium-review.googlesource.com/1087459 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Bill Budge authored
This reverts commit 3b93e695. Reason for revert: Breaks Linux nosnap: https://ci.chromium.org/buildbot/client.v8/V8%20Linux%20-%20nosnap%20-%20debug/19064 Original change's description: > Add InstanceType for EphemeronHashTable > > This will allow the GC to differentiate between regular HashTables and EphemeronHashTables. > > Bug: chromium:844008 > Change-Id: I2f9009ac25eb117de03786b110dd362b829c5e9e > Reviewed-on: https://chromium-review.googlesource.com/1089066 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Dominik Inführ <dinfuehr@google.com> > Cr-Commit-Position: refs/heads/master@{#53577} TBR=ulan@chromium.org,tebbi@chromium.org,dinfuehr@google.com Change-Id: I8f92d76e35ae419af937add9a0e70a288c604781 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:844008 Reviewed-on: https://chromium-review.googlesource.com/1090973Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#53589}
-
Bill Budge authored
This reverts commit 4f945599. Reason for revert: Changed break Linux Bot: https://ci.chromium.org/buildbot/client.v8/V8%20Linux%20-%20nosnap%20-%20debug/19064 Original change's description: > Add Visitor for EphemeronHashTable > > JSWeakCollection does not have any weak references anymore. Special > handling of Ephemerons can now be implemented in > VisitEphemeronHashTable. > > Bug: chromium:844008 > Change-Id: I9f4d8ad6a32cc7a55b715803f6a83ff8d2743ce8 > Reviewed-on: https://chromium-review.googlesource.com/1090274 > Commit-Queue: Dominik Inführ <dinfuehr@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53584} TBR=ulan@chromium.org,dinfuehr@google.com Change-Id: Ifba31e75b0ca221da3a3905db829af586d342e26 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:844008 Reviewed-on: https://chromium-review.googlesource.com/1090971Reviewed-by:
-
Michael Starzinger authored
This uses an optimized single-byte encoding for WASM_STUB_CALL reloc entries when possible, by sacrificing size from DEOPT_REASON. Note that stub calls in WebAssembly are used for trap handlers, which are fairly common on regular WasmCode. R=clemensh@chromium.org BUG=chromium:850111,chromium:850413 Change-Id: I153fdd775290dece2884d438d5defd441486b369 Reviewed-on: https://chromium-review.googlesource.com/1090831 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#53587}
-
Simon Zünd authored
This CL extracts code for loading a NumberDictionary element from "EmitElementLoad" to its own function in the CSA. This is done in preparation for a fast path in Torque for dictionary elements. R=jgruber@chromium.org Change-Id: I3bb9897910183cd50be127bae771e531a61d57be Reviewed-on: https://chromium-review.googlesource.com/1090832Reviewed-by:
-
