1. 22 Jul, 2020 2 commits
    • Maya Lekova's avatar
      Revert "Reland "[flags] warn about contradictory flags"" · a269ce20
      Maya Lekova authored
      This reverts commit d8f8a7e2.
      
      Reason for revert: Breaks code_serializer variant - https://cr-buildbucket.appspot.com/build/8874070652992164976
      
      Original change's description:
      > Reland "[flags] warn about contradictory flags"
      > 
      > This is a reland of b8f91666
      > Difference to previous CL: Additional functionality to specify
      > incompatible flags based on GN variables and extra-flags, used
      > to fix the issues that came up on the waterfall.
      > 
      > This also changes the rules regarding repeated flags: While
      > explicitly repeated flags are allowed for boolean values as long
      > as they are identical, repeated flags or explicit flags in the
      > presence of an active implication are disallowed for non-boolean
      > flags. The latter simplifies specifying conflict rules in
      > variants.py. Otherwise a rule like
      > 
      > INCOMPATIBLE_FLAGS_PER_EXTRA_FLAG = {
      >   "--gc-interval=*": ["--gc-interval=*"],
      > }
      > 
      > wouldn't work because specifying the same GC interval twice
      > wouldn't actually count as a conflict. This was an issue with
      > test/mjsunit/wasm/gc-buffer.js, which specifies
      > --gc-interval=500 exactly like the extra flag by the stress bot.
      > 
      > Also, this now expands contradictory flags checking to d8 flags
      > for consistency.
      > 
      > Original change's description:
      > > [flags] warn about contradictory flags
      > >
      > > Design Doc: https://docs.google.com/document/d/1lkvu8crkK7Ei39qjkPCFijpNyxWXsOktG9GB-7K34jM/
      > >
      > > Bug: v8:10577
      > > Change-Id: Ib9cfdffa401c48c895bf31caed5ee03545beddab
      > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2154792
      > > Reviewed-by: Clemens Backes <clemensb@chromium.org>
      > > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > > Reviewed-by: Georg Neis <neis@chromium.org>
      > > Reviewed-by: Tamer Tas <tmrts@chromium.org>
      > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#68168}
      > 
      > Bug: v8:10577
      > Change-Id: I268e590ee18a535b13dee14eeb15ddd0a9ee8341
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235115
      > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
      > Reviewed-by: Tamer Tas <tmrts@chromium.org>
      > Reviewed-by: Clemens Backes <clemensb@chromium.org>
      > Reviewed-by: Georg Neis <neis@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#68989}
      
      TBR=machenbach@chromium.org,neis@chromium.org,clemensb@chromium.org,tebbi@chromium.org,tmrts@chromium.org
      
      Change-Id: I7969065b0edbc463a94e530485bc2ab623d77b62
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:10577
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2312782Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
      Commit-Queue: Maya Lekova <mslekova@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#68992}
      a269ce20
    • Tobias Tebbi's avatar
      Reland "[flags] warn about contradictory flags" · d8f8a7e2
      Tobias Tebbi authored
      This is a reland of b8f91666
      Difference to previous CL: Additional functionality to specify
      incompatible flags based on GN variables and extra-flags, used
      to fix the issues that came up on the waterfall.
      
      This also changes the rules regarding repeated flags: While
      explicitly repeated flags are allowed for boolean values as long
      as they are identical, repeated flags or explicit flags in the
      presence of an active implication are disallowed for non-boolean
      flags. The latter simplifies specifying conflict rules in
      variants.py. Otherwise a rule like
      
      INCOMPATIBLE_FLAGS_PER_EXTRA_FLAG = {
        "--gc-interval=*": ["--gc-interval=*"],
      }
      
      wouldn't work because specifying the same GC interval twice
      wouldn't actually count as a conflict. This was an issue with
      test/mjsunit/wasm/gc-buffer.js, which specifies
      --gc-interval=500 exactly like the extra flag by the stress bot.
      
      Also, this now expands contradictory flags checking to d8 flags
      for consistency.
      
      Original change's description:
      > [flags] warn about contradictory flags
      >
      > Design Doc: https://docs.google.com/document/d/1lkvu8crkK7Ei39qjkPCFijpNyxWXsOktG9GB-7K34jM/
      >
      > Bug: v8:10577
      > Change-Id: Ib9cfdffa401c48c895bf31caed5ee03545beddab
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2154792
      > Reviewed-by: Clemens Backes <clemensb@chromium.org>
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Reviewed-by: Georg Neis <neis@chromium.org>
      > Reviewed-by: Tamer Tas <tmrts@chromium.org>
      > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#68168}
      
      Bug: v8:10577
      Change-Id: I268e590ee18a535b13dee14eeb15ddd0a9ee8341
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235115
      Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
      Reviewed-by: 's avatarTamer Tas <tmrts@chromium.org>
      Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
      Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#68989}
      d8f8a7e2
  2. 21 Jul, 2020 1 commit
    • Jakob Gruber's avatar
      [infra] Add and enable nci_as_highest_tier variant · d1fb6b5a
      Jakob Gruber authored
      With work on NCI proceeding, it makes sense to test multiple
      pipeline configurations.
      
      The nci variant (passes --turbo-nci) now spawns dedicated NCI
      compilation jobs and inserts generated code into the code cache.
      
      The nci_as_highest_tier variant (passes --turbo-nci-as-highest-tier)
      simply replaces TF with NCI code (no extra jobs, no extra caching).
      This mode stresses NCI generated code more than the nci variant, in
      which NCI code only runs on cache hits.
      
      Bug: v8:8888
      Change-Id: I4c2a43cce5271a6c288e7aba195dcc9daed6af9d
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2299361
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#68964}
      d1fb6b5a
  3. 06 Jul, 2020 1 commit
  4. 01 Jul, 2020 1 commit
  5. 23 Jun, 2020 1 commit
  6. 04 Jun, 2020 2 commits
  7. 13 May, 2020 1 commit
    • Jakob Gruber's avatar
      [infra] Add nci variant and enable it on fyi bots · a17a1724
      Jakob Gruber authored
      The native context independent (NCI) code variant will be used to test
      various aspects as the NCI implementation progresses. Examples:
      
      - Test js-generic-lowering with feedback collection.
      - Test NCI codegen without caching or tier-up.
      - Test NCI codegen and tier-up without caching.
      - Test full NCI (codegen, caching, tier-up).
      
      At some point a build-time flag may be required, we'll see when we get
      there.
      
      This variant should be removed once work on NCI is complete.
      
      Bug: v8:8888
      Change-Id: I8b12c9a5d69bf167e39e002af385f8f523585550
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2198776
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Auto-Submit: Jakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#67767}
      a17a1724
  8. 04 May, 2020 1 commit
  9. 18 Feb, 2020 1 commit
  10. 17 Feb, 2020 1 commit
  11. 24 Jan, 2020 1 commit
  12. 22 Jan, 2020 1 commit
  13. 17 Jan, 2020 2 commits
  14. 16 Jan, 2020 1 commit
    • Michael Achenbach's avatar
      [testrunner] Prevent erroneous overriding of signal handlers · d64a48db
      Michael Achenbach authored
      When an overall timeout is reached, swarming sends a SIGTERM to
      terminate the test runner. The test runner has a signal handler on the
      main process to terminate all workers gracefully.
      
      Additionally, every worker process installs a signal handler for
      terminating ongoing tests wrapped by command.Command.
      
      Also, command.Command is used on the main process to list tests for
      cctest and gtest executables, which led to overriding the test runner's
      main signal handler.
      
      This CL disables using signal handlers in commands by default and only
      explicitly enables it in safe source locations.
      
      Bug: v8:8292
      Change-Id: Ifceadaff75bdd2b77e761498bccbe00b6a3e265c
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002528Reviewed-by: 's avatarTamer Tas <tmrts@chromium.org>
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#65815}
      d64a48db
  15. 09 Jan, 2020 1 commit
  16. 08 Jan, 2020 1 commit
  17. 25 Nov, 2019 1 commit
  18. 12 Nov, 2019 1 commit
  19. 06 Nov, 2019 1 commit
  20. 29 Oct, 2019 1 commit
  21. 25 Oct, 2019 1 commit
  22. 22 Oct, 2019 2 commits
  23. 20 Sep, 2019 1 commit
  24. 09 Sep, 2019 1 commit
  25. 21 Aug, 2019 1 commit
  26. 05 Aug, 2019 3 commits
  27. 12 Jul, 2019 1 commit
  28. 25 Jun, 2019 1 commit
  29. 02 May, 2019 1 commit
  30. 23 Apr, 2019 1 commit
  31. 12 Apr, 2019 1 commit
  32. 09 Apr, 2019 1 commit
  33. 03 Apr, 2019 1 commit
  34. 18 Mar, 2019 1 commit