- 31 Jul, 2020 18 commits
-
-
Dan Elphick authored
This allows the configuration v8_enable_shared_ro_heap and v8_enable_pointer_compression on Linux and Android, although it still defaults to off. When pointer compression and read-only heap sharing are enabled, sharing is achieved by allocating ReadOnlyPages in shared memory that are retained in the shared ReadOnlyArtifacts object. These ReadOnlyPages are then remapped into the address space of the Isolate ultimately using mremap. To simplify the creation process the ReadOnlySpace memory for the first Isolate is created as before without any sharing. It is only when the ReadOnlySpace memory has been finalized that the shared memory is allocated and has its contents copied into it. The original memory is then released (with PC this means it's just released back to the BoundedPageAllocator) and immediately re-allocated as a shared mapping. Because we would like to make v8_enable_shared_ro_heap default to true at some point but can't make this conditional on the value returned by a method in the code we are yet to compile, the code required for sharing has been mostly changed to use ifs with ReadOnlyHeap::IsReadOnlySpaceShared() instead of #ifdefs except where a compile error would result due to the absence of a class members without sharing. IsReadOnlySpaceShared() will evaluate CanAllocateSharedPages in the platform PageAllocator (with pointer compression and sharing enabled) once and cache that value so sharing cannot be toggled during the lifetime of the process. Bug: v8:10454 Change-Id: I0236d752047ecce71bd64c159430517a712bc1e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2267300 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#69174}
-
Santiago Aboy Solanes authored
When we are not going to be accessing the heap anymore, we can park the LocalHeap which signals to not wait for this thread when requesting safepoints. There are a couple of places where we want to explicitly allow access to the heap, even though we have previously parked. We use UnparkedScope for those cases. Bug: v8:7790 Change-Id: Ic0acc51fe02af89836226670b828db4aafba4d0e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2319993 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#69173}
-
Dominik Inführ authored
We only use IsParked from the thread that owns the LocalHeap, which is the only thread which mutates state_. So it is safe to read state_ from that thread without a mutex. Bug: v8:10315 Change-Id: I3725ca4c4c4da1c661d7b4f06d295312914b4b52 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2332168Reviewed-by:
-
Omer Katz authored
Bug: chromium:1108537 Change-Id: Iafb87bb74aa15ac2005e43a62a95a83831ce4b03 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2332160Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#69171}
-
Dominik Inführ authored
Moves accounting of allocation observers into the AllocationCounter class. This CL removes top_on_previous_step_ for counters that are increased regularly in the slow path of the allocation functions. AdvanceAllocationObservers() informs the AllocationCounter about allocated bytes, InvokeAllocationObservers() needs to be invoked when an allocation step is reached. NextBytes() returns the number of bytes until the next AllocationObserver::Step needs to run. Bug: v8:10315 Change-Id: I8b6eb8719ab032d44ee0614d2a0f2645bfce9df6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2320650 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Bug: v8:10315 Change-Id: Ice1b4d2209985594506f0f40355f4a5ed8d3a7c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2332169Reviewed-by:
-
Igor Sheludko authored
This CL doesn't try to compress containers of Node* yet. Bug: v8:9923 Change-Id: Ica16b09b6f26321952b440d49a70f9a991d4275f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2324258 Commit-Queue: Igor Sheludko (OOO Aug 3-17) <ishell@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#69168}
-
Dominik Inführ authored
PersistentHandles were attached to the LocalHeap when passed in through the constructor but not when created inside LocalHeap using EnsurePersistentHandles. Bug: v8:10315 Change-Id: Id24d36c935776cb0b643521c465763da7fbffd06 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2326630 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Igor Sheludko authored
This is a reland of 13141c8a ... with a fix for an UB issue of passing null pointers to memcpy() when size is zero. TBR=leszeks@chromium.org Original change's description: > [zone-compr] Introduce ZoneTypeTraits and ZoneCompression > > Also move zone compression flags to src/common/globals.h. > > Bug: v8:9923 > Change-Id: Id0a77720e735e2669a1e5eef48e1b4866ad99480 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2324255 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#69160} Bug: v8:9923 Change-Id: I2245b81516c39ccea262c282c659ef601af57abf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2332165 Commit-Queue: Igor Sheludko (OOO Aug 3-17) <ishell@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
If an enum case has a type annotation, the corresponding enum constant has this type. This is useful for typing context slots. Bug: v8:7793 Change-Id: I8b91c3bd3686048f98cce3c034eec4e36f925e5b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2329631 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#69165}
-
Michael Achenbach authored
This is a JavaScript fuzzer originally authored by Oliver Chang. It is a mutation based fuzzer using Babel code transformations. For more information see the included README.md. The original code was altered: - Add new V8 copyright headers. - Make the test expectation generator aware of the headers. - Fix file endings for presubmit checks. - Fix `npm test` on fresh checkout with a new fake DB. - Make test skipping work with new v8/tools location. - OWNERS file. - New title section in README.md. No-Try: true Bug: chromium:1109770 Change-Id: Ie71752c0a37491a50500c49060a3c526716ef933 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2320330 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#69164}
-
Dan Elphick authored
Excluded regions are no longer available to the RegionAllocator, so should not be freeable so actually enforce that and aAdd a test. Bug: v8:10454 Change-Id: I51c41cf0bf3d2eeb699b10b1fa02f5465d93b6aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2330026Reviewed-by:
-
Nico Hartmann authored
This reverts commit 13141c8a. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20UBSan/12253? Original change's description: > [zone-compr] Introduce ZoneTypeTraits and ZoneCompression > > Also move zone compression flags to src/common/globals.h. > > Bug: v8:9923 > Change-Id: Id0a77720e735e2669a1e5eef48e1b4866ad99480 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2324255 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#69160} TBR=leszeks@chromium.org,ishell@chromium.org Change-Id: I01fc05b33d01c19f9a9432d4b2dd73cf8b38b972 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9923 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2332163Reviewed-by:
-
Clemens Backes authored
If we are near the stack limit, calling the proxy method might not work any more. Instead of crashing because of an empty MaybeLocal, handle this gracefully. Drive-by: Minor refactoring in TryGetValue. R=tebbi@chromium.org Bug: chromium:1110001 Change-Id: I07e7773768166b3dbea2e6b75a3ab8b24bfeee53 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2332156Reviewed-by:
-
Igor Sheludko authored
Also move zone compression flags to src/common/globals.h. Bug: v8:9923 Change-Id: Id0a77720e735e2669a1e5eef48e1b4866ad99480 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2324255Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#69160}
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: chromium:1111015 Change-Id: Ia56e38e1aa1b7de69b2203fe2b028f24cba16861 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2330024 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#69159}
-
Igor Sheludko authored
The shutdown process should destroy AccountingAllocator instance before the V8 platform. Bug: v8:9923 Change-Id: Iff76b64d16c42c711ce4ee0c3533acd5ba5aaaa5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2330020Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#69158}
-
Omer Katz authored
* GetThreadSlot was missing const (Blink CL failed to build). * Aligning IsEmptyThreadSafe implementation with IsEmpty. Bug: chromium:1108537 Change-Id: I9c07e9a0e7f029cf3d70b4d2507900b600d064cc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2330027 Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
- 30 Jul, 2020 21 commits
-
-
Shu-yu Guo authored
This normative PR reached consensus in the July 2020 TC39: https://github.com/tc39/ecma262/pull/2057 Bug: v8:10768 Change-Id: Ibe2affea0447b923435f77de5d3c0233deeb9877 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2327753 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#69156}
-
Shu-yu Guo authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/8575a6eb1..0f5a274aad Bug: v8:7834 Change-Id: Ie5fb4b4682f50d3c35d03b15a24b2680d4ecd175 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2327964 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#69155}
-
Dan Elphick authored
This adds new methods AllocateSharedPages, ReserveForSharedMemoryMapping and CanAllocateSharedPages to v8::PageAllocator, which if overridden allows the platform to declare that it supports allocation and remapping of shared memory. This interface is currently a work in progress so the new methods are marked "INTERNAL ONLY" and they may change without being first deprecated. An implementation of PageAllocator is provided that can allocate and map shared memory on Linux and Android, but no other platforms are yet supported. While Windows is not supported the interface has been designed to make this possible as AllocateSharedPages returns a SharedMemory object that wraps the shared memory and provides its own remap function. This should allow the SharedMemory object on windows to contain a mapping a to hFileMappingObject as required by MapViewOfFileEx. Bug: v8:10454 Change-Id: I2e601d49ea14da44867a102c823fa4e341cf0dab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2306789Reviewed-by:
-
Frank Tang authored
This is a reland of 482c3bbf Original change's description: > [Intl] Sync Intl.Segmenter to latest version > > https://tc39.es/proposal-intl-segmenter/ > > TC39 passed Intl.Segmenter to stage 3 in Jul 21. > This CL move our earlier prototype to the current spec. > > Bug: v8:6891 > Change-Id: I07234beed54f671c26bdbfb3983c5bc2fa5a29b0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2219413 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Frank Tang <ftang@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#69080} Bug: v8:6891 Change-Id: Ie3a02d8ddf6f95f0632f97b38b613b185abeb592 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2321118Reviewed-by:
Frank Tang <ftang@chromium.org> Reviewed-by:
-
Frank Tang authored
The resolvedOptions of Intl.NumberFormat depends on the ICU's skeleton. sffc change the output of the wildcard from + to * in ICU67 (https://github.com/unicode-org/icu/commit/ac4540f8a45775ba1aafdb352e2561c0d1527329) Change the v8 code to use * instead. Bug: chromium:1108810 Change-Id: I8b0249a5bc4cc199f454c5070635100f68d1f48d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2318272Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#69152}
-
Ng Zhi An authored
This was previously running on TurboFan and scalar lowering. Since Liftoff has gained support for shuffle instructions, we can run it there too. Bug: v8:10696 Change-Id: I5a33d500b8e584ec4d6ffd29373593aabebae4b6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2327183 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#69151}
-
Ng Zhi An authored
Change all the callers in backend specific instruction-selector to call the functions in simd-shuffle.h Also copy over the documentation that was in instruction-selector.h to simd-shuffle.h. Bug: v8:10696 Change-Id: Ic9339d6481316f18c19f35c45460e700b45ec38e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2327182 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Ng Zhi An authored
These are no longer tied to instruction-selector, so move them out into their own unittests. We can then remove the *ForTesting methods. Bug: v8:10696 Change-Id: I387cf38290d9602b011ee1d13ee5285ac660f208 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2326951Reviewed-by:
-
Shu-yu Guo authored
This is a spec bug in V8. Only call expressions literally of the form 'eval(...)' are considered direct. Bug: v8:10688 Change-Id: Ia5ac9992db82cad0ad6870119bd94a0b4daee417 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2327752Reviewed-by:
-
Liviu Rau authored
This reverts commit 5ee39a50. Reason for revert: To trigger builders again Original change's description: > Whitespace to trigger builders > > TBR: clemensb@chromium.org > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Change-Id: Id8dba0dad4b7bfd68ed7c0300ddfeac2b9c349b2 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2330012 > Reviewed-by: Liviu Rau <liviurau@chromium.org> > Commit-Queue: Liviu Rau <liviurau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#69146} TBR=clemensb@chromium.org,liviurau@chromium.org Change-Id: Iff68a4ab57a30bdc594a49f3ff0cff43740b6634 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2330015Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#69147}
-
Liviu Rau authored
TBR: clemensb@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Id8dba0dad4b7bfd68ed7c0300ddfeac2b9c349b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2330012Reviewed-by:
-
Gus Caplan authored
Bug: v8:9891 Change-Id: Ief289a9990ac545aa479f564094e3bbde4144aae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2293709 Commit-Queue: Gus Caplan <snek@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... by ensuring that the V8 platform is initialized before the AccountingAllocator used in the tests. Bug: v8:9923 Change-Id: I2d75b7c26dab55b9258c1be800a37a6f777f1103 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2328791Reviewed-by:
-
Santiago Aboy Solanes authored
This is to group them up and not have classes and methods intertwined. Change-Id: I8147f06f060932f7b70e478324ce5868d0ffd5d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2328786Reviewed-by:
-
Omer Katz authored
Bug: chromium:1108537 Change-Id: I82a64d57432b7e0854a3787f309c85477d37f701 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2327910Reviewed-by:
-
Ross McIlroy authored
Adds unittests that test the fast register allocator correctly deals with spills of Phi's between their definition and a predecessor block's gap move to populate the Phi. BUG=v8:9684 Change-Id: I17263058d5ac29088895ad3de7b3131315ec8fae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2299371 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Due to dynamic map checks we generate different code and the pattern fails. As a note, the other tests have already been disabled for TurboProp. Bug: v8:9684, v8:9820 Change-Id: Ib8be11ae10bc801116d6a17d1c6b08d8026287b3 Fixes: v8:9820 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2328784 Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Ross McIlroy authored
Adds support for Phis to be allocated to the fast register allocator. Registers used for Phis are marked specially between the point where the Phi is defined, and the gap-move's in the predecessor blocks which populate the Phi value, since if the Phi is spilled then all predecessor blocks must also spill the Phi even if they were already allocated. BUG=v8:9684 Change-Id: Iebe90495b83df655d3335a7d55874123f3b27f8d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2299366 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Dominik Inführ authored
PersistentHandlesScope works similar to the DeferredHandleScope, but returns PersistentHandles instead of DeferredHandles on Detach(). Since PersistentHandlesScope takes over filled blocks from the main thread local handle, remove the block_size_ field and use kHandleBlockSize instead. This way all blocks have exactly the same size. Bug: v8:10315 Change-Id: I295cad6f84852f87c55d95572905069443f5698c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2324254 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
The DecompressionOptimizationPhase performs MachineRepresentation changes in the nodes, which causes the node's instruction selection to avoid decompression. It is safe to run after we already have a schedule since it does not drop any nodes. Bug: v8:9684, v8:7703 Change-Id: I636ae80fa82d0c78878756e9f39e7a14c02803b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2324252 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#69137}
-
Z Nguyen-Huu authored
Bug: v8:10477 Change-Id: I0ce6cd46d3886a37e96bdd62df263addc5b9631f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2327186Reviewed-by:
-
- 29 Jul, 2020 1 commit
-
-
Milad Farazmand authored
lvx and stvx require 16-byte aligned addresses. This CL enables loading and storing to addresses which are not 16-byte aligned. Change-Id: I5635e857a979520822c8b30bb5477a159e97e6e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2327648Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#69135}
-
