- 15 Dec, 2015 12 commits
-
-
yangguo authored
Revert of [WIP][turbofan] Instruction scheduler for Turbofan. (patchset #7 id:120001 of https://codereview.chromium.org/1375253002/ ) Reason for revert: Does not compile https://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug%20builder/builds/6870/steps/compile/logs/stdio Original issue's description: > [turbofan] Instruction scheduler for Turbofan. > > Implement machine instruction scheduling after instruction selection. > > Currently only works for arm64. > > R=danno@chromium.org, bmeurer@chromium.org, titzer@chromium.org > > Committed: https://crrev.com/e11bba3acd5188f0e12686b6fcf3e0ab22989216 > Cr-Commit-Position: refs/heads/master@{#32858} TBR=jarin@chromium.org,bmeurer@chromium.org,baptiste.afsa@arm.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1526913002 Cr-Commit-Position: refs/heads/master@{#32860}
-
yangguo authored
credits to gcov. R=vogelheim@chromium.org Review URL: https://codereview.chromium.org/1529763002 Cr-Commit-Position: refs/heads/master@{#32859}
-
baptiste.afsa authored
Implement machine instruction scheduling after instruction selection. Currently only works for arm64. R=danno@chromium.org, bmeurer@chromium.org, titzer@chromium.org Review URL: https://codereview.chromium.org/1375253002 Cr-Commit-Position: refs/heads/master@{#32858}
-
yangguo authored
Debug evaluate no longer writes back changes to the replicated context chain to the original after execution. Changes to the global object or script contexts still stick. Calling functions that bind to the original context chain also have their expected side effects. As far as I can tell, DevTools is not interested in modifying local variable values. Modifying global variable values still works as expected. However, I have not yet removed the old implementation, but merely keep it behind a flag. R=mstarzinger@chromium.org, rossberg@chromium.org Committed: https://crrev.com/92caa9b85eefffbef51c67428397951bd2e2c330 Cr-Commit-Position: refs/heads/master@{#32841} Review URL: https://codereview.chromium.org/1513183003 Cr-Commit-Position: refs/heads/master@{#32857}
-
yangguo authored
We used to flood the handler when preparing for stepping, even if we may not throw. Instead, we now flood the handler only when we actually throw. This also solves an issue with step-next when we throw and leave the function unexpectedly. In combination with microtasks, this could cause a crash. R=mstarzinger@chromium.org BUG=chromium:568477 LOG=N Review URL: https://codereview.chromium.org/1527593002 Cr-Commit-Position: refs/heads/master@{#32856}
-
machenbach authored
Revert of [stubs] Fix TypeOfStub to properly return "undefined" for undetectable. (patchset #1 id:1 of https://codereview.chromium.org/1527863003/ ) Reason for revert: [Sheriff] Changes layout tests. Please fix upstream first: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3491 Original issue's description: > [stubs] Fix TypeOfStub to properly return "undefined" for undetectable. > > The TypeOfStub didn't test the undetectable bit properly if the instance > was also callable, and therefore returned "object" for document.all > (which is both undetectable and callable). > > R=yangguo@chromium.org > BUG=chromium:567998 > LOG=n > > Committed: https://crrev.com/02cc310370df7e51ac4f705038820066fdfd0cdc > Cr-Commit-Position: refs/heads/master@{#32852} TBR=yangguo@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:567998 Review URL: https://codereview.chromium.org/1525703003 Cr-Commit-Position: refs/heads/master@{#32855}
-
zhengxing.li authored
port 56673804 (r32803) original commit message: BUG= Review URL: https://codereview.chromium.org/1524063002 Cr-Commit-Position: refs/heads/master@{#32854}
-
zhengxing.li authored
X87: [proxy] fixing for-in for proxies, fixing harmony/proxy.js tests, improving error messages and some drive-by fixes. port df2a9297 (r32801) original commit message: BUG= Review URL: https://codereview.chromium.org/1523993003 Cr-Commit-Position: refs/heads/master@{#32853}
-
bmeurer authored
The TypeOfStub didn't test the undetectable bit properly if the instance was also callable, and therefore returned "object" for document.all (which is both undetectable and callable). R=yangguo@chromium.org BUG=chromium:567998 LOG=n Review URL: https://codereview.chromium.org/1527863003 Cr-Commit-Position: refs/heads/master@{#32852}
-
Benedikt Meurer authored
R=machenbach@chromium.org TBR=rmcilroy@chromium.org Review URL: https://codereview.chromium.org/1522343002 . Cr-Commit-Position: refs/heads/master@{#32851}
-
Adam Klein authored
Turning it off broke both the trace viewer and using the devtools to connect to an earlier version of Chrome running on another device. BUG=chromium:552100, chromium:569417, chromium:569647 TBR=rossberg@chromium.org LOG=y Review URL: https://codereview.chromium.org/1521993004 . Cr-Commit-Position: refs/heads/master@{#32850}
-
v8-autoroll authored
Rolling v8/build/gyp to b85ad3e578da830377dbc1843aa4fbc5af17a192 Rolling v8/tools/clang to f8fd8b699f6c474577b455e55b22df23ceaa2da8 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1527613005 Cr-Commit-Position: refs/heads/master@{#32849}
-
- 14 Dec, 2015 26 commits
-
-
mstarzinger authored
This unifies the decision whether to use Ignition or FullCodeGenerator to generate baseline code into a single place. This allows for small function literals that are compiled eagerly to go through Ignition. R=rmcilroy@chromium.org Review URL: https://codereview.chromium.org/1525663002 Cr-Commit-Position: refs/heads/master@{#32848}
-
mstarzinger authored
This removes the ability to generate stub code via the full-fledged compiler pipeline that parses and analyzes JavaScript source code. Generation of stub code has been moved to a lower-level entry point. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1520373002 Cr-Commit-Position: refs/heads/master@{#32847}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1526663002 Cr-Commit-Position: refs/heads/master@{#32846}
-
machenbach authored
Revert of [debugger] debug-evaluate should not not modify local values. (patchset #2 id:20001 of https://codereview.chromium.org/1513183003/ ) Reason for revert: [Sheriff] Layout test changes. Original issue's description: > [debugger] debug-evaluate should not not modify local values. > > Debug evaluate no longer writes back changes to the replicated > context chain to the original after execution. Changes to the > global object or script contexts still stick. Calling functions > that bind to the original context chain also have their expected > side effects. > > As far as I can tell, DevTools is not interested in modifying > local variable values. Modifying global variable values still > works as expected. However, I have not yet removed the old > implementation, but merely keep it behind a flag. > > R=mstarzinger@chromium.org, rossberg@chromium.org > > Committed: https://crrev.com/92caa9b85eefffbef51c67428397951bd2e2c330 > Cr-Commit-Position: refs/heads/master@{#32841} TBR=mstarzinger@chromium.org,rossberg@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1526553003 Cr-Commit-Position: refs/heads/master@{#32845}
-
jkummerow authored
- proxies-with-unscopables needed updating of trap names - proxies-symbols doesn't make sense any more: it tested symbol fitering/ blacklisting, but Proxies interact with Symbols just fine according to the current spec. BUG=v8:1543 LOG=n Review URL: https://codereview.chromium.org/1529473002 Cr-Commit-Position: refs/heads/master@{#32844}
-
neis authored
This CL tries to correctly support the following: - stringifying a proxy, - stringifying with a proxy as replacer (callable or arraylike), - stringifying with a replacer that returns a proxy, - parsing with a callable proxy as reviver, - parsing with a reviver that inserts proxies into the object, - and whatever else you can imagine. This also fixes some bugs observable without proxies. BUG=v8:3139,v8:1543 LOG=n Review URL: https://codereview.chromium.org/1515133002 Cr-Commit-Position: refs/heads/master@{#32843}
-
ahaas authored
The test Run_Wasm_StoreMem_offset_oob contained an I64STORE instruction, which is not yet implemented on 32 bit platforms. I turned off those parts of the test on 32 bit platforms which contain I64 instructions. R=bradnelson@chromium.org Review URL: https://codereview.chromium.org/1526573002 Cr-Commit-Position: refs/heads/master@{#32842}
-
yangguo authored
Debug evaluate no longer writes back changes to the replicated context chain to the original after execution. Changes to the global object or script contexts still stick. Calling functions that bind to the original context chain also have their expected side effects. As far as I can tell, DevTools is not interested in modifying local variable values. Modifying global variable values still works as expected. However, I have not yet removed the old implementation, but merely keep it behind a flag. R=mstarzinger@chromium.org, rossberg@chromium.org Review URL: https://codereview.chromium.org/1513183003 Cr-Commit-Position: refs/heads/master@{#32841}
-
machenbach authored
BUG=chromium:568949 LOG=n NOTRY=true Review URL: https://codereview.chromium.org/1520163003 Cr-Commit-Position: refs/heads/master@{#32840}
-
bradnelson authored
R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1526623002 Cr-Commit-Position: refs/heads/master@{#32839}
-
sigurds authored
Move replacements out of virtual object. Replacements are global to the graph and are not dependent on the virtual state (after they are discovered). R=mstarzinger@chromium.org BUG=v8:4586 LOG=n Review URL: https://codereview.chromium.org/1527533002 Cr-Commit-Position: refs/heads/master@{#32838}
-
mstarzinger authored
This uses the same pipeline entry function for all three assemblers currently supported by TurboFan. The Pipeline::GenerateCodeForCodeStub is by now generic enough to accommodate all uses. R=vogelheim@chromium.org Review URL: https://codereview.chromium.org/1521363003 Cr-Commit-Position: refs/heads/master@{#32837}
-
neis authored
This CL makes proxy-related error messages more accurate and verbose. (Exception: those used in deprecated functions in v8natives.js.) Some of the old error messages were simply wrong. On the side, fix ShouldThrow semantics of JSProxy::SetPrototype and JSProxy::DefineOwnProperty. R=cbruni@chromium.org, jkummerow@chromium.org BUG=v8:1543 LOG=n Review URL: https://codereview.chromium.org/1527583002 Cr-Commit-Position: refs/heads/master@{#32836}
-
yangguo authored
The parser reads one character beyond EOF to have an additional source position that the rewriter can use to insert the implicit return statement at the end of a script. If we break at that return statement, we need to be able to translate the source position to line and column number. R=jkummerow@chromium.org BUG=chromium:569514 LOG=N Committed: https://crrev.com/0b1076a68e1eadba260cec8afc5acec618561c28 Cr-Commit-Position: refs/heads/master@{#32825} Review URL: https://codereview.chromium.org/1521953003 Cr-Commit-Position: refs/heads/master@{#32835}
-
jkummerow authored
BUG=v8:1543 LOG=n Review URL: https://codereview.chromium.org/1514123002 Cr-Commit-Position: refs/heads/master@{#32834}
-
sigurds authored
Bugfixes and improvements in escape analysis include: * Handling of ObjectIsSmi (non-escaping) * Handling of nested phi replacements * Handling of phis with arity > 2 * Resilience against effectful nodes dangling from start * Allocations escape now, if non-const load/store is performed * Fixed a bug where non-allocated objects where tracked * Allow fixed double arrays to be tracked R=mstarzinger@chromium.org BUG=v8:4586 LOG=n Review URL: https://codereview.chromium.org/1510973006 Cr-Commit-Position: refs/heads/master@{#32833}
-
neis authored
BUG=v8:1543 LOG=N R=cbruni@chromium.org,jkummerow@chromium.org Review URL: https://codereview.chromium.org/1519073002 Cr-Commit-Position: refs/heads/master@{#32832}
-
yangguo authored
It has been broken by https://crrev.com/089edbfa97eab324bc463829ea03c167fdc6d45c R=machenbach@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1522883002 Cr-Commit-Position: refs/heads/master@{#32831}
-
yangguo authored
R=littledan@chromium.org, rossberg@chromium.org BUG=v8:4545 LOG=Y Review URL: https://codereview.chromium.org/1512253003 Cr-Commit-Position: refs/heads/master@{#32830}
-
yangguo authored
Revert of [debugger] correctly find source position of implicit return statement. (patchset #1 id:1 of https://codereview.chromium.org/1521953003/ ) Reason for revert: Layout test failures: https://chromegw.corp.google.com/i/client.v8.fyi/builders/V8-Blink%20Mac/builds/2732/steps/webkit_tests%20%28with%20patch%29/logs/stdio Original issue's description: > [debugger] correctly find source position of implicit return statement. > > The parser reads one character beyond EOF to have an additional source > position that the rewriter can use to insert the implicit return > statement at the end of a script. If we break at that return statement, > we need to be able to translate the source position to line and > column number. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/0b1076a68e1eadba260cec8afc5acec618561c28 > Cr-Commit-Position: refs/heads/master@{#32825} TBR=jkummerow@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1526583002 Cr-Commit-Position: refs/heads/master@{#32829}
-
yangguo authored
Debug-evaluate used to resolve stack variables that shadow context variables incorrectly, since the stack variable is not visible in the context chain. To fix this, we limit local variables accessible by debug- evaluate to the ones directly referenced inside the function. What is not referenced by the function itself, is considered optimized out and not accessible by debug-evaluate. To achieve this, we duplicate the entire context chain up to the native context, and write back changes after debug- evaluate. Changes to the original context chain will however be overwritten. This already happens for catch and block scopes though. Also fix a crash caused by declaring variables inside debug- evaluate. R=mstarzinger@chromium.org BUG=v8:4593 LOG=N Review URL: https://codereview.chromium.org/1500933002 Cr-Commit-Position: refs/heads/master@{#32828}
-
yangguo authored
BUG=v8:4344 LOG=N R=littledan@chromium.org Review URL: https://codereview.chromium.org/1506353009 Cr-Commit-Position: refs/heads/master@{#32827}
-
yangguo authored
R=littledan@chromium.org BUG=v8:4342 LOG=Y Review URL: https://codereview.chromium.org/1509733010 Cr-Commit-Position: refs/heads/master@{#32826}
-
yangguo authored
The parser reads one character beyond EOF to have an additional source position that the rewriter can use to insert the implicit return statement at the end of a script. If we break at that return statement, we need to be able to translate the source position to line and column number. R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1521953003 Cr-Commit-Position: refs/heads/master@{#32825}
-
Michael Achenbach authored
Cr-Commit-Position: refs/heads/master@{#32824}
-
bmeurer authored
Since the parser now desugars super constructor calls to simple primitives, we can also easily optimize those in fullcodegen w/ just a few simple lines of native code per architecture. This code in particular should be fast, so it seems worth the code in fullcodegen. BUG=v8:3330 LOG=n Review URL: https://codereview.chromium.org/1524673002 Cr-Commit-Position: refs/heads/master@{#32823}
-
- 12 Dec, 2015 2 commits
-
-
v8-autoroll authored
Rolling v8/tools/clang to ea0740546b2f5aa7dd9dd2ff5128b031717adc02 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1519353002 Cr-Commit-Position: refs/heads/master@{#32822}
-
paul.lind authored
Invalidate the instanceof cache in proxy-case of InstanceOfStub after the changes in https://codereview.chromium.org/1492243003. This didn't have a test case until https://codereview.chromium.org/1518773003 TEST=mjsunit/es6/instanceof-proxies.js BUG= Review URL: https://codereview.chromium.org/1519303002 Cr-Commit-Position: refs/heads/master@{#32821}
-