• yangguo's avatar
    [debugger] debug-evaluate should not not modify local values. · 92caa9b8
    yangguo authored
    Debug evaluate no longer writes back changes to the replicated
    context chain to the original after execution. Changes to the
    global object or script contexts still stick. Calling functions
    that bind to the original context chain also have their expected
    side effects.
    
    As far as I can tell, DevTools is not interested in modifying
    local variable values. Modifying global variable values still
    works as expected. However, I have not yet removed the old
    implementation, but merely keep it behind a flag.
    
    R=mstarzinger@chromium.org, rossberg@chromium.org
    
    Review URL: https://codereview.chromium.org/1513183003
    
    Cr-Commit-Position: refs/heads/master@{#32841}
    92caa9b8
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...