- 16 Jun, 2020 8 commits
-
-
Georgia Kouveli authored
The C++ code uses the A instruction key for return address signing, which is the default for Clang and GCC when the -mbranch-protection option is used (although this can be configured to use the B key). Using the B key for JS means that it's not possible to use an A key signing gadget to replace a return address signed with the B key and vice-versa. This should offer a degree of separation from the C++ side. Bug: v8:10026 Change-Id: Ia9dcc7ae7096c96b4a271efbe25fc02940f6fc8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2242953Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> Cr-Commit-Position: refs/heads/master@{#68360}
-
Anton Bikineev authored
Bug: chromium:1029379 Change-Id: I9b030cd8d130793ba5b79303b71e3d60be981218 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2246567 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#68359}
-
Anton Bikineev authored
This also introduces CagedHeapLocalData. Bug: chromium:1029379 Change-Id: Ice04fe5ad7daa02f17ad107e78e53bdd32479737 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2246560Reviewed-by:
-
Marja Hölttä authored
The DCHECK is true in the current V8 / Chrome. However, an embedder can create a snapshot where the object in question has dictionary properties (by using the object as a prototype). When reading the snapshot, in the object already has dictionary properties, and adding a property to it won't change it. The erroneous DCHECK was used to assert that adding a property to an object won't turn it to dictionary mode. But now it's in the wrong place, since this part of the code is executed after reading the snapshot in. The corresponding DCHECKs which are executed when setting up the objects before snapshot creation are still valid. Fixing the behavior wrt whether the object should turn dictionary mode or whether it should turn back is beyond the scope of this CL. See https://github.com/nodejs/node-v8/issues/160 Bug: v8:10479 Change-Id: Ie62c80495d4f4494eeb3a16b5bfe02305c0cac95 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2246577Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#68357}
-
Kim-Anh Tran authored
Extract commonly used instantiate() and evalWithUrl() functions. Bug: chromium:1093165 Change-Id: I14f8b49d556bc70d2092a80b41c5bbf678efd1a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2245599 Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#68356}
-
Andreas Haas authored
Recently the test harness of the js-api spec tests got updated to the test harness of wpt. With this CL we import the wpt test harness into V8. Some adjustments to the test harness had to be made. These additions are in the new files report.js and testharness-additions.js Bug: v8:10556 Change-Id: Ia5f7dec3f40ba8fc639135fb2b2078b9220eccf7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235116 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Emanuel Ziegler <ecmziegler@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#68355}
-
Frank Tang authored
Dep on https://chromium-review.googlesource.com/c/chromium/deps/icu/+/2242106 Bug: v8:10443 Change-Id: I258d3452120004df627af8d1c5f2b249d4b334c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2242260 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68354}
-
Deepti Gandluri authored
Change-Id: Ie7bf807a51b2dd822b956a92d0051bfabcaf81eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2246528Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#68353}
-
- 15 Jun, 2020 21 commits
-
-
Ng Zhi An authored
Bug: v8:10180 Change-Id: I729761b27786d84b0a730e2e001574eb329b7ef9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2243759Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#68352}
-
Milad Farazmand authored
Change-Id: I1b045c2c3e9b199d3f24b191639b5f8c28e8ac5b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2247038Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#68351}
-
Milad Farazmand authored
Change-Id: I93cc2793ab12602d0bd7df223bd662b10294e450 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2246853Reviewed-by:
-
Michael Lippautz authored
- Document internal namespace - Various trivial fixes Bug: chromium:1056170 Change-Id: If527d491a37d7ccd0aa4ff829ccc5dc06c02da38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2246569 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#68349}
-
Ng Zhi An authored
Bug: v8:10347 Change-Id: I58ca7604ffb17a0fbc2ecc2799fc6888c26a7853 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237354 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Implements f32x4 and f64x2 ceil, floor, trunc, nearestint for ia32. Bug: v8:10553 Change-Id: I272c20441297b9aebd39bc7ff96870b40e8ac653 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2227257 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/d2f7d428..f89ea875 Bug: v8:7834, v8:10554, v8:6891, v8:10395, v8:10449, v8:10578 Change-Id: I7fb15d34a80c38ec2adbfc25da6426462f549906 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2244434Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#68346}
-
Ng Zhi An authored
See https://clang.llvm.org/extra/clang-tidy/checks/google-readability-casting.html and https://google.github.io/styleguide/cppguide.html#Casting. Bug: v8:10488 Change-Id: Ia5ac4216066dc591e0492a6c0c66305faa94aa81 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2233986Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#68345}
-
Ng Zhi An authored
The intention is to print the address of Block, print it without any cast. See https://clang.llvm.org/extra/clang-tidy/checks/google-readability-casting.html and https://google.github.io/styleguide/cppguide.html#Casting. Bug: v8:10488 Change-Id: Id174083d0c51518a808459b1b4cd12d5aa9781ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2240503Reviewed-by:
-
Ng Zhi An authored
This is a reland of 3692bef9 Integer overflow in the test code is fixed by using MulWithWraparound. Original change's description: > [wasm-simd][x64] Prototype i32x4.dot_i16x8_s > > This implements I32x4DotI16x8S for x64 and interpreter. > > Bug: v8:10583 > Change-Id: I404ac68c19c1686a93f29c3f4fc2d661c9558c67 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2229056 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68244} Bug: v8:10583 Change-Id: Ie7d0032f5398b6f725c02b572764258adacc8578 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2236962Reviewed-by:
-
Thibaud Michaud authored
When inserting the temporary cache key for synchronous compilation, use the NativeModule's owned wire bytes. When we eventually install the native module, key comparison can then take the fast path by checking base pointer equality instead comparing the full bytes. R=clemensb@chromium.org Bug: chromium:1035786, v8:10576 Change-Id: I4bfb948b4383d58dd11060a7d1d1e0495ddeed2a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2246559Reviewed-by:
-
Santiago Aboy Solanes authored
Bug: v8:7790 Change-Id: I1c6622bd476832852af64c299dcf952bc9e92fe5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2245602Reviewed-by:
-
Arnaud Robin authored
The registers were not spilled correctly in liftoff when tracing function calls, which caused runtime errors. R=clemensb@chromium.org CC=thibaudm@chromium.org Bug: v8:10559 Change-Id: Ic0a9ae8a286bdee8f8440e006d0b47e52241ea5a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2245595Reviewed-by:
-
Jakob Gruber authored
... to OptimizedCompilationInfo, BytecodeGraphBuilder, and JSHeapBroker. Also add first uses of these flags in pipeline.cc by skipping certain phases when nci is enabled. With this change, tests in the NCI variant will start to fail since generic lowering is not fully implemented. These implementations will follow incrementally in the next days. Bug: v8:8888 Change-Id: I3f570fb92f09059d1f1f4015f88ffe80ccf746ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2239572 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Introduce HeapBase as an internal base implementation for concrete heaps (unified, stand-alone). Change-Id: I0aa7185e23f83e01e4e2ca23d983b28e32bb610e Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2238573 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Yang Guo authored
R=szuend@chromium.org Fixes: chromium:718827 Change-Id: I261ce2cf692b5bcf88f4f7f67249ec49c837de4e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2241521Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#68337}
-
Emanuel Ziegler authored
This is a reland of change Idb1061cafcba7a2a654a207402dca520f79a3bbe. The access to wire_bytes has been protected by using atomic operations. Under some circumstances, Wasm is trying to log code for which the wire bytes are not fully loaded yet. This can happen during streaming compilation when a few functions are already fully compiled but the engine is still streaming the remaining functions. If the profiler now kicks in, it will attempt to log these freshly compiled functions. As these functions will not be executed before the module is fully compiled, we can simply defer the logging in this case. R=clemensb@chromium.org Bug: chromium:1085852 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng Change-Id: Iccb6607e8adb9fdaf6138d4ccd30de58d6a6cdff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2230536 Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Reviewed-by:
-
Clemens Backes authored
We currently hit a nullptr access when trying to update the detected feature set. Instead of adding a check for nullptr there (which would be unnecessary overhead in production code), we just pass a pointer when compiling for debugging. R=thibaudm@chromium.org Bug: chromium:1092408 Change-Id: I7804edc3f67237bbf28d0ed2f5c58339d3a0f8f7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2238080Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68335}
-
Andreas Haas authored
R=v8-arm-ports@googlegroups.com, clemensb@chromium.org Bug: v8:10108 Change-Id: I2026c50536a3053aa3bc7d412ed67ff13c5fa0e3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2231338 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Jakob Gruber authored
We recently changed uc32 to be an unsigned type, and with the invalid marker being static_cast<uc32>(-1) this DCHECK no longer holds. After this CL it expicitly checks for the invalid marker. Bug: v8:10568,chromium:1094226 Change-Id: Idd9efe055b38387e3e37b132cb786cca130767b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2245592 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#68333}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/80a5599..908ea81 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iaa95742acd71c233dc06f7335e3f03fb64feb89e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2245216Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#68332}
-
- 14 Jun, 2020 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6fbfa22..80a5599 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/5e1d63a..79a0420 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia26223b35726dd00abede7ff99d804dd9f40dd38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2245088Reviewed-by:
-
- 13 Jun, 2020 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8038ef2..6fbfa22 Rolling v8/third_party/aemu-linux-x64: 57_eaFwoIK_Q_ctYaumI8hKikv527lQj5R7ctUOZBz4C..VTMne1aEixrBYfQxsfnRBgzudRPhjV-iUQeXgznyNqgC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/d3a5699..b919b00 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/44de5e3..03705f6 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/46f53df..9e7dae8 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/a68151f..eaf99a4 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I25eb86876a8eb304594c9c242cf7849b46e02766 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2244313Reviewed-by:
-
- 12 Jun, 2020 9 commits
-
-
Frank Tang authored
https://tc39.es/proposal-intl-datetime-style/ (Jun 10, 2020) fix extra s in message Bug: v8:10613 Change-Id: I2ef4f4004c1e8f0a58bf4409578876d1553de59b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2242258 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Andreas Haas authored
We want to enable the wasm-bigint implementation by default. However, at the moment there exist several tests which fail when wasm-bigint gets enabled. With this CL we adjust or delete these tests so that they pass once wasm-bigint gets enabled. At the same time we disable these tests for now, and re-enable them in the CL that flips the flag. R=jkummerow@chromium.org Bug: v8:7741 Change-Id: I733bfe7ff19e403913b143e6ea86ab13602ab993 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2243212 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Ng Zhi An authored
This default constructor is used in a couple of places (e.g. compilation-cache.cc) to hold a default value that is later overwritten. See https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++-dos-and-donts.md#prefer-to-use. Bug: v8:10488 Change-Id: Ibe4741cebdcf7c350580de3e6b0bd10fd8b7be73 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2240504Reviewed-by:
-
Etienne Pierre-doray authored
To investigate jank found in UMA sampling profiler. Bug: chromium:1081433 Change-Id: I457731380505af5a4d7a0c30d01b4049ffd2b436 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2242037 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Port 4559bd69 Original Commit Message: Implements f32x4 and f64x2 ceil, floor, trunc, nearestint, arm64. R=zhin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I055b5d9c725c51df9e2e3e8274ed8c6a57e7dfad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2242140Reviewed-by:
-
Seth Brenith authored
The graph verifer caught this bug. The offset in a load instruction should be pointer-sized. Bug: v8:10605 Change-Id: I816165c9c9ef4f0d7fbdcaf9c70faf845dbbb9fd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2238016Reviewed-by:
-
Manos Koukoutos authored
Change-Id: I959409fb1a4f2d427c252f3904b197b71e335825 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2241520Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#68323}
-
Ulan Degenbaev authored
This also removes unused free list classes. Change-Id: I705ca3aca94e404cf388e6c9bac2ff9f3c38fe10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2241525 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#68322}
-
Manos Koukoutos authored
This function wasm created as a partial subtyping check after the subtyping refactoring for wasm-gc, but is really not needed. Change-Id: I5f3a38dba599f1571e26d29254eb0f8614c16a8b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2241519Reviewed-by:
-
