- 28 Jan, 2019 31 commits
-
-
Jakob Kummerow authored
The workaround is simple: cast to unsigned before shifting. Bug: v8:3770 Change-Id: I5f0f7af697ec5db0ab1df3d061008940c83c5c56 Reviewed-on: https://chromium-review.googlesource.com/c/1436215Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#59140}
-
Adam Klein authored
This reverts commit 3145505a. Reason for revert: breaks jumbo build due to interpreter::Register using declaration Original change's description: > [turbofan] Support new.target in the serializer. > > Bug: v8:7790 > Change-Id: Ie98cff6f8b1f184c8152952cc3d39e373c93565d > Reviewed-on: https://chromium-review.googlesource.com/c/1435943 > Commit-Queue: Georg Neis <neis@chromium.org> > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59118} TBR=neis@chromium.org,mslekova@chromium.org Change-Id: I81369da5e7a9b3ec946737bbb2fc349b51e3bd7f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7790 Reviewed-on: https://chromium-review.googlesource.com/c/1440116Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#59139}
-
Wez authored
The ZX_VM_FLAG_PERM_* names have been deprecated in favour of the ZX_VM_PERM_* form, and will shortly be removed from the Fuchsia SDK. Bug: chromium:925597 Change-Id: Ic05912cbf9758915e1bc97c41c682aee028a3b5d Reviewed-on: https://chromium-review.googlesource.com/c/1437817Reviewed-by:
-
Irina Yatsenko authored
If running under debugger: 1. Output from _v8_internal_Print_Object into debugger's command window 2. Break into debugger before aborting Change-Id: I49e4d83c817e6588c4679c9fb9766602927542db Reviewed-on: https://chromium-review.googlesource.com/c/1435771 Commit-Queue: Irina Yatsenko <irinayat@microsoft.com> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#59137}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I40e8068630deda0396680e062d471cda0c4ef875 Reviewed-on: https://chromium-review.googlesource.com/c/1439416 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
peterwmwong authored
Two small changes were done as part of the port: - Changes TypedArrayInitializeWithBuffer from a TFS builtin to a macro. It was only called from ConstructByArrayBuffer and this removes the overhead of the TFS call. - Introduces a GetTypedArrayElementsInfo that retrieves both the element size and map. Instead of generating the elements kind switch code ( DispatchTypedArrayByElementsKind) twice, just generate once at the beginning of CreateTypedArray. This reduces overall builtins size by 364 bytes (Mac x64.release) - Before 1364 - TypedArrayInitializeWithBuffer 6468 - CreateTypedArray - After 7468 - CreateTypedArray This also improves performance of TypedArray JSPerf benchmarks (SubarrayNoSpecies, ConstructByArrayBuffer) by 5-8%. Bug: v8:7161 Change-Id: I68eed2ea4db103f44ad9751229c29fba9bc9d24d Reviewed-on: https://chromium-review.googlesource.com/c/1437822 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#59135}
-
Daniel Clifford authored
Previously, macros that returned true for "ShouldBeInlined" were only compiled if they were called, which made it impossible to type/semantic check all Torque code (e.g. newly added methods to structs). One might argue that all code should be tested (and thus through inlining compiled), but for prototyping, the skipped compilations were definitely annoying. As part of this change, added a ShouldGenerateExternalCode method to declarables (by default returns !ShouldBeInlined) that makes it possible to suppresses C++ code generation for any method. To support this at the lowest level, a NullOStream classes is added as part of this patch. Finally, added support for generating C++ for passing structs as label parameters to run previously inlined methods through the implementation-visitor for non-inlined compilation. Bug: v8:7793 Change-Id: I8ce23382e12ddc25f46222c25729c82433040a73 Reviewed-on: https://chromium-review.googlesource.com/c/1434378 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#59134}
-
Clemens Hammacher authored
Store the WasmError longer and only creating the heap Error object (via ErrorThrower) right before it's being used. This prevents a DeferredHandleScope and simplifies code a lot. R=mstarzinger@chromium.org Bug: v8:8689 Change-Id: Iad98f6facaf1914e4d31edde4221ed8789c1fbfa Reviewed-on: https://chromium-review.googlesource.com/c/1439116 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#59133}
-
Michael Starzinger authored
R=mlippautz@chromium.org Change-Id: I8ca8b899212786f78a0d42753aedbad02c211c06 Reviewed-on: https://chromium-review.googlesource.com/c/1426120Reviewed-by:
-
Michael Starzinger authored
This adds preliminary support for exception handling to the interpreter. Note that due to missing reference type support, the exception object is not yet correctly put onto the operand stack. Also exceptions raised by call operations are not handled properly yet. R=clemensh@chromium.org TEST=cctest/test-run-wasm-exceptions BUG=v8:8091 Change-Id: Ie68ca9448c7beafe8967dff5bb5de6642edcc9e4 Reviewed-on: https://chromium-review.googlesource.com/c/1436017 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Mythri authored
If the context is in strict mode, then we can avoid iterating the stack since we cannot go stricter than that. Bug: chromium:925289 Change-Id: I422176c85f2dfd9176a60bc7c3a7674f96238bd0 Reviewed-on: https://chromium-review.googlesource.com/c/1439396Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#59130}
-
Leszek Swirski authored
Vars without initialisers don't need to allocate a VariableProxy, as the proxy expression is not really needed for anything. So, we can special case declaration parsing to look ahead for a '=' (plus a few other cases), and skip the variable proxy allocation if it isn't there. As a side-effect, variables that are only declared but never used are no longer marked is_used, and thus not allocated. This saves on generating dead code. Change-Id: Ie4f04c6b5c1138df4c2e17acf1f0150459b3b571 Reviewed-on: https://chromium-review.googlesource.com/c/1434376 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#59129}
-
Toon Verwaest authored
Change-Id: I8971d1e2ab47599bba4db8cac8631bcf39058593 Reviewed-on: https://chromium-review.googlesource.com/c/1436024Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org TEST=cctest/test-disasm-x64 Change-Id: I704537886b80701921eeae918a1f867f42ad305b Reviewed-on: https://chromium-review.googlesource.com/c/1437289Reviewed-by:
-
Michael Achenbach authored
TBR=mslekova@chromium.org NOTRY=true Bug: chromium:925750 Change-Id: I6700ce261e2e083867b71874dfe4c308ccc0d764 Reviewed-on: https://chromium-review.googlesource.com/c/1437117 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59126}
-
Clemens Hammacher authored
Now that I saw the typo I cannot unsee it anymore, but somehow this typo went unrecognized for nearly 12 months (since https://crrev.com/c/904443). R=ahaas@chromium.org Bug: v8:8562 Change-Id: Iafaeb2313dcfa305007c3c87e8f0440d8b15980e Reviewed-on: https://chromium-review.googlesource.com/c/1436021Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#59125}
-
Georg Neis authored
Bug: v8:7790 Change-Id: I834dd74803d610666d40fdb50f7e9671aa99d215 Reviewed-on: https://chromium-review.googlesource.com/c/1437288Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#59124}
-
peterwmwong authored
Bug: v8:7793 Change-Id: I5e682ba555d79be533e325bed12e87aabf90b311 Reviewed-on: https://chromium-review.googlesource.com/c/1437989Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Cr-Commit-Position: refs/heads/master@{#59123}
-
Clemens Hammacher authored
The API for serialized modules changed a bit in version 7.3. The old API is deprecated, hence remove it in 7.4. R=mstarzinger@chromium.org, ulan@chromium.org Bug: chromium:912031 Change-Id: Ib1a55dc88db9e98aef03006caf8cdc1be4f85b9f Reviewed-on: https://chromium-review.googlesource.com/c/1436020Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Ben L. Titzer authored
The spec wasn't clear (or I misunderstood). As per (https://github.com/WebAssembly/bulk-memory-operations/issues/11), zero-count table operations are also out of bounds. R=mstarzinger@chromium.org CC=binji@chromium.org BUG=v8:7747 Change-Id: Iac689b93a040eb6eb06975bc2ba0facb85d24756 Reviewed-on: https://chromium-review.googlesource.com/c/1436022Reviewed-by:
-
Camillo Bruni authored
- Dehandlify ScopeInfo::ContextSlotIndex - Dehandlify ScriptContextTable::Lookup - Introduce function-kind.h with range-based helper methods - Spread usage of Scope::is_script_scope and friends Change-Id: I8ed1d82cc5bb9ea3fce856e16e9eafe194fb57ba Reviewed-on: https://chromium-review.googlesource.com/c/1430100Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Anton Bikineev authored
The ToDateString builtin now uses StringStream to format dates instead of SNPrintF. The patch also implements a new allocator based on SSO that's able to expand automatically. Bug: v8:7770 Change-Id: I23e03ec06fcfc7bda1e5abb1ac82637e5c9ddc95 Reviewed-on: https://chromium-review.googlesource.com/c/1425905 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Georg Neis authored
Bug: v8:7790 Change-Id: Ie98cff6f8b1f184c8152952cc3d39e373c93565d Reviewed-on: https://chromium-review.googlesource.com/c/1435943 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL changes 'HasNext' to 'HasFrame' and 'Next' to 'Advance' to better reflect the semantics of the iterator. 'Next' usually returns the next element. R=jgruber@chromium.org Bug: v8:8562 Change-Id: Idbd1c084c39dd4a10c1c6a6db7782637b9b16cc4 Reviewed-on: https://chromium-review.googlesource.com/c/1436023Reviewed-by:
-
Clemens Hammacher authored
The implicit constructor is deprecated since version 7.3, hence can be removed in 7.4. R=ulan@chromium.org Change-Id: I54a530240648c1721924195d7fccc157d483e6d8 Reviewed-on: https://chromium-review.googlesource.com/c/1436018Reviewed-by:
-
Ulan Degenbaev authored
Change-Id: I927eed8354fdb3eba2d8ab94caafa89b1ce02016 Reviewed-on: https://chromium-review.googlesource.com/c/1436019 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This reverts commit c9616b0f. Reason for revert: Fails gc-stress tests: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Mac64%20GC%20Stress/5460 Original change's description: > Infer the language mode instead of passing it as a parameter to builtins > > It is better to infer the language mode from the context and the closure > instead of getting it from the feedback vector. This will allow us to use > some of these builtins even when feedback vectors are not allocated. > Language mode is only needed to decide if we need to throw an exception > when a store fails. This is on a slow path and hence deriving the language > mode is not on critical path. > > Bug: v8:8580 > Change-Id: Id0d8e78d35046f015b5cdc15d5fc3f8a17dd8757 > Reviewed-on: https://chromium-review.googlesource.com/c/1421924 > Commit-Queue: Mythri Alle <mythria@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59113} TBR=mythria@chromium.org,verwaest@chromium.org Change-Id: I584b41ca4d396165a3a294b7facee30f0c4f4a7f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8580 Reviewed-on: https://chromium-review.googlesource.com/c/1436025Reviewed-by:
-
Mythri authored
It is better to infer the language mode from the context and the closure instead of getting it from the feedback vector. This will allow us to use some of these builtins even when feedback vectors are not allocated. Language mode is only needed to decide if we need to throw an exception when a store fails. This is on a slow path and hence deriving the language mode is not on critical path. Bug: v8:8580 Change-Id: Id0d8e78d35046f015b5cdc15d5fc3f8a17dd8757 Reviewed-on: https://chromium-review.googlesource.com/c/1421924 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Change-Id: Ia082e676e2cabab07c99b424f80b91e9459f1d3d Reviewed-on: https://chromium-review.googlesource.com/c/1430070Reviewed-by:
-
Georg Neis authored
No difference in behavior because the other branch of the condition already allowed positive 0. Change-Id: Ia31d3366f882b5eaf004f17d26e4213f8de57794 Reviewed-on: https://chromium-review.googlesource.com/c/1435936Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/4c3ae01..a041d21 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ie68dccacbecc99a6de4fdb50b7fd754d84ac60b8 Reviewed-on: https://chromium-review.googlesource.com/c/1438558Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#59110}
-
- 27 Jan, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/75934e6..4c3ae01 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/eb2767b..bdb1123 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/9518a57..5ec7f0c TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I390a19b67d4cafbad6e0cca72b3a28728d0cd3f1 Reviewed-on: https://chromium-review.googlesource.com/c/1438337Reviewed-by:
-
- 26 Jan, 2019 5 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/test/test262/data: https://chromium.googlesource.com/external/github.com/tc39/test262/+log/116c95d..1068137 TBR=adamk@chromium.org,gsathya@chromium.org Change-Id: I1572b3b1f27b09fba4169903c3df46c3f0d178d3 Reviewed-on: https://chromium-review.googlesource.com/c/1437819Reviewed-by:
-
Michael Achenbach authored
The test runner is stuck on start-up otherwise. TBR=sergiyb@chromium.org NOTRY=true Bug: v8:8552 Change-Id: Ief2632ce168f83ae33bc9ae1f7edee152505cae9 Reviewed-on: https://chromium-review.googlesource.com/c/1437276Reviewed-by:
-
Ross McIlroy authored
BUG=v8:8395 Change-Id: Ie900be7d146d3a7ded13565b94b192807bc7eb28 Reviewed-on: https://chromium-review.googlesource.com/c/1417930 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#59106}
-
peterwmwong authored
This is part of an effort to improve the performance of TA#subarray. Bug: v8:7161 Change-Id: Iffd469ca6528710c28cc454604a725ca9748359d Reviewed-on: https://chromium-review.googlesource.com/c/1435768 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/018911f..75934e6 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b000c21..514fe3e Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/80b9cf7..eb2767b Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/3a16568..361dfd1 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Iea12f7b105b94293ca32ac4933b7338d07c0864e Reviewed-on: https://chromium-review.googlesource.com/c/1437816Reviewed-by:
-
- 25 Jan, 2019 3 commits
-
-
Jakob Kummerow authored
This roll includes: 8515c2a1c UBSan fix 9977c471b (does not touch files imported into V8) 9cba74155 (does not touch files imported into V8) Bug: v8:3770 Change-Id: If5ae5e7c6a7a81a246c8376545c4437cacaf1dc3 Reviewed-on: https://chromium-review.googlesource.com/c/1436230Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#59103}
-
Jakob Kummerow authored
An enum-typed value should never have a value outside of that enum's range. This patch enforces that in Debug mode, while in Release mode keeping the previous behavior of returning "UnknownOpcode" as the mnemonic for illegal IrOpcode values to ease debugging. Bug: v8:3770 Change-Id: I83a5a356f1fb7a266921940a4495f1d39a1823cd Reviewed-on: https://chromium-review.googlesource.com/c/1436221Reviewed-by:
-
Jakob Kummerow authored
Not even when copying 0 bytes. Same for memmove and memcmp. Bug: v8:3770 Change-Id: I3ed45a4572467ec7a9fc697ac28c004aa9b8b274 Reviewed-on: https://chromium-review.googlesource.com/c/1436217Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
