1. 25 Nov, 2019 1 commit
  2. 22 Nov, 2019 1 commit
  3. 18 Nov, 2019 1 commit
  4. 15 Nov, 2019 1 commit
  5. 13 Nov, 2019 1 commit
  6. 11 Nov, 2019 1 commit
  7. 07 Nov, 2019 1 commit
  8. 04 Nov, 2019 2 commits
  9. 31 Oct, 2019 1 commit
  10. 28 Oct, 2019 2 commits
  11. 24 Oct, 2019 1 commit
  12. 22 Oct, 2019 2 commits
  13. 21 Oct, 2019 1 commit
  14. 17 Oct, 2019 1 commit
  15. 14 Oct, 2019 1 commit
  16. 11 Oct, 2019 1 commit
  17. 09 Oct, 2019 2 commits
  18. 04 Oct, 2019 3 commits
  19. 30 Sep, 2019 1 commit
  20. 27 Sep, 2019 1 commit
  21. 24 Sep, 2019 1 commit
  22. 18 Sep, 2019 1 commit
    • Mike Stanton's avatar
      [Turbofan] Wiser zone allocation for child serializers · 3c3bd147
      Mike Stanton authored
      The serialization step in the pipeline gets an initial zone, and thus
      far, it's allocated all of it's hinting information in that zone.
      However, much of this comes from stepping into calls and
      walking the bytecode of the called function. Once we finished
      recursing into a call, we should be able to throw all those
      hints away -- they've served their purpose, and the "output"
      of their work is a set of new objects made visible to the broker.
      
      Therefore, we should create and destroy a child zone.
      
      On a run of typescript, this reduces absolute max (high water mark)
      allocation of the serialization phase from 10 MB to 5 MB.
      
      Bug: v8:7790
      Change-Id: Icbb35abed28b1a924328541df82be23594152a8f
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1800570Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
      Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
      Commit-Queue: Michael Stanton <mvstanton@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#63872}
      3c3bd147
  23. 17 Sep, 2019 1 commit
  24. 16 Sep, 2019 1 commit
    • Georg Neis's avatar
      [turbofan] Fix and simplify optimization of access on global proxy · 97c89ebb
      Georg Neis authored
      We used to have two special cases for named accesses on the global
      proxy, one based on seeing the global proxy constant in the graph and
      on based on seeing the global proxy map either in the feedback or in
      the graph. A change I made a while ago accidentally disabled the second
      one. This CL restores that.
      
      Moreover, given how things are set up now (this might have been
      different before), the first optimization is subsumed by the second
      one, so this CL also removes the first one.
      
      Finally, this CL records an accumulator hint in the case of a load,
      which improves precision of the serializer for concurrent inlining.
      
      Tbr: tebbi@chromium.org
      Bug: v8:7790
      Change-Id: I255afc6c79e5c5c900b3ccfcd8459d836d21e42b
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801954
      Commit-Queue: Georg Neis <neis@chromium.org>
      Reviewed-by: 's avatarMichael Stanton <mvstanton@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#63806}
      97c89ebb
  25. 12 Sep, 2019 2 commits
  26. 06 Sep, 2019 1 commit
    • Swapnil Gaikwad's avatar
      Reland "Update GetIterator bytecode to load and call object[Symbol.iterator]" · ffa9f163
      Swapnil Gaikwad authored
      This is a reland of 8b89a7c3
      
      Reland after disabling the test getting deadlocked with '--gc_stress' flag.
      The CL was reverted because of the 'wasm/grow-shared-memory' test from
      the mjsunit test suite deadlocked for the 'gc_stress' variant. This is
      the known issue (v8:9221) and the deadlocking test is now disabled (
      https://chromium.googlesource.com/v8/v8.git/+/1c8981e3f4729b7a8220a8823e0a0d45f2a4b788).
      
      
      Original change's description:
      > Update GetIterator bytecode to load and call object[Symbol.iterator]
      >
      > The functionality of the GetIterator bytecode introduced previously is
      > now extended from loading the @@iterator property to calling the property
      > as well. This change basically absorbs the functionality of additional
      > two bytecodes - Star, CallProperty0 in the GetIterator bytecode.
      > Importantly, this change handles the cases of eager and lazy deoptimization
      > in the middle of the bytecode, i.e., lazy deopt for LdaNamedProperty and
      > eager deopt of the CallProperty0 bytecode, using the continuation builtins.
      > This mechanism can work as a template for the future bytecode that require
      > handling such inter-bytecode deopt scenario. The tests evaluating the eager
      > and lazy deopt scenarios are also included.
      >
      > Bug: v8:9489
      > Change-Id: I93eb022bbc3d37582407820aa8482a343cac6c12
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1758313
      > Commit-Queue: Swapnil Gaikwad <swapnilgaikwad@google.com>
      > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
      > Reviewed-by: Georg Neis <neis@chromium.org>
      > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#63528}
      
      Bug: v8:9489,v8:9221
      Change-Id: I4286255aef457bfdbbe5eb50fc6dabdf9c0955b1
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1787427Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
      Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Commit-Queue: Swapnil Gaikwad <swapnilgaikwad@google.com>
      Cr-Commit-Position: refs/heads/master@{#63599}
      ffa9f163
  27. 04 Sep, 2019 1 commit
  28. 03 Sep, 2019 6 commits
    • Francis McCabe's avatar
      Revert "Update GetIterator bytecode to load and call object[Symbol.iterator]" · af04a51e
      Francis McCabe authored
      This reverts commit 8b89a7c3.
      
      Reason for revert: GC Stress tests timing out.
      See https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/24272
      
      Original change's description:
      > Update GetIterator bytecode to load and call object[Symbol.iterator]
      > 
      > The functionality of the GetIterator bytecode introduced previously is
      > now extended from loading the @@iterator property to calling the property
      > as well. This change basically absorbs the functionality of additional
      > two bytecodes - Star, CallProperty0 in the GetIterator bytecode.
      > Importantly, this change handles the cases of eager and lazy deoptimization
      > in the middle of the bytecode, i.e., lazy deopt for LdaNamedProperty and
      > eager deopt of the CallProperty0 bytecode, using the continuation builtins.
      > This mechanism can work as a template for the future bytecode that require
      > handling such inter-bytecode deopt scenario. The tests evaluating the eager
      > and lazy deopt scenarios are also included.
      > 
      > Bug: v8:9489
      > Change-Id: I93eb022bbc3d37582407820aa8482a343cac6c12
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1758313
      > Commit-Queue: Swapnil Gaikwad <swapnilgaikwad@google.com>
      > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
      > Reviewed-by: Georg Neis <neis@chromium.org>
      > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#63528}
      
      TBR=rmcilroy@chromium.org,neis@chromium.org,leszeks@chromium.org,tebbi@chromium.org,swapnilgaikwad@google.com
      
      Change-Id: I9ae475f71275f71f1b9e60b8bf0578e21ce2704b
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:9489
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1783736Reviewed-by: 's avatarFrancis McCabe <fgm@chromium.org>
      Commit-Queue: Francis McCabe <fgm@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#63536}
      af04a51e
    • Swapnil Gaikwad's avatar
      Update GetIterator bytecode to load and call object[Symbol.iterator] · 8b89a7c3
      Swapnil Gaikwad authored
      The functionality of the GetIterator bytecode introduced previously is
      now extended from loading the @@iterator property to calling the property
      as well. This change basically absorbs the functionality of additional
      two bytecodes - Star, CallProperty0 in the GetIterator bytecode.
      Importantly, this change handles the cases of eager and lazy deoptimization
      in the middle of the bytecode, i.e., lazy deopt for LdaNamedProperty and
      eager deopt of the CallProperty0 bytecode, using the continuation builtins.
      This mechanism can work as a template for the future bytecode that require
      handling such inter-bytecode deopt scenario. The tests evaluating the eager
      and lazy deopt scenarios are also included.
      
      Bug: v8:9489
      Change-Id: I93eb022bbc3d37582407820aa8482a343cac6c12
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1758313
      Commit-Queue: Swapnil Gaikwad <swapnilgaikwad@google.com>
      Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
      Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#63528}
      8b89a7c3
    • Maya Lekova's avatar
      Reland "[turbofan] Serialize missing objects" · 8864510e
      Maya Lekova authored
      This is a reland of d82600ec
      
      Added missing builtin serializations that were breaking Clusterfuzz,
      layout tests and Speedometer.
      
      Original change's description:
      > [turbofan] Serialize missing objects
      >
      > Added a few objects to the standard objects list, as well as specific
      > builtins when the corresponding runtime calls are detected in the
      > serializer. Now JSHeapCopyReducer is needed only when concurrent
      > inlining is disabled.
      >
      > Bug: v8:7790
      > Change-Id: I91d933611b0352df8ede4fded665f13669591fef
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781053
      > Reviewed-by: Georg Neis <neis@chromium.org>
      > Commit-Queue: Maya Lekova <mslekova@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#63509}
      
      Bug: v8:7790, chromium:1000136
      Change-Id: I4775014bfe8100fb76f60e4088f1bdf2a8da64a2
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781681
      Commit-Queue: Maya Lekova <mslekova@chromium.org>
      Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#63525}
      8864510e
    • Leszek Swirski's avatar
      Revert "[turbofan] Prepare for moving part of CreateGraph into the background" · f3796bbc
      Leszek Swirski authored
      This reverts commit ab089c78.
      
      Reason for revert: Breaking GC stress (https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/27523)
      
      Original change's description:
      > [turbofan] Prepare for moving part of CreateGraph into the background
      > 
      > - Pass Refs, not Handles, to graph builder, and drop bytecode array argument
      >   (get it from SFI instead).
      > - Add some fields to FeedbackVectorRef that are needed to avoid heap access
      >   in BytecodeGraphBuilderPhase.
      > - Rename FeedbackVectorRef's SerializeSlots to Serialize, since it's more
      >   than just the feedback slots.
      > - Rearrange the last steps in PipelineCompilationJob::PrepareJobImpl such
      >   that CreateGraph is last.
      > 
      > Bug: v8:7790
      > Change-Id: I4b17790d1d74da41ba63ee68e3a33968662fc398
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781682
      > Reviewed-by: Maya Lekova <mslekova@chromium.org>
      > Commit-Queue: Georg Neis <neis@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#63515}
      
      TBR=neis@chromium.org,mslekova@chromium.org
      
      Change-Id: I4dc95907657597d12cbe1ce6a8ebb694ef44e915
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:7790
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781687Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#63517}
      f3796bbc
    • Georg Neis's avatar
      [turbofan] Prepare for moving part of CreateGraph into the background · ab089c78
      Georg Neis authored
      - Pass Refs, not Handles, to graph builder, and drop bytecode array argument
        (get it from SFI instead).
      - Add some fields to FeedbackVectorRef that are needed to avoid heap access
        in BytecodeGraphBuilderPhase.
      - Rename FeedbackVectorRef's SerializeSlots to Serialize, since it's more
        than just the feedback slots.
      - Rearrange the last steps in PipelineCompilationJob::PrepareJobImpl such
        that CreateGraph is last.
      
      Bug: v8:7790
      Change-Id: I4b17790d1d74da41ba63ee68e3a33968662fc398
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781682Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
      Commit-Queue: Georg Neis <neis@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#63515}
      ab089c78
    • Maya Lekova's avatar
      Revert "[turbofan] Serialize missing objects" · 8b455eff
      Maya Lekova authored
      This reverts commit d82600ec.
      
      Reason for revert: Blocking the roll, see https://ci.chromium.org/p/chromium/builders/try/linux-rel/181725
      
      Original change's description:
      > [turbofan] Serialize missing objects
      > 
      > Added a few objects to the standard objects list, as well as specific
      > builtins when the corresponding runtime calls are detected in the
      > serializer. Now JSHeapCopyReducer is needed only when concurrent
      > inlining is disabled.
      > 
      > Bug: v8:7790
      > Change-Id: I91d933611b0352df8ede4fded665f13669591fef
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781053
      > Reviewed-by: Georg Neis <neis@chromium.org>
      > Commit-Queue: Maya Lekova <mslekova@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#63509}
      
      TBR=neis@chromium.org,mslekova@chromium.org
      
      Change-Id: I5eb8a8371994822debb852fc2a090ba585826d4a
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:7790
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1782157Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
      Commit-Queue: Maya Lekova <mslekova@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#63514}
      8b455eff