- 25 Sep, 2018 8 commits
-
-
Leszek Swirski authored
The existing script source tracking was racing with general external script resource tracking, resulting in heap-order-dependent labels. Bug: v8:8218 Change-Id: Ib09c28ca1e13768b328ecef7f8ee3ea5131ba12e Reviewed-on: https://chromium-review.googlesource.com/1238927Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#56191}
-
Florian Sattler authored
Change-Id: I4cffe3d595aa3b3d85d4c45d5bb9654728c9137b Reviewed-on: https://chromium-review.googlesource.com/1238923 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#56190}
-
Peter Marshall authored
This is a regression test for a really specific issue that is flaky. We should just disable it for all configurations rather than wait for extra flakes which we then have to diagnose. Bug: v8:8209 Change-Id: I976f2d7cdd92f3ce5c7eb9fd28976201d1d6612f Reviewed-on: https://chromium-review.googlesource.com/1240120Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#56189}
-
Andreas Haas authored
R=titzer@chromium.org Change-Id: I6eabacf07e3dd95d1bec68f1980ec6aae5220c97 Reviewed-on: https://chromium-review.googlesource.com/1238926Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#56188}
-
Maya Lekova authored
This reverts commit 31228a69. Reason for revert: Introduces new pretty consistent flakes on Linux sanitizers, one of which block LKGR. Please see https://crbug.com/v8/8219 Original change's description: > [Compile] Refactor BackgroundCompileTask to enable its use by CompilerDispatcher > > Splits background compilation data out of ScriptStreamingData and into > BackgroundCompileTask. Also makes BackgroundCompileTask no longer a sub-class > of ScriptStreamingTask, and instead have ScriptStreamingTask delegate to a > BackgroundCompileTask. > > As part of this change, we now create the CharacterStream on the main thread, > and therefore have to set the (thread-local) runtime_call_stats on the already > created CharacterStream when the BackgroundCompileTask is run on the background > thread. As such, changes to CharacterStream were needed to feed the > runtime_call_stats through appropriately. > > Deprecates Source::GetCachedData and StreamedSource::GetCachedData since they are > no longer used, and the streamed source never has cached data (streaming is > suppressed if cached data is available). Also removes Utf8ChunkedStream which > is dead code. > > BUG=v8:8041, v8:8015 > TBR=yangguo@chromium.org > > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: Ifcc723ebf930a1dc01135fcb70929d6168471cb3 > Reviewed-on: https://chromium-review.googlesource.com/1236353 > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56182} TBR=rmcilroy@chromium.org,yangguo@chromium.org,verwaest@chromium.org Change-Id: Ib05bcbde2e9a588bd4008d2155f75cdac5cc47f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8041, v8:8015 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1241958Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#56187}
-
Toon Verwaest authored
This reverts commit f2f48bd8. Reason for revert: Negative performance impact Original change's description: > [parser] Restructure Binary expression parsing > > Change-Id: I1ff35a3e647b32edb229f47fde80de1b8b50737b > Reviewed-on: https://chromium-review.googlesource.com/1240333 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56179} TBR=ishell@chromium.org,verwaest@chromium.org Change-Id: If08f8c5f538dc25f5f3ea62cd8dd80e024156e81 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1241957Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#56186}
-
Clemens Hammacher authored
Wasm modules can now grow up to 1024 MB. Bump the maximum of the corresponding histogram so we record the full range. R=titzer@chromium.org Change-Id: I984b2314fcb41435f300df6e8f63b62c096d1330 Reviewed-on: https://chromium-review.googlesource.com/1240337Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/dfca77b..4325c99 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/868fbbf..c51eb62 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/baf0927..64b6133 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/dc90d99..9b435fc TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I6582dfcb56e4f1dbfdd32ea32134044c76dd339d Reviewed-on: https://chromium-review.googlesource.com/1242603Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#56184}
-
- 24 Sep, 2018 31 commits
-
-
Deepti Gandluri authored
Change-Id: I554c028627c4032d7c47e8d6d6a6ed4e4a38d0a5 Reviewed-on: https://chromium-review.googlesource.com/1241474Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#56183}
-
Ross McIlroy authored
Splits background compilation data out of ScriptStreamingData and into BackgroundCompileTask. Also makes BackgroundCompileTask no longer a sub-class of ScriptStreamingTask, and instead have ScriptStreamingTask delegate to a BackgroundCompileTask. As part of this change, we now create the CharacterStream on the main thread, and therefore have to set the (thread-local) runtime_call_stats on the already created CharacterStream when the BackgroundCompileTask is run on the background thread. As such, changes to CharacterStream were needed to feed the runtime_call_stats through appropriately. Deprecates Source::GetCachedData and StreamedSource::GetCachedData since they are no longer used, and the streamed source never has cached data (streaming is suppressed if cached data is available). Also removes Utf8ChunkedStream which is dead code. BUG=v8:8041, v8:8015 TBR=yangguo@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ifcc723ebf930a1dc01135fcb70929d6168471cb3 Reviewed-on: https://chromium-review.googlesource.com/1236353 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/7ca3ffa..c52a2a2 This includes fixes from https://crrev.com/c/1240414. TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I2afd319dbb244356a9bb057eb80c5fb0310b8686 Reviewed-on: https://chromium-review.googlesource.com/1240106Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#56181}
-
Toon Verwaest authored
Change-Id: I05db378984b583d9dff3fe9fceb3adbf7e046e20 Reviewed-on: https://chromium-review.googlesource.com/1240338Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#56180}
-
Toon Verwaest authored
Change-Id: I1ff35a3e647b32edb229f47fde80de1b8b50737b Reviewed-on: https://chromium-review.googlesource.com/1240333Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=machenbach@chromium.org Bug: chromium:863607 Change-Id: I1352bc236e7e236d70130db7fcc4333821fdec70 Reviewed-on: https://chromium-review.googlesource.com/1238924 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#56178}
-
Toon Verwaest authored
Change-Id: I6c4f8c736e3c5f55f9541109f0093b2c026bce27 Reviewed-on: https://chromium-review.googlesource.com/1240136 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#56177}
-
Clemens Hammacher authored
In the wasm code manager unittest, use the more specific AddressRange class instead of a generic std::pair. Also, rename the two {CheckLooksLike} methods to capture what they actually check ({CheckPool} and {CheckRange}). R=ahaas@chromium.org Bug: v8:8015 Change-Id: Ia02523eabb1ddd8a3e8a255cc3987017b8338721 Reviewed-on: https://chromium-review.googlesource.com/1240135Reviewed-by:Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#56176}
-
Yang Guo authored
This is a reland of 33fa357b TBR=mvstanton@chromium.org Original change's description: > Do not use FixedDoubleArray to store RNG state > > Also: > - replace runtime call with cheaper C call > - change state to double conversion > > R=mvstanton@chromium.org > > Bug: v8:8212 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: If4bfe0f5fb1864c89f4acd871cb8b74c7cd7ab09 > Reviewed-on: https://chromium-review.googlesource.com/1240116 > Commit-Queue: Yang Guo <yangguo@chromium.org> > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56165} Bug: v8:8212 Change-Id: Iccc9128034ce7b65801a04a54982219b5a4fe84e Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1238551Reviewed-by:
-
Igor Sheludko authored
Bug: v8:8015 Change-Id: I1a423b356d09bdf46d49d69fb83cc24acabb6313 Reviewed-on: https://chromium-review.googlesource.com/1238550Reviewed-by:
-
Toon Verwaest authored
This allows to inline the part where we call to the nested rule and the token check while keeping the bulk of the work if it's actually a unary/conditional expression outline. Change-Id: I1b1f7ebaf2d4f660f157ece7f9534525b80a95a6 Reviewed-on: https://chromium-review.googlesource.com/1238922Reviewed-by:
-
Yang Guo authored
R=petermarshall@chromium.org Change-Id: I2738b6ccf8b3c56b58554aa8dd626da5d2c3865d Reviewed-on: https://chromium-review.googlesource.com/1240137Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#56172}
-
Toon Verwaest authored
The previous clear mechanism would also unnecessarily allocate a preparser. This fixes regressions introduced by https://chromium-review.googlesource.com/c/v8/v8/+/1238614 Change-Id: Ia3eef371c80857f2cd6cdd5852c849fa7f8716fc Reviewed-on: https://chromium-review.googlesource.com/1238918 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Peter Marshall authored
This is more generic as it doesn't restrict embedded code to just builtins. Also, some builtins are still on-heap so the name was not totally accurate. Bug: v8:8116 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I44cd24d6baf2bce0e5d914d36a2bae98e77bdc6d Reviewed-on: https://chromium-review.googlesource.com/1238919 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... so that it is no longer needed to iterate over other lists. This CL also moves data handler maps to the RO roots list (because they are RO). Bug: v8:8015 Change-Id: If21fe5bac5a6ac1e44a47783ad930df5fcecda9a Reviewed-on: https://chromium-review.googlesource.com/1240134Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/218f466..868fbbf Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/0dc1fa0..baf0927 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ifb64ed8de7d45867a7b3bbae1357ba0f0aecc4b6 Reviewed-on: https://chromium-review.googlesource.com/1240103 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Maya Lekova authored
This reverts commit 33fa357b. Reason for revert: Breaking the V8 Linux - arm64 - sim - MSAN bot. Please see here: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/23001 Original change's description: > Do not use FixedDoubleArray to store RNG state > > Also: > - replace runtime call with cheaper C call > - use xor instead of addition to remove bias > > R=mvstanton@chromium.org > > Bug: v8:8212 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: If4bfe0f5fb1864c89f4acd871cb8b74c7cd7ab09 > Reviewed-on: https://chromium-review.googlesource.com/1240116 > Commit-Queue: Yang Guo <yangguo@chromium.org> > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56165} TBR=yangguo@chromium.org,mvstanton@chromium.org Change-Id: I05f23f0b52a706233bbc1a1877cc15691ed9f40a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8212 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1238549Reviewed-by:
-
Jaroslav Sevcik authored
Change-Id: Id31c1178b84be5ec4e876495ce220302864713e0 Reviewed-on: https://chromium-review.googlesource.com/1240118Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#56166}
-
Yang Guo authored
Also: - replace runtime call with cheaper C call - use xor instead of addition to remove bias R=mvstanton@chromium.org Bug: v8:8212 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: If4bfe0f5fb1864c89f4acd871cb8b74c7cd7ab09 Reviewed-on: https://chromium-review.googlesource.com/1240116 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#56165}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/641370b..dfca77b Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/6f7c60d..218f466 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/92df4e6..0dc1fa0 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I5ae82581f54b2206f2574b61fa3c02aad5d7427c Reviewed-on: https://chromium-review.googlesource.com/1239190 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Dan Elphick authored
ToBoolean and BooleanValue cannot throw exceptions so the Maybe versions of the functions don't make sense. As such this deprecates the Maybe versions and undeprecates ToBoolean(Isolate*). It also adds BooleanValue(Isolate*). Fix up all of the v8 code to not use the deprecated functions. Bug: v8:7279, v8:8015 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I50e7474d205c75baa153f0dea7f02dcf60232d1d Reviewed-on: https://chromium-review.googlesource.com/1238476 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This swaps out ebx in favor of esi. The root pointer value itself is pushed and restored from the stack through pushad/popad. Bug: v8:6666 Change-Id: I2a685f6659a5fbe2f7d91e431c5addff85664b5b Reviewed-on: https://chromium-review.googlesource.com/1238653 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#56162}
-
Igor Sheludko authored
... containing ROOT_LIST-compatible entries. Bug: v8:8015 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ia7a2620e2b6c9b2238cc0c2a6ead6bf7e6a46c00 Reviewed-on: https://chromium-review.googlesource.com/1238724 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Igor Sheludko authored
INTERNALIZED_STRING_ROOT_LIST, [PRIVATE|PUBLIC|WELL_KNOWN]_SYMBOL_ROOT_LIST Bug: v8:8015 Change-Id: I6f271fa8bfbe5e994ebcef191e6750fa3ff6dd7f Reviewed-on: https://chromium-review.googlesource.com/1238567Reviewed-by:
-
Ben L. Titzer authored
Neither the native module nor the trap handler flag are needed to compile JS to WASM wrappers. R=clemensh@chromium.org Change-Id: I46770d26e4063a6efbcaef55bebab5e1a131a0e8 Reviewed-on: https://chromium-review.googlesource.com/1238506 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
-
Daniel Clifford authored
Issues/problems addressed: - Fix line-wrapping and indenting for long declarations including strings, e.g. generates and constexpr clauses. - Implement proper formatting for typeswitch statements - Fix formatting of operator declarations - Fix formatting of constexpr if-clauses (the constexpr is now included on the same line as the if and it doesn't mess up the formatting that - Fix formatting of label declarations on callables, the "label" keyword now always starts a new line with indentation. - Remove space after identifier name in generic parameter declarations, e.g. "<a : T>" is now "<a: T>" which is consistent with type specification formatting elsewhere. - Indent "otherwise" clauses that have been pushed to the next line. Also ran the formatter over all existing .tq files. Bug: v8:7793 Change-Id: I5adbb2ffa3d573deed062f9a5c1da57348c8fc71 Reviewed-on: https://chromium-review.googlesource.com/1238580 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#56158}
-
Toon Verwaest authored
Change-Id: I38e7ea204c84dfef22e1f87ac5923d93322b2620 Reviewed-on: https://chromium-review.googlesource.com/1238722Reviewed-by:
-
Clemens Hammacher authored
1) Avoid putting empty VirtualMemory objects in {owned_code_space_}. 2) After allocating more code space, the actual allocation in that space should also succeed. DCHECK that. 3) Remove pointless std::move. R=ahaas@chromium.org Bug: v8:8015 Change-Id: Ifda30d8279579ea290c6fa8e9c310f05a044b288 Reviewed-on: https://chromium-review.googlesource.com/1238721Reviewed-by: -
Toon Verwaest authored
Change-Id: Ic2efd81492836bf9f6dd1b48fdfb57ce19ef566a Reviewed-on: https://chromium-review.googlesource.com/1240117Reviewed-by:
-
Toon Verwaest authored
Change-Id: I5b5228427039ce31b9b978d406d860ff08b32dae Reviewed-on: https://chromium-review.googlesource.com/1238543Reviewed-by:
-
Benedikt Meurer authored
When we detect during SimplifiedLowering that the index for the MaybeGrowFastElements operation is less than the length of the array, which are both passed as explicit parameters to the operation, we can just drop the operation from the graph completely and go with the existing elements. This happens for example when code creates a new Array and immediately stores to it, i.e. like in the case of ```js const array = new Array(); array.push(something); ``` where the `new Array()` already creates a backing store of 4 elements, so the check for growing in `Array#push()` is redundant here. Change-Id: I548049b2c7b60c5f189f8ffdcb20b3a6ff1b0555 Reviewed-on: https://chromium-review.googlesource.com/1238655Reviewed-by:
-
- 21 Sep, 2018 1 commit
-
-
Aseem Garg authored
This CL ignores multiple name sections in wasm modules instead throwing an error. This is in line with the spec with regards to custom sections. BUG=v8:8186 R=clemensh@chromium.org,adamk@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8c6610afe389d8f8d03f9fca164bd46cb5fb030d Reviewed-on: https://chromium-review.googlesource.com/1232676 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by:
-
