• Benedikt Meurer's avatar
    [turbofan] Remove unnecessary MaybeGrowFastElements operations. · 4bfa074b
    Benedikt Meurer authored
    When we detect during SimplifiedLowering that the index for the
    MaybeGrowFastElements operation is less than the length of the
    array, which are both passed as explicit parameters to the
    operation, we can just drop the operation from the graph completely
    and go with the existing elements. This happens for example when
    code creates a new Array and immediately stores to it, i.e. like
    in the case of
    
    ```js
    const array = new Array();
    array.push(something);
    ```
    
    where the `new Array()` already creates a backing store of 4 elements,
    so the check for growing in `Array#push()` is redundant here.
    
    Change-Id: I548049b2c7b60c5f189f8ffdcb20b3a6ff1b0555
    Reviewed-on: https://chromium-review.googlesource.com/1238655Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#56153}
    4bfa074b
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...